Re: [Kicad-developers] STEP Export

On 9/21/2016 7:27 PM, Cirilo Bernardo wrote: > OK, I've updated the branch with the following changes: > > 1. removed wxT() from kicad2step and dialogs. The remaining wxT() > instances are created by wxFormBuilder. > > 2. refined the Export STEP GUI for cases in which the exporter > fails

Re: [Kicad-developers] STEP Export

I forgot to mention (3) quoted all filenames (application path, input file, output file). On Thu, Sep 22, 2016 at 9:27 AM, Cirilo Bernardo wrote: > OK, I've updated the branch with the following changes: > > 1. removed wxT() from kicad2step and dialogs. The remaining

Re: [Kicad-developers] [PATCH v3 5/5] [Build] No need to use the source tree for temporary files.

On 9/21/2016 3:14 PM, Chris Pavlina wrote: > On Wed, Sep 21, 2016 at 09:04:03PM +0200, Niki Guldbrand wrote: >> On ons, 2016-09-21 at 20:13 +0200, jp charras wrote: >>> Le 21/09/2016 à 19:33, Niki Guldbrand a écrit : On ons, 2016-09-21 at 12:32 +0200, jp charras wrote: > > Le

Re: [Kicad-developers] STEP Export

OK, I've updated the branch with the following changes: 1. removed wxT() from kicad2step and dialogs. The remaining wxT() instances are created by wxFormBuilder. 2. refined the Export STEP GUI for cases in which the exporter fails (returns an error or segfaults). It also just occurred to me

Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

No problem. I think the original concern was abuse of virtual not the use of override. If Simon R doesn't have time to fix this, I'm not opposed to applying your patch temporarily until we can get it resolved. On 9/21/2016 4:57 PM, Simon Wells wrote: > Oh my apologies wayne, i vaguely

Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

Oh my apologies wayne, i vaguely remembered them being discussed on list and i thought that it was decided that it wasn't an issue or something On Thu, Sep 22, 2016 at 8:48 AM, Wayne Stambaugh wrote: > Simon, > > Simon Richter had a patch with all or most of the overrides

Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

Simon, Simon Richter had a patch with all or most of the overrides warnings fixed. I asked him to rebase it so I could get it merged because it was out of sync. That was a while ago. I haven't heard anything from him since then unless I missed it. I actually like the override since it

Re: [Kicad-developers] [PATCH] Synchronize forward declaration with definition

Simon, I pushed your patch to the product repo, thanks for the patch. Cheers, Wayne On 9/20/2016 10:58 PM, Simon Richter wrote: > > The actual definition uses "class", so the forward declarations should do > so, too. > --- > include/class_title_block.h | 2 +- > include/wxPcbStruct.h |

[Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

--- CMakeLists.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5ff860b..1fd55e7 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -265,6 +265,11 @@ if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" ) endif(

Re: [Kicad-developers] [PATCH v3 5/5] [Build] No need to use the source tree for temporary files.

On ons, 2016-09-21 at 20:13 +0200, jp charras wrote: > Le 21/09/2016 à 19:33, Niki Guldbrand a écrit : > > > > On ons, 2016-09-21 at 12:32 +0200, jp charras wrote: > > > > > > Le 21/09/2016 à 00:21, Niki Guldbrand a écrit : > > > > > > > > > > > > > > > > * Move the generated PNG and

Re: [Kicad-developers] pcbnew tools uses long instead of intptr_t

Hi Gustav, Thank you, your patch is sensible. I have just applied it to the master branch. Regards, Orson On 09/18/2016 01:04 AM, Gustav Bergquist wrote: > Hello, > > I just managed to setup a build environment on windows and noticed that > kicad/pcbnew/tools/pcb_editor_control.cpp >

Re: [Kicad-developers] [PATCH v3 5/5] [Build] No need to use the source tree for temporary files.

On Wed, Sep 21, 2016 at 09:04:03PM +0200, Niki Guldbrand wrote: > On ons, 2016-09-21 at 20:13 +0200, jp charras wrote: > > Le 21/09/2016 à 19:33, Niki Guldbrand a écrit : > > > > > > On ons, 2016-09-21 at 12:32 +0200, jp charras wrote: > > > > > > > > Le 21/09/2016 à 00:21, Niki Guldbrand a

Re: [Kicad-developers] [PATCH v3 2/5] [Build] Edit some comments.

On ons, 2016-09-21 at 07:36 +0200, Nick Østergaard wrote: > To nitpick, I suspect that step 4 is also one for all, right? Not > only step 3. > Haven't seen if this has been pushed yet, else I'll have a look at that part, and update the text, may just send the update directly to JP. 2016-09-21

Re: [Kicad-developers] [PATCH v3 5/5] [Build] No need to use the source tree for temporary files.

On ons, 2016-09-21 at 12:32 +0200, jp charras wrote: > Le 21/09/2016 à 00:21, Niki Guldbrand a écrit : > > > > > > * Move the generated PNG and temporary files to the build tree, but > >   keep the generated c files in the source tree for easier > >   addition/updates in tree. > > * Syncronize

Re: [Kicad-developers] STEP Export

Cirilo, I just tested this since you fixed the windows extension issue. The menu item is enabled but I always get an "Unable to create step file whenever there are spaces in the file name and/or path." You didn't by chance forget to double quote the command line string did you? If you don't,

Re: [Kicad-developers] VRML Export

Cirilo, I committed your vrml_export branch to product master. I'll try to get the kicad-step branch merged this evening. Thanks, Wayne On 9/21/2016 9:36 AM, Wayne Stambaugh wrote: > Cirilo, > > Never mind. I figured out what I was doing wrong. Sorry for the noise. > > Cheers, > > Wayne

Re: [Kicad-developers] pcbnew tools uses long instead of intptr_t

Orson, Please take a look at this patch to see if it makes sense. Thanks, Wayne On 9/17/2016 7:04 PM, Gustav Bergquist wrote: > Hello, > > I just managed to setup a build environment on windows and noticed that > kicad/pcbnew/tools/pcb_editor_control.cpp >

Re: [Kicad-developers] [PATCH v3 5/5] [Build] No need to use the source tree for temporary files.

JP, Since you do most if not all of the bitmap maintenance, please apply the patches in this patch set that make sense and discard anything that doesn't work for you. Thanks, Wayne On 9/21/2016 6:32 AM, jp charras wrote: > Le 21/09/2016 à 00:21, Niki Guldbrand a écrit : >> >> * Move the

Re: [Kicad-developers] VRML Export

Cirilo, Never mind. I figured out what I was doing wrong. Sorry for the noise. Cheers, Wayne On 9/21/2016 9:14 AM, Wayne Stambaugh wrote: > Cirilo, > > Is this > > https://git.launchpad.net/~cirilo-bernardo/kicad/+git/kicad-oce/commit/?id=424d98f81c410b7b6cd315fd8a6834192cd9d2f3 > > the

Re: [Kicad-developers] VRML Export

Hi Cirilo, I tested both VRML export options and they work just fine. I agree that adding the automatic centering option would be a useful feature for vrml post elaboration... Maurice On 9/21/2016 1:20 AM, Cirilo Bernardo wrote: Yes, it should be OK to merge. I think it has been tested