Re: [Kicad-developers] Packaging question

Am 26.02.2018 um 01:31 schrieb Wayne Stambaugh: >> As i do not yet plan to ban major changes, i tagged the repos with >> "v5.0.0-rc1" >> > > Rene, > > I don't think there is a major issue here but tagging rc1 wont hurt > anything. Yes, absolutely! As I started about 2 years ago to keep

Re: [Kicad-developers] Packaging question

On 02/25/2018 07:31 PM, Wayne Stambaugh wrote: > > > On 02/25/2018 07:25 PM, Rene Pöschl wrote: >> On 25/02/18 23:29, Wayne Stambaugh wrote: >>> Stephen, >>> >>> I would say that you should pull from HEAD of each library.  This will >>> probably be acceptable up to the stable release.  At this

Re: [Kicad-developers] pcbnew: Right Click Context Menu

I agree that it could be improved; though I agree with Jon that messing with someone's muscle memory might make them sad. Editable context menus are the solution I've seen (and used) in other complex software. The heuristics that kicad uses to create the context menu are complex, so the

Re: [Kicad-developers] pcbnew: Right Click Context Menu

To be honest I'm not sure I think those options should even be in the context menu, especially when you have selected an item. They are already on the toolbar and have hotkeys. But maybe some people use them and would be sad if we removed them :) On Sun, Feb 25, 2018 at 9:27 PM, Andrey Kuznetsov

[Kicad-developers] pcbnew: Right Click Context Menu

Hi, Does anyone else think the right context menu in pcbnew should have some items shelved into submenus? For example, this looks OK when you click on nothing [image: Inline image 1] but if you start using the right click context menu for what it was meant for, then all those Center, and Zoom

Re: [Kicad-developers] Pads front and F.Cu visibility, possible bugs?

Not sure if this is the right thread that dealt with Layers tab, but anyone else thinks the first 2 names should say: F.Copper B.Copper instead of: [image: Inline image 1] On Sat, Feb 17, 2018 at 3:04 PM, Andrzej Wolski wrote: > There is a simple fix to this problem,

Re: [Kicad-developers] RPATH issue on _pcbnew.so

Attached On 26/02/18 11:15, Wayne Stambaugh wrote: hauptmech, Would you please attach this change as a committed patch when you get a chance?  I want to test this on windows and linux and maybe we can get one of our macos devs to test it there as well.  I would like to work out any

Re: [Kicad-developers] gerbview on macOS path issue for job files

OK, got the crash bug too. On Sun, Feb 25, 2018 at 8:12 PM, Jon Evans wrote: > I'm still trying to debug the crash, but the attached patch should fix the > files not found issue. > > On Sun, Feb 25, 2018 at 7:16 PM, Andy Peters wrote: > >> >> >> On Feb 25,

Re: [Kicad-developers] gerbview on macOS path issue for job files

I'm still trying to debug the crash, but the attached patch should fix the files not found issue. On Sun, Feb 25, 2018 at 7:16 PM, Andy Peters wrote: > > > On Feb 25, 2018, at 5:11 PM, Jon Evans wrote: > > Hmm, can't reproduce on Linux (when loading job

Re: [Kicad-developers] Packaging question

On 02/25/2018 07:25 PM, Rene Pöschl wrote: On 25/02/18 23:29, Wayne Stambaugh wrote: Stephen, I would say that you should pull from HEAD of each library.  This will probably be acceptable up to the stable release.  At this point we will have to tag each repo.  Are any of our library devs

Re: [Kicad-developers] [PATCH] GerbView performance optimizations

Yep. > On 25 Feb 2018, at 23:49, Clemens Koller wrote: > > What is the quickest way to git pull your changes when I want to follow you > in real-time? > > git.launchpad.net/kicad ? > > On 2018-02-26 00:39, Wayne Stambaugh wrote: >> Patches merged. Thanks! >> >> On

Re: [Kicad-developers] [PATCH] GerbView performance optimizations

And one final performance patch for now On Sun, Feb 25, 2018 at 6:56 PM, Jon Evans wrote: > One more performance optimization attached > > Clemens -- are you talking to me directly? For most of my smaller fixes I > do not push them to anywhere public before they get merged.

[Kicad-developers] gerbview on macOS path issue for job files

On macOS High Sierra, latest updates. I want to send boards out to fab and I’m checking Gerbers. When generating the files, I check the “create job file” option. I launch GerbView from the Kicad project manager. From the GerbView menu, I choose “Load Gerber Job File.” The File Open dialog box

Re: [Kicad-developers] [PATCH] GerbView performance optimizations

One more performance optimization attached Clemens -- are you talking to me directly? For most of my smaller fixes I do not push them to anywhere public before they get merged. Wayne has been merging my changes pretty quickly though, so the nightly builds are pretty close to real-time. On Sun,

Re: [Kicad-developers] Packaging question

On 25/02/18 23:29, Wayne Stambaugh wrote: Stephen, I would say that you should pull from HEAD of each library. This will probably be acceptable up to the stable release. At this point we will have to tag each repo. Are any of our library devs planning on doing any major reorganization of the

Re: [Kicad-developers] [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

Patch merged. Thanks! On 02/25/2018 04:01 PM, Jon Evans wrote: This patch uses simple iteration instead of the RTREE search to update the layer order and color in VIEW.  On my Linux system, this results in a ~50% speedup in release build (less in debug build) and is most noticeable when

Re: [Kicad-developers] [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

Patch merged. Thanks! On 02/25/2018 04:01 PM, Jon Evans wrote: This patch uses simple iteration instead of the RTREE search to update the layer order and color in VIEW.  On my Linux system, this results in a ~50% speedup in release build (less in debug build) and is most noticeable when

Re: [Kicad-developers] gerbview on macOS path issue for job files

Hmm, can't reproduce on Linux (when loading job file, it successfully finds the Gerbers in the same directory as the job file) Do you have the ability to build a debug build and get a stack trace of the crash? -Jon On Sun, Feb 25, 2018 at 7:02 PM, Andy Peters wrote: > On

Re: [Kicad-developers] [PATCH] GerbView performance optimizations

What is the quickest way to git pull your changes when I want to follow you in real-time? git.launchpad.net/kicad ? On 2018-02-26 00:39, Wayne Stambaugh wrote: > Patches merged. Thanks! > > On 02/25/2018 03:14 PM, Jon Evans wrote: >> These patches improves redraw performance when toggling

Re: [Kicad-developers] [PATCH] GerbView performance optimizations

Patches merged. Thanks! On 02/25/2018 03:14 PM, Jon Evans wrote: These patches improves redraw performance when toggling sketch/filled draw modes. On Linux at least, the difference is quite noticeable on complicated Gerber files. -Jon ___

Re: [Kicad-developers] GerbView: KiCad-rc2: Layer filenames mixed up in right tab view.

I'm having trouble reproducing this. If you try opening some of the example Gerber files in the kicad source tree, do you see the same issue? On Sun, Feb 25, 2018 at 6:26 PM, Clemens Koller wrote: > Hi, Jon! > > The files are newly generated proprietary %FSDAX33Y33*% (without

Re: [Kicad-developers] GerbView: KiCad-rc2: Layer filenames mixed up in right tab view.

Hi, Jon! The files are newly generated proprietary %FSDAX33Y33*% (without X2 attributes AFAICT). * * G04 PADS VX.1.2 Build Number: 698008 generated Gerber (RS-274-X) file* G04 PC Version=2.1* * %IN ".pcb"*% * %MOMM*% * %FSDAX33Y33*% * ... I opened from a directory by File - Load Gerber

Re: [Kicad-developers] Decimal separator characters

I wouldn't say it's rare. I have Kicad set to English language, so it displays ".", but numeric keyboard on my system puts ",". Andrzej W dniu 2018-02-26 o 00:10, Jeff Young pisze: I think we can close it for now. The patch only addresses one side of the issue (accepting a ‘.’ in a ‘,’

Re: [Kicad-developers] GerbView: KiCad-rc2: Layer filenames mixed up in right tab view.

Comparison with Gerbv attached... here, the filenames are correct. (Difference in speed is huge! btw.) Regards, Clemens On 2018-02-26 00:15, Clemens Koller wrote: > Hi! > > I am not absolutely sure what's going on with the layer names in Gerbview. It > seems that the filenames in the right

[Kicad-developers] [PATCH] Ensure ROUTER_PREVIEW_ITEM draws on top of all normal layers

Fixes: https://bugs.launchpad.net/kicad/+bug/1751646 From e648158336af3f90c41bf17a9a2b387b5b095191 Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Sun, 25 Feb 2018 18:17:59 -0500 Subject: [PATCH] Ensure ROUTER_PREVIEW_ITEM draws on top of all normal layers Fixes: lp:1751646 *

Re: [Kicad-developers] GerbView: KiCad-rc2: Layer filenames mixed up in right tab view.

Hi Clemens, do these files have Gerber X2 attributes? What process did you use to load them? (i.e. did you load one at a time; use a Gerber job file, load them all at once, etc)? Thanks, Jon On Sun, Feb 25, 2018 at 6:15 PM, Clemens Koller wrote: > Hi! > > I am not absolutely

[Kicad-developers] GerbView: KiCad-rc2: Layer filenames mixed up in right tab view.

Hi! I am not absolutely sure what's going on with the layer names in Gerbview. It seems that the filenames in the right layers tab view are mixed up. Attached is an image of a 4 layer board where the filenames were selected from copper layer 1 (top) 2 3 4 (bottom) ... etc. But in the tab view,

Re: [Kicad-developers] Decimal separator characters

I think we can close it for now. The patch only addresses one side of the issue (accepting a ‘.’ in a ‘,’ locale), but the opposite (typing a ‘,’ in a ‘.’-locale) is probably extremely rare. Cheers, Jeff. > On 25 Feb 2018, at 20:53, Nick Østergaard wrote: > > I guess

Re: [Kicad-developers] [PATCH] Make all new hotkeys editable; label some GAL-only hotkeys

Patch merged. Thanks! On 02/25/2018 01:30 PM, Jon Evans wrote: Fixes: https://bugs.launchpad.net/kicad/+bug/1751183 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] validators

Hi Wayne, The primary issue is that they try to do all their validation through OnChar(). As JP mentioned, this leads to problems like typing 0 to start a number. But it also means the only way they have to guarantee a number is to allow only digits, zero-or-one minus sign, and zero-or-one

Re: [Kicad-developers] Packaging question

2018-02-25 23:29 GMT+01:00 Wayne Stambaugh : > Stephen, > > I would say that you should pull from HEAD of each library. This will > probably be acceptable up to the stable release. At this point we will > have to tag each repo. Are any of our library devs planning on

Re: [Kicad-developers] Packaging question

2018-02-25 23:18 GMT+01:00 Carsten Schoenert : > Am 25.02.2018 um 22:25 schrieb Nick Østergaard: > > One final question - does the kicad team guide package development on > each > > of the various distros, or is it up to each distro owner to sort out how > to > > best

Re: [Kicad-developers] [PATCH] Refactor post-load actions in PcbNew and apply them consistently

Patch merged. Thanks! On 02/25/2018 12:51 PM, Jon Evans wrote: Fixes: https://bugs.launchpad.net/kicad/+bug/1751589 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [PATCH] Fix regression in GerbView display settings; some optimization too

Patch merged. Thanks! On 02/25/2018 12:38 PM, Jon Evans wrote: The attached fixes a regression where the view would not be updated immediately when changing some GerbView display settings.  It also introduces a new method to VIEW that allows quick updating of a subset of flags on all items,

Re: [Kicad-developers] Packaging question

Am 25.02.2018 um 22:25 schrieb Nick Østergaard: > One final question - does the kicad team guide package development on each > of the various distros, or is it up to each distro owner to sort out how to > best package the project for their distro? > > I think every other packager shall look at

Re: [Kicad-developers] RPATH issue on _pcbnew.so

We can test it for macOS as well. I'm spending some time on it every day at this point to get it ready for v5, so now is the perfect time :) On Feb 25, 2018 4:16 PM, "Wayne Stambaugh" wrote: > hauptmech, > > Would you please attach this change as a committed patch when

Re: [Kicad-developers] Packaging question

Stephen, I would say that you should pull from HEAD of each library. This will probably be acceptable up to the stable release. At this point we will have to tag each repo. Are any of our library devs planning on doing any major reorganization of the libraries between now and the stable

Re: [Kicad-developers] validators

Jeff, I'm not opposed to this solution but I need technical information as to why we should use one solution over another. "Brain dead" is not a technical reason and doesn't really help me make an informed decision. I've used validators for simple edit control validation in the past and

Re: [Kicad-developers] RPATH issue on _pcbnew.so

hauptmech, Would you please attach this change as a committed patch when you get a chance? I want to test this on windows and linux and maybe we can get one of our macos devs to test it there as well. I would like to work out any packaging issues as soon as possible to give our package devs

[Kicad-developers] Windows Nightlies Installer - Unable to check components for instal

Hi, Is this intended behaviour? Downloaded: http://downloads.kicad-pcb.org/windows/nightly/kicad-r9594.21f46776c-x86_64.exe The unchecked components in the image below cannot be checked. [image: Inline image 1] -- Remember The Past, Live The Present, Change The Future Those who look only to

Re: [Kicad-developers] Improving Eagle Import netlist matching

Just wondering what approach we are going to use for v5? Global labels or my latest matching algorithm? Kind Regards Russell On 25 Feb 2018 08:43, "Russell Oliver" wrote: > Hi Orson, > > I looked at the Kicad project from the and I don't see any global labels, > just

Re: [Kicad-developers] Packaging question

Den 25. feb. 2018 3.44 PM skrev "Steven A. Falco" : Now that 5.0.0-rc1 is out, I'd like to ask how this should be packaged. In particular, I'm using Fedora, and my private builds are built based on the mechanisms from the "fedora-packaging" repo on github. However, the

Re: [Kicad-developers] [PATCH] GerbView performance optimizations

One more performance patch for GerbView attached On Sun, Feb 25, 2018 at 3:14 PM, Jon Evans wrote: > These patches improves redraw performance when toggling sketch/filled draw > modes. > > On Linux at least, the difference is quite noticeable on complicated > Gerber files. >

[Kicad-developers] [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

This patch uses simple iteration instead of the RTREE search to update the layer order and color in VIEW. On my Linux system, this results in a ~50% speedup in release build (less in debug build) and is most noticeable when switching layers in GerbView with large Gerber files loaded (i.e. high

Re: [Kicad-developers] Decimal separator characters

I guess this is addressed with Michaels patch in that bug, or are there still any open questions? Den 23. feb. 2018 6.24 PM skrev "Jeff Young" : > We had a discussion a while back about local-specific decimal characters > in which JP made the point that we don’t have any use for

Re: [Kicad-developers] Fabrication Outputs and Plot

Thanks for your replies. I think there's a consensus that this needs improving and restructuring, but given your emails, it sounds like a big task :) In the meantime, would you accept the attached patch to change the order in which "Fabrication Outputs" is listed in the menu? Before: Fabrication

[Kicad-developers] [PATCH] GerbView performance optimizations

These patches improves redraw performance when toggling sketch/filled draw modes. On Linux at least, the difference is quite noticeable on complicated Gerber files. -Jon From 04cb51708ff6f46773b3f1acad2b8b8e9adf2db6 Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Sun, 25 Feb

[Kicad-developers] [PATCH] Refactor post-load actions in PcbNew and apply them consistently

Fixes: https://bugs.launchpad.net/kicad/+bug/1751589 From c8e31559693753a6fd9cfaab29c5d77e01122a7b Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Sun, 25 Feb 2018 12:52:52 -0500 Subject: [PATCH] Refactor post-load actions in PcbNew and apply them consistently Fixes:

[Kicad-developers] [PATCH] Fix regression in GerbView display settings; some optimization too

The attached fixes a regression where the view would not be updated immediately when changing some GerbView display settings. It also introduces a new method to VIEW that allows quick updating of a subset of flags on all items, which speeds up toggling of transparency and high-contrast mode in

Re: [Kicad-developers] A fix for our TEXT_CTRL_EVAL class.

Cool. I'll just wait till Michael’s changes are merged. > On 25 Feb 2018, at 15:14, jp charras wrote: > > Le 25/02/2018 à 15:03, Jeff Young a écrit : >> Cool. Thanks for the confirmation, Michael. >> >> BTW, JP, could you let me know if you’re going to make this

Re: [Kicad-developers] A fix for our TEXT_CTRL_EVAL class.

Le 25/02/2018 à 15:03, Jeff Young a écrit : > Cool.  Thanks for the confirmation, Michael. > > BTW, JP, could you let me know if you’re going to make this change.  I’ve > been doing some work in > the NumericEvaluator to support the new units architecture and the hungarian > notation is

[Kicad-developers] Packaging question

Now that 5.0.0-rc1 is out, I'd like to ask how this should be packaged. In particular, I'm using Fedora, and my private builds are built based on the mechanisms from the "fedora-packaging" repo on github. However, the "fedora-packaging" repo still pulls in the "kicad-libraries" repo from kicad

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

There is a similar issue with "New" and "Append Board" operations, but it existed way before Jon's improvements. I've created a bug report, so it not gets lost: https://bugs.launchpad.net/kicad/+bug/1751589 Andrzej W dniu 2018-02-23 o 13:18, jp charras pisze: Le 23/02/2018 à 01:04, Jon Evans

Re: [Kicad-developers] A fix for our TEXT_CTRL_EVAL class.

Cool. Thanks for the confirmation, Michael. BTW, JP, could you let me know if you’re going to make this change. I’ve been doing some work in the NumericEvaluator to support the new units architecture and the hungarian notation is starting to hurt my brain, so I’d like to reformat it (for

Re: [Kicad-developers] Stable 5 development.

Just a quick heads up. The development branch of kicad is open so feel free to push bug fixes as we work towards rc2. Thanks, Wayne On 02/24/2018 07:53 PM, Wayne Stambaugh wrote: It didn't take much to convince me.  I've made the changes.  We are still at rc1 and marching on to rc2.

Re: [Kicad-developers] A fix for our TEXT_CTRL_EVAL class.

The original idea was to have one evaluator object per dialog so that several text entries could access a common set of variables. Now that there is one evaluator object per entry field I think there is no reason to retain the (single) input text in clear(). If there is ever to be support for

[Kicad-developers] [PATCH 5/8] fix misspelled 'Occassionally' -> 'Occasionally'

From: Carsten Schoenert --- pcbnew/dialogs/dialog_freeroute_exchange_help.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pcbnew/dialogs/dialog_freeroute_exchange_help.html b/pcbnew/dialogs/dialog_freeroute_exchange_help.html index

[Kicad-developers] [PATCH 7/8] fix misspelled 'streching' -> stretching

From: Carsten Schoenert --- common/gal/opengl/gl_builtin_shaders.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/gal/opengl/gl_builtin_shaders.cpp b/common/gal/opengl/gl_builtin_shaders.cpp index dff1e627c..009caba05 100644 ---

[Kicad-developers] [PATCH 1/8] fix misspelled 'accesing' -> 'accessing'

From: Carsten Schoenert --- common/gal/opengl/gl_builtin_shaders.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/gal/opengl/gl_builtin_shaders.cpp b/common/gal/opengl/gl_builtin_shaders.cpp index 450960a76..dff1e627c 100644 ---

[Kicad-developers] [PATCH 3/8] fix misspelled 'Modifed' -> 'Modified'

From: Carsten Schoenert --- pcbnew/dimension.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pcbnew/dimension.cpp b/pcbnew/dimension.cpp index 9a5ae136a..617f75f90 100644 --- a/pcbnew/dimension.cpp +++ b/pcbnew/dimension.cpp @@ -230,7 +230,7 @@

[Kicad-developers] [PATCH 4/8] fix misspelled 'neeeded' -> 'needed'

From: Carsten Schoenert --- eeschema/sch_eagle_plugin.cpp | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/eeschema/sch_eagle_plugin.cpp b/eeschema/sch_eagle_plugin.cpp index f4f134fa6..57e2d0f3f 100644 ---

[Kicad-developers] [PATCH 8/8] fix misspelled 'Unkown' -> 'Unknown'

From: Carsten Schoenert --- eeschema/drc_erc_item.cpp | 2 +- pcbnew/pcbnew_config.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eeschema/drc_erc_item.cpp b/eeschema/drc_erc_item.cpp index b5fe9b1d6..15a893cca 100644 ---

[Kicad-developers] [PATCH 2/8] fix misspelled 'Appearence' -> 'Appearance'

From: Carsten Schoenert --- pcbnew/dialogs/dialog_keepout_area_properties_base.fbp | 2 +- pcbnew/dialogs/dialog_non_copper_zones_properties_base.fbp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Kicad-developers] A fix for our TEXT_CTRL_EVAL class.

Hmmm, pObj isn’t stored. Since we use an instance of NumericEvaluator for each control, we don’t actually need the storage to be a map (there’s only ever one key in it). For now, probably easiest to just do: NumericEvaluator :: clear( const void* pObj ) { free(clToken.token);

Re: [Kicad-developers] A fix for our TEXT_CTRL_EVAL class.

Hi JP, Rather than calling evaluate() in the new TEXT_CTRL_EVAL::SetValue(), I’d call clear(), and add these two lines to NumericEvaluator::clear(): void NumericEvaluator :: clear() { free(clToken.token); clToken.token = nullptr; clToken.input = nullptr; bClError =

Re: [Kicad-developers] Stable 5 development.

I’ll be eradicating the global g_UserUnit for 6.0, but it won’t be in 5.0. Cheers, Jeff. > On 25 Feb 2018, at 08:35, Andrey Kuznetsov wrote: > > I thought there was also variable renaming, can't remember if it was global > variables or other variables. > > On Sun, Feb

[Kicad-developers] A fix for our TEXT_CTRL_EVAL class.

Hi Orson, Could you have a look into this small patch. I am not sure I used the better way to fix an issue. It fixes an issue when using SetValue() to change the value shown by this widget. The issue was due to the fact TEXT_CTRL_EVAL stores internally the last entered value in a buffer. So

Re: [Kicad-developers] Stable 5 development.

I thought there was also variable renaming, can't remember if it was global variables or other variables. On Sun, Feb 25, 2018 at 12:31 AM, jp charras wrote: > Le 25/02/2018 à 03:12, Andrey Kuznetsov a écrit : > > Just curious, a month back there were some emails

Re: [Kicad-developers] Stable 5 development.

Le 25/02/2018 à 03:12, Andrey Kuznetsov a écrit : > Just curious, a month back there were some emails discussing about major > variable renames, it was > decided to wait until people finished committing major features to avoid > rebasing every patch. > > Has this been done? > Are you talking