Re: [Kicad-developers] SIM_PLOT_TYPE

2019-11-06 Thread Ian McInerney
I would guess that is a mistake. It seems that the intention is to eventually have both linear and log scaling, so they would need to be different. Right now though it looks like log scaling isn't handled differently (a search for SPT_LOG_FREQUENCY returns a TODO comment and an if check that is

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Wayne Stambaugh
I forgot to mention in my last response that the commit message is still not correct. You have a line that is 95 characters wide. The limit is 75. I recommend a good text editor that allows you to set the fixed text width to 80 characters so it is obvious when you are violating the line width.

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Wayne Stambaugh
This patch does not apply cleanly against master using `git am`. Did you forget to rebase against the master branch before creating your patch? Wayne On 11/6/19 5:48 PM, Jonatan Liljedahl wrote: > Ok, now I think I've followed the policies correctly, here's the updated > patch. > > Cheers >

Re: [Kicad-developers] 5.1 branch commits

2019-11-06 Thread Jeff Young
Oops. At least one of those was mine. Apologies. Cheers, Jeff. > On 6 Nov 2019, at 22:08, Wayne Stambaugh wrote: > > Just a reminder, please do not push any commits to the 5.1 branch unless > it fixes a high priority bug (crash or data loss) without letting the > dev team know. I want to

[Kicad-developers] [PATCH] Pcbnew drill sizes statistics & Project manager multiple selection options

2019-11-06 Thread Mikołaj Wielgus
Hello, I have submitted two patches on Launchpad some time ago. I would like to ask for feedback. Links: https://bugs.launchpad.net/kicad/+bug/1841144 https://bugs.launchpad.net/kicad/+bug/1016464 Best Regards, Mikołaj Wielgus ___ Mailing list:

[Kicad-developers] 5.1 branch commits

2019-11-06 Thread Wayne Stambaugh
Just a reminder, please do not push any commits to the 5.1 branch unless it fixes a high priority bug (crash or data loss) without letting the dev team know. I want to avoid the 5.1.1 and 5.1.3 disasters. Looking at the commits that flew in under the radar I didn't see anything that looked like

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Holger Vogt
If you have just done a single simulation, creating one plot, it will be sufficient to query the current plot by /* return to the caller a pointer to the name of the current plot */ char* ngSpice_CurPlot(void) and then use char** ngSpice_AllVecs(char* plotname) About the 'plot' notion in

[Kicad-developers] Commit message format

2019-11-06 Thread Wayne Stambaugh
I should have done this a long time ago. We now have an official commit message format[1]. I have been asking new developers to follow it. Given that the members of lead development team haven't been doing great job of this (myself included) either, I'm going to start dinging commits that don't

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Holger Vogt
Before that you need to know the plots you might have generated during simulation: /* return to the caller a pointer to an array of all plots created by ngspice. Last entry in the array is NULL. */ char** ngSpice_AllPlots(void) Am 06.11.2019 um 22:49 schrieb Holger Vogt: You may invoke the

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Wayne Stambaugh
When in doubt, consult the Oracle of ngspice ;) Thanks Holger! On 11/6/19 4:49 PM, Holger Vogt wrote: > You may invoke the shared ngspice api function > > char** ngSpice_AllVecs(char* plotname) > > /* return to the caller a pointer to an array of vector names in the plot > named by plotname.

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Sylwester Kocjan
Hi, I was working too on pt.4 from 1814188, but frankly, I misunderstood that and I added search textbox to filter signal list. Do you think is it still worth any effort? My code is here: https://github.com/skocjan/kicad_initialconditions/tree/SIM_FindSignalDlg Interaction between searchCtrl

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Holger Vogt
You may invoke the shared ngspice api function char** ngSpice_AllVecs(char* plotname) /* return to the caller a pointer to an array of vector names in the plot named by plotname. Last entry in the array is NULL. */ It would be nice if there was a way to query ngspice for a list of vectors

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Wayne Stambaugh
Hi Jonathon, I tested your original patch on the 5.1 branch and it seems to work as advertised. It would be nice if there was a way to query ngspice for a list of vectors rather than using just the net list to populate add signals dialog. Maybe Holger can weigh in on this. Before you submit

[Kicad-developers] SIM_PLOT_TYPE

2019-11-06 Thread Jonatan Liljedahl
in sim_types.h: //> Possible plot types enum SIM_PLOT_TYPE { // Y axis SPT_VOLTAGE = 0x01, SPT_CURRENT = 0x02, SPT_AC_PHASE= 0x04, SPT_AC_MAG = 0x08, // X axis SPT_TIME= 0x10, SPT_LIN_FREQUENCY = 0x20,

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Jonatan Liljedahl
This patch does not implement all of pt 4 in that bug report, it only allows adding plots of vectors by name, including vectors created by LET statements in a spice text block in the schematic (which are not listed in the signals list, since that list is based on the net names, not the existing

[Kicad-developers] Symbol library code changes

2019-11-06 Thread Wayne Stambaugh
I finally finish up the initial attempt at simple inheritance for the symbol library code. The change is non-trivial and will likely have some unexpected side affects that I missed. I pushed the branch to my personal repo[1] and I would like a few pair of extra eyes on it before I merge it into

Re: [Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Sylwester Kocjan
Hi Jonatan, On 06/11/2019 13:29, Jonatan Liljedahl wrote: useful for plotting calculated vectors ("let AB=V(a)*V(b)"), see for example https://forum.kicad.info/t/ac-analysis-of-op-amp-loop-gain-and-phase/19661/6 Just small remark to limit entropy in bug reports: it looks like you have

Re: [Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Brian Piccioni
Kiway is a “sockets” (I think that is the correct term) system for communications between things like eeSchema and PCBNew. That’s how if you select a part in PCBNew and have eeSchema running it highlights the part in the schematic. The way I envision the prototype working is that I’ll prepare

Re: [Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Alexander Shuklin
Hi, thanks for answers! Brian, I will definitely like to give a hand. But before start everything I need to study things guys talking about. I haven't really look about KIWAY yet. Probably after that I will have more clear look how to implement that. And many thanks for suggestions and advices.

Re: [Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Brian Piccioni
Brian here. My utility is up on GitHub as a standalone app. I learned enough c++ and wxWidgets so porting it to Kicad should be useful. I set porting it to Kicad itself to the side for a few months so I could catch up with life and since it is destined for V6 (IIRC) I have some time. While

Re: [Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Jon Evans
Eeschema now keeps its internal net state up to date continuously, but I didn't work on any continuous syncing to PcbNew. The way it works in Eeschema, the graphical schematic is still the driving source of truth; the netlist does not drive the schematic. -Jon On Wed, Nov 6, 2019 at 9:08 AM Ian

Re: [Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Ian McInerney
I thought that was part of the connectivity stuff that Jon was working on (it certainly wasn't me, and I don't know if there is another Ian contributing code right now). I remember seeing some email threads on real-time updates to the information in Eeschema. The wishlist item that Wayne

Re: [Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Simon Richter
Hi, On Wed, Nov 06, 2019 at 08:26:52AM -0500, Wayne Stambaugh wrote: > > May I implement some back annotation feature from PCB to schematic? > You are welcome to contribute to KiCad. I suspect it will not be as > easy as you think it will be. Complex schematic hierarchies (using the > same

Re: [Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Wayne Stambaugh
Hi Alexander, On 11/6/19 5:39 AM, Alexander Shuklin wrote: > Hi all, > I used some Python script to renumber components in PCB and annotate > it back to schematics. I think now it's usually done by parsing .sch > file as a plain text and re-writing references inside. This is fine for your own

[Kicad-developers] [PATCH] simulation: allow entering signals (spice vectors) by name

2019-11-06 Thread Jonatan Liljedahl
useful for plotting calculated vectors ("let AB=V(a)*V(b)"), see for example https://forum.kicad.info/t/ac-analysis-of-op-amp-loop-gain-and-phase/19661/6 -- /Jonatan http://kymatica.com 0001-simulation-allow-entering-signals-spice-vectors-by-n.patch Description: Binary data

[Kicad-developers] Back annotate references from PCB

2019-11-06 Thread Alexander Shuklin
Hi all, I used some Python script to renumber components in PCB and annotate it back to schematics. I think now it's usually done by parsing .sch file as a plain text and re-writing references inside. May I implement some back annotation feature from PCB to schematic? I looked a bit and probably