Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-28 Thread Maciej Sumiński
, Russell Oliver wrote: > Awesome, > > I'm excited to finally see v5 come to pass. I think we should nickname the > release, Godot, since we have all be waiting for it for so long. > > Russ > > On Mon, Feb 26, 2018 at 9:59 PM Maciej Sumiński <maciej.sumin...@cern.ch

Re: [Kicad-developers] GerbView: ASSERT: wxRound(): argument out of supported range

2018-02-27 Thread Maciej Sumiński
Clemens, Please report problems on the bug tracker. It is much easier for us to coordinate the work this way. There is a high chance that your report on the mailing list will be lost in a few days due to high traffic on the mailing list. Thank you for understanding. Cheers, Orson On 02/27/2018

Re: [Kicad-developers] A fix for our TEXT_CTRL_EVAL class.

2018-02-27 Thread Maciej Sumiński
Hi Jean-Pierre, Thank you for investigating the issue, I think you are correct about the changes. The attached patches follow Jeff's suggestion about resetting the previous expression value in NumericEvaluator, but only the modified expression is cleared. I realize that right now there is no

Re: [Kicad-developers] [PATCH] expose BOARD_COMMIT to python

2018-02-27 Thread Maciej Sumiński
Hi Miles, On 02/27/2018 09:20 AM, miles mccoo wrote: > Is the patch required? It appears that I don't need it. > > However... > > I would like to know what formatting errors I made in the patch. Avoid it > next time. - in .cpp files there are two empty lines between consecutive methods

Re: [Kicad-developers] [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

2018-02-26 Thread Maciej Sumiński
~80ms to ~30ms > on my machine) > We can consider revisiting this later to eliminate the need for > dynamic_cast by ensuring that anything that VIEW calls on an item it owns > is a member of that object. > > -Jon > > On Mon, Feb 26, 2018 at 11:03 AM, Maciej Sumiński <

Re: [Kicad-developers] [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

2018-02-26 Thread Maciej Sumiński
, Orson On 02/26/2018 04:12 PM, Wayne Stambaugh wrote: > Orson, > > That's what I was doing so it sounds like it might be something with > your setup. > > Wayne > > On 2/26/2018 9:30 AM, Maciej Sumiński wrote: >> Wayne, >> >> I meant selecting any lay

Re: [Kicad-developers] [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

2018-02-26 Thread Maciej Sumiński
son, > > What do you mean by "any layer switching"? I am not have any issues on > windows when selecting a different layer in the layer manager using > either canvas when launched from kicad or stand alone mode. > > Cheers, > > Wayne > > On 2/26/

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-26 Thread Maciej Sumiński
at you are getting global labels >>> using >>>> the Arduino project. Can you send me your copy of the project and the >>> kicad >>>> files that are generated? >>> >>> Sure, this is the official Arduino Mega 2560 rev3 [1]. I uploaded the &

Re: [Kicad-developers] [PATCH] Ensure ROUTER_PREVIEW_ITEM draws on top of all normal layers

2018-02-26 Thread Maciej Sumiński
Thank you Jon, I have just committed your patch. Cheers, Orson On 02/26/2018 12:18 AM, Jon Evans wrote: > Fixes: https://bugs.launchpad.net/kicad/+bug/1751646 > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to :

Re: [Kicad-developers] PPA: KiCad 5.0

2018-02-26 Thread Maciej Sumiński
Does it mean there are no more documentation updates for 5.0 foreseen/accepted? On 02/26/2018 11:13 AM, Nick Østergaard wrote: > kicad-doc and kicad-i18n has been tagged > > 2018-02-26 10:53 GMT+01:00 Jean-Samuel Reynaud : > >> Dear All, >> >> Following KiCad 5.0 tagging,

Re: [Kicad-developers] [PATCH] Don't use the RTREE in UpdateAllLayersOrder() / UpdateAllLayersColor()

2018-02-26 Thread Maciej Sumiński
Jon, With this patch applied, any layer switching in pcbnew leads to a crash, even with no layout loaded. Can anyone else confirm this? See the the attached address sanitizer report for details. Regards, Orson On 02/25/2018 10:01 PM, Jon Evans wrote: > This patch uses simple iteration instead

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-22 Thread Maciej Sumiński
Good catch, thank you Andrzej. I have just committed your patch to the master branch. Cheers, Orson On 02/22/2018 02:43 PM, Andrzej Wolski wrote: > Wayne, > > thanks for merging. I have a complementary patch that fixes problem with > selecting hidden tracks. > > Cheers, > Andrzej > > > On

Re: [Kicad-developers] eeschema patch, ngspice simulation bjt carac use case

2018-02-22 Thread Maciej Sumiński
Hi Ludovic, Thank you very much for your simulator improvements, it looks very promising. I see there is a lot of changes to the code and I am a bit afraid to push it to the master branch right now, when we are so close to v5 release. I am going to review it in details and merge it as soon as v5

Re: [Kicad-developers] [PATCH] Don't recache items unnecessarily when toggling D-code display

2018-02-22 Thread Maciej Sumiński
Hi Jon, Thank you for the patch, I have just pushed it to the master branch. Cheers, Orson On 02/22/2018 05:12 AM, Jon Evans wrote: > Hi all, > > This patch improves the logic for d-code display in GerbView so that there > is now no cost in toggling the codes on or off. They are still slow to

Re: [Kicad-developers] wxPython/wxWidgets compatibility check

2018-02-21 Thread Maciej Sumiński
8:19* CMake Error at CMakeLists.txt:710 (message): >>>>> *17:58:19* >>>>> *17:58:19* >>>>> *17:58:19* wxWidgets and wxPython use different toolkits ( vs msw). >>> It will result in >>>>> *17:58:19* a broken build. Please eit

Re: [Kicad-developers] wxPython/wxWidgets compatibility check

2018-02-20 Thread Maciej Sumiński
that > drags in wxPython when only the KICAD_SCRIPTING option is enabled. > > Cheers, > > Wayne > > On 2/20/2018 2:40 AM, Maciej Sumiński wrote: >> Hi Nick, >> >> Thank you for testing the patch. I think a hint about disabling >> scripting is a good idea

Re: [Kicad-developers] New menu structure tweaks

2018-02-20 Thread Maciej Sumiński
Thank you Michael, the menu indeed looks better with your changes. I have pushed your patch to the master branch. Cheers, Orson On 02/20/2018 01:40 AM, Michael Kavanagh wrote: > Minor modification. Sorry for the noise. > > On 19 February 2018 at 23:07, Michael Kavanagh >

Re: [Kicad-developers] wxPython/wxWidgets compatibility check

2018-02-19 Thread Maciej Sumiński
Hi Nick, Thank you for testing the patch. I think a hint about disabling scripting is a good idea. Do you know if it is enough just to disable wxPython or rather everything scripting related should be turned off? There is a different warning when GTK3 is detected as the wxWidgets toolkit.

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-19 Thread Maciej Sumiński
xcept for >>> the visual >>> >> aspect. Though I think just replacing the global net on the >>> pcb with the >>> >> net from the schematic with the matching end label ( >>> ignoring any sheet >

Re: [Kicad-developers] Kicad-from-scratch: Segfault after unarchiving active project.

2018-02-16 Thread Maciej Sumiński
Hi Jeff, Many thanks for quick reaction. I have just pushed your patch. Cheers, Orson On 02/16/2018 03:22 PM, Jeff Young wrote: > Hi Clemens, > > If you build your own Kicad, you can try the patch attached to the below bug > report. > > Cheers, > Jeff. > >> On 16 Feb 2018, at 13:00, Jeff

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-16 Thread Maciej Sumiński
was some discussion > about this patch. Do we have path forward on this yet? I would like to > get this into rc1 if possible. > > Thanks, > > Wayne > On 02/14/2018 08:17 AM, Russell Oliver wrote: >> Please find the attached patch for this issue.  >> >>

Re: [Kicad-developers] Git tags for 5.x.x-rc1 yet?

2018-02-16 Thread Maciej Sumiński
Hi Clemens, RC1 is not released/tagged yet, Wayne plans to do it this weekend [1]. Regards, Orson 1. https://lists.launchpad.net/kicad-developers/msg33890.html On 02/16/2018 12:04 PM, Clemens Koller wrote: > Hi, There! > > I am wondering if I am following the right git repository on

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

2018-02-15 Thread Maciej Sumiński
son, > > Did you fix the IS_ACCELERATOR issue in patch 0002 when calling > AddHotkeyName()? > > Wayne > > On 2/15/2018 11:00 AM, Maciej Sumiński wrote: >> To reduce the discussion scope, I have committed the obvious improvements: >> 0001-Fix-spelling-error.patch >

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

2018-02-15 Thread Maciej Sumiński
To reduce the discussion scope, I have committed the obvious improvements: 0001-Fix-spelling-error.patch 0002-Improve-edit-menu-and-use-common-hotkeys.patch 0004-Remove-duplicate-track-menu-item.patch To be discussed: 0003-Fix-up-file-menu-and-hotkeys.patch 0005-Add-missing-tools-to-menubar.patch

Re: [Kicad-developers] string coherence and a wish

2018-02-15 Thread Maciej Sumiński
Hi Marco, For some reason, I have not received your original message. On 02/15/2018 09:00 AM, Marco Ciampa wrote: > On Fri, Feb 09, 2018 at 11:27:49AM +0100, Marco Ciampa wrote: >> Hi devs, >> just a small heads-up: > > I waited a few days, don't want to harass. > > Please feedback even

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-14 Thread Maciej Sumiński
, Russell Oliver wrote: > Please find the attached patch for this issue. > > On Tue, Feb 13, 2018 at 2:34 AM Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: > >> Hi Russell, >> >> On 02/11/2018 05:41 AM, Russell Oliver wrote: >>> Hi All, >

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

2018-02-14 Thread Maciej Sumiński
Well done, Michael! There is one more patch that should go with these changes (see the attachment), otherwise Linux users see some asserts. I mostly agree with Jeff's remarks below, but IMHO your patches are already a huge improvement in their current state. On 02/14/2018 02:23 AM, Jeff Young

Re: [Kicad-developers] New OpenGL debug stuff crashes pcbnew on startup

2018-02-14 Thread Maciej Sumiński
Good point, in the end I have added an explicit check using GLEW extensions query. Regards, Orson On 02/14/2018 06:44 AM, Mark Roszko wrote: > FYI, GL_DEBUG_OUTPUT is only available starting OpenGL4 so users with > older video cards/drivers are probably the ones having issues. >

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

2018-02-13 Thread Maciej Sumiński
is required. >> >>> >>> >>> >>> On 13 Feb 2018 02:59, "Wayne Stambaugh" <stambau...@gmail.com >>> <mailto:stambau...@gmail.com>> wrote: >>> >>> I prefer adding an empty.kicad_wks file be added to the pro

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

2018-02-12 Thread Maciej Sumiński
a file format change, but it also provides the option to > those that do not want a border to specify it for a schematic. > > Kind Regards > Russell > > > On Thu, Feb 8, 2018 at 10:25 PM Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: > >> There i

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-12 Thread Maciej Sumiński
Hi Russell, On 02/11/2018 05:41 AM, Russell Oliver wrote: > Hi All, > > I've discovered the cause of a problem when importing Eagle Projects and > getting the schematic and boards synced. > > Currently when importing an Eagle schematic, labels for nets that are only > found one Eagle sheet are

Re: [Kicad-developers] [PATCH] Eagle schematic import, label placement fix.

2018-02-12 Thread Maciej Sumiński
Thank you Russell, I have just pushed your patch. Regards, Orson On 02/11/2018 03:55 AM, Russell Oliver wrote: > This fixes an issue i found during some testing. Small labels are added to > connect segments sharing the same net name in the eagle schematic. These > were placed in the middle of a

Re: [Kicad-developers] New OpenGL debug stuff crashes pcbnew on startup

2018-02-11 Thread Maciej Sumiński
On 02/10/2018 12:05 PM, jp charras wrote: > Le 10/02/2018 à 10:54, jp charras a écrit : >> Le 09/02/2018 à 20:08, Wayne Stambaugh a écrit : >>> Linux and windows are find for me. >>> >>> On 02/09/2018 01:14 PM, Jeff Young wrote: Mac-only? >> >> Mac-only?: No. For me, it crashes on Windows (W7

Re: [Kicad-developers] Zone fill hangup - more info

2018-02-09 Thread Maciej Sumiński
Steven, Please try 86566fc1 or newer, it may fix the problem. Regards, Orson On 02/08/2018 09:15 PM, Steven A. Falco wrote: > I continue to have problems performing a zone fill with the latest kicad 5 > builds. A copy of the project that is causing me trouble is here: > >

Re: [Kicad-developers] Another performance patch....

2018-02-09 Thread Maciej Sumiński
Jeff, Thank you for the patches, I have just tested the one for KiCad. While I do not see any difference when launching the footprint list dialog for the first time (~6s on a debug build), the subsequent ones are significantly faster (~2.6s reduced to ~0.6s). I tested: - removing a footprint

Re: [Kicad-developers] UI changes for 5.0?

2018-02-08 Thread Maciej Sumiński
On 02/09/2018 08:00 AM, Marco Ciampa wrote: > On Fri, Feb 09, 2018 at 07:34:41AM +0100, Carsten Schoenert wrote: >> Am 09.02.2018 um 01:54 schrieb Wayne Stambaugh: >>> For the libs, docs, and translations, I'm ok if we hold off tagging >>> until the stable release if that works for you. >> >>

Re: [Kicad-developers] Pads front and F.Cu visibility, possible bugs?

2018-02-08 Thread Maciej Sumiński
As you noticed, one can only define simple layer visibility dependencies in GAL using SetRequired() method. Effectively, you can quickly disable a whole layer when another is invisible, but it does not handle well cases of e.g. texts whose visibility should depend both on the layer and the parent

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

2018-02-08 Thread Maciej Sumiński
0))\n"  >> > >> > JP mentions in a comment to the bug report that there is a legacy >> > compatibility requirement to have at least one item in the page >> layout, >> > otherwise the default layout it used. This was for old schematics t

Re: [Kicad-developers] eeschema ngspice simulation improvment

2018-02-08 Thread Maciej Sumiński
Apparently you got it to work, cool! What was the actual problem? Do you use ngspice v26 or v27? Would you share the patch? Regards, Orson On 02/08/2018 11:19 AM, ludovic léau-mercier wrote: > I work on. First result in attachment. > > > On 08/02/2018 10:07, Maciej Sumiński

Re: [Kicad-developers] eeschema ngspice simulation improvment

2018-02-08 Thread Maciej Sumiński
Hi Ludovic, If I recall correctly, when you run an analysis different than transient, ngspice will not return any data when you ask for currents. There is also another related line: void NETLIST_EXPORTER_PSPICE_SIM::writeDirectives( OUTPUTFORMATTER* aFormatter, unsigned aCtl ) const { // Add

Re: [Kicad-developers] wxGTK3 patches

2018-02-08 Thread Maciej Sumiński
...and for some reason antialiasing stays enabled anyway. I retract the question. Cheers, Orson On 02/08/2018 09:01 AM, Maciej Sumiński wrote: > One more question, I have just realized that I disabled antialiasing > when USE_WX_GRAPHICS_CONTEXT is enabled. Is that fine for macOS or >

Re: [Kicad-developers] wxGTK3 patches

2018-02-08 Thread Maciej Sumiński
y) or is not updated at all. >> +Refresh(); >> +#endif >>>>> >> will make it slow (might cause double painting every time because of how it >> is already handled right now without the extra refresh). >> >> I’ll report (if no other macOS guy

Re: [Kicad-developers] wxGTK3 patches

2018-02-07 Thread Maciej Sumiński
every operation, otherwise the cursor >>>> leaves a trail (when xor >>>> +// operation is changed to copy) or is not updated at all. >>>> +Refresh(); >>>> +#endif >>>>>>> >>>> will make it slow (might cause double painting

Re: [Kicad-developers] Build broken against glm 0.9.8.4

2018-02-07 Thread Maciej Sumiński
/07/2018 03:53 PM, Steven A. Falco wrote: > On 02/07/2018 08:46 AM, Maciej Sumiński wrote: >> Thank you Steven, that is a valuable data point. Would you try updating >> gcc or building KiCad with clang? I guess that could gives the final answer. >> >> Regards,

[Kicad-developers] wxGTK3 patches

2018-02-07 Thread Maciej Sumiński
Two patches to fix some troubles occurring on wxGTK3. The first one displays a warning when it detects that KiCad is being built against wxGTK3. The second one makes eeschema functional, just a bit slower when compared to wxGTK2. The only thing that is really broken is pcbnew printing, but there

Re: [Kicad-developers] Build broken against glm 0.9.8.4

2018-02-07 Thread Maciej Sumiński
Thank you Steven, that is a valuable data point. Would you try updating gcc or building KiCad with clang? I guess that could gives the final answer. Regards, Orson On 02/07/2018 02:34 PM, Steven A. Falco wrote: > On 02/07/2018 08:16 AM, Maciej Sumiński wrote: >> Hi Steven, >&g

Re: [Kicad-developers] [PATCH] Don't draw invisible pins in component chooser

2018-02-07 Thread Maciej Sumiński
: > We could hold this until after 5.0 and either add an ERC check, or better > yet make it so that you can't actually make connections to invisible pins? > > -Jon > > On Feb 7, 2018 08:29, "Maciej Sumiński" <maciej.sumin...@cern.ch> wrote: > >> Hi Way

Re: [Kicad-developers] [PATCH] Don't draw invisible pins in component chooser

2018-02-07 Thread Maciej Sumiński
; On Mon, Jan 15, 2018 at 4:24 AM, Rene Pöschl <poesc...@gmail.com >> <mailto:poesc...@gmail.com>> wrote: >> >> On 15/01/18 10:00, Maciej Sumiński wrote: >> >> Perhaps we should have an ERC rule >> that warns about invisible pins being

Re: [Kicad-developers] Build broken against glm 0.9.8.4

2018-02-07 Thread Maciej Sumiński
Hi Steven, Could you confirm that e0f7958d breaks Fedora builds? It is a bit strange, as I build KiCad against the same glm version and there are no errors reported. Another peculiar issue is that the error is reported for a file that has not been touched in the mentioned commit. Regards, Orson

Re: [Kicad-developers] [PATCH] Bug #1731802 Unable to open eagle footprint lib, No error message just empty footprint editor

2018-02-06 Thread Maciej Sumiński
Thank you Russell. I confirm your patch fixed the problem, so I merged it to the master branch. Regards, Orson On 02/04/2018 03:21 AM, Russell Oliver wrote: > Fixes the bug by removing a line that deleted the imported footprint > templates every time the plugin init function is called. > > >

Re: [Kicad-developers] [PATCH] Add empty eeschema page layout for Eagle schematic import. Bug #1729722

2018-02-06 Thread Maciej Sumiński
Hi Russell, Thank you very much for the patch. It works as expected and I would like to merge it, but there are two things. I have simplified the patch a bit (moved the empty layout to an existing file, minor code formatting fixes), so please confirm you are ok with committing it under your

Re: [Kicad-developers] [PATCH] Increase initial vertex container size by order of magnitude

2018-02-01 Thread Maciej Sumiński
Hi Jon, TL;DR: I have no idea why it boosts the performance. I would love to see some extra input from others, to see if patch helps on other systems or at least does not decrease performance on low-spec cards. It is hard to explain why do you see a performance boost. I tried it on my machine

Re: [Kicad-developers] Documentation update

2018-01-31 Thread Maciej Sumiński
On 01/31/2018 01:03 PM, Marco Ciampa wrote: > On Wed, Jan 31, 2018 at 12:43:34PM +0100, Maciej Sumiński wrote: >> On 01/31/2018 12:35 PM, Marco Ciampa wrote: >>> On Wed, Jan 31, 2018 at 12:16:50PM +0100, Maciej Sumiński wrote: >>>> Does anyone currently work on the

Re: [Kicad-developers] Documentation update

2018-01-31 Thread Maciej Sumiński
On 01/31/2018 12:35 PM, Marco Ciampa wrote: > On Wed, Jan 31, 2018 at 12:16:50PM +0100, Maciej Sumiński wrote: >> Does anyone currently work on the user documentation updates? I plan to >> do so, but I would rather avoid work duplication. >> >> Regards, >> Orso

[Kicad-developers] Documentation update

2018-01-31 Thread Maciej Sumiński
Does anyone currently work on the user documentation updates? I plan to do so, but I would rather avoid work duplication. Regards, Orson signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers

Re: [Kicad-developers] Blue lines on selected objects?

2018-01-31 Thread Maciej Sumiński
Yes, it is normal. It is done to make finding corresponding reference/value easier. Cheers, Orson On 01/31/2018 11:12 AM, Jeff Young wrote: > I’m trying to figure out if I broke something on my build, or if it’s always > been that way and I just didn’t notice. > > In pcbnew (OpenGL) when you

Re: [Kicad-developers] Is this OSX-specific or not?

2018-01-26 Thread Maciej Sumiński
No problem on Linux. Cheers, Orson On 01/26/2018 03:59 PM, Jeff Young wrote: > I’m trying to see if a bug is OSX-specific or not. > > Open board in pcbnew. > Open Plot dialog. > Click on the Run DRC button at the bottom. > Click on Cancel in the DRC dialog. > > Can you now close the Plot

Re: [Kicad-developers] Kicad Build Issue on Ubuntu

2018-01-26 Thread Maciej Sumiński
Hi Babar, You need to install wxPython development files, package python-wxgtk3.0-dev or similar. Regards, Orson On 01/26/2018 02:45 PM, Babar Malik wrote: > Dear all, > I am trying to build Kicad on Ubuntu 14.04 but I am facing a problem with > "wxPython". I tried a lot to install this package

Re: [Kicad-developers] process to push improvement

2018-01-26 Thread Maciej Sumiński
Hi Ludovic, You did the right thing, normally people send their patches here for review and proposed changes receive comments or get committed. I have tested your patch and it works as expected, so I pushed it to the master branch. Thank you! One thing I would suggest is to commit your changes

Re: [Kicad-developers] [RFC] Pin edition coupling description

2018-01-25 Thread Maciej Sumiński
re how clear the icon will be to users but >> it makes more sense to me than the current icon. The wording definitely >> makes more sense. Thanks for fixing this. >> >> Cheers, >> >> Wayne> >> On 1/24/2018 9:28 AM, Maciej Sumiński wrote: >>> I attach

Re: [Kicad-developers] Loading symbol libraries

2018-01-24 Thread Maciej Sumiński
I believe there is only one code path leading to this function. Would you post the full stacktrace? On 01/24/2018 04:59 PM, Jeff Young wrote: > 75% (!) of the time building the component tree is spent here: > > bool SCH_LEGACY_PLUGIN_CACHE::IsFile( const wxString& aFullPathAndFileName ) > const

Re: [Kicad-developers] [RFC] Pin edition coupling description

2018-01-24 Thread Maciej Sumiński
On 01/23/2018 05:43 PM, Rene Pöschl wrote: [snip] > I am not so sure the default state should be enabled. If i understand it > correctly the enabled state would result in pins being modified without > the user directly noticing it. (If they are on the same position but in > a different unit, they

Re: [Kicad-developers] [RFC] Pin edition coupling description

2018-01-24 Thread Maciej Sumiński
/01/2018 à 16:55, Maciej Sumiński a écrit : >> On 01/23/2018 04:35 PM, jp charras wrote: >>> Le 23/01/2018 à 12:18, Maciej Sumiński a écrit : >>>> I am trying to find a better description for pin edition coupling in the >>>> symbol library editor (the rightmost bu

Re: [Kicad-developers] [RFC] Pin edition coupling description

2018-01-23 Thread Maciej Sumiński
On 01/23/2018 04:35 PM, jp charras wrote: > Le 23/01/2018 à 12:18, Maciej Sumiński a écrit : >> I am trying to find a better description for pin edition coupling in the >> symbol library editor (the rightmost button on the top toolbar). My >> proposal is in the attached p

[Kicad-developers] [RFC] Pin edition coupling description

2018-01-23 Thread Maciej Sumiński
I am trying to find a better description for pin edition coupling in the symbol library editor (the rightmost button on the top toolbar). My proposal is in the attached patch, but perhaps one of our native English speakers can come up with a clearer description. Cheers, Orson From

Re: [Kicad-developers] Trouble with libngspice build script

2018-01-22 Thread Maciej Sumiński
Hi Jeff, Have you run './autogen.sh' after cloning the repository? I attach a fixed script that should work with any bison coming from brew. Let me know if it fixes your problem, so I can commit it. Cheers, Orson On 01/22/2018 02:52 PM, Jeff Young wrote: > I’m having trouble getting the

Re: [Kicad-developers] Oval Pads in Zones

2018-01-19 Thread Maciej Sumiński
After reading the bug report, I consider the changes proposed by Julius sensible. What do you think? In particular I am asking our geometry experts. Regards, Orson On 11/02/2017 03:18 PM, Julius Schmidt wrote: > Hello, > > I filed a bug [1] a while ago pertaining to oval pads in zones leading >

Re: [Kicad-developers] [PATCH] Clear autoplaced flag when modifiying field orientation/justification

2018-01-19 Thread Maciej Sumiński
Thank you Jon, I have just verified the changes and pushed your patch to the master branch. Regards, Orson On 01/18/2018 03:51 AM, Jon Evans wrote: > Fixes: https://bugs.launchpad.net/kicad/+bug/1743893 > > -Jon > > > > ___ > Mailing list:

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

2018-01-18 Thread Maciej Sumiński
I pushed both patches to the master branch. Jon, thank you for your contribution to KiCad. Cheers, Orson On 01/17/2018 05:54 PM, Maciej Sumiński wrote: > I have just tested the patch on a Windows virtual machine where KiCad > normally crashed and it seems that the fallback mechanism

Re: [Kicad-developers] Kicad and ngspice 27 undefined reference

2018-01-18 Thread Maciej Sumiński
I started using ngspice-27 with KiCad a long time ago, never had such problems (Arch Linux). Regards, Orson On 01/18/2018 06:25 AM, Lachlan Audas wrote: > Hi, was trying to compile the latest Dev build of KiCad with version of > ngspice 27 > and getting the following undefined reference, > >

Re: [Kicad-developers] [PATCH] Filter via selection based on render settings

2018-01-18 Thread Maciej Sumiński
Thank you Jon, I pushed your patch to the master branch. Cheers, Orson On 01/18/2018 03:12 AM, Jon Evans wrote: > Fixes: https://bugs.launchpad.net/kicad/+bug/1743894 > > -Jon > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers >

Re: [Kicad-developers] Request for advice on building an exporting capability from Scheme-it to KiCad

2018-01-18 Thread Maciej Sumiński
Hi Ed, Thank you for interest in KiCad. The approach depends on what you want to achieve, if you simply want to create a board basing on schematics exported from Scheme-it, then a netlist file should be enough. Unfortunately, I am not aware of a document describing KiCad netlist format, but it is

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

2018-01-18 Thread Maciej Sumiński
; > I think I found the issue. New patch attached (this time I actually think it > will fix the issue). > > Thanks, > Jeff. > > > > On 17 Jan 2018, at 16:16, Maciej Sumiński > <maciej.sumin...@cern.ch<mailto:maciej.sumin...@cern.ch>> wrote: > >

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

2018-01-17 Thread Maciej Sumiński
without OpenGL support might crash even before KiCad has a chance to throw an exception (X.Org error). Perhaps this case could be resolved with Jon's patch. Cheers, Orson On 01/17/2018 04:30 PM, Maciej Sumiński wrote: > An alternative approach attached. Perhaps the two patches could be > co

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

2018-01-17 Thread Maciej Sumiński
I start dragging a footprint, mouse cursor is >>> warped back to the drag origin, so the footprint is never moved. If >>> footprint was previously selected, then selection is cleared, but it is >>> still stuck. >>> >>> Cheers, >>> Orson >>>

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

2018-01-17 Thread Maciej Sumiński
An alternative approach attached. Perhaps the two patches could be combined for extra safety. Cheers, Orson On 01/16/2018 08:15 PM, Maciej Suminski wrote: > For me - not entirely, but definitely it is better than the current > implementation. If you run KiCad for the first time and select

Re: [Kicad-developers] Future plans on the KiCad library releases?

2018-01-17 Thread Maciej Sumiński
On 01/17/2018 11:05 AM, Rene Pöschl wrote: [snip] > The reason for this not being able to be auto tested is that one > can not really parse a datasheet automatically. Minor off-topic: you may want to have a look at uConfig [1]. I do not claim it is a perfect tool, as I doubt it is possible to

Re: [Kicad-developers] Future plans on the KiCad library releases?

2018-01-17 Thread Maciej Sumiński
Hi Matthijs, On 01/17/2018 08:55 AM, Matthijs Kooijman wrote: [snip] > Additionally, I don't really want to think about this when upgrading. If > I upgrade the libraries package, I really want to still be able to just > use all official libraries, without having to check after each upgrade > if

Re: [Kicad-developers] [PATCH] Defer canvas type setting save until destruction of EDA_DRAW_FRAME

2018-01-16 Thread Maciej Sumiński
I have already read the patch, and IMHO it has a chance to fix the problem. Right now I am building KiCad on an ultraslow virtual machine that does not support OpenGL 2.1, so stay tuned! Cheers, Orson On 01/16/2018 05:26 PM, Jon Evans wrote: > Wayne/Orson, I'm not sure Chris will have time to

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

2018-01-16 Thread Maciej Sumiński
Same is true whether footprint/pad was previously selected or not. > Same is true with trackpad 3-finger drag. > > Is one of these wrong, or are you seeing different behaviour? > > Thanks, > Jeff. > >> On 16 Jan 2018, at 12:24, Maciej Sumiński <maciej.sumin...@cern.c

Re: [Kicad-developers] One more quick plug for reducing "Clarify Selection" dialogs

2018-01-16 Thread Maciej Sumiński
Hi Jeff, I apologize for long delay. I have just reviewed and tested your patch and the changes look fine, but there is one thing that needs to be addressed before they can be accepted. Dragging a footprint with mouse cursor does not work anymore, cursor simply gets stuck at the drag origin

Re: [Kicad-developers] KiCad And Quces

2018-01-16 Thread Maciej Sumiński
On 01/16/2018 09:38 AM, Christian Gagneraud wrote: > CC Qucs's maintainer, please feel free to extend. > > On 16 January 2018 at 21:14, Babar Malik wrote: >> I am much more interested to integrate Kicad and Qucs, and the first step >> towards this would be to study the

Re: [Kicad-developers] [PATCH] Ensure DrawRectangle() stroke outline will always be visible

2018-01-16 Thread Maciej Sumiński
Hi Jon, On 01/16/2018 05:09 AM, Jon Evans wrote: > SELECTION_AREA::ViewDraw() doesn't set the line width. I thought about > fixing it by adding a call to set some kind of arbitrary width, but decided > to do it a different way to be more generally applicable. Despite my > saying that, this is

Re: [Kicad-developers] [PATCH] Save view control settings before dispatching new tool events

2018-01-15 Thread Maciej Sumiński
I confirm your patch fixes the problem, so I pushed it to the master branch. Many thanks for solving another issue! Regards, Orson On 01/12/2018 04:13 AM, Jon Evans wrote: > Fix another cause of https://bugs.launchpad.net/kicad/+bug/1741357 > > Using the "add via" hotkey was causing an

Re: [Kicad-developers] Via dialog to support

2018-01-15 Thread Maciej Sumiński
For the record: this patch was committed on 10th January. On 01/06/2018 11:47 PM, kristoffer Ödmark wrote: > Attached patch that implements the via choices, they seem to render fine > and work as expected under linux. > > I guess that not many tests with different vias, since they have been >

Re: [Kicad-developers] [PATCH] LSET::UIOrder and LSET::Technicals now match layer widget order

2018-01-15 Thread Maciej Sumiński
Thank you Jon, I have just pushed your patch. Regards, Orson On 01/12/2018 04:32 AM, Jon Evans wrote: > Fixes: https://bugs.launchpad.net/kicad/+bug/1673792 > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to :

Re: [Kicad-developers] [PATCH] Don't draw invisible pins in component chooser

2018-01-15 Thread Maciej Sumiński
Hi Jon, It seems there is no patch attached to this message. I realize it is better to hide invisible pins when they obscure the view, but I wonder whether the user should be at least aware of their presence. In case a symbol does not follow the KLC and has invisible pins exposed, then it can

Re: [Kicad-developers] Launchpad janitor down?

2018-01-15 Thread Maciej Sumiński
ened here? There is > no comment from lp janitor. > > https://bugs.launchpad.net/kicad/+bug/1740593 > > It is fixed by c842787492004da849ae1aef7945310f5a07 > > 2018-01-08 9:11 GMT+01:00 Maciej Sumiński <maciej.sumin...@cern.ch>: > >> It is a Python script

Re: [Kicad-developers] [PATCH] Implement primitive icon scaling for high DPI

2018-01-09 Thread Maciej Sumiński
Hi Chris, The patch does not apply cleanly on the current master, would you rebase it? Thanks in advance. Cheers, Orson On 01/09/2018 03:43 AM, Chris Pavlina wrote: > Hi, > > As discussed with Wayne earlier, I've attached a patch which adds simple > toolbar icon scaling so the toolbars are

Re: [Kicad-developers] get_libngspice_so.sh link broken

2018-01-08 Thread Maciej Sumiński
I agree, it is better to keep it easily accessible. I added the script to the repository as suggested. Regards, Orson On 01/04/2018 06:12 PM, Wayne Stambaugh wrote: > I suppose we could add it to scripts/ folder in the source tree. > > On 01/04/2018 07:18 AM, Mark Roszko wrote: >> The

Re: [Kicad-developers] Launchpad janitor down?

2018-01-08 Thread Maciej Sumiński
It is a Python script invoked via WSGI, so it needs an HTTP server with python-wsgi support, Python itself and a few Python libraries (launchpadlib, git). The code is on Launchpad [1] and there is a short README about setting it up. I think it would be much better if we could move it a more

Re: [Kicad-developers] help with redraw

2017-12-21 Thread Maciej Sumiński
Hi Andreas, You might be missing VIEW::Update() [1] call to invalidate a VIEW_ITEM after it has been modified. If it does not help, I will have a look at the code. Cheers, orson 1.

Re: [Kicad-developers] SELECTION_TOOL::guessSelectionCandidates()

2017-12-21 Thread Maciej Sumiński
Hi Jeff, I applied a different patch, but it should be fine now (more explanations in the bug report). Cheers, Orson On 12/20/2017 05:59 PM, Jeff Young wrote: > Hi Maciej, > > Could you have a look at bug https://bugs.launchpad.net/bugs/1739425 > ? >

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

2017-12-20 Thread Maciej Sumiński
> with merging this. Otherwise, we should hold off until the version 6 > development. > > Cheers, > > Wayne > > On 12/20/2017 4:53 AM, Maciej Sumiński wrote: >> Hi Andreas, >> >> I tested the patch with many boards and I confirm it reduces the polygon >> c

Re: [Kicad-developers] [RFC] Eeschema bus upgrades and new connectivity algorithm

2017-12-20 Thread Maciej Sumiński
Hi Kristoffer, No offence, but is there any added value in using a configurable separator character or is it just your preference? It seems to me that adding such feature will complicate the code a lot for a small benefit, but I may not see the full picture. Perhaps it is just a convention that

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

2017-12-20 Thread Maciej Sumiński
Hi Andreas, I tested the patch with many boards and I confirm it reduces the polygon complexity, without introducing any DRC violations. I would love to merge it, but it is difficult for me to assess the risk of adding new bugs, which are particularly not wanted during the feature freeze. If

Re: [Kicad-developers] [PATCH] Fi build error on macOS

2017-12-19 Thread Maciej Sumiński
Hi Bernhard, Thank you for the patch, I have just pushed it to the master branch. Regards, Orson On 12/19/2017 01:33 PM, Bernhard Stegmaier wrote: > Hi, > > Attached patch fixes 2 build errors on macOS. > Just fixed the build error, no test of the plugin. > > > Regards, > Bernhard > > > >

Re: [Kicad-developers] macOS 3d-viewer improvements

2017-12-18 Thread Maciej Sumiński
Hi Bernhard, I tested your patches on Linux and Windows 7 and I have not noticed any problems, so I pushed them to the master branch. Thank you! Regards, Orson On 12/17/2017 10:55 PM, Bernhard Stegmaier wrote: > Hi Wayne, > > sorry, I obviously have copied a wx-3.1 only constructor. > Please

Re: [Kicad-developers] All kinds of glitches because polygons don't have an origin. Also: Outline ?

2017-12-13 Thread Maciej Sumiński
Henner, Thank you for the message and your findings, I am sure they will be useful for fixing the problem. I turned this into a bug report, so it is not forgotten [1]. Cheers, Orson 1. https://bugs.launchpad.net/kicad/+bug/1738032 On 11/21/2017 06:26 AM, Henner Zeller wrote: > Hi, > I am

Re: [Kicad-developers] [PATCH] bugfix: OPENGL_GAL::DrawPolygon did not close closed polygons

2017-12-13 Thread Maciej Sumiński
Thank you Andreas, I have just pushed your patch to the master branch. Cheers, Orson On 12/10/2017 11:01 PM, Andreas Buhr wrote: > Dear Kicad developers, > > The polygon drawing routing in the OpenGL-GAL did > not plot polygons which are "closed", i.e. have a segment > from their last point to

<    1   2   3   4   5   6   7   8   9   >