Re: [Kicad-developers] Possibility of uninitialised variable in RN_DATA::Add

2016-09-25 Thread Maciej Sumiński
Hi John, Good catch, thank you for the patch. I have just committed it and simplified the related code parts a bit. Regards, Orson On 09/23/2016 08:01 PM, John Beard wrote: > Hi, > > If RN_DATA::Add is called with a BOARD_ITEM* aItem where > aItem->IsConnected() fails (and it's not a module or

Re: [Kicad-developers] pcbnew tools uses long instead of intptr_t

2016-09-21 Thread Maciej Sumiński
Hi Gustav, Thank you, your patch is sensible. I have just applied it to the master branch. Regards, Orson On 09/18/2016 01:04 AM, Gustav Bergquist wrote: > Hello, > > I just managed to setup a build environment on windows and noticed that > kicad/pcbnew/tools/pcb_editor_control.cpp >

Re: [Kicad-developers] [PATCH] Remove assert in pcbnew on osx with a debug build

2016-09-19 Thread Maciej Sumiński
n console on every redraw (even just moving the mouse around) > > although these are only visible in debug mode they drive me nuts when > doing a lot of restarts to debug something > > thanks > > Simon > > > > On Mon, Sep 19, 2016 at 11:53 PM, Maciej Sumiński >

Re: [Kicad-developers] [PATCH] Remove assert in pcbnew on osx with a debug build

2016-09-19 Thread Maciej Sumiński
Hi Simon, Can you give more details about the assert? Perhaps it is a different problem and should be solved in another way. wxWidgets documentation[1] says it is necessary to create a wxPaintDC object, even if it is not used. IIRC GAL worked on every platform even when it has not created

Re: [Kicad-developers] [PATCH] Include header instead of full source

2016-09-16 Thread Maciej Sumiński
Hi Simon, Shame on me, thank you for catching this. I have just applied your patch to the master branch. Regards, Orson On 09/16/2016 07:54 AM, Simon Richter wrote: > --- > pcbnew/class_board_connected_item.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >

Re: [Kicad-developers] Spice simulator: need info about net names versus net number option

2016-09-15 Thread Maciej Sumiński
Hi Jean-Pierre, We have decided to use net numbers, as it was convenient for us. They were already available, and Spice to eeschema maps are map instead of map. I doubt it would really influence the performance, as anyway the majority of the simulation time is

Re: [Kicad-developers] pcbnew zoom bug in OpenGL at min zoom, Any one else seeing this ?

2016-09-14 Thread Maciej Sumiński
Hi Lachlan, I cannot reproduce the problem on any of the machines I have at hand. Would you give more details? Does it happen with every board? How about Cairo? What video card do you have? I would be grateful if this message was transformed into a proper bug report, otherwise it is likely to

Re: [Kicad-developers] PNS router patches batch #1

2016-09-06 Thread Maciej Sumiński
On 09/01/2016 06:12 PM, Michael Steinberg wrote: > Hello, > > as part of my efforts on the pns-router some refactoring patches are > attached. Prefix-numbers indicate the patch order. > The router is moved into namespace PNS, some places are decorated with > unique_ptr usage, some code quality

[Kicad-developers] Undo buffer refactor

2016-09-05 Thread Maciej Sumiński
Recently I was refactoring the undo buffer code [1], as I have mentioned sometime ago. The main goal was to make the code simpler and more generic, remove some redundant parts. Short changelog: - BOARD_COMMIT class. Wrapper around undo buffer to simplify storing changes. Also performs all the

Re: [Kicad-developers] Blured text on OpenGL

2016-08-31 Thread Maciej Sumiński
Hi, There were no recent changes to bitmap fonts. Perhaps we could try the solution Michael had suggested, but no promises on the dates. Regards, Orson On 08/30/2016 06:11 PM, Mário Luzeiro wrote: > Hi all, > > I had a feeling yesterday, on the openGL mode that looks different: low-res >

Re: [Kicad-developers] [PATCH] Simulator: Fix probe and tune cursors on OSX.

2016-08-30 Thread Maciej Sumiński
Thank you Johannes, I have just applied your patch. This part of code is a truly a demonstration of wxWidgets platform independence. Good that at least they give you hints. Today I got an assert: "failed in Add(): invalid bitmap size in wxImageList: this might work on this platform but definitely

Re: [Kicad-developers] [PATCH] Update version string formatting after git migration

2016-08-27 Thread Maciej Sumiński
On 08/27/2016 06:06 PM, Chris Pavlina wrote: > Sure, if you're trying to pin down an _exact_ commit...but how does the > fake bzr revno help you there? The bzr repo isn't used anymore, it's not > like you can just check the bzr log for it. > > All you need is a sense of how old it is. If you need

Re: [Kicad-developers] Git transition

2016-08-22 Thread Maciej Sumiński
This is really excellent news! Thank you Wayne! The webhook is already set, let's fix a few bugs to see if it works. Just to remind you, there is a git config file that should ease marking commits as bug fixes [1]. Cheers, Orson 1. https://lists.launchpad.net/kicad-developers/msg25728.html On

Re: [Kicad-developers] Git transition

2016-08-21 Thread Maciej Sumiński
On 08/21/2016 05:30 PM, Wayne Stambaugh wrote: [snip] > To all my developers with commit access, please do not commit any > changes to the product branch until further notice. I am going to > attempt to switch the project over to use git as the default vcs > sometime later today and I don't want

Re: [Kicad-developers] Stable release 4.0.4

2016-08-19 Thread Maciej Sumiński
Hi Bruno, It is a duplicate of #1606332 and it is already fixed in both stable & product branches. Regards, Orson On 08/19/2016 04:44 PM, Bruno Andrade wrote: > I posted the Bug #1614821, should it be fixed too? > > On Fri, Aug 19, 2016 at 10:24 AM, Wayne Stambaugh >

Re: [Kicad-developers] [PATCH v2] Complete str[n]icmp -> str[n]casecmp

2016-08-16 Thread Maciej Sumiński
Thank you Simon, I have committed your patch in revision 7060. Regards, Orson On 08/15/2016 08:51 PM, Simon Richter wrote: > > This also reverses the substitution logic if strcasecmp is missing. > --- > CMakeModules/config.h.cmake| 8 > common/class_bitmap_base.cpp

Re: [Kicad-developers] Differential pair settings per net class

2016-08-15 Thread Maciej Sumiński
; KiCad version. > > On Mon, Aug 15, 2016 at 05:37:31PM +0200, Maciej Sumiński wrote: >> On 08/15/2016 04:34 PM, Wayne Stambaugh wrote: >> [snip] >>> Orson, >>> >>> Go ahead an merge this. In the short term, we can bump the rev for each >>> change

Re: [Kicad-developers] Differential pair settings per net class

2016-08-15 Thread Maciej Sumiński
On 08/15/2016 04:34 PM, Wayne Stambaugh wrote: [snip] > Orson, > > Go ahead an merge this. In the short term, we can bump the rev for each > change and see how it goes. If it becomes problematic, we can readdress > it then. I don't want this to slow down development. I will say up > front,

Re: [Kicad-developers] Differential pair settings per net class

2016-08-15 Thread Maciej Sumiński
On 08/12/2016 05:57 PM, Chris Pavlina wrote: > On Fri, Aug 12, 2016 at 05:18:57PM +0200, Maciej Sumiński wrote: >> There is a set of patches for the PNS router [1] coded by Tom that we >> would like to commit soon (a few teasers: locking tracks & vias, >> removing tracks w

Re: [Kicad-developers] Broken setlocale in sim/ngspice.cpp

2016-08-15 Thread Maciej Sumiński
On 08/15/2016 03:03 PM, jp charras wrote: > The reason is setlocale( LC_ALL, "" ); switches the locale to the system > locale, not the previously > set locale. > It creates serious issues if the previous locale or the Kicad locale is not > the system locale. > (For instance if you are using

Re: [Kicad-developers] Testing Tom’s integrated ngspice simulator on Mac OSX

2016-08-15 Thread Maciej Sumiński
m libs due to the bundle >> utilities cmake script bundling everything else >> >> Simon >> >> On Tue, Aug 9, 2016 at 1:43 AM, Maciej Sumiński <maciej.sumin...@cern.ch> >> wrote: >>> Hi Bernhard, >>> >>> The case is similar to othe

Re: [Kicad-developers] [PATCH] Remove definition of log10(double)

2016-08-15 Thread Maciej Sumiński
Thank you Simon. I have committed your patch in revision 7031. Regards, Orson On 08/12/2016 09:17 PM, Simon Richter wrote: > > This is also defined in , and likely to be a compiler intrinsic. > --- > common/widgets/mathplot.cpp | 6 -- > 1 file changed, 6 deletions(-) > > > >

[Kicad-developers] Differential pair settings per net class

2016-08-12 Thread Maciej Sumiński
There is a set of patches for the PNS router [1] coded by Tom that we would like to commit soon (a few teasers: locking tracks & vias, removing tracks while the router is active, 45-degree tuning meanders). One of the changes adds a possibility to specify differential pairs width & gap per net

Re: [Kicad-developers] Integrated Simulator

2016-08-12 Thread Maciej Sumiński
On 08/12/2016 04:38 PM, Wayne Stambaugh wrote: [snip] >> Hi Orson, >> >> I saw your commit. Thanks for addressing this issue in a timely mannor. >> I have on minor comment. FindFoo.cmake files should always have an >> option to override the default find location which should take >> precedence

Re: [Kicad-developers] Integrated Simulator

2016-08-12 Thread Maciej Sumiński
On 08/11/2016 05:37 PM, Wayne Stambaugh wrote: > Congratulations on everyone who made the is happen. This is a nice > feature for KiCad and hopefully users will find it useful. > > There are a few things will need to addressed that I missed when I > initially evaluated the code. > > Maybe I

Re: [Kicad-developers] Git transition

2016-08-12 Thread Maciej Sumiński
On 08/11/2016 08:28 PM, Wayne Stambaugh wrote: [snip] > I'll see if I can figure out how to do this and if it works we can use > it instead of adding the bug report url to the commit message. I wonder > if we can link a commit to a bug report? That could be an issue if we > cannot. I don't want

Re: [Kicad-developers] [PATCH] Memoize SHAPE_LINE_CHAIN bounding box computation

2016-08-11 Thread Maciej Sumiński
Just to let you know: I had asked Tom and he had had nothing against the patch, so Chris has committed it. Regards, Orson On 08/10/2016 04:19 PM, Wayne Stambaugh wrote: > Orson & Tom, > > Please look over this patch when you get a chance to see if it makes > sense to commit it. > > Thanks, >

Re: [Kicad-developers] Integrated Simulator

2016-08-11 Thread Maciej Sumiński
I have just merged the ngspice branch. It is still required to enable KICAD_SPICE switch in cmake in order to use it, so it does not cause problems on systems without ngspice library installed. Regards, Orson On 08/05/2016 09:40 PM, Maciej Sumiński wrote: > I had spoken with ngspice d

Re: [Kicad-developers] Git transition

2016-08-11 Thread Maciej Sumiński
On 08/10/2016 03:34 PM, Wayne Stambaugh wrote: > On 8/10/2016 5:02 AM, Maciej Sumiński wrote: >> On 08/08/2016 06:09 PM, Wayne Stambaugh wrote: >>> The last time I looked, notifications of repo commits still were not >>> implemented. This is a show stopper fo

Re: [Kicad-developers] Git transition

2016-08-10 Thread Maciej Sumiński
On 08/10/2016 04:49 PM, Chris Pavlina wrote: [snip] > Any particular reason for having (fixes lp:) in the first > line? Typically the first line of the commit message is kept very > short and limited to things one might need when quickly browsing a > log. The usual convention in git is to

Re: [Kicad-developers] Integrated Simulator

2016-08-10 Thread Maciej Sumiński
On 08/10/2016 02:43 PM, jp charras wrote: > Le 10/08/2016 à 10:21, jp charras a écrit : >> Le 10/08/2016 à 09:43, jp charras a écrit : >>> Le 10/08/2016 à 09:03, Maciej Sumiński a écrit : >>>> Hi Jean-Pierre, >>>> >>>> This is str

Re: [Kicad-developers] Git transition

2016-08-10 Thread Maciej Sumiński
with LP until something better comes along or we take full > control a provide our own hosting. > > On 8/8/2016 3:58 AM, Maciej Sumiński wrote: >> Apparently we have not discussed git transition for a long time now, so >> I felt it is the right time to raise the subject agai

Re: [Kicad-developers] Integrated Simulator

2016-08-10 Thread Maciej Sumiński
Hi Jean-Pierre, This is strange. I had the problem you describe (Windows 7 x86_64) and fixed it in commit ee24275f [1]. Does the cursor look fine if you revert the commit? What wxWidgets & Windows versions do you use? Regards, Orson 1.

Re: [Kicad-developers] Testing Tom’s integrated ngspice simulator on Mac OSX

2016-08-08 Thread Maciej Sumiński
>>> it won’t get merged anyhow. >>> >>> But, I have just asked the Homebrew devs if they think that a >>> separate „libngspice“ formula that just builds the library would >>> be OK for them. Let’s see what comes out of this… >>> >>

Re: [Kicad-developers] Testing Tom’s integrated ngspice simulator on Mac OSX

2016-08-08 Thread Maciej Sumiński
ebrew > formula. > > > Best, > Johannes > >> Am 01.08.2016 um 16:01 schrieb Adam Wolf <adamw...@feelslikeburning.com>: >> >> I'll make sure it works on the build server regardless of what homebrew does >> :) >> >> On Mon, Aug 1, 2016 at

[Kicad-developers] Git transition

2016-08-08 Thread Maciej Sumiński
Apparently we have not discussed git transition for a long time now, so I felt it is the right time to raise the subject again to keep our routine. Launchpad now supports merge proposals [1] and it looks like they are still improving git integration. The only missing feature are links between bug

Re: [Kicad-developers] Integrated Simulator

2016-08-05 Thread Maciej Sumiński
I had spoken with ngspice devs and they have suggested me a workaround for the bug. Unfortunately, it requires a patch that is currently not included in the release version, so we resort to building from the source again. To ease the pain, I have updated get_libngspice_so.sh [1]. Now it should

Re: [Kicad-developers] Integrated Simulator

2016-08-04 Thread Maciej Sumiński
On 08/02/2016 09:23 AM, Johannes Maibaum wrote: > Hi Orson, > >> Am 01.08.2016 um 15:08 schrieb Maciej Sumiński <maciej.sumin...@cern.ch >> <mailto:maciej.sumin...@cern.ch>>: >> >> Hi Jean-Pierre, >> >> Thank you for the wxWidgets patch, I ha

Re: [Kicad-developers] Integrated Simulator

2016-08-03 Thread Maciej Sumiński
TL;DR: I consider preparing a script that builds patched ngspice DLL to solve the problem. The bug stems from the fact that when an error occurs user is expected to answer whether the simulation should be continued with y/n. As there is no way we can answer the question when ngspice runs from a

Re: [Kicad-developers] Power components vs labels

2016-08-02 Thread Maciej Sumiński
ropriate symbol based on net name, place it, rename it to the selected > net" workflow? It can sit under the P hotkey in place of the filtered > selection we have now. > > On Aug 2, 2016 11:43 AM, "Maciej Sumiński" <maciej.sumin...@cern.ch> wrote: > &

Re: [Kicad-developers] Power components vs labels

2016-08-02 Thread Maciej Sumiński
On 08/02/2016 05:30 PM, Chris Pavlina wrote: > Moving this to a new thread. > >> On 8/2/2016 7:16 AM, Chris Pavlina wrote: >>> My implementation had a large number of symbols, would have allowed >>> user-supplied arbitrary symbols if I had finished it, and automatically >>> selected a symbol

Re: [Kicad-developers] About Bug 1604841: Pcbnew crash at moving via, and boost::context fixes to make it compatible with boost 1.61

2016-08-02 Thread Maciej Sumiński
Hi Michael, Good job, I know it was not trivial. I have just tested the patch against the same boost versions under Linux and it works as expected. Thank you for the fix, it has been committed in revision 7002. Regards, Orson On 08/02/2016 02:26 AM, Michael Steinberg wrote: > Hello all, > >

Re: [Kicad-developers] Integrated Simulator

2016-08-01 Thread Maciej Sumiński
red library has been built successfully!\e[0m > > Now, to finish the installation run the script as root with 'install' > parameter: > sudo ./get_libngspice_so.sh install > > В Понедельник, 1 авг. 2016 в 4:19 , Maciej Sumiński > <maciej.sumin...@cern.ch> написал: >>

Re: [Kicad-developers] Testing Tom’s integrated ngspice simulator on Mac OSX

2016-08-01 Thread Maciej Sumiński
Hi Johannes, Cool! I am really grateful for your fixes - they are already merged and I am going test them with Linux and Windows. I really hope homebrew developers will accept your formula soon, as it would make getting ngspice library so much simpler. Regards, Orson On 08/01/2016 12:40 PM,

Re: [Kicad-developers] Integrated Simulator

2016-08-01 Thread Maciej Sumiński
Hi Eldar, I would rather install the libraries to /usr/local, so they do not interfere with libraries installed by package managers. I guess I know what I kind of issue you have faced, and now it should be fixed in the new version get_libngspice_so.sh script [1]. Regards, Orson 1.

Re: [Kicad-developers] About Bug 1604841: Pcbnew crash at moving via, and boost::context fixes to make it compatible with boost 1.61

2016-08-01 Thread Maciej Sumiński
Hi Wayne, Jean-Pierre, Excuse my late answer, I was away for a week. I could not reproduce the problem here, so right now I am unable to say whether it fixes the recent issue. I will try again later with another virtual machine. I believe the stable branch is not affected by the bug, but we will

Re: [Kicad-developers] Integrated Simulator

2016-08-01 Thread Maciej Sumiński
On 07/23/2016 01:17 PM, jp charras wrote: > Le 22/07/2016 à 13:49, Tomasz Wlostowski a écrit : >> On 22.07.2016 13:36, jp charras wrote: >>> Le 22/07/2016 à 13:15, jp charras a écrit : Le 22/07/2016 à 11:59, Tomasz Wlostowski a écrit : > On 22.07.2016 11:56, Eldar Khayrullin wrote: >>

Re: [Kicad-developers] Integrated Simulator

2016-08-01 Thread Maciej Sumiński
Hi Tom, Thank you for the report. I have just updated the get_libngspice_so.sh [1] script. Would you try it again? Regards, Orson 1. https://orson.net.pl/pub/libngspice/get_libngspice_so.sh On 07/22/2016 03:30 PM, Tom Andrews wrote: > Hi guys, > > Thanks very much for adding this feature for

Re: [Kicad-developers] About Bug 1604841: Pcbnew crash at moving via, and boost::context fixes to make it compatible with boost 1.61

2016-08-01 Thread Maciej Sumiński
On 08/01/2016 05:15 AM, Michael Steinberg wrote: > Hey, > > pinpointing the problem proved really difficult, I didn't expect it > where it was... > This bug existed before my 1.61-patch and did not surface because > DELEGATE would not clear its content on destruction. See the attached > patch. >

Re: [Kicad-developers] KiCad New Main Icon proposal

2016-07-06 Thread Maciej Sumiński
I am in favor of pencil removal too. What do you think about keeping the page with a folded corner as the icon base, and depending on the editor: - a part of schematic (like we have now) - a single component - a part of layout (like we have now) - a single footprint to show what is the editor

Re: [Kicad-developers] Trouble with bitmapped font

2016-07-06 Thread Maciej Sumiński
I am glad that you liked it. Surprisingly, I suspected that you are going to hate the new bitmap fonts the most due to antialiasing, so I see the patches as a quite positive change. Regards, Orson On 07/05/2016 09:56 PM, Lorenzo Marcantonio wrote: > On Tue, Jul 05, 2016 at 09:21:05PM +0200,

Re: [Kicad-developers] [PATCH 2/2] Avoid warning about int -> pointer conversion

2016-06-30 Thread Maciej Sumiński
On 06/30/2016 04:22 PM, Wayne Stambaugh wrote: > @Orson, please take a look at this patch and see if it makes sense when > you get a chance. It looks fine to me, but this is code that you are > more familiar with than I am. Hi Wayne, The first patch is already applied, and the second one is

Re: [Kicad-developers] replace_boost_function_boost_bind.patch: Replace boost::function and boost::bind with their std:: counterparts

2016-06-29 Thread Maciej Sumiński
On 06/28/2016 05:52 PM, Wayne Stambaugh wrote: > Orson, > > Since this mostly effects the new tool framework, I'll defer to your > judgement as to whether or not to commit this patch. I don't have a > strong opinion one way or the other since we will not be able to > completely eliminate boost

Re: [Kicad-developers] What's still missing in GAL?

2016-06-16 Thread Maciej Sumiński
Hi Chris, Have a look at the last summary, commented by Wayne [1] and a few reports tagged as such [2]. Perhaps we need to have a software renderer that offers decent speed, then we can either use wxDC or try to boost Cairo GAL performance (I have done some minor improvements [3], but probably

Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation

2016-06-14 Thread Maciej Sumiński
Is not the difference caused by the footprint anchor placed outside the footprint bounds? Just guessing. Regards, Orson On 06/14/2016 08:07 PM, firewalker wrote: > I am using it for some time now. > > One note for the component preview. For through hole components the pcb is > quite larger. >

Re: [Kicad-developers] Opengl issues after commit 6912/6913

2016-06-14 Thread Maciej Sumiński
; BUILD_GITHUB_PLUGIN=ON > > > On 13 June 2016 at 14:47, jp charras <jp.char...@wanadoo.fr> wrote: > >> Le 13/06/2016 à 09:52, Maciej Sumiński a écrit : >>> On 06/10/2016 07:20 PM, jp charras wrote: >>>> Hi, Orson, >>>> >>

Re: [Kicad-developers] Opengl issues after commit 6912/6913

2016-06-13 Thread Maciej Sumiński
On 06/13/2016 01:58 AM, Collin Anderson wrote: > This same behavior occurs on my OS X box as well. It also has coordinate > transformation issues if you try to lower the size of the window. Here, > rather than try and describe it, here is a gif (frame rate is low in the gif, > it is not

Re: [Kicad-developers] Opengl issues after commit 6912/6913

2016-06-13 Thread Maciej Sumiński
On 06/13/2016 01:58 AM, Collin Anderson wrote: > This same behavior occurs on my OS X box as well. It also has coordinate > transformation issues if you try to lower the size of the window. Here, > rather than try and describe it, here is a gif (frame rate is low in the gif, > it is not

Re: [Kicad-developers] Opengl issues after commit 6912/6913

2016-06-13 Thread Maciej Sumiński
On 06/11/2016 11:27 AM, Prabhu Sammandam wrote: > Hi All, > > I am also facing crashes in the following scenario. > > 1. Opened pcbnew and switched to OPENGL mode. Then invoked the Desing Rules > dialog, it crashed > 2. Opened pcbnew and invoked the properties dialog for the FP. Then if I >

Re: [Kicad-developers] Opengl issues after commit 6912/6913

2016-06-13 Thread Maciej Sumiński
On 06/10/2016 07:20 PM, jp charras wrote: > Hi, Orson, > > I have a new issue after commit 6912/6913: > I can switch from legacy to opengl canvas or cairo canvas, but once I have > switched from opengl to > cairo, I cannot switch to opengl: > the error message is > Couldn't create OpenGL context

Re: [Kicad-developers] [PATCH v2] Use size_t for sizes and offsets

2016-06-10 Thread Maciej Sumiński
On 06/10/2016 03:45 PM, Simon Richter wrote: > > This shouldn't affect code because these are compile time constants anyway, > but gets rid of some annoying warnings about casting integers to pointers > of different size. Thank you Simon. I have just committed this and patch "[PATCH 1/2] Avoid

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-09 Thread Maciej Sumiński
Hi Mario, I have just committed a patch that does your suggestion regarding setting contexts only when a different one is used. On 06/09/2016 12:09 AM, Mário Luzeiro wrote: [snip] >> In wxWidgets examples they do not need to set context, as there is only >> one, so there is no chance OpenGL

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-08 Thread Maciej Sumiński
Hi Mario, On 06/08/2016 08:09 PM, Mário Luzeiro wrote: > Hi Orson, > > I am back on testing this openGL issues. > I implemented your context manager in my branch. > It looks good the implementation (still need a bit style clean up your source > code file, eg: gl_context_mgr.cpp line 86) > > I

Re: [Kicad-developers] [PATCH 10/16] Replace unshared boost::shared_array with std::unique_ptr

2016-06-08 Thread Maciej Sumiński
Thank you Simon, committed in 6902. Regards, Orson On 06/07/2016 09:54 PM, Simon Richter wrote: > > These are never shared, so std::unique_ptr works fine, and std::unique_ptr > has a specialisation for array types that uses "operator delete[]", so this > is still correct. > --- >

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-07 Thread Maciej Sumiński
On 06/07/2016 03:41 PM, jp charras wrote: > Le 07/06/2016 à 15:14, Maciej Sumiński a écrit : >> On 06/03/2016 05:26 PM, jp charras wrote: >>> The 3D viewer does not crash. >>> >>> Only Opengl crashes if I switch to cairo, or when exiting pcbnew if I am in

Re: [Kicad-developers] [PATCH] Legacy: delete and force middle button pan for GAL consistency

2016-06-07 Thread Maciej Sumiński
I, for one, support the patch. I see it is not a hot topic with an endless discussion, so perhaps it is safe to commit. I hope this message is a gentle reminder to people who would vote against, if there are any. Regards, Orson On 06/04/2016 09:30 PM, Chris Pavlina wrote: > This is one of the

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-07 Thread Maciej Sumiński
On 06/03/2016 05:26 PM, jp charras wrote: > The 3D viewer does not crash. > > Only Opengl crashes if I switch to cairo, or when exiting pcbnew if I am in > legacy mode, and if I > used the opengl canvas during the session. > When exiting, if pcbnew is in opengl mode, no crash. Hi Jean-Pierre,

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-03 Thread Maciej Sumiński
On 06/03/2016 04:40 PM, jp charras wrote: > Le 03/06/2016 à 16:04, Maciej Sumiński a écrit : >> Hi, >> >> I have just pushed the mentioned changes. >> >> @Jean-Pierre, >> If you experience crash on exit with OpenGL GAL again, then we can >> revert c

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-03 Thread Maciej Sumiński
On 05/31/2016 05:53 PM, Maciej Sumiński wrote: > Jean-Pierre, Mario, > > I have just finished another approach to the OpenGL contexts problem > [1]. I will be grateful if you could test it. I have tried it out with 2 > window managers on Linux/64, and now I am rebuilding it on W7/64.

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-01 Thread Maciej Sumiński
On 05/31/2016 08:11 PM, jp charras wrote: > Thanks, Orson. > > This version fixes the crash on my W7, 32 bits. > > I am now trying to compile in debug mode, but I have an undefined symbol: > E:/kicad-launchpad/essais/opengl_ctx_fix/include/xnode.h:53: undefined > reference to `vtable for XNODE'

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-31 Thread Maciej Sumiński
On 05/29/2016 08:40 PM, jp charras wrote: [snip] > Hi, Orson, > > About the crash which happens in OPENGL_GAL dtor, when executing delete > OPENGL_GAL::glContext;, I am > now pretty sure the crash is due to an use after delete issue. > > If it is called when exiting the application, no problem.

Re: [Kicad-developers] Copy & operator=

2016-05-26 Thread Maciej Sumiński
On 05/26/2016 04:53 PM, Maciej Sumiński wrote: > On 05/26/2016 09:46 AM, jp charras wrote: >> Le 26/05/2016 à 08:59, Maciej Sumiński a écrit : >>> Thank you Cirilo. I am trying to be really careful here, that is why I >>> am asking for more details. I would like t

Re: [Kicad-developers] Copy & operator=

2016-05-26 Thread Maciej Sumiński
On 05/26/2016 04:51 PM, Wayne Stambaugh wrote: > On 5/26/2016 10:38 AM, Maciej Sumiński wrote: >> On 05/26/2016 09:46 AM, jp charras wrote: >>> Le 26/05/2016 à 08:59, Maciej Sumiński a écrit : >>>> Thank you Cirilo. I am trying to be really careful here, that is

Re: [Kicad-developers] Copy & operator=

2016-05-26 Thread Maciej Sumiński
On 05/26/2016 09:46 AM, jp charras wrote: > Le 26/05/2016 à 08:59, Maciej Sumiński a écrit : >> Thank you Cirilo. I am trying to be really careful here, that is why I >> am asking for more details. I would like to make the code simpler, so >> there are no more doubts about wh

Re: [Kicad-developers] Copy & operator=

2016-05-26 Thread Maciej Sumiński
On 05/26/2016 09:46 AM, jp charras wrote: > Le 26/05/2016 à 08:59, Maciej Sumiński a écrit : >> Thank you Cirilo. I am trying to be really careful here, that is why I >> am asking for more details. I would like to make the code simpler, so >> there are no more doubts about wh

Re: [Kicad-developers] Copy & operator=

2016-05-26 Thread Maciej Sumiński
> bar( a1 ); > bar( a2 ); > } > > bar( A0* bar ) > { > // now we want a copy of *bar - how do we do that? > > // the typical solution: > A0* newItem = bar->NewCopy(); > } > > > On Thu, May 26, 2016 at 12:03 AM, Maciej Sumiński <maciej.su

[Kicad-developers] Copy & operator=

2016-05-25 Thread Maciej Sumiński
I am trying to understand the meaning of Copy() method defined for some of BOARD_ITEMs. I would like to replace the method with operator= to make the code clearer, and then give it consistent behavior. I have noticed that Copy() implementations differ in: - clearing Pback/Pnext fields - setting a

Re: [Kicad-developers] PATCH: fix double-free bug in 3D model viewer

2016-05-24 Thread Maciej Sumiński
Hi Cirilo, I am wondering whether it really solves the problem. C++ standard ([1], 5.3.5.2) explicitly permits null pointer to be an argument for delete, so it should not crash there. I am afraid the problem might be a bit more entangled. Mario & me have already noticed a few cases when an

Re: [Kicad-developers] lost mipmaps after resume from suspend

2016-05-23 Thread Maciej Sumiński
Hi Mario, I have tried a few times and I cannot reproduce the problem. I am not sure if it is something we can fix, as I would not say it is KiCad's job to restore (video) memory contents on resume. To be honest, I consider this a video driver issue. Can you confirm that such problem exists only

Re: [Kicad-developers] Vacation

2016-05-13 Thread Maciej Sumiński
Excuse my RFC mail then, I promise that was the last one from my side. Enjoy your time in Europe! Cheers, Orson On 05/13/2016 03:27 PM, Wayne Stambaugh wrote: > Just a heads up for everyone. I will be leaving for Italy tomorrow for > a nice long family vacation until the 25th of May. Please

[Kicad-developers] [RFC] Undo buffer refactoring

2016-05-13 Thread Maciej Sumiński
I would like to solve once and for all the problem of GAL view/ratsnest not being occasionally updated. I am still getting related bug reports, as there are just many places in the source code that need to have "item->ViewUpdate(); ratsnest->Update(item)" added. 1. Replace UR_MODEDIT with

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-10 Thread Maciej Sumiński
latest, cleaning all the files and I > will be back with more info... > thanks > > > On 10/05/2016 17.50, Maciej Sumiński wrote: >> Do you get any error message? I am trying hard to reproduce the problem, >> but none of the available PCs expose the bug. I have tried Win

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-10 Thread Maciej Sumiński
Do you get any error message? I am trying hard to reproduce the problem, but none of the available PCs expose the bug. I have tried Win7 & Win10 64-bit. Both build with msys2/gcc 5.3, but I still cannot crash pcbnew. Are there any particular steps I need to perform? Open pcbnew empty? Load a

[Kicad-developers] Track locking

2016-05-09 Thread Maciej Sumiński
I have noticed there is an option to mark tracks & vias as 'locked' in the legacy canvas (right click on a track->Set Flags->Track: Locked. According to my observations, it is only used by Global Deletion dialog. Should we make locked tracks & vias behave like locked modules, so they cannot be

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-04 Thread Maciej Sumiński
On 05/04/2016 11:45 AM, jp charras wrote: > Le 04/05/2016 à 11:20, Maciej Sumiński a écrit : >> On 05/03/2016 04:48 PM, Wayne Stambaugh wrote: >> [snip] >>> Not quite yet. See attached screen shot on latest msys2/mingw32. The >>> Cairo version is 1.15.2. I

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-04 Thread Maciej Sumiński
On 05/03/2016 04:48 PM, Wayne Stambaugh wrote: [snip] > Not quite yet. See attached screen shot on latest msys2/mingw32. The > Cairo version is 1.15.2. I suppose it could be the graphics drivers on > my work laptop (it's one of the Intel HD graphics chips). I'll test it > on my home system

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-04 Thread Maciej Sumiński
work with the right context. Most of the time the OpenGL canvas is shown, therefore SetCurrent() will be called. The only moment when the canvas is not shown is during the pcbnew initialization, but this case is handled by OPENGL_TEST. Regards, Orson > Mario > __

Re: [Kicad-developers] Bitmap fonts (+ dotted grid)

2016-05-04 Thread Maciej Sumiński
eks old and grid is fine >>> both with dots and lines. >>> >>> >>> Thanks, Bernhard. >>> >>> @Orson, >>> On wxWidgets 3.1, the dotted grid is not visible on Opengl. The line grid is >>> visible. >>> On Cairo, both are

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-04 Thread Maciej Sumiński
t] on behalf of > Mário Luzeiro [mrluze...@ua.pt] > Sent: 03 May 2016 15:27 > To: Maciej Sumiński; kicad-developers@lists.launchpad.net > Subject: Re: [Kicad-developers] mode openGL issues after latest updates > > I tested (on Windows) and it works! > I didn't feel any issue

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-03 Thread Maciej Sumiński
On 05/03/2016 12:06 PM, Mário Luzeiro wrote: > Hi Orson, > I tested the new updates on my branch code, and now on Windows I got this > issues after I close the 3d-viewer windows: > > Error: mapping vertices buffer: invalid operation > Error: unmapping vertices buffer: invalid operation > Error:

Re: [Kicad-developers] Bitmap fonts (+ dotted grid)

2016-05-03 Thread Maciej Sumiński
splay. It would also introduce another inconsistency with the legacy canvas, and I would rather avoid it at the moment. Regards, Orson > Simon > > On Tue, May 3, 2016 at 3:16 AM, Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: >> As noone had opposed the changes,

Re: [Kicad-developers] mode openGL issues after latest updates

2016-05-03 Thread Maciej Sumiński
On 05/03/2016 03:23 PM, Wayne Stambaugh wrote: > On 5/3/2016 6:58 AM, jp charras wrote: >> Le 03/05/2016 à 12:06, Mário Luzeiro a écrit : >>> Hi Orson, >>> I tested the new updates on my branch code, and now on Windows I got this >>> issues after I close the 3d-viewer windows: >>> >>> Error:

Re: [Kicad-developers] Bitmap fonts (+ dotted grid)

2016-05-03 Thread Maciej Sumiński
t; * Font of RTC_INT is pretty small in comparison to GND or RXD/TXD… track > width > of RXD/TXD is the same as RTC_*. Similar for GND/+3.3V. > > > Regards, > Bernhard > > > > > >> On 02.05.2016, at 18:33, jp charras <jp.char...@wanadoo.fr >>

[Kicad-developers] Missing features in GAL

2016-05-02 Thread Maciej Sumiński
Now we plan to fill the remaining gaps between the legacy and GAL canvases. I think it is a good opportunity to either improve or remove certain tools, therefore I am asking for your input. What do you think about porting the following features? Do you find them useful, maybe would you change

Re: [Kicad-developers] Bitmap fonts (+ dotted grid)

2016-05-02 Thread Maciej Sumiński
As noone had opposed the changes, I have just merged the bitmap fonts branch. As a small bonus, we have also added an option to switch to dotted grid in GAL (thanks to Tom for refactoring the grid drawing routine). Regards, Orson signature.asc Description: OpenPGP digital signature

Re: [Kicad-developers] Bitmap fonts

2016-04-22 Thread Maciej Sumiński
On 04/22/2016 12:04 PM, jp charras wrote: > Le 22/04/2016 11:52, Maciej Sumiński a écrit : >> On 04/22/2016 11:45 AM, jp charras wrote: >>> Le 22/04/2016 11:31, Maciej Sumiński a écrit : >>>> On 04/22/2016 11:03 AM, jp charras wrote: >>>>> I just

Re: [Kicad-developers] Bitmap fonts

2016-04-22 Thread Maciej Sumiński
On 04/22/2016 11:45 AM, jp charras wrote: > Le 22/04/2016 11:31, Maciej Sumiński a écrit : >> On 04/22/2016 11:03 AM, jp charras wrote: >>> I just tested the new code: >>> With a large board (for instance the "video" demo), i have a segmentation >>&g

Re: [Kicad-developers] Bitmap fonts

2016-04-22 Thread Maciej Sumiński
On 04/22/2016 11:03 AM, jp charras wrote: > I just tested the new code: > With a large board (for instance the "video" demo), i have a segmentation > fault (no error displayed, > just a crash) Is it possible to get a backtrace? I cannot crash it here. Regards, Orson > Texts are correctly

Re: [Kicad-developers] Bitmap fonts

2016-04-22 Thread Maciej Sumiński
On 04/21/2016 08:35 PM, jp charras wrote: > Le 21/04/2016 17:51, Maciej Sumiński a écrit : >> On 04/21/2016 05:46 PM, jp charras wrote: >>> Yes, W7 32 bits + msys2. >>> >>>> >>>>> I also noticed an issue for pcb texts: the vertical

Re: [Kicad-developers] Bitmap fonts

2016-04-21 Thread Maciej Sumiński
On 04/21/2016 05:46 PM, jp charras wrote: > Yes, W7 32 bits + msys2. > >> >>> I also noticed an issue for pcb texts: the vertical justification has >>> changed: >>> when changing the horizontal justification, the vertical justification is >>> also changed. >>> (This is a bug which break

<    1   2   3   4   5   6   7   8   9   >