Fixed that issue, and pushed to master. Thanks for testing, Andrzej!
On Mon, Mar 5, 2018 at 12:57 PM, Andrzej Wolski
wrote:
> Hi Jon,
>
> another small issue: if only enabled layer is In1.Cu, THT pads are
> visible, but footprint cannot be selected.
> I think that breaks your visible=selectable
Hi Jon,
another small issue: if only enabled layer is In1.Cu, THT pads are
visible, but footprint cannot be selected.
I think that breaks your visible=selectable rule.
Fragment of code from D_PAD::ViewGetLOD that may help here:
if( ( GetAttribute() == PAD_ATTRIB_STANDARD || GetAttribute()
I like this change! I've never liked the fact that objects on invisible
layers get selected. Has anyone else had a chance to test this? If
there are no objections, I recommend that this patch get merged for rc2.
On 2/26/2018 10:11 PM, Jon Evans wrote:
> This patch changes the selection logic fo
Hey Andy, Andrzej,
Updated patch attached, let me know if this behavior makes more sense
Best,
Jon
On Fri, Mar 2, 2018 at 3:29 PM, Andy Peters wrote:
>
>
> On Mar 2, 2018, at 10:28 AM, Andrzej Wolski
> wrote:
>
> Jon,
>
> I probably didn't express myself clearly. What I mean is a situation wh
> On Mar 2, 2018, at 10:28 AM, Andrzej Wolski wrote:
>
> Jon,
>
> I probably didn't express myself clearly. What I mean is a situation when
> *only* enabled layer if F.Paste and then you disable "Pads Front". Now
> nothing is visible on the board, but footprints are still selectable.
>
> In
No, I agree with you in that case, that sounds like a bug in my patch and
I'll check it out this weekend when I can get back to coding.
Thanks,
Jon
On Fri, Mar 2, 2018 at 12:28 PM, Andrzej Wolski
wrote:
> Jon,
>
> I probably didn't express myself clearly. What I mean is a situation when
> *only
Jon,
I probably didn't express myself clearly. What I mean is a situation
when *only* enabled layer if F.Paste and then you disable "Pads Front".
Now nothing is visible on the board, but footprints are still selectable.
In other words, when no single item belonging to footprint is visible,
f
Hi Andrzej,
This was my intention, which is why I said I was prepared for other people
to have other opinions :-)
I think that you should still be able to select footprints even if the
"front pads" is hidden from layers like the paste layer, *unless* you are
in high contrast mode.
-Jon
On Fri,
I've tried this patch, and there is a small issue: if you have only eg
front paste layer enabled and front pads are hidden, footprint is still
selectable.
Andrzej
W dniu 2018-02-27 o 04:11, Jon Evans pisze:
This patch changes the selection logic for footprints to fix a
reported issue[1] and
This patch changes the selection logic for footprints to fix a reported
issue[1] and to make the behavior more logical to me.
I know that correct selection behavior is something of a personal
preference, so I'm ready to be flamed :-)
The new behavior:
A footprint may be selected if:
1) The corre
10 matches
Mail list logo
