Re: [Kicad-developers] Non copper zones

2018-02-24 Thread Wayne Stambaugh
Orson, The problem is that users have been using zones in non-copper layers so the expectation is that they will be able to continue to use them. I tested this and when you create a zone on a non-copper zone using the zone editor tool, it actually saves the object as a zone which is

Re: [Kicad-developers] Non copper zones

2018-02-24 Thread jp charras
Le 24/02/2018 à 08:42, Maciej Suminski a écrit : > Sorry for late answer, I will not have a reliable Internet connection until > Sunday evening. I > removed the option to draw ZONE_CONTAINERs as they are dedicated to copper > layers. For graphical > items there is DRAWSEGMENT of POLYGON type. If

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Maciej Suminski
Sorry for late answer, I will not have a reliable Internet connection until Sunday evening. I removed the option to draw ZONE_CONTAINERs as they are dedicated to copper layers. For graphical items there is DRAWSEGMENT of POLYGON type. If you find it unacceptable, please revert the commit. I am

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
 There are a number of missing features in the polygon tool that exist in the zone editor.  Adding corners is a large one. Cutouts would be a big regression. I think gr_poly is a single polygon and cannot have cutouts? Andrzej ___ Mailing

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
I have just found nice bug in 4.0. If you first edit copper zone and set corner smoothing to chamfer, then you can make non copper zone with chamfered corners: https://imgur.com/a/GsLn2 Andrzej W dniu 2018-02-24 o 02:15, Seth Hillbrand pisze: Playing with the tool some more, I can see that

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
On 02/23/2018 08:24 PM, Andrzej Wolski wrote:  Does the polygon tool allow you to edit zones on non-copper layers or were zones on non-copper layers saved as polygons?  If the latter is the case then I'm guessing this change is not significant but if that is not the case then there could be

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
 Does the polygon tool allow you to edit zones on non-copper layers or were zones on non-copper layers saved as polygons?  If the latter is the case then I'm guessing this change is not significant but if that is not the case then there could be some editing issues. Zones on non copper

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Seth Hillbrand
Playing with the tool some more, I can see that Andrzej is right. There are a number of missing features in the polygon tool that exist in the zone editor. Adding corners is a large one. If you have an existing non-copper zone, it seems you can keep it, change its layer, add cut-outs, etc.

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
Was it ever possible to run the fill algorithm (meaning, only fill in parts of a polygon outline, based on some clearance to other items on the same layer) on a non-copper zone? No, I didn't mean it was already possible. Seth, yes I see that dialog too in old builds, but the outline

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
There definitely was a change in the commit that removed InvokeNonCopperZonesEditor() from the ZONE_CREATE_HELPER tool so I can see how this would be jarring for users that have been using that feature. I'm going to wait until Orson responds to my original question. If we are going to make a

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
I can edit existing zones on non copper layers, but I can't place new one. What I mean is zones and polygons behave differently and I think they both should be there. But maybe I do not fully understand the intentions. Andrzej W dniu 2018-02-24 o 01:37, Wayne Stambaugh pisze: I'm seeing this

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
But setting the width of a graphical polygon to 0 removes the size issue Andrzej mentioned. But the you don't have them with rounded corners :) For filling vs. non-filling, I don't personally see the usefulness in having the fill algorithm run over a polygon that will always be filled. 

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
This is what I'm trying to determine. It sounds like this was a premature assessment on my part. If this is the case, I will branch and tag rc1 now. On 02/23/2018 07:49 PM, Jon Evans wrote: Was it ever possible to run the fill algorithm (meaning, only fill in parts of a polygon outline,

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
Seth, So you can still edit files with zones without using the zone tool or does the polygon tool pop up for editing zones on non-copper layers? I don't have any boards with zones on non-copper layers. As long as they are still editable, then I don't see the problem. As far filled versus

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
What behavior do you mean? In 4.0 and nightly from few days ago zones on non copper layers: - have outline drawn like zones, not like graphic polygons (I mean difference in size) - can be displayed in outline mode (hatched, fully hatched etc), polygons can't Moreover, zones have tools like

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Jon Evans
Was it ever possible to run the fill algorithm (meaning, only fill in parts of a polygon outline, based on some clearance to other items on the same layer) on a non-copper zone? I might be missing something, but from looking over the code (even back at 4.0 branch) I don't think this has ever been

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Seth Hillbrand
I have a number of zones on non-copper layers in older designs. They used to have the attached dialog. But setting the width of a graphical polygon to 0 removes the size issue Andrzej mentioned. For filling vs. non-filling, I don't personally see the usefulness in having the fill algorithm run

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
I'm seeing this as well. Andrzej, are you sure this is correct? Can you not edit zones on non-copper layers any longer? On 02/23/2018 07:26 PM, Jon Evans wrote: I went back to an older version of master (back around September of last year) and I can't make a zone on a non-copper layer that

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Jon Evans
I went back to an older version of master (back around September of last year) and I can't make a zone on a non-copper layer that behaves like a copper zone. Even when using the zone tool, they behave like graphic polygons. Were you able to do this up until Orson's recent change? If so, how do

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Andrzej Wolski
Polygons do work, but they are different kind of object than zones and I think they both should be there. I think zones suppose to flood, while polygons should be always solid. Polygons do not currently have "do not show filled". There are many designs which already have zones on non coppers

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Jon Evans
Yes, this is not really a bug. The behavior of the "draw polygon" tool is the same as the zone tool on non-copper layers used to be. On Fri, Feb 23, 2018 at 6:49 PM, Seth Hillbrand wrote: > The graphical polygon tool works for non-copper layers. > > Andrzej, does this

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Seth Hillbrand
The graphical polygon tool works for non-copper layers. Andrzej, does this tool not work? -S 2018-02-23 15:28 GMT-08:00 Wayne Stambaugh : > Orson, > > Is there any reason not to allow zones to be drawn on non-copper layers? > The changes you made in this commit would

Re: [Kicad-developers] Non copper zones

2018-02-23 Thread Wayne Stambaugh
Orson, Is there any reason not to allow zones to be drawn on non-copper layers? The changes you made in this commit would seem to indicate there was a reason not to allow this. I'm going to hold off on rc1 until we get this resolved. Thanks, Wayne On 02/23/2018 06:10 PM, Andrzej Wolski