Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-30 Thread Nick Østergaard
Hi Andrew Seth already shared the build log. tir. 31. jul. 2018 05.29 skrev Andrew Lutsenko : > I just noticed that my patch was reverted with reference to a build > failure with gcc 4.9.2 > > Could you share the error messages too? > Also curios which platform uses such ancient compiler. I

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-30 Thread Andrew Lutsenko
I just noticed that my patch was reverted with reference to a build failure with gcc 4.9.2 Could you share the error messages too? Also curios which platform uses such ancient compiler. I tried msys2, it only has gcc back to 5.1 and even debian stable uses 6.3. I'm more than willing to put in

Re: [Kicad-developers] Strange crashes

2018-07-30 Thread Steven A. Falco
Thanks for looking at it. Regarding your first question, I've placed a copy of my build log in the same dropbox directory, named "build.log". Regarding your second question, the gdb crash dump from the Copr nightly build looks about the same as the one from my local build. Both builds fail

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-30 Thread Mark Roszko
Is KiCad still really doing language icons? Are we going to ignore how offensive it is to mix up English with just the British flag and Spanish with the flag of Spain when there is an entire continent of countries speaking the language... On Mon, Jul 30, 2018 at 5:57 PM Seth Hillbrand wrote: > >

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-30 Thread Seth Hillbrand
​Good catch! Thanks John. Best- Seth​ Am Do., 26. Juli 2018 um 08:16 Uhr schrieb John Beard < john.j.be...@gmail.com>: > Hi, > > The SVGs for Catalan and Chinese did not match the XPM constant names, > so there were linking errors. > > I'm not sure how this hasn't been causing breakages since

Re: [Kicad-developers] Strange crashes

2018-07-30 Thread Seth Hillbrand
Hi Steve- The assert is not triggering for me using Debian. However, I note that this is a wxWidgets assertion, which should be disabled for release builds. Since you did the packaging for Fedora, do you have a build log? Alternatively, do you see this assertion when running a local build? -S

[Kicad-developers] Strange crashes

2018-07-30 Thread Steven A. Falco
I am using Fedora 28, and have just noticed a strange crash. This happens with 5.0.0 and also with the latest nightly (r13432-e750382e). I've got to assume I'm doing something wrong, but I am baffled, so I want to see what folks think. I've attached a backtrace. The way I cause this crash is

[Kicad-developers] Jenkins build is back to normal : kicad-qa #4416

2018-07-30 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-30 Thread Seth Hillbrand
Hi Andrew- Unfortunately your patch did not compile correctly in our qa system. It compiled for me (Linux/gcc 6) with only normal SWIG warnings but the qa system uses a different setup and encountered an error. You can view the output here: http://ci.kicad-pcb.org/job/kicad-qa/4415/ I suspect

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-30 Thread Andrew Lutsenko
Thank you Seth, Any chance this can be pushed to 5.0 branch too? > Keep in mind that the SWIG-based interface will (hopefully) be retired soon in favor of a fully-abstracted KiCad scripting language. Oh. When that happens there hopefully will be a transition period to give plugin writers a

Re: [Kicad-developers] [PATCH] Import attributes and variants from eagle.

2018-07-30 Thread Seth Hillbrand
Hi Mark- Generally looks good. There are a few coding style issues and a couple questions. The coding style issues - else on new line - empty () should not have spaces - blank line above if statements Questions: - Why are you storing unknown attributes? Are these used for something? - The

Re: [Kicad-developers] [PATCH] Re: SHAPE_LINE_CHAIN in swig?

2018-07-30 Thread Seth Hillbrand
This compiles cleanly and does not appear to have negative side effects so I pushed it. I made a small change to the boilerplate in math.i. Keep in mind that the SWIG-based interface will (hopefully) be retired soon in favor of a fully-abstracted KiCad scripting language. But since that goal is

[Kicad-developers] Build failed in Jenkins: kicad-qa #4415

2018-07-30 Thread Miguel Angel Ajo
See Changes: [hillbrand] Extend swig definitions to contain SHAPE_LINE_CHAIN and VECTOR2I -- Started by an SCM change Building remotely on debian8 (clang gcc linux) in workspace

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-30 Thread Tomasz Wlostowski
On 30/07/18 11:14, jp charras wrote: > Le 30/07/2018 à 00:29, Tomasz Wlostowski a écrit : >> On 27/07/18 15:31, jp charras wrote: >>> Le 27/07/2018 à 15:20, Tomasz Wlostowski a écrit : >>> >> Hi again, >> >> I've optimized the OpenGL bitmap drawing code (now it caches the bitmaps >> and uses

Re: [Kicad-developers] [RFC] Op-amp symbol icons

2018-07-30 Thread Jeff Young
Hi John, Good find. We should delete that one too. With the new UI I’ve found some places where it would be nice to have footprint & symbol viewers available, but we’ve only the one icon (library with magnifying glass). The library icon is almost totally gone anyway, so I think we should

Re: [Kicad-developers] [RFC] Op-amp symbol icons

2018-07-30 Thread John Beard
Hi, Here are 6a and 6b options, including the DeMorgan icons. Cheers, John On Thu, Jul 26, 2018 at 5:40 PM, Jeff Young wrote: > I actually agree that 6a looks better on it’s own, but 6b matches the > DeMorgan icons better. > > (Of course we could always update those to match the opamp….) > >

Re: [Kicad-developers] MacOS build issue with new geometry tests

2018-07-30 Thread Maciej Sumiński
Hi John, Thanks for the patch. I have had the same problem compiling KiCad with clang and I confirm that the proposed fix solves the problem, so I merged it. Cheers, Orson On 07/29/2018 05:34 PM, John Beard wrote: > Hi Adam, > > Sorry, this in my stuff - I though that was a way to get PI

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-30 Thread jp charras
Le 30/07/2018 à 00:29, Tomasz Wlostowski a écrit : > On 27/07/18 15:31, jp charras wrote: >> Le 27/07/2018 à 15:20, Tomasz Wlostowski a écrit : >> > Hi again, > > I've optimized the OpenGL bitmap drawing code (now it caches the bitmaps > and uses textures to draw them). Both mine and your patch

Re: [Kicad-developers] [RFC] Op-amp symbol icons

2018-07-30 Thread John Beard
While we're at it, new_cvpcb looks like it's also unused: it's built and listed in bitmaps.h, but nothing ever uses it. Cheers, John On Sat, Jul 28, 2018 at 11:28 PM, Jeff Young wrote: > No, looks like I just missed deleting it. > >> On 28 Jul 2018, at 23:01, John Beard wrote: >> >> Hi Jeff,