http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Status|Pushed to Master|RESOLVED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|Passed QA |Pushed to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Keywords|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #51 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Back on this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #52 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 24221
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24221
Bug 10807: Add an authority search history for the OPAC
Review of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #56 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 27375
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27375action=edit
[PASSED QA] Bug 10807: FIX UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #58 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 27377
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27377action=edit
[PASSED QA] Bug 10807: Add an authority search history for the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #55 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 27374
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27374action=edit
[PASSED QA] Bug 10807: Change the GPL version to v3+
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #54 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 27373
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27373action=edit
[PASSED QA] Bug 10807 [Follow-up] OPAC: There is no authority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #57 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 27376
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27376action=edit
[PASSED QA] Bug 10807: The new field search_history.type should
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #53 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 27372
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27372action=edit
[PASSED QA] Bug 10807: Add an authority search history for the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #59 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 27378
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27378action=edit
Bug 10807: Follow-up: Change wording of tabs
Changed the tabs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #24221|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #24222|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #24226|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #24223|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #24225|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #24224|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
QA Contact|katrin.fisc...@bsz-bw.de
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Blocks||10677
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #23676|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24223
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24223action=edit
Bug 10807: Change the GPL version to v3+
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #43 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24222
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24222action=edit
Bug 10807 [Follow-up] OPAC: There is no authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24226
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24226action=edit
Bug 10807: Add an authority search history for the OPAC -
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #46 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24225
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24225action=edit
Bug 10807: The new field search_history.type should be a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 24224
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24224action=edit
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
QA Contact|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23712
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23712action=edit
Bug 10807: FIX conflicts with bug 10380
Bug 10380 changes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #22560|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23677
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23677action=edit
Bug 10807: FIX if zebra is down, total is undef
The
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23679
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23679action=edit
Bug 10807: Change the GPL version to v3+
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23678
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23678action=edit
Bug 10807 [Follow-up] OPAC: There is no authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23680
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23680action=edit
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23681
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23681action=edit
Bug 10807: The new field search_history.type should be a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23682
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23682action=edit
Bug 10807: Add an authority search history for the OPAC -
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com ---
I fixed a conflict in the first patch and add a new patch for the bootstrap
theme.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
QA Contact|katrin.fisc...@bsz-bw.de
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22562
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22562action=edit
Bug 10807 [Follow-up] OPAC: There is no authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #20988|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22563
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22563action=edit
Bug 10807: Change the GPL version to v3+
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22561
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22561action=edit
Bug 10807: FIX if zebra is down, total is undef
The
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22564
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22564action=edit
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22565
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22565action=edit
Bug 10807: The new field search_history.type should be a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #23)
(In reply to Jonathan Druart from comment #21)
I created the module in the C4 namespace precisely because it is not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #20)
(In reply to Chris Cormack from comment #19)
Me either, except I think that for a module that isn't OO, get is a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21403
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21403action=edit
Bug 10807: The new field search_history.type should be a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #23 from Galen Charlton gmcha...@gmail.com ---
(In reply to Jonathan Druart from comment #21)
I created the module in the C4 namespace precisely because it is not a OO
module.
I don't recall there be any requirement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #23)
I suggest running with Class::Accessor -- there are plenty of examples in
the Koha namespace already.
What I did in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #11)
Hi Jonathan,
Katrin,
could you take a look at the license and check if you want to update to GPL3?
FAIL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21362
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21362action=edit
Bug 10807: Change the GPL version to v3+
Signed-off-by:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21363
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21363action=edit
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #17 from Galen Charlton gmcha...@gmail.com ---
Comment on attachment 20988
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20988
[SIGNED-OFF] Bug 10807: Add an authority search history for the OPAC
Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #18 from Galen Charlton gmcha...@gmail.com ---
(In reply to Jonathan Druart from comment #14)
1) The subs in Search:History.pm don't seem to follow our usual naming
conventions. I am a bit unsure about this.
I
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Chris Cormack ch...@bigballofwax.co.nz changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #20 from Galen Charlton gmcha...@gmail.com ---
(In reply to Chris Cormack from comment #19)
Me either, except I think that for a module that isn't OO, get is a bad name
for a subroutine.
If it were $history-get() I'd
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jonathan,
I wonder if PurgeSearchHistory should be moved into the new module, what do you
think? It was introduced by bug 10361.
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #20990|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hum(In reply to Jonathan Druart from comment #9)
Owen,
Thank you for the followup, I let you change the status to signed off if
it is good for you.
I didn't
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Attachment #20951|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Patch complexity|--- |Medium
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Owen Leonard oleon...@myacpl.org changed:
What|Removed |Added
Attachment #20952|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #7 from Owen Leonard oleon...@myacpl.org ---
Created attachment 20990
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20990action=edit
Bug 10807 [Follow-up] OPAC: There is no authority search history
This
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #20764|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #20734|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20764
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20764action=edit
Bug 10807: FIX if zebra is down, total is undef
The
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|NEW
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20734
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20734action=edit
Bug 10807: Add an authority search history for the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|ASSIGNED
78 matches
Mail list logo