[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Frédéric Demians changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #56 from Liz Rea --- Created attachment 55671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55671=edit [Follow up] Bug 17135 - Cleaner message for updatedatabase To test: Read

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #55 from Katrin Fischer --- Currently it reads: +print "WARNING: There is a possibility (= just a possibility, it's configuration dependent etc.) that - due to regression introduced

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #54 from Katrin Fischer --- I'd like to propose rewriting the database update message a bit before release - it's not really easy to understand and would require reading through longish bugs to

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #53 from Katrin Fischer --- Hm, I think it was my fault not running the web installer from koha-shell. Running the script with the right path in the koha-shell works fine: perl

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #52 from Jacek Ablewicz --- (In reply to Katrin Fischer from comment #51) > I just ran the db update from command line and got: > Can't open perl script >

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #51 from Katrin Fischer --- I just ran the db update from command line and got: Can't open perl script "/home/katrin/kohaclone/installer/data/mysql/fix_unclosed_nonaccruing_fines_bug17135.pl":

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Attachment #55413|0

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Attachment #55082|0

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Attachment #55081|0

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Attachment #55414|0

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Attachment #55080|0

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #43 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #42) > (In reply to Marcel de Rooy from comment #35) > > > running it from the command line. But it will be a problem for

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #42 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #35) > running it from the command line. But it will be a problem for several > install types when running it from the web

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #41 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #37) > Constructions with blocks and last statements are not really nice imo. If > possible, prevent them? Remembers some

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #40 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #37) > You use sub BorType in Overdues. It should actually not be there anymore > (imho) with the new series of Koha Objects.

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #39 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #37) > You select all accountlines with FU with an corresponding issue record, but > what about hypothetical records FU that

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #38 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #35) > The location of the script in misc/maintenance would be fine for > running it from the command line. But it will be a

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #37 from Marcel de Rooy --- Sorry, cannot finish this today. So some preliminary remarks here apart from the follow-ups: Tested regular overdue OK Tested changing a description OK Since my

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #35 from Marcel de Rooy --- Created attachment 55413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55413=edit Bug 17135: [QA Follow-up] Change location of new script to fix

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #36 from Marcel de Rooy --- Created attachment 55414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55414=edit Bug 17135: [QA Follow-up] Changes as to reporting We should at

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #34 from Marcel de Rooy --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Chris Cormack changed: What|Removed |Added Attachment #55077|0 |1

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Chris Cormack changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Chris Cormack changed: What|Removed |Added Attachment #55075|0 |1

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Chris Cormack changed: What|Removed |Added Attachment #54972|0 |1

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #30 from Jacek Ablewicz --- Created attachment 55077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55077=edit Bug 17135 - Maintenance script execution added as part of an atomic DB

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #29 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #26) > You could also think of running the script via updatedatabase? Sounds like a good idea, and there are some precedences

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Jacek Ablewicz changed: What|Removed |Added Attachment #55074|0 |1

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #27 from Jacek Ablewicz --- Created attachment 55074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55074=edit Bug 17135 - Some minor changes & fixes in the script - all non-fatal

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #26 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #25) > > Add a dbrev that at least prints a NOTE: <> that tells the > > sysadmin to optionally run your script when

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #25 from Jacek Ablewicz --- (In reply to Marcel de Rooy from comment #21) > Jacek, Just a quick glance: > Why Warn ? We always just warn. Just a copy & paste from some random local script (warn

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #24 from Jacek Ablewicz --- (In reply to Katrin Fischer from comment #17) > If we don't do 3) - would the fines still be calculated correctly? You mean 3.b part (correcting the dates in

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Severity|blocker

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #22 from Marcel de Rooy --- Change title of this report ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #21 from Marcel de Rooy --- Jacek, Just a quick glance: Why Warn ? We always just warn. Add a dbrev that at least prints a NOTE: <> that tells the sysadmin to optionally run your script when

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #20 from Jacek Ablewicz --- Created attachment 54972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54972=edit Bug 17135 - Fine for the previous overdue may get overwritten by the

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Jacek Ablewicz changed: What|Removed |Added Status|NEW |Needs

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #19 from Marcel de Rooy --- What about: Go thru all FU records. Look up issue record. If no issue record or CalcFine==0, consider as old fine. Move FU to F. If CalcFine < accountlines.amount,

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #18 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #16) > (In reply to Jacek Ablewicz from comment #15) > > Would be a simple sql statement like > > > > issues.due_date >

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #17 from Katrin Fischer --- If we don't do 3) - would the fines still be calculated correctly? I got lost a bit at some point :) But if that's the case, maybe 3) is not worth the trouble of

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #16 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #15) > Would be a simple sql statement like > > issues.due_date > NOW() > > good enough for selecting old FU fines which

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #15 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #13) This part > 3.a) if the fine is not accruing / item is not currently due: giving me a big headache. Would be a simple

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #14 from Jacek Ablewicz --- This part > 3.b) if the fine is accruing (item is due / CalcFine() returns a positive > value): this is an old record which got overwritten: leave it as FU, but >

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #13 from Jacek Ablewicz --- Proposed solution for the issues still remaining (moved from Bug 14390): 1) select the FU fine records that may need correction: for that we may need to compare a due

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #12 from Jacek Ablewicz --- Bug 14390 moved forward, now thanks to it if there is a clear distinction between F and FU fines in a given production database, it will stay that way in the future -

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #11 from Marcel de Rooy --- (In reply to Jacek Ablewicz from comment #10) > Side note: clean up of the 'F' / 'FU' fine types in existing accountlines > records is already done (in Bug 15675),

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Frédéric Demians changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #9 from Jacek Ablewicz --- (In reply to Kyle M Hall from comment #8) > The solution is pretty simple, we should never update closed out fines ( > account type 'F' ). My latest followup on bug

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #8 from Kyle M Hall --- We should never remove the issue_id from an accountline. It's not a foreign key because of the way we move issues to the old_issues table. It is necessary in order to

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Kyle M Hall changed: What|Removed |Added Depends on|15675

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Kyle M Hall changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Barton Chittenden changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Josef Moravec changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #7 from Jacek Ablewicz --- Yet another way to fix this would be an extra column in issues table to keep an accountlines_id of the currently accruing overdue fine for this issue (to be set NULL on

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #6 from Jacek Ablewicz --- (In reply to Katrin Fischer from comment #5) > issue_id ... Hm, I think you could probably use it for statistics... finding > out about... not sure. Might be I just like

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #5 from Katrin Fischer --- issue_id ... Hm, I think you could probably use it for statistics... finding out about... not sure. Might be I just like things linked :) I seem to remember that we

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #4 from Jacek Ablewicz --- (In reply to Katrin Fischer from comment #3) > I think the cleanest way without losing information (issue_id) would be your > third option: > > > - set fine type to 'F'

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #2 from Marcel de Rooy --- A fix on bug 14390 might address this too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Jacek Ablewicz changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 --- Comment #1 from Jacek Ablewicz --- Dunno how to resolve this problem properly - reintroduce due date to the issue record <-> fine record matching in UpdateFine() - unlink fine record from the issue record

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135 Jacek Ablewicz changed: What|Removed |Added Depends on|