https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Jonathan Druart changed:
What|Removed |Added
Blocks||23040
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #144 from Jonathan Druart
---
The output of the tests contains warnings:
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Illrequests.t
t/db_dependent/Illrequests.t .. 1/11 no query in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to Master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #140 from Kyle M Hall ---
Created attachment 86535
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86535=edit
Bug 20750: Add unit tests
Signed-off-by: Josef Moravec
Bug 20750: (follow-up) Remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #141 from Kyle M Hall ---
Created attachment 86536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86536=edit
Bug 20750: (QA follow-up) Fix templates
Signed-off-by: Josef Moravec
Signed-off-by: Kyle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Kyle M Hall changed:
What|Removed |Added
Attachment #86434|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Bug 20750 depends on bug 22363, which changed state.
Bug 22363 Summary: Move C4::Logs::GetLogs to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Status|Passed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #137 from Josef Moravec ---
Created attachment 86436
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86436=edit
Bug 20750: (QA follow-up) Fix templates
Signed-off-by: Josef Moravec
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85829|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #136 from Josef Moravec ---
Created attachment 86435
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86435=edit
Bug 20750: Add unit tests
Signed-off-by: Josef Moravec
Bug 20750: (follow-up) Remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Bug 20750 depends on bug 20639, which changed state.
Bug 20639 Summary: Allow setting a default/single backend for OPAC driven
requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Bug 20750 depends on bug 20639, which changed state.
Bug 20639 Summary: Allow setting a default/single backend for OPAC driven
requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #134
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85757|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85826|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85710|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85765|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #133 from Josef Moravec ---
Created attachment 85848
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85848=edit
Bug 20750: (QA follow-up) Add use KohaDates to status change template
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #132 from Josef Moravec ---
Created attachment 85847
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85847=edit
Bug 20750: (QA follow-up) Add ILL status change option to actions in log viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85709|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85827|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85704|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85702|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85700|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85705|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85701|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85703|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85706|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85708|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85707|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85698|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85699|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Attachment #85697|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #113 from Andrew Isherwood ---
Created attachment 85827
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85827=edit
Bug 20750: (follow-up) Remove BLDSS_STATUS_CHECK
As per comment #110 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #112 from Andrew Isherwood ---
Created attachment 85826
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85826=edit
Bug 20750: (follow-up) Explicitly pass log var
As per comment #109 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #111 from Josef Moravec ---
(In reply to Andrew Isherwood from comment #108)
> (In reply to Josef Moravec from comment #101)
> > Andrew, have you some plans with this logger to the future? It is
> > interesting idea. But
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #110 from Josef Moravec ---
> > > [%CASE 'CHANGE PASS' %]Change password
> > > [%CASE 'ADDCIRCMESSAGE' %]Add circulation message
> > > [%CASE 'DELCIRCMESSAGE' %]Delete circulation message
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #109 from Josef Moravec ---
(In reply to Andrew Isherwood from comment #104)
> (In reply to Josef Moravec from comment #99)
> > Comment on attachment 85697 [details] [review] [review]
> > Bug 20750: Allow logging of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #108 from Andrew Isherwood ---
(In reply to Josef Moravec from comment #101)
> Andrew, have you some plans with this logger to the future? It is
> interesting idea. But the implementation is just for one module and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #107 from Andrew Isherwood ---
Created attachment 85765
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85765=edit
Bug 20750: (follow-up) Pass hashrefs to functions
As per comment #100 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #85756|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #105 from Andrew Isherwood ---
(In reply to Josef Moravec from comment #99)
> Comment on attachment 85697 [details] [review]
> Bug 20750: Allow logging of arbitrary actions
>
> Review of attachment 85697 [details]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #104 from Andrew Isherwood ---
(In reply to Josef Moravec from comment #99)
> Comment on attachment 85697 [details] [review]
> Bug 20750: Allow logging of arbitrary actions
>
> Review of attachment 85697 [details]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #103 from Andrew Isherwood ---
Created attachment 85756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85756=edit
Bug 20750: (follow-up) Don't use object variable
We were unecessarily setting a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #102 from Andrew Isherwood ---
(In reply to Josef Moravec from comment #99)
> Comment on attachment 85697 [details] [review]
> Bug 20750: Allow logging of arbitrary actions
>
> ::: Koha/Illrequest/Logger.pm
> @@ +110,5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #101 from Josef Moravec ---
Andrew, have you some plans with this logger to the future? It is interesting
idea. But the implementation is just for one module and action. It would be
nice to have it a bit more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #100
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #99 from Josef Moravec ---
Comment on attachment 85697
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85697
Bug 20750: Allow logging of arbitrary actions
Review of attachment 85697:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Katrin Fischer changed:
What|Removed |Added
QA Contact||josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #98 from Josef Moravec ---
(In reply to Andrew Isherwood from comment #97)
> Hi Josef - I've just rebased and reattached. Make sure you apply the 22363
> dependency first, hopefully this bug will then apply.
Thanks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #85238|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #85099|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #85097|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #85113|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84978|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #85266|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #85101|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84976|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #85098|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84979|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84977|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84975|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84974|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84973|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Bug 20750 depends on bug 20639, which changed state.
Bug 20639 Summary: Allow setting a default/single backend for OPAC driven
requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #81 from Andrew Isherwood ---
Done :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #80 from Katrin Fischer ---
Hi Andrew, could you maybe sign-off on the dependency bug 22363?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #79 from Andrew Isherwood ---
Created attachment 85266
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85266=edit
Bug 20750: (follow-up) Use Koha::ActionLogs
We now use Koha::ActionLogs in favour of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Josef Moravec changed:
What|Removed |Added
Depends on||22363
--- Comment #78 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #77 from Andrew Isherwood ---
Hi Josef
Thanks for that. Sorry, I'm a bit lost. Are you suggesting I rewrite C4::Log as
a Koha object? If so, that seems a bit out of scope just to get this bug
through QA. Apologies if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #76 from Josef Moravec ---
(In reply to Andrew Isherwood from comment #74)
> (In reply to Josef Moravec from comment #72)
>
> > I don't think the time formatting should be done here in the logger... it is
> > helper
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #75 from Andrew Isherwood ---
Created attachment 85238
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85238=edit
Bug 20750: (follow-up) Set logging default off
As per comment #72 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #74 from Andrew Isherwood ---
(In reply to Josef Moravec from comment #72)
> I don't think the time formatting should be done here in the logger... it is
> helper method working with date and time... this way we could
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #73 from Katrin Fischer ---
(In reply to Josef Moravec from comment #72)
> (In reply to Andrew Isherwood from comment #69)
> > (In reply to Katrin Fischer from comment #64)
> >
> > > 1) QA script:
> >
> > Fixed
> >
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #72 from Josef Moravec ---
(In reply to Andrew Isherwood from comment #69)
> (In reply to Katrin Fischer from comment #64)
>
> > 1) QA script:
>
> Fixed
>
> > 2) I am wondering a bit about the date operations in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #70 from Andrew Isherwood ---
Created attachment 85113
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85113=edit
Bug 20750: (follow-up) Remove status_alias test
As per item 8) here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #69 from Andrew Isherwood ---
(In reply to Katrin Fischer from comment #64)
> 1) QA script:
Fixed
> 2) I am wondering a bit about the date operations in the Logger module,
> get_epoch especially.
What's concerning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #68 from Andrew Isherwood ---
Created attachment 85101
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85101=edit
Bug 20750: (follow-up) Remove wayward space
As per item 7) here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #67 from Andrew Isherwood ---
Created attachment 85099
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85099=edit
Bug 20750: (follow-up) Modify display log wording
As per item 5) here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #66 from Andrew Isherwood ---
Created attachment 85098
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85098=edit
Bug 20750: (follow-up) Remove ill_logging_pref.*
As per item 3) here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #65 from Andrew Isherwood ---
Created attachment 85097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85097=edit
Bug 20750: (follow-up) Fix QA script errors
As per item 1) here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #64
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84195|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84498|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84266|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #63 from Andrew Isherwood ---
Created attachment 84979
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84979=edit
Bug 20750: (follow-up) Fix merge problems
Since we now merging on top of Bug 20581, we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84203|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84193|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84194|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
Andrew Isherwood changed:
What|Removed |Added
Attachment #84497|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #56 from Andrew Isherwood ---
This needs some serious rebasing due to the changes in Bug 20581. I'll get this
sorted ASAP
--
You are receiving this mail because:
You are watching all bug changes.
1 - 100 of 186 matches
Mail list logo