[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Blocks||24339 Referenced Bugs:

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Text to go in the||**Reports note**: SIP2

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Text to go in the|**Reports note**: SIP2 |**Reports note**: SIP2

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #35 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89502|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89503|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89498|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89500|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89499|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89501|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Depends on||20307 Referenced Bugs:

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Blocks|17702 | Referenced Bugs:

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Blocks||23049 Depends

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 jdem...@roseville.ca.us changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Depends on||23049 Referenced Bugs:

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Nick Clemens changed: What|Removed |Added Keywords|rel_19_05_candidate | CC|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #28 from Martin Renvoize --- Good idea, that would work in the interim. Thanks for the suggestion Jonathan.. sometimes I just can't see the wood for the trees! -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #27 from Jonathan Druart --- (In reply to Martin Renvoize from comment #26) > (In reply to Jonathan Druart from comment #24) > > Also, we are loosing the translation... > > Yup, I was sort of hoping no-one would mind

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #26 from Martin Renvoize --- (In reply to Jonathan Druart from comment #24) >Is it really useful to check for the others PayXX (in the updatedatabase >entry)? (In reply to Jonathan Druart from comment #25) > Why not

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #25 from Jonathan Druart --- Why not switch the sip_type (00, 01, 02) to something meaningful? Also, we are loosing the translation... -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #23 from Liz Rea --- awesome, I'm happy if y'all are happy :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_05_candidate --

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Small patch -- You are

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #21 from Kyle M Hall --- Created attachment 89502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89502=edit Bug 22610: (QA follow-up) Add unit tests for FeePayment Signed-off-by: Kyle M Hall -- You

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #22 from Kyle M Hall --- Created attachment 89503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89503=edit Bug 22610: (QA follow-up) Make upgrade query more accurate Signed-off-by: Kyle M Hall --

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #19 from Kyle M Hall --- Created attachment 89500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89500=edit Bug 22610: (follow-up) Catch non-standard SIP codes Signed-off-by: Kyle M Hall -- You are

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #20 from Kyle M Hall --- Created attachment 89501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89501=edit Bug 22610: (follow-up) Correction to accounts tests Signed-off-by: Kyle M Hall -- You are

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #18 from Kyle M Hall --- Created attachment 89499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89499=edit Bug 22610: Update SIP2 to use payment_type The SIP2 interface has long used a set of

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Kyle M Hall changed: What|Removed |Added Attachment #89492|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #15 from Martin Renvoize --- Created attachment 89495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89495=edit Bug 22610: (follow-up) Correction to accounts tests -- You are receiving this mail

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89471|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89461|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #16 from Martin Renvoize --- Created attachment 89496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89496=edit Bug 22610: (QA follow-up) Add unit tests for FeePayment -- You are receiving this mail

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89460|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #11 from Martin Renvoize --- Right, I've gotten to the bottom of this.. it's tester error :).. man SIP is 'fun' to test. So, I tested with: perl misc/sip_cli_emulator.pl --sip_user=staff --sip_pass=staff --patron=dir

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #10 from Martin Renvoize --- (In reply to Liz Rea from comment #8) > I think libraries are going to miss these: > > [% CASE 'Pay00' %]Payment (cash via SIP2) > [% CASE

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #9 from Liz Rea --- actually, I'm wrong about the numbers, but we're still not getting the right SIP fee type for the different codes. The emulator defaults to 01, which is VISA, but it says Cash in the description. --

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #89470|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #6 from Martin Renvoize --- Created attachment 89470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89470=edit Bug 22610: (follow-up) Catch non-standard SIP codes -- You are receiving this mail

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #5 from Martin Renvoize --- Freshly rebased. Test Plan: 1) Check for presence of Pay01, Pay02 and Pay03 accounttypes in your database 2) Apply first patch and notice those occurrences have all changed to 'Pay' and an

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #88619|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Attachment #88620|0 |1 is obsolete|

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com --

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #1 from Martin Renvoize --- Created attachment 88619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88619=edit Bug 22610: Update SIP payment accounttypes This DB update updates the Pay00, Pay01 and

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 --- Comment #2 from Martin Renvoize --- Created attachment 88620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88620=edit Bug 22610: Update SIP2 to use payment_type The SIP2 interface has long used a set of

[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What|Removed |Added Blocks||17702 Depends