https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Pedro Amorim changed:
What|Removed |Added
Blocks||35310
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Aude Charillon changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Aude Charillon changed:
What|Removed |Added
Documentation||Aude Charillon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
Text to go in the|This enhancement adds a |This enhancement adds a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Text to go in the||This enhancement adds a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Bug 23838 depends on bug 30275, which changed state.
Bug 30275 Summary: Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Lucas Gass changed:
What|Removed |Added
Status|Pushed to master|Needs documenting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||22.11.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #138039|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #84 from Tomás Cohen Arazi ---
Created attachment 138043
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138043=edit
Bug 23838: (QA follow-up) Move include files
As talked with Martin, this patches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #80 from Tomás Cohen Arazi ---
Created attachment 138040
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138040=edit
Bug 23838: Add 'view' link to item detail page
Signed-off-by: Tomas Cohen Arazi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #83 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #79 from Tomás Cohen Arazi ---
Created attachment 138039
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138039=edit
Bug 23838: (QA follow-up) Rename patron-renewal => checkout-renewal
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #138040|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
Attachment #137168|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
Attachment #138007|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
Attachment #137169|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
Attachment #137167|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #74 from Martin Renvoize ---
Created attachment 138007
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138007=edit
Bug 23838: Use $patron_to_html formater
This patch updates the renewals modal to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #73
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #72 from Martin Renvoize ---
Rebased now that the dependency bug has been pushed :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #134892|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #134891|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #134890|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
QA Contact|tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Assignee|andrew.isherwood@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #68 from Martin Renvoize ---
Added sponsorship line to attribute original sponsor of the feature from long
long ago.. and rebased ;)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #133968|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #133967|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #133966|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #64 from Martin Renvoize ---
Note to self, must add 'Sponsored-by: Loughborough University' line back into
patches
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #63 from Owen Leonard ---
Created attachment 133968
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133968=edit
Bug 23838: (follow-up) Add missing template filter
Quieting an issue highlighted by the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #62 from Owen Leonard ---
Created attachment 133967
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133967=edit
Bug 23838: Use $datetime formater
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Owen Leonard changed:
What|Removed |Added
Attachment #133945|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #60 from Martin Renvoize ---
(In reply to Andrew Fuerste-Henry from comment #56)
> I applied this and 30275 and tried to run through the test plan here. I'm
> not getting a View button next to the renewal count in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #131915|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #131914|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #57 from Katrin Fischer ---
(In reply to Andrew Fuerste-Henry from comment #56)
> I applied this and 30275 and tried to run through the test plan here. I'm
> not getting a View button next to the renewal count in patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Andrew Fuerste-Henry changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #55 from Martin Renvoize ---
Created attachment 131915
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131915=edit
Bug 23838: Use $datetime formater
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #131892|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #53 from Martin Renvoize ---
OK, I squashed the existing patches and reworked them slightly to use the new
API's introduced in bug 30275 to try and get this one moving again.
Keeping the signoff as the feature continue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #96190|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #96189|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #96188|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #96186|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Attachment #96187|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #51 from Martin Renvoize ---
Right.. I've added bug 30275 to deal with creating the new renewals table..
having discussed it with Tomas deeply we decided this was the best option to
keep the API code clean in the long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Depends on||30275
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #50 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #49)
> Assuming I'm reading this right, I think an minimal version 2 option would
> be the best route to goal.. a simple 'renewals' table with just
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #49 from Martin Renvoize ---
Assuming I'm reading this right, I think an minimal version 2 option would be
the best route to goal.. a simple 'renewals' table with just 'issue_id' and
'timestamp' required really.. all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #48 from Katrin Fischer ---
I'd really like to see this one move forward, but I haven't been able to come
up with a good suggestion yet.
My impression is that if the same person checks out the same item multiple
times,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #47 from Andrew Isherwood ---
I can't really say what the best way forward for this is, I don't really have
the history or context to be able to judge. Obviously this bug isn't the place
for far reaching changes with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #46 from Tomás Cohen Arazi ---
(In reply to Andrew Isherwood from comment #43)
> (In reply to Tomás Cohen Arazi from comment #41)
> > We should add something like:
> >
> > parent_issue_id
> > is_renewal
> >
> > to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #45 from Andrew Isherwood ---
Hi Katrin
(Looks like I was typing my message below at the same time you were typing
yours, I think we came to the same conclusion)
The more I look at this, the more it feels like it's a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #44 from Katrin Fischer ---
> We should add something like:
>
> parent_issue_id
> is_renewal
>
> to the issues table.
>
> And then make /checkouts/:checkout_id/renewals return, well, the renewals.
> I wouldn't oppose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #43 from Andrew Isherwood ---
(In reply to Tomás Cohen Arazi from comment #41)
> We should add something like:
>
> parent_issue_id
> is_renewal
>
> to the issues table.
Actually, thinking about this, I'm not sure the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #42 from Andrew Isherwood ---
(In reply to Tomás Cohen Arazi from comment #41)
>
> We should add something like:
>
> parent_issue_id
> is_renewal
>
> to the issues table.
OK, this makes sense, I'll take this approach
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #41 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #40)
> Hm, for the API it might be good to get opinions of people more familiar
> with it.
>
> I can see the issue about statistics and action_logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #40 from Katrin Fischer ---
Hm, for the API it might be good to get opinions of people more familiar with
it.
I can see the issue about statistics and action_logs not having all the
information we need. :(
I would not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #39 from Tomás Cohen Arazi ---
(In reply to Andrew Isherwood from comment #38)
> (In reply to Katrin Fischer from comment #36)
>
> 1 & 2)
>
> > There is a strong pattern in the patches, file names, the API path of
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #38 from Andrew Isherwood ---
(In reply to Katrin Fischer from comment #36)
1 & 2)
> There is a strong pattern in the patches, file names, the API path of
> patron-renewals. Tbh, I wonder if this is not misleading. I'd
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_20_11_target|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_20_05_candidate |rel_20_11_target
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #37 from Katrin Fischer ---
> But after 4) I have the same information show on both entries.
> 3 renewals = 2 renewals logged on 2020-05-14
> 1 renewal = 2 renwals logged on 2020-05-15
Sorry, this doesn't make sense: I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #36
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #35 from Jonathan Druart
---
(In reply to Andrew Isherwood from comment #34)
Indeed, sorry about that. Looks like I forgot to squash the patches!
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #34 from Andrew Isherwood ---
(In reply to Jonathan Druart from comment #33)
> +$('#patronRenewals #incomplete').append(note + ': ' +
> data.length + ' ' + out_of + ' ' + renewals + ' ' +
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #32 from Andrew Isherwood ---
Hi Tomás
I'm not sure what you mean when you say "putting the mapping on the
Koha::Object level", could you please elaborate? Do you mean add a "to_api"
method into the Koha::ActionLog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #31 from Tomás Cohen Arazi ---
Andrew, I think we will need to adapt this one to the new idea of putting the
mapping on the Koha::Object level. We can chat about it whenever you want/need
to.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Andrew Isherwood changed:
What|Removed |Added
Attachment #95469|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Andrew Isherwood changed:
What|Removed |Added
Attachment #95470|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Andrew Isherwood changed:
What|Removed |Added
Attachment #95467|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Andrew Isherwood changed:
What|Removed |Added
Attachment #95466|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Andrew Isherwood changed:
What|Removed |Added
Attachment #95468|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Andrew Isherwood changed:
What|Removed |Added
Attachment #95471|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Andrew Isherwood changed:
What|Removed |Added
Attachment #95472|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #24 from Andrew Isherwood ---
Hi Bouzid
I think when you attached your sign off patches to this bug, you accidentally
attached an unrelated patch to the end. If this is correct, could you please
obsolete it?
Many
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #25 from Andrew Isherwood ---
Sorry, correction, you appended two unrelated patches. They're clearly for
another bug, so I'm going to obsolete them.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #22 from Bouzid Fergani ---
Created attachment 95471
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95471=edit
Bug 17374: (follow-up) Unit tests and remove warns
Signed-off-by: Maxime Dufresne
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #23 from Bouzid Fergani ---
Created attachment 95472
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95472=edit
Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in
patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Bouzid Fergani changed:
What|Removed |Added
Attachment #94684|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Bouzid Fergani changed:
What|Removed |Added
Attachment #94685|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Bouzid Fergani changed:
What|Removed |Added
Attachment #94682|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Bouzid Fergani changed:
What|Removed |Added
Attachment #94683|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Bouzid Fergani changed:
What|Removed |Added
Attachment #94681|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_19_11_candidate |rel_20_05_target
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #16 from Owen Leonard ---
Created attachment 94685
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94685=edit
Bug 23838: (follow-up) Rephrase log message
As suggested by Owen in comment #10
Thanks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #15 from Owen Leonard ---
Created attachment 94684
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94684=edit
Bug 23838: (follow-up) Fix JS strings
As requested by Owen in comment #7
Owen, I have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #14 from Owen Leonard ---
Created attachment 94683
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94683=edit
Bug 23838: (follow-up) Fix QA tool failures
Remove those pesky tabs as requested by Owen in
1 - 100 of 119 matches
Mail list logo
