https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #21 from Jonathan Druart ---
(In reply to David Cook from comment #18)
> (In reply to Jonathan Druart from comment #15)
> > I think this is the correct approach, what do you think?
>
> I'm not 100% sure.
>
> I find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #20 from David Cook ---
One last thing... we might want to rename this issue to be "Cache effective
circulation rules" because that would be more accurate than "Cache circulation
rules".
We're not just saving a database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #19 from David Cook ---
(In reply to Jonathan Druart from comment #15)
> I think this is the correct approach, what do you think?
Since we are clearing the cache via set_rule, there's probably no harm in using
the L2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #18 from David Cook ---
(In reply to Jonathan Druart from comment #15)
> I think this is the correct approach, what do you think?
I'm not 100% sure.
I find that the code in ./admin/smart-rules.pl and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #17 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #16)
> Rephrasing my question.. why the choice to use Koha::Cache::Memory::Lite
> instead of just Koha::Cache ?
> I don't think the approach is bad
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #16 from Martin Renvoize ---
Rephrasing my question.. why the choice to use Koha::Cache::Memory::Lite
instead of just Koha::Cache ?
I don't think the approach is bad at all, just trying to understand the
decisions made.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #15 from Jonathan Druart ---
I think this is the correct approach, what do you think?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #14 from Jonathan Druart ---
Created attachment 135463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135463=edit
Bug 29623: Don't flush the whole L1 cache
We shouldn't flush L1 cache completely, only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #13 from Jonathan Druart ---
(In reply to David Cook from comment #11)
> Comment on attachment 134209 [details] [review]
> Bug 29623: Cache circulation rules
>
> Review of attachment 134209 [details] [review]:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #11 from David Cook ---
Comment on attachment 134209
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134209
Bug 29623: Cache circulation rules
Review of attachment 134209:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #10 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #9)
> Silly question... why do this just at the request caching level?
Where else? Sorry I am not sure I understand your question.
> I had a bit of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Nick Clemens changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Victor Grousset/tuxayo changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #8 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #5)
> Could I get a test plan for this please?
Confirm that the rule is taken into account where get_effective_rules is used
(hardduedate for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Jonathan Druart changed:
What|Removed |Added
Attachment #128576|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #5 from Katrin Fischer ---
Could I get a test plan for this please?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #4 from Nick Clemens ---
Testing on top of 29703 this improves the performance on request.pl by about
1.5 seconds with 100 items, which is pretty decent
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Nick Clemens changed:
What|Removed |Added
Attachment #128180|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Jonathan Druart changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Jonathan Druart changed:
What|Removed |Added
Depends on||29537
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #1 from Jonathan Druart ---
Created attachment 128180
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128180=edit
Bug 29623: Cache circulation rules
--
You are receiving this mail because:
You are
27 matches
Mail list logo
