date:20180218

[Koha-bugs] [Bug 19715] Add the amount of contracts in the vendor's details page and check against it when ordering

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19715

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add the amount of   |Add the amount of contracts
   |contract's in the vendor's  |in the vendor's details
   |détails page.   |page and check against it
   ||when ordering
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19779] Some notices not using Reply To email address

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19779

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Rachel,
Overdue notices should work, can you check if this is still not working for
you? We have funded the initial development and overdue notices was tested and
has since been used with the new configuration - but we are on an older version
now. Which version did you test with?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19850] Enhance invoicing functionality for each line item

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19850

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Jeff, could you write up an example of how this would look like to make it
clearer how you'd like to enter the data? I think we have a similar problem
here with electronic and print taxed differently and the need to divide up
costs for some packages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19859] Add option to return to the search result in authorities

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19859

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Patrick,

I just tested on master with adding a new autohority record:

- Go to cataloguing
- Start a new record
- Open plugin on 100$a
- Create a new authority
- Save authority
- Authority window closes and you are taken back to cataloguing, form is filled
out automatically

I think what you want is that the same works for editing the authority,
correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19905] Don't append wildcard to query terms

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19905

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Hi David, I see this is marked in discussion - something we can do about it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20067] Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl)

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Marjorie, can you check in your framework for 952$3 which authorised value
it's mapped to?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3777] Field Sizes Inconsistent

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

--- Comment #13 from Katrin Fischer  ---
(In reply to Jon Knight from comment #12)
> I'm just trawling through old REOPENed cases and I see that the current
> (17.05) borrower schema still has the inconsistencies in the addresses.  As
> this was reopened because it was proving to be an issue for some addresses
> longer than 100 characters, is it worth just attacking just those fields to
> make them all match the address versions?
> 
> In other words make these field changes in the borrowers table schema:
> 
> B_address mediumtext NOT NULL,
> B_address2 text,
> B_city mediumtext NOT NULL,
> 
> and
> 
> altcontactaddress1 mediumtext NOT NULL,
> altcontactaddress2 text,
> altcontactaddress3 mediumtext NOT NULL,

I once tried to start a clean-up, but ended very confused. In your eample I
think there is probably no reason that ...address2 should not be mediumtext not
null too?
One thing I encountered back then was that some types can't be using not null
(iirc).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Katrin Fischer  changed:

   What|Removed |Added

Summary|can't place holds on 'on|Can't place holds on 'on
   |order' items with   |order' items with
   |AllowOnShelfHolds off   |AllowOnShelfHolds off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #15 from Katrin Fischer  ---
Tomas, could we get your opinion here, plz? :)

Lari, did you see https://wiki.koha-community.org/wiki/REST_api_RFCs?

I think it might be good to make some changes to make this endpoint match. For
example:
borrowernumber > patron_id
categorycode > category_id

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

paxed  changed:

   What|Removed |Added

 CC||pasi.kalli...@joensuu.fi

--- Comment #60 from paxed  ---
(In reply to Jesse Weaver from comment #57)
> Created attachment 70974 [details] [review]
> Bug 15395: Example usage of I18N Template::Toolkit plugin
> 
> Moved this patch for example usage to teh end of patch set
> and resolved minor conflict while applyin
> Signed-off-by: Marc Véron 

I'm confused by this example. How does the msgid look like in the po-file?

msgid "item"
msgid_plural "items"

Like that?

If so, then that's a bad example, as it's basically the same as concatenating
number + "item"
The number placeholder should be included in the translatable string, so the
msgid looks like this:

msgid "one item"
msgid_plural "%s items"

Because the translator can then actually make it sound natural in their own
language - perhaps the language needs an article before the number, or a suffix
to the number, both of which would be impossible to do with the original
example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19225] Warn on About page regarding sysprefs autoMemberNum and BorrowerMandatoryField

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19225

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19466
 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Bug 19466 will show a warning directly on entering a new patron - can we mark
this duplicate/resolved?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because field is required

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19225

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15510] New professional cataloguing editor shows OPAC favicon

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
I had some interesting favicon experiences on Bug 20173. Maybe it's related? I
think sometimes the browser tries to be too smart for its own good...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #19 from David Cook  ---
Created attachment 71917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71917=edit
Fix favicon.ico path in installer

This patch corrects the favicon.ico path for the installer.

On git installs, it used to point to ./koha-tmpl/favicon.ico,
and on regular installs, it probably just didn't work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #18 from David Cook  ---
Guess it doesn't really matter how it's doing it. I'll just update the file to
be consistent with the other intranet pages. 

Interesting how browsers try to outsmart the servers though...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #17 from David Cook  ---
OK I don't quite know how it's doing it, but it is caching super heavily. I
just used the following "convert -size 200x200 xc:none -fill red -draw "circle
20,20 10,10 circle 100,100 50,50" favicon.ico" and that switched the favicon
for the tab...and after deleting it from the server, it's still being used in
the browser after multiple fresh loads...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #16 from David Cook  ---
Whoa, this is cool/scary:

I created ./koha-tmpl/favicon2.ico and I'm visiting the URL: "/favicon2.ico" on Tab 2 of my browser. On Tab 1, I'm visiting
"/cgi-bin/koha/installer/install.pl?step=1=updatestructure". 

I see the following in my network tab on tab 2:

favicon2.ico200 documentOther   269 B   15 ms   656742  
favicon.ico 302 x-perl  Other   257 B   1.36 s  656742  
install.pl?step=1=updatestructure200 text/html   favicon.ico
3.7 KB  1.38 s  656742

I reckon that Chrome is looking at other tabs to see if it has a favicon for
that same host. That's creepy. I'll have to shutdown Chrome to test that
theory...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #15 from David Cook  ---
If I try to visit the favicon, I see the following:

favicon.ico 200 documentOther   269 B   9 ms655653 
favicon.ico 200 x-icon  Other   (from disk cache)   1 ms0

I reckon Chrome must be caching the favicon and using it on a host basis.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #14 from David Cook  ---
Created a fake favicon.ico and the browser is still showing the real Koha
one... but I see the following in the network tab:

favicon.ico 200 x-icon  Other   269 B   3 ms652379

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #13 from David Cook  ---
(In reply to Julian Maurice from comment #11)
> There is still a reference to this favicon.ico in
> koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc:
> 
> 

So I'm actually finding something pretty weird here. I've applied the patch and
this is what I see in my browser's network tab:

favicon.ico 302 x-perl  Other   257 B   1.39 s  648889

Looking at my Apache virtual host config... I see with a git install that
"../git/koha-tmpl" is the document root, so I suppose ./koha-tmpl/favicon.ico
would show in a git install. (Although in a Debian install the document roots
should be "/usr/share/koha/intranet/htdocs" and "/usr/share/koha/opac/htdocs".)

In any case... the ./koha-tmpl/favicon.ico is gone and I see nothing in the
Apache config that should be causing a redirect. 

I see the favicon in my browser and it seems to be downloading it and not
retrieving it from a browser cache...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

--- Comment #12 from David Cook  ---
(In reply to Julian Maurice from comment #11)
> There is still a reference to this favicon.ico in
> koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc:
> 
> 

I don't really think that's worth failing something over, since that line will
have generated an error since forever ago (since ./koha-tmpl/favicon.ico isn't
in the DocumentRoot) but OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

David Cook  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20173] Clean up koha-tmpl directory

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20243] New: ILS-DI CIDR notation

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20243

Bug ID: 20243
   Summary: ILS-DI CIDR notation
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: b...@interleaf.ie
QA Contact: testo...@bugs.koha-community.org

At present it is only possible to add single IP addresses to
ILS-DI:AuthorizedIPs. This is difficult to manage if the source resource has a
large pool of public addresses that can be used to connect. Adding CIDR
notation ability to ILS-DI:AuthorizedIPs would help to manage this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #23 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #22)
> QA tools pass.
> 
> Some first notes from reading the code:
> 
> 1)
> installer/data/mysql/en/marcflavour/marc21/mandatory/
> marc21_framework_DEFAULT.sql
> 
> It looks like the code makes some assumptions about
> biblioitems.publicationyear. There is something you will not like about this
> field: It's only used by UNIMARC by default. MARC21 installations safe that
> information to biblio.copyrightdate. Both use cases need to be supported.

It is the current behaviour, neworderempty.tt displays
biblioitems.publicationyear.
If it is an existing bug it needs to be fixed on a separate bug report.

> 2) Only en and fr-FR installers are changed?

Yes, what I wrote in the first commit message "Other frameworks will be updated
before to be pushed, to avoid unecessary rebases"
Same changes will be copied/pasted to other installer files before push.


> 3) Atomicupdate doesn't include changes for creating the ACQ framework.

ACQ framework was added by bug 3841 for new installation. I do not think we
should deal with existing installation (what about those having already the
framework?)

> 3) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
> A lot of FIXMEs in this code?

It is to highlight the fact that the default values defined in ACQ will not be
taken into account. I can remove it if you think it is confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #92 from Aleisha Amohia  ---
(In reply to Nick Clemens from comment #91)
> Is this ready for testing?

Not yet, still working on fixes from Comment 68. Been having some trouble with
my devbox but the patch is coming!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18760] printable checkin alerts

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13937

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18760

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19360

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19360] Give items URL a link text

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13937

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

--- Comment #76 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #75)
> Tomas, it seems that I missed something, the DBIC schema files are different:
> 
>  Koha/Schema/Result/Club.pm|  8 
>  Koha/Schema/Result/ClubTemplate.pm|  8 
>  Koha/Schema/Result/ClubTemplateEnrollmentField.pm |  8 
>  Koha/Schema/Result/ClubTemplateField.pm   |  8 
>  Koha/Schema/Result/MarcSubfieldStructure.pm   | 12 ++--
>  Koha/Schema/Result/UploadedFile.pm|  8 
> 
> 
>"name",
> -  { data_type => "text", is_nullable => 0 },
> +  { data_type => "tinytext", is_nullable => 0 },
> 
> 
> The ones in master have been generated with a DB upgraded from v17.11.00,
> but with a fresh install (kohastructure.sql) they are different.
> That is weird I am sure I took time to confirm that before I pushed.
> 
> Can you double-check and provide a follow-up please (change to kohastructure
> or updatedabase I guess)?

I will try different engines too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact||alex.arn...@biblibre.com

--- Comment #9 from Katrin Fischer  ---
Hi Alex, can you please take another look here? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191

--- Comment #8 from Jonathan Druart  
---
still fails: https://jenkins.koha-community.org/job/Koha_Master_D8/377/console

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #22 from Katrin Fischer  ---
QA tools pass.

Some first notes from reading the code:

1)
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

It looks like the code makes some assumptions about
biblioitems.publicationyear. There is something you will not like about this
field: It's only used by UNIMARC by default. MARC21 installations safe that
information to biblio.copyrightdate. Both use cases need to be supported.

2) Only en and fr-FR installers are changed?

3) Atomicupdate doesn't include changes for creating the ACQ framework.

3) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
A lot of FIXMEs in this code?

Jonathan, can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #184 from Katrin Fischer  ---
Comment on attachment 70524
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70524
Bug 11897: Add bulk of Stockrotation module.

Review of attachment 70524:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11897=70524)
-

::: api/v1/swagger/paths.json
@@ +26,5 @@
>"/illrequests": {
>  "$ref": "paths/illrequests.json#/~1illrequests"
> +  },
> +  "/rotas/{rota_id}/stages/{stage_id}/position": {
> +"$ref": 
> "paths/rotas.json#/~1rotas~1{rota_id}~1stages~1{stage_id}~1position"

8) Not commenting on the API specifically, but I think this will need more work
as there has been a lot of changes since this part was written.

::: installer/data/mysql/userflags.sql
@@ +19,4 @@
>  (19, 'plugins', 'Koha plugins', '0'),
>  (20, 'lists', 'Lists', 0),
>  (21, 'clubs', 'Patron clubs', '0'),
> +(22,'ill','The Interlibrary Loans Module',0),

9) Not related to these patches - maybe a leftover from a rebase/merge?

::: koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
@@ +40,4 @@
>  [% IF ( issuehistoryview ) %][% ELSE %][% END %]
>  Checkout history
>  [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %] class="active">[% ELSE %][% END %] href="/cgi-bin/koha/tools/viewlog.pl?do_it=1modules=CATALOGUINGaction=MODIFYobject=[%
>  biblio_object_id | url  %]">Modification log [% END %]
> +[% IF ( CAN_user_stockrotation_can_add_items_rotas && 
> Koha.Preference('StockRotation') ) %][% IF ( stockrotationview ) %] class="active">[% ELSE %][% END %] href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% 
> biblio_object_id %]">Rota [% END %]

9) Here user_stockrotation_can_add_items_rotas is asked, but stockrotation.pl
asks for catalogue => 1 ?

::: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
@@ +110,5 @@
>  [%- CASE 'edit_templates' -%]Create and edit club templates
>  [%- CASE 'enroll' -%]Enroll patrons in clubs
>  [%- CASE 'edi_manage' -%]Manage EDIFACT transmissions
> +[%- CASE 'can_add_items_rotas' -%]Add and remove items from 
> rotas
> +[%- CASE 'can_edit_rotas' -%]Create, edit and delete rotas

10) Ha! Fixes 5)

::: koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
@@ +4,5 @@
> +$(document).ready(function() {
> +var path = location.pathname.substring(1);
> +if (path.indexOf("labels") >= 0 && path.indexOf("spine") < 0 ) {
> +  $('#navmenulist 
> a[href$="/cgi-bin/koha/labels/label-home.pl"]').css('font-weight','bold');
> +} else if (path.indexOf("patroncards") >= 0 ) {

11) This JavaScript block appears unrelated to the stock rotation feature?

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ +868,4 @@
>yes: Enable
>no: Disable
>  - "housebound module"
> +Stock Rotation module:

12) Capitalization: Stock rotation

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt
@@ +4,5 @@
> +Koha  Catalog  Stock rotation details for [% 
> biblio.title %]
> +[% INCLUDE 'doc-head-close.inc' %]
> +[% INCLUDE 'browser-strings.inc' %]
>

[Koha-bugs] [Bug 12904] Force browser to load new JavaScript and CSS files after upgrade

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Katrin Fischer  changed:

   What|Removed |Added

Summary|Force browser to load new   |Force browser to load new
   |javascript files after  |JavaScript and CSS files
   |upgrade |after upgrade

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

--- Comment #75 from Jonathan Druart  
---
Tomas, it seems that I missed something, the DBIC schema files are different:

 Koha/Schema/Result/Club.pm|  8 
 Koha/Schema/Result/ClubTemplate.pm|  8 
 Koha/Schema/Result/ClubTemplateEnrollmentField.pm |  8 
 Koha/Schema/Result/ClubTemplateField.pm   |  8 
 Koha/Schema/Result/MarcSubfieldStructure.pm   | 12 ++--
 Koha/Schema/Result/UploadedFile.pm|  8 


   "name",
-  { data_type => "text", is_nullable => 0 },
+  { data_type => "tinytext", is_nullable => 0 },


The ones in master have been generated with a DB upgraded from v17.11.00, but
with a fresh install (kohastructure.sql) they are different.
That is weird I am sure I took time to confirm that before I pushed.

Can you double-check and provide a follow-up please (change to kohastructure or
updatedabase I guess)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20222] Make bread crumb for cleanborrowers.pl match the link text in tools-home.pl

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20222

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20148] Don't allow adding same user multiple times to a basket or an order

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20145] borrowers.datexpiry eq '0000-00-00' means expired?

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] Fix ITEMTYPECAT feature for grouping item types for search

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #11 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #17 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #11 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #183 from Katrin Fischer  ---
Comment on attachment 70521
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70521
Bug 11897: Add Stock Rotation atomic update schema.

Review of attachment 70521:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11897=70521)
-

::: installer/data/mysql/atomicupdate/stockrot_tables.sql
@@ +6,5 @@
> +description text NOT NULL default '',   -- Description for this rota
> +cyclical tinyint(1) NOT NULL default 0, -- Should items on this rota 
> keep cycling?
> +active tinyint(1) NOT NULL default 0,   -- Is this rota currently active?
> +PRIMARY KEY (`rota_id`)
> +) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

2) Should now be: ... ENGINE=InnoDB DEFAULT CHARSET=utf8mb4
COLLATE=utf8mb4_unicode_ci; (see bug 18336)

::: installer/data/mysql/kohastructure.sql
@@ +4156,5 @@
> +description text NOT NULL default '',   -- Description for this rota
> +cyclical tinyint(1) NOT NULL default 0, -- Should items on this rota 
> keep cycling?
> +active tinyint(1) NOT NULL default 0,   -- Is this rota currently active?
> +PRIMARY KEY (`rota_id`)
> +) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

3) Same here as above:
ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

::: installer/data/mysql/sysprefs.sql
@@ +601,5 @@
>  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over 
> results page display on intranet','Free'),
>  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields 
> for Personal Name Authorities to fill biblio.author','free'),
> +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will 
> replace authors in biblio.author','YesNo'),
> +('StockRotation','0',NULL,'If ON, enables the stock rotation 
> module','YesNo'),
> +('RotationPreventTransfers','0',NULL,'If ON, prevent any transfers for items 
> on stock rotation rotas, except for stock rotation transfers','YesNo')

4) Preferences in this file are sorted alphabetically, please move into the
right spot.

::: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
@@ +21,4 @@
>  [%- CASE 'lists' -%]Lists
>  [%- CASE 'clubs' -%]Patron clubs
>  [%- CASE 'ill' -%]Create and modify Interlibrary loan 
> requests
> +[%- CASE 'stockrotation' -%]Manage stockrotation operations

5) Descriptions for the sub-permissions appear to be  missing?

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ +879,5 @@
> +- pref: RotationPreventTransfers
> +  choices:
> +  yes: Enable
> +  no: Disable
> +- "Prevent branchtransfers on items in stockrotation rotas"

6) These preferences don't form sentences and are not nicely formatted. Please
avoid use of 'branch' in favor of 'library'. Also, should it be stock rotation
or stockrotation? Both are used here. It should probably be something like:

- yes: Enable
- no: Disable
- "library transfers on items in stockrotation rotas."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

--- Comment #15 from Jonathan Druart  
---
Created attachment 71916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71916=edit
Bug 19785: Replace intranet-tmpl with [% interface %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #182 from Katrin Fischer  ---
I've tried to get these patches to apply, but I'd like a proper rebase. 

1) Database update doesn't work
DEV atomic update: stockrot_tables.sql
C4::Installer::load_sql returned the following errors while attempting to load
/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/stockrot_tables.sql:

Will continue comments using splinter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20237] Don't allow adding same user multiple times to be notified on receive

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20237

--- Comment #2 from Katrin Fischer  ---
Hey, I wanted to fix that later! :P

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20237] Don't allow adding same user multiple times to be notified on receive

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20237

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 20148 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20148] Don't allow adding same user multiple times to a basket or an order

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148

--- Comment #7 from Jonathan Druart  
---
Created attachment 71915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71915=edit
Bug 20148: Prevent adding same user multiple times to an order

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20148] Don't allow adding same user multiple times to a basket or an order

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148

--- Comment #8 from Jonathan Druart  
---
*** Bug 20237 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20148] Don't allow adding same user multiple times to a basket or an order

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20148

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Summary|Don't allow adding same |Don't allow adding same
   |user multiple times to an   |user multiple times to a
   |acq basket  |basket or an order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17600] Standardize the EXPORT

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |In Discussion

--- Comment #82 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #81)
> Hi Jonathan,
> could you please rebase your branch on current master? Thx!

See my previous comment, I do not plan to maintain this branch up-to-date.
As I did not get the expected feedback it is not longer on my priority list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

--- Comment #15 from Katrin Fischer  ---
Works nicely, QA tools and tests pass :)

I fixed patch subjects and changed the database update message a little to
describe the change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

--- Comment #14 from Katrin Fischer  ---
Created attachment 71914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71914=edit
Bug 17672: Fixing Items.t expected tests from 12 to 13

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68937|0   |1
is obsolete||
  Attachment #68938|0   |1
is obsolete||
  Attachment #68939|0   |1
is obsolete||
  Attachment #71912|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 71913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71913=edit
Bug 17672: Add damaged_on to items and deleteditems tables

This patchset adds a 'damaged_on' column to store the date an item is
marked damaged, analogous to withdrawn_on and itemlost_on

To test:
1 - Apply patch
2 - Mark an item damaged via moredetail.pl (Items tab on left in
details)
3 - Note the damaged on date apears below
4 - Unmark the item, the date is removed
5 - Go to the edit items screen (from top bar 'Edit->edit items')
6 - Mark item damaged - check db or moredetails.pl to see damaged_on
date
7 - Unmark item damaged - confirm date is removed
8 - prove t/db_dependent/Items.t

Signed-off-by: Owen Leonard 

Signed-off-by: Charles Farmer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

--- Comment #12 from Katrin Fischer  ---
Created attachment 71912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71912=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|katrin.fisc...@bsz-bw.de
 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
Hi Tomas, started on this one not noticing your QA contact at first then saw
it's from December. Grabbing this one :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15336] Script for merging vendors

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336

--- Comment #36 from Katrin Fischer  ---
Comment on attachment 68676
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68676
Bug 15336 - New command-line script: merge_bookseller.pl

Review of attachment 68676:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15336=68676)
-

Hi Alex, 

started QA on this, but found some issues, please fix:

1) QA tools fail:

FAILKoha/Acquisition/Bookseller.pm
   FAIL   pod
empty =head3
 in file Koha/Acquisition/Bookseller.pm
*** ERROR: 

   FAIL   pod coverage
POD is missing for 'merge_with'

2) Please fix your commit message to include the correct script name! I think
you also change subscriptions and items? Please document in your test plan.

::: Koha/Acquisition/Bookseller.pm
@@ +77,5 @@
> +
> +my $from_vendor = Koha::Acquisition::Booksellers->find( $mergefrom );
> +my $result = $from_vendor->merge_with($mergeto);
> +
> +merge source vendor (-f) into target vendor (-t)

3) ...merge with :)

::: misc/migration_tools/merge_vendors.pl
@@ +102,5 @@
> +
> +=item B<--confirm>
> +
> + --confirm  Commit the changes in database. Running without this
> +parameter is like testing. It is recommanded to run 
> without

4) ... recommended

@@ +107,5 @@
> +--confirm first to be sure of the changes.
> +
> +=item B<--from>
> +
> + --from=  The source vendor identifier that will be merged in

5) Suggestion: The identifier of the source vendor that will be merged with the
target vendor.

@@ +112,5 @@
> +target vendor.
> +
> +=item B<--to>
> +
> + --to=The target vendor identifier in which merge

6) Suggestion: The identifier of the target vendor that the source vendor is
merged with.

::: t/Bookseller.t
@@ +1,3 @@
>  #!/usr/bin/perl
>  #
> +# This Koha test module is a stub!

7) Could possibly remove this now :)
All tests pass for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

--- Comment #9 from Katrin Fischer  ---
Created attachment 71911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71911=edit
Bug 19837: Add error feedback for duplicated or unfound cardnumbers

To test:
1 - Enter some patrons on a list
2 - 'Enter multiple cardnumbers'
3 - Make sure to add some that are already in list, some that don't
exist, and some new patrons
4 - Verify results are as expected with warnings

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20242] items marked as checkout marked as check in automatically in koha

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20242

--- Comment #3 from Katrin Fischer  ---
Questions about updating are better suited for the mailing list. The most
recent stable version of Koha is 17.11, released in November 2017. We currently
actively maintain 17.11, 17.05 and 16.11. I'd recommend updating to one of 17.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20242] items marked as checkout marked as check in automatically in koha

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20242

--- Comment #2 from Ahmad Najeh  ---
Thanks, Katrin.

Could you tell me about the new version of koha that I can upgrade to it?

Best Regards.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70277|0   |1
is obsolete||
  Attachment #70278|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 71910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71910=edit
Bug 19837: Add multiple patrons to a list by barcode

This patch adds the interface change and basic functionality for an
option to add multiple patrons to a patron list by scanning barcodes.

To test, apply the patch and go to Tools -> Patron lists.

- Create a patron list if necessary, and got to the "Add patrons"
  screen.
- Test the process for adding patrons using the "Patron search" text
  input.
- Test the process for adding patrons using the "Enter multiple card
  numbers" option.

This should really have some error-handling added to it: Onscreen
messages when a non-existing patron card number is submitted or when a
patron already exists on the list.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20242] items marked as checkout marked as check in automatically in koha

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20242

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Katrin Fischer  ---
Hi Ahmad, 3.22 is too old and no longer receives any bugfixes. Please consider
updating. New versions have a specific option to prevent that:

Do not check in items scanned during inventory:

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19823] Move template JavaScript to the footer: MARC21 editor plugins

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #3 from Katrin Fischer  ---
Please check and adapt for use of the new KOHA_VERSION for Javascript and
switch back to Signed off :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044

--- Comment #5 from Katrin Fischer  ---
Created attachment 71909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71909=edit
Add record form - menu a bit out of place?

Hi Owen,

I noticed a visible difference on editing a record. It's a record from the
sample database shown in the screenshot. The form visibly moved to the left
while the menu on top got quite long. Can you check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20242] New: items marked as checkout marked as check in automatically in koha

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20242

Bug ID: 20242
   Summary: items marked as checkout marked as check in
automatically in koha
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: PC
OS: Windows
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ahmad.na...@majancollege.edu.om
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Hi All,

items marked as checkout marked as check-in automatically in koha.

This issue happened when I used inventory tool.
Can you help? Please.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Hi Maksim, for these changes there is mostly no visible change at the moment -
so not seeing a difference is ok :) I think things might get more interesting
when Owen starts to change the multi-column templates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71350|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 71908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71908=edit
Bug 20037: Switch single-column templates to Bootstrap grid: Serials

This patch updates several single-column Serials module templates to
use the Bootstrap grid. In addition to grid changes, some templates have
been modified to include the footer with the correct popup parameter.

- serials\acqui-search.tt - Go to Serials -> New subscription. Click
  "Search for a vendor."

- serials\acqui-search-result.tt - Vendor search results

- serials\result.tt - Click "Search for record."

- serials\subscription-bib-search.tt - Catalog search results.

Each of these pages should look correct.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20241] New: Fix display of publication year in result page when searching for bibliographic record

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20241

Bug ID: 20241
   Summary: Fix display of publication year in result page when
searching for bibliographic record
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: minor
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

When creating a new subscription and searching for a bibliographic record, the
result list will never show the publication year even if one exists.

I think this might be because it attempts to show publicationyear (used for
UNIMARC installations) instead of copyrightdate which is used for MARC21
installations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20240] New: Remove space before : when searching for a vendor in serials (Vendor name :)

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20240

Bug ID: 20240
   Summary: Remove space before : when searching for a vendor in
serials (Vendor name :)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When creating a new subscription and searching for a vendor, the search field
is labelled "Vendor name :". Fix tiny inconsistency by removing the space after
before :.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71711|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 71907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71907=edit
Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves

This patch updates three single-column course reserves templates to use
the Bootstrap grid:

- course-reserves.tt - The main Course Reserves page
- course-details.tt - The detail view of an individual course
- course.tt - Editing a course
- add_items-step1.tt - Adding items to a course, step 1 (scan barcode)
- add_items-step2.tt - Adding items to a course, step 2
- invalid-course.tt - The error page shown if you try to view
  course_reserves/course-details.pl directly without passing a course id
  in the URL
  - Also changed in this template: Error message has been wrapped in the
standard "dialog alert" .

Each of these pages should look correct, with a single centered column
with wide margins on either side. At lower browser widths the margins
should disappear.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954

--- Comment #10 from Katrin Fischer  ---
Moved buttons are ok for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19954] Update popup window templates to use Bootstrap grid: Patrons

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19954

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71754|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 71906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71906=edit
Bug 19954: Update popup window templates to use Bootstrap grid: Patrons

This patch updates two patron-related templates to use the
Bootstrap grid instead of the YUI grid.

This patch also corrects an unrelated error in update-child.tt where
some JS variable declarations required by members-menu.js were
missing.

To test you must have more than one adult-type patron category defined.

- Locate and view a child-type patron record.
- From the "More" menu in the toolbar, choose "Update child to adult
  patron."
  - The popup window which appears should look correct and work
correctly.
  - The table of patron categories should be sortable.
- Add a new patron and enter the first and last names of an existing
  patron.
  - When Koha asks to confirm a possible duplicate record, click the
"View existing record" link. The popup which is triggered should
look correct.

Signed-off-by: Zoe Bennett 
Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
I like the new context menu - cleaner and easier to use with the options
stacked. Fixed the commit message from using - to : after the bug number.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71540|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 71904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71904=edit
Bug 19939 - Move cataloging Z39.50 results actions into menu

This patch modifies the template which displays cataloging Z39.50
search results so that the "MARC," "Card," and "Import" links are moved
out of separate table cells and into one menu.

The old menu which would appear when any table cell is clicked has been
removed, and code added to display the same Bootstrap menu if a table
cell is clicked.

To test, apply the patch and go to Cataloging -> New from Z39.50/SRU.

- Perform a Z39.50 search which will return more than one result.
- Confirm that clicking the "Actions" button triggers a drop-down menu.
  - Confirm that the links in the menu trigger actions for the correct
bibliographic record.
- Confirm that clicking any other table cell in the table of results
  will trigger the display of the same menu.
  - Confirm that this menu works correctly for the correct record.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19939] Move cataloging Z39.50 results actions into menu

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19939

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71904|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 71905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71905=edit
Bug 19939: Move cataloging Z39.50 results actions into menu

This patch modifies the template which displays cataloging Z39.50
search results so that the "MARC," "Card," and "Import" links are moved
out of separate table cells and into one menu.

The old menu which would appear when any table cell is clicked has been
removed, and code added to display the same Bootstrap menu if a table
cell is clicked.

To test, apply the patch and go to Cataloging -> New from Z39.50/SRU.

- Perform a Z39.50 search which will return more than one result.
- Confirm that clicking the "Actions" button triggers a drop-down menu.
  - Confirm that the links in the menu trigger actions for the correct
bibliographic record.
- Confirm that clicking any other table cell in the table of results
  will trigger the display of the same menu.
  - Confirm that this menu works correctly for the correct record.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

--- Comment #4 from Katrin Fischer  ---
I think there are also some missing VERSION:

+

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/authorities/auth_finder.tt
   FAIL   forbidden patterns
forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 31)

  valid_template

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt
   FAIL   forbidden patterns
forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 103)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Created attachment 71903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71903=edit
Screenshot of too small pop-up window for 'create authority'

"create authority" opens in a really small window for me. Can you please check?

Tested with Firefox 58.0.2 (64-bit)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19786] Move template JavaScript to the footer: Authorities, part 2

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20239] Fix spelling on authority linker plugin

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20239

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20239] New: Fix spelling on authority linker plugin

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20239

Bug ID: 20239
   Summary: Fix spelling on authority linker plugin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When using the autority linker plugin, 'choose' would look better as 'Choose'.

To test:
- create a new record
- go to 100
- click on plugin link behind $a
- look for an existing authoriy in your system
- take a look at the results table for your search

0 times choose  Edit authority

_C_hoose would be nicer, wouldn't it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

--- Comment #14 from Katrin Fischer  ---
Hi Owen, QA tools complain, but I suspect false positives. Could you please
double check?

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
   FAIL   forbidden patterns
forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 102)
forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 102)

The line in the template is:


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1

2018-02-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71601|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 71902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71902=edit
Bug 19785: Move template JavaScript to the footer: Authorities, part 1

This patch modifies even more staff client authorities templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Authorities
   - New from Z39.50
   -> Search
  -> Results
 - New from Z39.50
 - Deletion confirmation
 - Merge records -> Merge
   - Tabs
   - Tag selection
 -> Authority detail
- Tabs
- Deletion confirmation
- New from Z39.50

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 133 matches

Mail list logo