[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19167|0

[Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 --- Comment #3 from kenza kenza.z...@biblibre.com --- The patch 10386 doesn't add the rollback, so i think these two patches are complementary. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #67 from Kyle M Hall k...@bywatersolutions.com --- Jonathan I had a short discussion about this patch DBIC: we have the same question: what's the next step once this patch is pushed ? We need to have clear directions,

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #68 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #67) Jonathan I had a short discussion about this patch DBIC: we have the same question: what's the next step once this patch is pushed ? We

[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18821|0 |1

[Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Patch

[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19177|0

[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #13) Type of arg 1 to keys must be hash (not subroutine entry) at t/db_dependent/HoldsQueue.t line 47, near GetBranches; It's certainly

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Needs

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19116|0 |1

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19107|0 |1

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19108|0 |1

[Koha-bugs] [Bug 7228] can't order more than 1 when importing all from staged file

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #23 from Nicole C. Engard neng...@gmail.com --- The problem I reported was the one thing that this patch doesn't fix: - syspref AcqCreateItem : create items on ORDERING - in a basket, create an order (click on add to add

[Koha-bugs] [Bug 10487] UT: GetMaxPickupDate needs unit tests.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10487] UT: GetMaxPickupDate needs unit tests.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19110|0 |1

[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 10483] check_uniqueness.pl does not work

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10483] check_uniqueness.pl does not work

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19075|0 |1

[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18660|0 |1

[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18397|0 |1

[Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18536|0 |1

[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18597|0 |1

[Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed

[Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18566|0 |1

[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18827|0 |1

[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19179|0 |1

[Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 --- Comment #4 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #1) This patch changes it prototype to output_pref({ dt = $dt, If we switch to named parameters, we may as well avoid over-abbreviating. Would

[Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #69 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #68) On the other hand, a squashed patch could be uploaded for QA purposes, and the individual patches pushed afterward. I think that should provide

[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Severity|minor

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #70 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #66) (In reply to comment #60) Chris and I discussed this bug today and he's agreed to update the patch series for master; I intend to push DBIC

[Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #71 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #70) What I propose is a multi-part process: [1] Once DBIC support is pushed, along with at least one other patch that uses it, we promote the

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #72 from Kyle M Hall k...@bywatersolutions.com --- [1] Once DBIC support is pushed, along with at least one other patch that uses it, we promote the existence of it vigorous, with the aim of encouraging folks to use it

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #73 from Galen Charlton gmcha...@gmail.com --- Paste of an IRC conversation with the maintainer of DBIX::Class today: riba I wanted to comment on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 but didn't

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #74 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #71) (In reply to comment #70) I think it would be a reasonable goal to get to the point where, once the cycle for 3.16 starts, DBIC is required for

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #75 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #74) My preference is that that every effort should be made when introducing a DBIC-based method to remove the C4 function(s) that it

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #76 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #72) I agree with unit testable-ness for functions, but what about scripts? One of the great reasons to have DBIC is we can just use find() or single()

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #77 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #75) (In reply to comment #74) My preference is that that every effort should be made when introducing a DBIC-based method to remove the C4

[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #78 from Kyle M Hall k...@bywatersolutions.com --- I cannot agree more with this assertion. Koha scripts have often been too 'smart' for their own good ; ) Over time this has definitely improved with more and more logic

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #79 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #78) I cannot agree more with this assertion. Koha scripts have often been too 'smart' for their own good ; ) Over time this has definitely

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #80 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #79) tests of their core functionality can be easily written. Test::www::Mechanize can also help us testing scripts in web-environment as well. It's

[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 19192 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19192action=edit Bug 9788: Followup for expirationdate in Letter.pm Pasting comment

[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- OK. I tested the following now: With patch 1 only (and deleted maxpickupdelay): Crash just like Kyle mentioned. With patch 2 applied too (still undef maxpickupdelay): No

[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #16092|0 |1

[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19192|0 |1

[Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 --- Comment #3 from Jason Etheridge ja...@esilibrary.com --- Created attachment 19195 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19195action=edit patch for ClassSortRoutine_Dewey.t Here's the test to go with the

[Koha-bugs] [Bug 10478] Do we need a sequential number generator?

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC|

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |In

[Koha-bugs] [Bug 10478] Do we need a sequential number generator?

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478 --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- M. de Rooy, you use MySQL's LAST_INSERT_ID, which is not forward compatible with people who may be attempting to use a different back end, or working towards that. The next