date:20170424

[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #62608|0   |1
is obsolete||

--- Comment #2 from Barton Chittenden  ---
Created attachment 62650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62650=edit
Bug 18484 - opac-advsearch.tt missing closing div tag for .container-fluid

This patch corrects HTML validation errors by adding back a missing
 which was removed accidentally by Bug 9043 (2014!).

This patch also removes "border" attributes from  tags because the
attribute is obsolete.

To test, apply the patch and test the validity of the OPAC's advanced
search page. The only error should be one about 'Bad value
"api-server,"' which isn't really resolvable.

Signed-off-by: Barton Chittenden 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18484] opac-advsearch.tt missing closing div tag for .container-fluid

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18484

Barton Chittenden  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #6)
> Sounds like changes to etc/koha-conf.xml are missing.

Bug 7533?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490

Christopher Brannon  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490

--- Comment #1 from Christopher Brannon  ---
Created attachment 62649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62649=edit
[Bug 18490] Change transfer message/show cancel

This patch changes the transfer message and shows the cancel button on
the first checkin.  I've also cleaned up some formatting in the code.

To test:

Test A:
1) Check in an item at a library other than its homebranch.

Test B:
2) Place an item on hold to be picked up at another library.
3) Check in the item at a library other than the home branch or pickup
loccation.

Test C:
4) Add item to a rotating collection.
5) Transfer collection to another library.
6) Check in the item to trigger the transfer.

7) On each test, notice the phrase "Please transfer item to:" and notice
that the Cancel transfer button does not appear on the first checkin.

8) Apply patch.
9) Repeat steps 1-6.
10) On each test notice the phrase is now "Transferring item to:" and
notice that the Cancel transfer button now shows after the first
checkin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490

Christopher Brannon  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |cbran...@cdalibrary.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18490] New: Transfer message confusing, cancel button missing

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490

Bug ID: 18490
   Summary: Transfer message confusing, cancel button missing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When checking in an item that is being transferred to another branch (not for a
reserve), the dialog is a bit confusing.  It says:

Please return item to: Library XYZ

And then shows a Print slip button.

I see two problems.  First, checking in the item initiates the transfer, and
this is not clear in the message.  Second, you can't cancel the hold unless you
check it in again, and then you get the Cancel transfer button.

I don't think there is any reason not to show the cancel button the first time
around.  I also think it would be much clearer as to what is going on if the
message read:

Transferring item to: Library XYZ

I am open to suggestions on the phrasing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483

Marc Véron  changed:

   What|Removed |Added

  Attachment #62579|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 62648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62648=edit
Bug 18483 - Customised help: Enhance staff client with news based, easily
editable help system

Koha's staff client has a file based help system with an edit function for
customising.
However, the edited files have to be saved and restored with each release.
Otherwise they
are overwritten.

As an enhancement or alternative, the existing news system can be used to
implement a
complementing help system. Similar to the news, the text can be created for all
branches
or for individual branches. Help is context sensitive (based on the existing
help system),
 and it can be created / edited directly from the help page (based on a user
permission).

The display can be managed with a system preference (Bug 18472: Add system
preference
CustomOnlineHelpStaff to hide / select custom online help system).

This patch is a first draft. It is not yet ready for testing or sign-off.
Amended to resolve minor conflicts with Bug 18472
Amended to expand sysprefs from Bug 18472
Amended to add permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18472] Add system preference CustomOnlineHelpStaff to hide / select custom online help system

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18469] Suspend all holds when specifying a date to resume hold does not keep date

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18469

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #3 from Jonathan Druart  
---
Nick it seems that we have the same issue on moremember, but the feature is not
displayed because SuspendHoldsIntranet and or AutoResumeSuspendedHolds is not
passed (should use Koha.Preference instead).
I am also wondering if we should not re-add the datepicker class name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18469


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18469
[Bug 18469] Suspend all holds when specifying a date to resume hold does not
keep date
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18469] Suspend all holds when specifying a date to resume hold does not keep date

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18469

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||14060


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060
[Bug 14060] Remove readonly on date inputs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15352] a way not to show the full url in the holdings

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I think it's better to replace the link with "Link to resource" than a free
text than will not be translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18472] Add system preference CustomOnlineHelpStaff to hide / select custom online help system

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18472

--- Comment #4 from Marc Véron  ---
Created attachment 62647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62647=edit
Bug 18472: (followup) Add system preference CustomOnlineHelpStaff

Add bug description to file
bug_18472-Add_system_preference_CustomOnlineHelpStaff.perl

The bug description was not filled in upgrade message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18459] Add the Koha::Item->biblioitem method

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18459

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
Kyle, this patch has not been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #24 from Jonathan Druart  
---
Hum, I get "Template process failed: undef error - The method biblioitem is not
covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121." when I
export to CSV.

Something else I completely missed before: if you select rows then switch to
another page the behaviour will not work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #9 from Jonathan Druart  
---
(In reply to Marc Véron from comment #6)
> 8. Try checking in the item again, and this time after clicking the
> 'confirm' button on the modal box notice that the yellow warning message
> is displayed telling the user the item was "Not checked out"

Yes, but the hold is not confirmed!
The form submission (and so the page reload) does something: it confirms the
hold, which is why we expect here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #6)
> Sounds like changes to etc/koha-conf.xml are missing.

Ha, it is there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

--- Comment #53 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #52)
> Created attachment 62646 [details] [review]
> Bug 18066: Remove warnings from translate script
> 
> This patch removes the following warnings:
> Use of uninitialized value $pref_name in concatenation (.) or string at
> LangInstaller.pm

This patch has been pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18066] Hea - Version 2

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066

--- Comment #52 from Jonathan Druart  
---
Created attachment 62646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62646=edit
Bug 18066: Remove warnings from translate script

This patch removes the following warnings:
Use of uninitialized value $pref_name in concatenation (.) or string at
LangInstaller.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18456] Update Italian installer sample files for 17.05

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18456

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62413|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 62645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62645=edit
Update Italian installer sample files for 17.05

Update and translate sample SQL file of the Italian installer.

To test:
- Start with an empty database
- Install it-IT
- Run the web installer in it-IT/Italian
- Verify all files, especially sample notices, sample_frequencies,
  sample_numberpatterns load without any problems.

https://bugs.koha-community.org/show_bug.cgi?id=18456

While applying I got a 3-way-merge. Verified in staff client places
mentioned above, notices, frequencies, sample_numberpatterns, HSBND_FREQ
Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18456] Update Italian installer sample files for 17.05

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18456

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18489] New: "You must define a budget" even when budgets exist

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18489

Bug ID: 18489
   Summary: "You must define a budget" even when budgets exist
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Bug 8452 was similar, but it was related to using the DB user. Right now, with
a proper staff user with enough privileges (superlibrarian), I get this error
due to the absence of defined FUNDS. It is probably a good idea to force the
FUND creation for using the acquisitions module, but the message itself is
missleading. It should say 'fund' if that's what it is talking about.

Steps to reproduce:
- Have a fresh install
- Go to the acquisitions module
=> SUCCESS: You are notified that you need to first defined a budget in order
to operate.
- Follow the link, create an ACTIVE budget.
- Go to the acquisitions module
=> FAIL: "You must define a budget..." message still shows

Verify the problem condition:
- Go to the budgets page
- Create a fund on the newly created budget
- Go back to the acquisitions module
=> SUCCESS: The warning is not shown anymore, the budgets table shows at the
bottom

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #119 from Jonathan Druart  
---
(In reply to Marc Véron from comment #106)
> Created attachment 62206 [details] [review]
> Bug 14224: (follow-up): Make äöü display properly after input

Marc, This patch worked but actually could hide a problem. The issue was in the
svc script, encode_json must have been used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #118 from Jonathan Druart  
---
Created attachment 62644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62644=edit
Bug 14424: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62205|0   |1
is obsolete||

--- Comment #116 from Jonathan Druart  
---
Created attachment 62642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62642=edit
Bug 14224: Check if the columns do not exist before creating them

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #117 from Jonathan Druart  
---
Created attachment 62643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62643=edit
Bug 14224: Use encode_json instead of to_json

To handle unicode characters properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62203|0   |1
is obsolete||

--- Comment #114 from Jonathan Druart  
---
Created attachment 62640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62640=edit
Bug 14224: Update Copyright

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62204|0   |1
is obsolete||

--- Comment #115 from Jonathan Druart  
---
Created attachment 62641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62641=edit
Bug 14224: Improve escaped characters

To recreate the problem, submit a note like
  doh"doh

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62198|0   |1
is obsolete||

--- Comment #109 from Jonathan Druart  
---
Created attachment 62635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62635=edit
Bug 14224: Reintroduce previous copyright

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62201|0   |1
is obsolete||

--- Comment #112 from Jonathan Druart  
---
Created attachment 62638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62638=edit
Bug 14224: Make strings translatable

The strings should be translatable.
This patch also removes the error as it appears that we only have 1
error.
To improve we could surround the store with an eval.

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62199|0   |1
is obsolete||

--- Comment #110 from Jonathan Druart  
---
Created attachment 62636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62636=edit
Bug 14224: Remove SQL query in svc script

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62196|0   |1
is obsolete||

--- Comment #107 from Jonathan Druart  
---
Created attachment 62633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62633=edit
Bug 14224: Allow patron notes about item shown at check in

This patch adds a "Note" input field to checked out items in the "your summary"
section. The field allows patrons to write notes about the item checked out,
such as "this DVD is scratched", "the binding was torn", etc. The note will be
emailed to the library and displayed on item check in.

Patch adds two fields to the "issues" table - "note" and "notedate".
Patch adds syspref "AllowIssueNotes" - default off.

Test Plan:
1) Apply this patch
2) Update database
3) Rebuild schema
4) Turn on 'AllowIssueNote' syspref
5) Check out three different items to a borrower (may be easiest to check
out to yourself)
6) Log in as that borrower (or yourself) on the OPAC side and go to your
summary
7) Confirm text field shows under Note column for all checkouts. Set a
note for each issue, confirm all save.
8) Check the message_queue in mysql for the entries for ALL THREE issue
notes.
9) Disable javascript in your browser
10) Refresh your summary page. Confirm that you can no longer edit the
notes in the text field. Click the 'Create/edit note' button and confirm
you are redirected to a new page.
11) Confirm that the correct title and author show for the note button
you clicked.
12) Set the note and click Submit -> confirm you are redirected
back to summary page and note is saved
13) Confirm there is a new entry in message_queue
14) Enable javascript and go back to the your checkouts page in the
staff client for the borrower you issued the items to
15) Check in TWO items
16) Confirm that the issue notes show under the "Date due" column for
the two items you checked in, and are accurate to the item (i.e. the
right issue note under the right item)
17) Go to circ/returns.pl and check in the final item using the barcode.
Confirm the issue note shows and the date is formatted correctly.

Sponsored-by: Region Halland

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62200|0   |1
is obsolete||

--- Comment #111 from Jonathan Druart  
---
Created attachment 62637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62637=edit
Bug 14224: Fix prevent submit

That did not work, the form was submitted anyway

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62202|0   |1
is obsolete||

--- Comment #113 from Jonathan Druart  
---
Created attachment 62639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62639=edit
Bug 14224: Replace AllowIssueNotes with AllowCheckoutNotes

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62197|0   |1
is obsolete||

--- Comment #108 from Jonathan Druart  
---
Created attachment 62634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62634=edit
Bug 14224: Do not reintroduce GetItemIssue, it's dying

Bug 17680 is removing it.

Signed-off-by: Jonathan Druart 

Signed-off-by: Josef Moravec 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
  Attachment #62569|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #62617|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 62632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62632=edit
Bug 18461: (bug 13757 follow-up) Do not mix decode_json and to_json

Internal server error while approving OPAC-edited patron attributes
containing umlauts (äöü)

If a OPAC user enters text containing umlauts (äöü) in a patron atribute
and saves it, the Staff client will get an inernal server error in
members-update.pl (approving).

E.g. a text like 111ä222 leads to the following in plack error log:

malformed UTF-8 character in JSON string, at character offset 14

To test:
- Reproduce problem above
- Apply patch
- Verify that Home > Patron > Update records displays without error
and 'New value' displays properly
- Approve!

Also, run the tests:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/Patron/Modifications.t
=> FAIL: Tests explode due to encoding problems in JSON handling
- Apply the patch
- Run the tests again:
 k$ prove t/db_dependent/Koha/Patron/Modifications.t
=> SUCCESS: Tests pass!

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 62631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62631=edit
Bug 18461: Make tests break on wrong UTF8 data handilng

This patch makes the tests fail if extended attributes handling fails due to
wrong UTF-8 data handling.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/Patron/Modifications.t
=> FAIL: Tests explode

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311

M. Tompsett  changed:

   What|Removed |Added

  Attachment #62624|0   |1
is obsolete||

--- Comment #24 from M. Tompsett  ---
Created attachment 62630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62630=edit
Bug 3311: Followup clean up HTML on page.

There should be no validator.w3.org validation issues
for this page's source.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||18182
 Status|Signed Off  |Needs Signoff

--- Comment #16 from Tomás Cohen Arazi  ---
I just re-did this patch following what we discussed with Jonathan.
Please sign again if it works for you!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182
[Bug 18182] TestBuilder should be able to return Koha::Object objects
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18339


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339
[Bug 18339] Koha::Patron::Attribute ->opac_editable and ->opac_display should
be removed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #62419|0   |1
is obsolete||

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 62628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62628=edit
Bug 18339: Remove ->opac_editable ->opac_display from Koha::Patron::Attribute

Trying to simplify the implementation of 13757, I replaced some legacy code
in favour of a Koha::Object-based implementation for the OPAC controller
scripts.
On doing so I went too far with this methods, as what was needed was a way to
retrieve
the type of the attribute and ask it about such properties.

This patch removes those methods, its tests, and replaces them for new methods
in the
Koha::Patron::Attributes class:
- K:P:A->search_opac_displayable
- K:P:A->search_opac_editable

To test:
- Run
  $ prove t/db_dependent/Koha/Patron/Attributes.t
=> SUCCESS: Tests still pass
- Try changing the opac_editable and opac_display properties and play in the
OPAC with those attributes.
Verify that everything works as expected.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #62420|0   |1
is obsolete||

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 62629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62629=edit
Bug 18339: (followup) Remove warnings on adding a patron modification

This patch removes warnings raised because hash values existence is not
checked before comparing them.

As the sub is deleting fields that are similar from the modification, I
considered
the following use cases
- Both fields are defined, need to compare values, should delete if they match
- One of the fields is defined, the other isn't, discrepancy, should not
delete.
- Both fields are not defined, they match, should delete.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Jonathan Druart  
---
Alex, same as bug 18291 comment 6: you should not need to add new method.

Ping me on IRC if you need more details.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18247] Remove SQL queries from branch_transfer_limit.pl administrative script

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18247

Jonathan Druart  changed:

   What|Removed |Added

Version|17.05   |unspecified
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18488] Fines tab on staff client not showing all patron data

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18488

--- Comment #1 from Jesse Maseto  ---
Created attachment 62627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62627=edit
Screen shot 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13835] Popup with searches: results hidden by language menu in footer

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62582|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 62626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62626=edit
Bug 13835: Popup with searches: results hidden by language menu in footer

Language menus in pop up windows are not necessary and can hide the contents
(especially search results) on a narrow screen.

For an example, see screenshot in comment #3

This patch allows to mark pop p menus not to display the language footer.

To test:

- Reproduce issue from comment #3
- Apply patch
- Try to reproduce issue from comment #3
  -> language menu should no longer display
- Verify that language menu is suppresed in 'Add to ist' as well
  (from catalog search results, select an item, Add to:...)

Note: There will be more pop-ups with unwnated language selector.
  That can be resolved in follow up bugs.

Followed test plan which worked as intended
Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18488] New: Fines tab on staff client not showing all patron data

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18488

Bug ID: 18488
   Summary: Fines tab on staff client not showing all patron data
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: je...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 62625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62625=edit
Screen Shot

>From the patrons details page on the staff client. Click on fines tab in left
column. Default is to the Pay Fines tab - Patron information displays correct
under patron image. If you choose the Account, Create manual invoice or Create
manual credit you no longer see the patrons Home library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13835] Popup with searches: results hidden by language menu in footer

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13837] Popup "Search for garantor" should not display language menu in footer

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13837

Jonathan Druart  changed:

   What|Removed |Added

 Status|CLOSED  |RESOLVED
 Resolution|WONTFIX |DUPLICATE
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 13835 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13835] Popup with searches: results hidden by language menu in footer

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13835

--- Comment #7 from Jonathan Druart  
---
*** Bug 13837 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311

M. Tompsett  changed:

   What|Removed |Added

  Attachment #62541|0   |1
is obsolete||

--- Comment #23 from M. Tompsett  ---
Created attachment 62624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62624=edit
Bug 3311: Followup clean up HTML on page.

Should be no validation errors if you paste source code to validator.w3.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3311] Statistical reports should error if row and column aren' t selected

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311

M. Tompsett  changed:

   What|Removed |Added

  Attachment #62533|0   |1
is obsolete||

--- Comment #22 from M. Tompsett  ---
Created attachment 62623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62623=edit
Bug 3311: Form validation feedback

By using the validated class, make use of jquery form submission
validation to inform user of required fields.

TEST PLAN
-
1) run Home -> Reports -> Catalog -> Submit
   -- no meaningful output and no error messages.
2) apply patch
3) repeat 1
   -- meaningful error messages appear.
   -- headings are in red, indicative of required values.
4) try other combinations of row or column selected/unselected.
   -- meaningful error messages.
5) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

--- Comment #11 from Lari Taskula  ---
Removed dependency to Bug 13995 and rebased patch to use Koha::Exceptions
instead. Switched to Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13995] Proper Exception handling

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Lari Taskula  changed:

   What|Removed |Added

 Blocks|14791   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791
[Bug 14791] Automatically attempt to resend failed notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

 Depends on|13995   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

  Attachment #62615|0   |1
is obsolete||

--- Comment #10 from Lari Taskula  ---
Created attachment 62622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62622=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

Sometimes notices keep failing due to various reasons. One common problem
is network connection failures. Because of this, the notices go into
'failed' status without another attempt for sending. This is very problematic,
because we have to not only monitor the failed messages but also resend
them manually. The purpose of this patch is to move us into more automated
way of handling delivery failures.

This patch enables us to handle exceptions in SMS messaging. The main idea
is to throw an exception from SMS::Send driver in case of a failure.
The exception will be caught by C4::SMS and from here it will be forwarded
to C4::Letters where instead of automatically setting the message into
'failed' status, we now can do as we wish with various exceptions.

As an example I have caught Koha::Exceptions::ConnectionFailed in
C4::Letters::_send_message_by_sms(). When we catch the said exception,
we simply leave the message in 'pending' status.  This way it will be resent
whenever process_message_queue.pl is executed again.

sub send_sms {
#.your implementation.

# Throw an exception in case of a connection error
# $connError can be for example: ($curl->{'retcode'} == 6)
# cURL code 6: CURLE_COULDNT_RESOLVE_HOST
if ($connError){
Koha::Exceptions::ConnectionFailed->throw(error => "Connection
failed");
}
}

To test:
1. prove t/db_dependent/Letters.t

Also testable with your own implementation of SMSSendDriver.
1. Have/create some pending sms messages into message_queue
2. Go to Patrons -> Notices
3. Observe that the your message is in pending status
4. Run misc/cronjob/process_message_queue.pl
5. Observe that the message is no longer pending
6. Add Koha::Exceptions::ConnectionFailed->throw(error => "Connection failed");
   to your SMS::Send driver send_sms.
7. Set your message back to pending status
8. Run misc/cronjob/process_message_queue.pl
9. Observe that your message is back in pending status
10. Observe it also has the following delivery note:
"Connection failed. Attempting to resend."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18482] False duplicates detected on adding a batch from a stage file

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62581|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 62621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62621=edit
Bug 18482 False duplicates detected on adding a batch from a stage file

When adding a batch from a stage file with defaut matching on
title/author, if a duplicate is detected, all following records
treated in the batch are discarded from import even if they are not duplicates

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18482] False duplicates detected on adding a batch from a stage file

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18452] Should say 'URL' instead of 'url' in catalog detail

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18452

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15815] improve wording in popup warning when deleting patron from patron-batch

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15815

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18466] No article requests breaks the opac-user-views block

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Eric!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #19 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12074] Filter duplicates when adding a full batch from a staged file

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482
[Bug 18482] False duplicates detected on adding a batch from a stage file
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18482] False duplicates detected on adding a batch from a stage file

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||12074
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |k...@univ-lyon3.fr
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074
[Bug 12074] Filter duplicates when adding a full batch from a staged file
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18457] process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks for the tests Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457
[Bug 18457] process_message_queue.pl will die if a patron has no
sms_provider_id set but sms via email is enabled for that patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18435] Message about Materials specified does not display when items are checked out and checked in

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18435

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18457] process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||9021


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021
[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18457] process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18457] process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62580|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 62619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62619=edit
Bug 18457 - process_message_queue.pl will die if a patron has no
sms_provider_id set but sms via email is enabled for that patron

If SMS via Email is enabled, and a patron has opted for SMS messages, but has
not selected a service provider, the cronjob will die with the error
Can't call method "domain" on an undefined value at
/usr/share/koha/lib/C4/Letters.pm line 1055.
This will cause all messages that come after the error to not be sent!

Test Plan:
1) Enable SMS via Email
2) Enable SMS for a patron, but don't set a provider
3) Perform an action that will trigger an sms message to go into
   the holds queue ( item due, item checkout, etc )
4) Run process_message_queue.pl, note the error
5) Apply the patch
4) Run process_message_queue.pl, no error this time!

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18457] process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457

--- Comment #5 from Jonathan Druart  
---
Created attachment 62620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62620=edit
Bug 18457: Add tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62578|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 62618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62618=edit
Bug 18468 - When adding from a staged file order discounts are not passed into
C4::Acquisitions::populate_order_with_prices

To test:
1 - Setup a vendor with a discount
2 - Stage a file
3 - Create a basket
4 - Order from staged file
5 - Add a price but no discount
6 - Save order
7 - Note ecost is not discounted
8 - Apply patch
9 - Repeate 2-6
10 - Note ecost is discounted

Signed-off-by: Alex Buckley 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18468


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468
[Bug 18468] When adding from a staged file order discounts are not passed into
C4::Acquisitions::populate_order_with_prices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||15503


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
[Bug 15503] Grab Item Information from Order Files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461

Jonathan Druart  changed:

   What|Removed |Added

   Severity|major   |critical
 Status|Failed QA   |Needs Signoff
   Assignee|ve...@veron.ch  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461

--- Comment #6 from Jonathan Druart  
---
Created attachment 62617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62617=edit
Bug 18461: (bug 13757 follow-up) Do not mix decode_json and to_json

Internal server error while approving OPAC-edited patron attributes
containing umlauts (äöü)

If a OPAC user enters text containing umlauts (äöü) in a patron atribute
and saves it, the Staff client will get an inernal server error in
members-update.pl (approving).

E.g. a text like 111ä222 leads to the following in plack error log:

malformed UTF-8 character in JSON string, at character offset 14

To test:
- Reproduce problem above
- Apply patch
- Verify that Home > Patron > Update records displays without error
and 'New value' displays properly
- Approve!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table.

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18461


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461
[Bug 18461] Internal server error while approving OPAC-edited patron attributes
containing umlauts (äöü)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||13757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
[Bug 13757] Make patron attributes editable in the opac if set to 'editable in
OPAC'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
It does not work for me, I get "The passed extended_attributes is not valid
JSON"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18466] No article requests breaks the opac-user-views block

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62563|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 62616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62616=edit
Bug 18466: article requests box outline in opac

To test:
1) apply patch
2) ensure ArticleRequests is set to Enable
3) sign in as a user with no article requests on the OPAC side
4) click the 'article requests' tab & see the box & message

Sponsored-By: California College of the Arts

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18466] No article requests breaks the opac-user-views block

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18466] No article requests breaks the opac-user-views block

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||14610


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610
[Bug 14610] Add ability to place article requests in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18466


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466
[Bug 18466] No article requests breaks the opac-user-views block
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42698|0   |1
is obsolete||

--- Comment #9 from Lari Taskula  ---
Created attachment 62615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62615=edit
Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers

Sometimes notices keep failing due to various reasons. One common problem
is network connection failures. Because of this, the notices go into
'failed' status without another attempt for sending. This is very problematic,
because we have to not only monitor the failed messages but also resend
them manually. The purpose of this patch is to move us into more automated
way of handling delivery failures.

This patch enables us to handle exceptions in SMS messaging. The main idea
is to throw an exception from SMS::Send driver in case of a failure.
The exception will be caught by C4::SMS and from here it will be forwarded
to C4::Letters where instead of automatically setting the message into
'failed' status, we now can do as we wish with various exceptions.

As an example I have caught Koha::Exception::ConnectionFailed in
C4::Letters::_send_message_by_sms(). When we catch the said exception,
we simply leave the message in 'pending' status.  This way it will be resent
whenever process_message_queue.pl is executed again.

There are multiple other reasons of failure where Exceptions will come
in handy. For example the SMS Gateway provider may return some errors
at request, and with this patch we will be able to handle them better.

Below is a short example for making your SMS::Send driver throw an
exception in case of a connection failure in SMS/Send/MyDriver/Driver.pm.

___
use Koha::Exception::ConnectionFailed;

sub send_sms {
#.your implementation.

# Throw an exception in case of a connection error
# $connError can be for example: ($curl->{'retcode'} == 6)
# cURL code 6: CURLE_COULDNT_RESOLVE_HOST
if ($connError){
Koha::Exception::ConnectionFailed->throw(error => "Connection failed");
}

#.your implementation.
}
___

prerequisites:
-2. Set system preference SMSSendDriver to Example::ExceptionExample
-1. Enable system preference EnhancedMessagingPreferences

To test:
1. Have/create some pending sms messages into message_queue
2. Go to Patrons -> Notices
3. Observe that the your message is in pending status
4. Apply patch
5. Run misc/cronjob/process_message_queue.pl
6. Observe that your message is still in pending status

You can also test it with your own implementation of SMSSendDriver.
What you need to do is follow the example mentioned earlier to make
send_sms() subroutine throw Koha::Exception::ConnectionFailed
in case of a connection failure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #18 from Jonathan Druart  
---
Created attachment 62614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62614=edit
Bug 15702: Recommended Counter-patch

As per comment #7, this patch affects AddMember and ModMember.
The test plan should be the same as comment #6.
Secondary patch with tests still to come.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62527|0   |1
is obsolete||
  Attachment #62528|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 62613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62613=edit
Bug 15702: Add test cases for modified code

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #6 from Jonathan Druart  
---
Alex,
There are several things wrong in these patches:

1. The test you added to t/db_dependent/sysprefs.t does not test the new method
you added to Koha::Config::SysPref

2. For modules based on Koha::Object[s], we have 2 modules:
Koha::Config::Syspref and Koha::Config::Sysprefs (notice the s at the end).
One if for a single record, the other one is for collection/list.
Modules based on Koha::Object[s] already provide you a lot of CRUD
functionalities, without doing anything in the module.
For instance Koha::Config::Sysprefs->find( $variable ) will return an object
representing the system preference $variable.
It is exactly what you are doing with your new method.

3. To access sysprefs you need to call C4::Context->preference.
This subroutine uses a cache and is the one to call to access sysprefs.

I do not see a valid reason not to fetch the in cache values here, so a 1 line
patch should do the trick ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18291] Remove SQL from preferences.pl administrative script

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18291

Jonathan Druart  changed:

   What|Removed |Added

Version|17.05   |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
I think this isn't the right way to format the string. As it is now, the po
file for this string looks like this:

"No item found with barcode %s"

After this patch, it looks like this:

"No item found %swith barcode %s%s"

I think the latter is going to be more confusing to translators. It's more
verbose, but I wonder if this would be better:

[% IF ERROR_ITEM_NOT_FOUND %]
[% IF UNKNOWN_BARCODE %]
No item found with barcode [%
UNKNOWN_BARCODE %]
[% ELSE %]
 No item found
[% END %]
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18299] Removal of SQL queries from admin/ env_tz_test.pl script into a perl module

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18299

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||m.de.r...@rijksmuseum.nl,
   ||tomasco...@gmail.com
Version|17.05   |unspecified

--- Comment #8 from Jonathan Druart  
---
I was not aware of this script and I think it does not make sense to have it.
I'd prefer to remove it than adding more code to the codebase to maintain it.

Opinions?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #55 from Kyle M Hall  ---
Can you please camel case your module names for readability ( e.g.
Koha::StockRotationItem instead of Koha::Stockrotationitem )?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 181 matches

Mail list logo