[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #62 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #61) > This works well without UseControlNumber so far, but when I turn it on, the > link that was visible before, disappears: > > Parent record: > 001 15661423 > > Child record: > LDR 00395a2200121 4500 = monographic component part > 773 0 _dCambridge, Mass. : Belknap Press of Harvard > University Press, > 2009. > _aWilson, Peter H. > _z9780674036345 (hardcover : alk. paper) > _w15661423 > _tThe Thirty Years War : > > Can you please check? Will check. If you use master, and the link shows. Does it give you any results? It now shows based on those results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25650] Add location and itype descriptions in ILS-DI GetRecords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- (In reply to Nick Clemens from comment #5) > This works as described. > > I have a question: for homebrnahcname and holdingbranchname we include the > key whether or not we have a value - here the description tags are not > included if the itype of location don't match an existing value - is there a > reason for this? Julian, can you please check and comment? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 Katrin Fischer changed: What|Removed |Added Attachment #107860|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 108947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108947=edit Bug 25791: Remove win.print() Test plan: 1) Turn on system preference SelfCheckReceiptPrompt 2) Check out item via /cgi-bin/koha/sco/sco-main.pl 3) Click "Finish" 4) Click 'Print receipt and end session' 5) Notice two print dialog boxes right on top of each other 6) Apply patch 7) Repeat steps 1 - 4 8) Should only get a single print dialog. 9) Test in FF/Chrome and make sure behavior is consistent Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #61 from Katrin Fischer --- This works well without UseControlNumber so far, but when I turn it on, the link that was visible before, disappears: Parent record: 001 15661423 Child record: LDR 00395a2200121 4500 = monographic component part 773 0 _dCambridge, Mass. : Belknap Press of Harvard University Press, 2009. _aWilson, Peter H. _z9780674036345 (hardcover : alk. paper) _w15661423 _tThe Thirty Years War : Can you please check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- I've tried testing this from the branch, but there is an error on the yarn build: $ yarn build --view opac yarn run v1.22.4 $ node_modules/.bin/gulp build --view opac [10:47:07] Using gulpfile ~/kohaclone/gulpfile.js [10:47:07] Starting 'build'... Error in plugin 'sass' Message: koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss Error: File to import not found or unreadable: ../../../../../node_modules/bootstrap/scss/functions. on line 39 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >> @import "../../../../../node_modules/bootstrap/scss/functions"; ^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Katrin Fischer changed: What|Removed |Added Attachment #108166|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 108946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108946=edit Bug 24973: Load custom localization file It adds a new localization directory that could host a custom SQL file for each language, xx-YY/custom.sql This will be the last file to be loaded at install time, it can be used to set any difference from default values. It can't be deselected at install time. Moved corresponding files for de-DE, it-IT, nb-NO and completed es-ES To test: 1) Apply the patch 2) Install es-ES/de-DE/it-IT/nb-NO translation (any lang) ( cd misc/translation; ./translate install es-ES ) 3) Do a clean install using es-ES 4) After all files have been loaded check: * A new section labeled "Localization data added" with one file, custom.sql * Inspect the value of FrameworksLoaded syspref, last entry must be custom.sql 5) Remove/rename the file or localization dir and repeat 3/4, install must proceed normally Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #81 from Katrin Fischer --- Could someone help me out here by at least testing the SIP bit? I can take care of the other parts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 --- Comment #16 from Katrin Fischer --- I think this is a nice little enhancement as is. I'd love to see codemirror JSON highlighting used on the modal in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer changed: What|Removed |Added Attachment #108191|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 108944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108944=edit Bug 18829: Elasticsearch - Put a better display for the view of ES indexed record To test: - apply the patch - go to global sysPref - make sure that SearchEngine have "ElasticSearch" as value - Search whatever you want in Search the catalog and select a record - Search the link (Ctrl f) : "Elasticsearch Record :" , click on the link - make sure that the pop-up open and you should see the elasticsearch result in JSON (the pop-up look the same as MARC preview) - note fields are alphabetized - from the command line delete the es record: curl -XDELETE es:9200/koha_kohadev_biblios/data/5 - click the preview link, it syas record not found - check the logs - you see the error on missing record Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 --- Comment #15 from Katrin Fischer --- Created attachment 108945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108945=edit Bug 18829: (QA follow-up) Fix punctuation, capitalization and page title Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #6 from Katrin Fischer --- Hi Kyle, can you please help me with testing this? I don't have any invoice data to use. From review: 1) Pref description " automatically import EDIFACT invoice message file when they are downloaded." Small typo, I think it should read "files"? 2) Why pref driven and not an EDI account option? From looking at the options available, I was wondering why this is our first EDIFACT preference. I would have expected this on the EDI account level, where we also have the "Automatic ordering:" and other workflow relevant options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Katrin Fischer changed: What|Removed |Added Attachment #108210|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 108943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108943=edit Bug 23682: Add ability to manually import EDI invoices as an alternative to automatic importing on download Some library would like to delay the importing of invoices until a time of their choosing. The invoices should be imported into the database as they do now, but the invoice processing should be skipped. Instead, any invoice file with a status of 'new' should have an 'Import' button to process the invoice. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref EdifactInvoiceImport 4) Run the edi cronjob to import a new invoice file 5) View EDI messages table at /acqui/edifactmsgs.pl 6) Note the invoice files is not processes, and retains the status of 'new' 7) Use the 'import' button to process the invoice 8) Note the invoice is now marked 'received' and the 'import' button is gone 9) Verify the invoice was actually processes Signed-off-by: Debi Stears -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Katrin Fischer changed: What|Removed |Added Attachment #106299|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 108942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108942=edit Bug 25662: (follow-up) Add tests for the wrong patron_id added behaviour This patch adds trivial tests for the new error (400) raised when the passed patron_id doesn't exist. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Katrin Fischer changed: What|Removed |Added Attachment #106298|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 108941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108941=edit Bug 25662: Make the route for holds restpect maxreserves This patch fixes the behaviour for the POST /holds route. It assumed maxreserves was checked in CanItemBeReserved which is not the case. Tests are added to check for this behaviour. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Katrin Fischer changed: What|Removed |Added Attachment #106297|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 108940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108940=edit Bug 25662: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #12 from Katrin Fischer --- Let's pretend we switched - I will sign off and Kyle will count for QA ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- Please check comment#9 and comment#10 - something appears not to be right with uninstalling plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26139] 'Place hold' button isn't hidden in all detail views if there are no items available for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26139 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #6 from Katrin Fischer --- This depends on bug 23166 that hasn't been signed off yet - moving to BLOCKED. Please bring it back into the QA queue once the dependency is resolved. This patch also does no longer apply. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26139: Centralize code for "Place hold" button (detail) Using index info to reconstruct a base tree... M t/db_dependent/Koha/Items.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Items.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Items.t error: Failed to merge in the changes. Patch failed at 0001 Bug 26139: Centralize code for "Place hold" button (detail) The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-26139-Centralize-code-for-Place-hold-button-de-zcySqH.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26139] 'Place Hold' button isn't hidden in all detail views if there are no items available for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26139 Katrin Fischer changed: What|Removed |Added Summary|'Place Hold' button isn't |'Place Hold' button isn't |hidden in all biblio views |hidden in all detail views |if there's no items |if there are no items |available for loan. |available for loan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26139] 'Place hold' button isn't hidden in all detail views if there are no items available for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26139 Katrin Fischer changed: What|Removed |Added Summary|'Place Hold' button isn't |'Place hold' button isn't |hidden in all detail views |hidden in all detail views |if there are no items |if there are no items |available for loan |available for loan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #42 from Katrin Fischer --- I am still learning about Elasticsearch. In order to test this patch set, I applied the patches and tried do reindex. When I run the reindex with -d, I have an error that doesn't appear without the patches: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ ./misc/search_tools/rebuild_elasticsearch.pl -d One or more ElasticSearch errors occurred when indexing documents at ./misc/search_tools/rebuild_elasticsearch.pl line 302. The sorting appears to work really well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23875] Elasticsearch - When sorting by score we should provide a tiebreaker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- (In reply to Martin Renvoize from comment #12) > Are you intending on continuing here with the requested followup Nick? > > I think the suggestion was to have a fixed biblionumber index which is > numeric and use that for the tie-breaker by default.. as aposed to using the > existing 'local-number' index which can be re-mapped? I really believe we should do that and have a numerical sort on the biblionumber as a tiebreaker. I hear your argument about remapping local-number, but I believe that this is a concern that needs more work and thinking overall if we want to officially support it. At the moment, doing that, would probably break your Zebra pretty badly and now allow to switch back and forth easily anymore. Having a numerical sort on biblionumber on the tiebreaker would also mimick Zebra a bit allowing to compare relevance sort results more easily. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23875] Elasticsearch - When sorting by score we should provide a tiebreaker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 Katrin Fischer changed: What|Removed |Added Summary|Elasticsearch - ES - When |Elasticsearch - When |sorting by score we should |sorting by score we should |provide a tiebreaker|provide a tiebreaker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 Katrin Fischer changed: What|Removed |Added Attachment #107591|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 108939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108939=edit Bug 26076: (QA Follow up) Prevent error by using a fresh resultset Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 --- Comment #23 from Katrin Fischer --- As the error has proven hard to replicate I am passing this mostly on base of regression testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 Katrin Fischer changed: What|Removed |Added Attachment #107590|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 108938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108938=edit Bug 26076: Sum the amount due in the database query instead of a loop in Perl This appears to be a bug due to inaccuracies in floating point math. I've been unable to reproduce it on demand. Sometimes when using the "Write off selected" button, Koha will give the error that the payment is more than the amount owed, even though they are the same. The solution I've implemented is to move the summation from Perl code to the database query. This video demonstrates the issue and afterward, shows the error goes away after the patch is applied: https://monosnap.com/file/pG69HC7iI9mU9kkuoCtbkVzVTffKlE Test Plan: 1) Apply this patch 2) Restart all the things! 3) Verify that "Write off selected" functions as usual Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #14 from Katrin Fischer ---
Hi Kyle,
I spotted an unresolved TODO:
+my $guarantees_fines_amount = $flags->{CHARGES_GUARANTEES} ?
$flags->{CHARGES_GUARANTEES}->{amount} : 0; #TODO: Replace with
$patron->relationships_debt
Do you want to fix this?
The "blocking" worked this time for me. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer --- Hi Nick, the QA script found some problems, please fix: AIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column search_field.mandatory is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/SearchField.pm), see the SQL12 coding guideline FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt FAIL filters missing_filter at line 193 () missing_filter at line 196 () missing_filter at line 383 ( Delete) OK forbidden patterns OK git manipulation OK js_in_body OK spelling FAIL tt_valid lines 193, 196 OK valid_template * Commit title does not start with 'Bug X: ' - df373aaf1f * Commit title does not start with 'Bug X: ' - 7c2fb8cbb1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #61 from Katrin Fischer --- (In reply to Katrin Fischer from comment #58) > The test worked for me, but the reserve_id column remained NULL at all times > - can you please explain? Making sure this is seen after I added a follow-up for a comma. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #60 from Katrin Fischer --- Created attachment 108937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108937=edit Bug 18958: (QA follow-up) Add missing comma to kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Katrin Fischer changed: What|Removed |Added Attachment #108500|0 |1 is obsolete|| --- Comment #59 from Katrin Fischer --- Created attachment 108936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108936=edit Bug 18958: Make hold_fill_targets specific to reserves After looking at Marcel's comments, the problem is in our matching to hold_fill_targets - rather than adjusting to find filled/waiting holds we could ensure that hold_fill_targets only refers to the specific hold it is intended to This patch is clearer, if slightly less performant than last (we now return all the reserves and have to find the 'highest') Test Plan: 1 - Create and use a patron that can place multiple record level holds per record 2 - Create a record with X items, each at a different library 3 - Place X 'Next available' holds on the record for the patron using the 'Holds to place' box 4 - perl misc/cronjobs/holds/build_holdsqueue.pl 5 - Check in LibraryA's copy as LibraryA and confirm the hold 6 - Revisit request.pl for the record, notice the next hold in line is now item-specific 7 - Checkout the item to the patron, notice the remaining hold is marked waiting 8 - Attempt to place another hold for your patron, notice that it requires an item-specific hold 8 - Apply this patch 9 - Repeat steps 1-5 10 - Revisit request.pl for the record, notice the next hold in line has *not* become item-specific 11 - Checkout the item to the patron, ensure the first hold is filled and the second remains record level 12 - Repeat whole test plan without building holds queue to confirm holds are still treated correctly Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #58 from Katrin Fischer --- The test worked for me, but the reserve_id column remained NULL at all times - can you please explain? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Katrin Fischer changed: What|Removed |Added Attachment #108553|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 108935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108935=edit Bug 21539: addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan Signed-off-by: Daniel Gaghan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 Katrin Fischer changed: What|Removed |Added Attachment #108592|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 108933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108933=edit Bug 25958: Allow LongOverdue cron to exclude specified lost values When lost items are not marked as returned, they are still subject to the long overdue cron, so an item that has already been marked Lost may automatically roll to Long Overdue. In some cases, a library may not want that lost value to change. This becomes especially important with the introduction of Claims Returned, which uses a variety of lost. Test Plan: 1) Set up a long overdue item that would be moved to lost by longoverdue.pl 2) Run the cronjob with the new --skip-lost-value option 3) Note the item is not altered 4) Include that value in the new system preference DefaultLongOverdueSkipLostStatuses 5) Run the cronjob *without* the new option 6) Note the item is not altered 7) Run the cronjob again with the new command line option, but set it to a different value so the item will be affected 8) Note the item is altered as it would have been before this patch was applied Signed-off-by: Lisette Scheer Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 --- Comment #7 from Katrin Fischer --- Created attachment 108934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108934=edit Bug 25958: (QA follow-up) Add some punctuation to new DefaultLongOverdueSkipLostStatuses Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Amit Gupta changed: What|Removed |Added CC||amit.gupta@informaticsgloba ||l.com, ||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Amit Gupta changed: What|Removed |Added CC||amit.gupta@informaticsgloba ||l.com, ||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26266] Add jQuery validator to opac-password-recovery.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 --- Comment #2 from Amit Gupta --- (In reply to Timothy Alexis Vass from comment #1) > Created attachment 108800 [details] [review] > Bug 26266: Add jQuery validator to opac-password-recovery.tt > > To test: > 1) Initiate password recovery. > 2) Try to enter an invalid password. > 3) Confirm that validation occurs. > 4) Try to enter mismatching passwords. > 5) Confirm that validation occurs. > 6) Sign off. Hi Timothy, I have applied the patch and not find any validation while entering the mismatch password. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26266] Add jQuery validator to opac-password-recovery.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Amit Gupta changed: What|Removed |Added CC||amit.gupta@informaticsgloba ||l.com, ||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26067] Member email validation based on MX record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067 Amit Gupta changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26067] Member email validation based on MX record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067 Amit Gupta changed: What|Removed |Added Attachment #108660|0 |1 is obsolete|| --- Comment #17 from Amit Gupta --- Created attachment 108932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108932=edit Bug 26067: Member email validation based on MX record. To Test 1. Enable system preference PatronSelfRegistration 2. Set PatronSelfRegistrationDefaultCategory for ex: ST 3. Set PatronSelfRegistrationLibraryList for ex: MPL 4. Open the page /cgi-bin/koha/opac-memberentry.pl 5. Fill the form and enter email address in Primary email, Secondary email and B_email for ex: amit@gmail.c, amit1@gmail.c, amitgupta@gmail.c you will able to submit the page and it will not give any error message. 6. Apply the patch 7. Check system preference PatronEmailValidationMXrecord by default it show "Require". 8. Open the /cgi-bin/koha/opac-memberentry.pl again 9. Fill the form and enter email address in Primary email, Secondary email and B_email for ex: amit@gmail.c, amit1@gmail.c, amitgupta@gmail.c and click on Submit button and it will give error message "Invalid primary email address", "Invalid secondary email address", "Invalid email address". 10. This patch will check email, emailpro and B_email address field. -- Fix QA comments This patch will check email, emailpro and B_email address field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #12 from Katrin Fischer ---
Starting with a first round of testing and reviewing here:
1) Database update
I feel it would be cleaner to do the same check for the old_reserves table as
well:
if( !column_exists( 'reserves', 'non_priority' ) ) {
2) GUI
request.tt
a) I am not sure of a 'non priority hold' is a standing term, but I haven't
seen this feature in another ILS before. I think maybe having an explanation in
a tool tip or after the checkbox could be quite helpful here.
I'd also suggest to add an ID to the to help libraries hide this
functionality if they don't intend on using it:
+
+Non priority
hold:
+
+
b) Once the hold is placed, there is no way to visually tell that it's a
non-priority hold. I think this could lead to support questions and we will
only be able to figure it out looking at the database entry.
I'd strongly recommend to add a note to request.tt and to the hold list in the
patron account on staff side. On request.tt this could go into the Details
column.
3) More than one hold
My test case:
- Check out item to Henry
- Place a non-priority hold for admin
- Henry can still renew
- Place another hold for a regular staff patron
- Henry can still renew...
I feel like it needs to look at all holds and not only the next one?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] Add JavaScript validation to date of birth field in OPAC registration form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Hi Amit, I have checked the patches here: 1) Change for date of birth I can replicate the error Owen describes when I change the dateformat to dd.mm.. I click on the datepicker, select a date, but the input field remains empty. It works without the patch. This works as described for mm/dd/, but I feel like this would be irritating to users. I'd prefer if we displayed a validation error "Date is invalid, please enter a correct date" or similar. 2) Change to opac-reserve.pl I think this would be a separate problem for another bug and should be moved if necessary. But that said, I cannot replicate the problem you describe. :( I have checked the opac-reserve.pl page on master: - Place hold - More options - Calendar icon on "Hold not needed after:" shows and works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] Add JavaScript validation to date of birth field in OPAC registration form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 --- Comment #10 from Katrin Fischer --- Hi Brandon, please check your process for signing off bugs with mulitple patches - we need the sign-off lines on all patches and the old ones to be marked obsolete. Git bz can help you with all that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] Add JavaScript validation to date of birth field in OPAC registration form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Katrin Fischer changed: What|Removed |Added Attachment #108335|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #13 from Katrin Fischer ---
Hi,
it looks like the readonly is set in the JavaScript:
$(".toggle-hold-options").show();
$(".hold-options").hide();
$(".holddatefrom,.holddateto").prop("readOnly", true);
.holddateto is the one for "Hold not needed after:".
Owen, could you maybe help out here? I am not sure why this was added and if we
have means to validate the field input.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26067] Member email validation based on MX record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067 Amit Gupta changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #16 from Amit Gupta --- (In reply to Katrin Fischer from comment #15) > Hi Amit, > > 1) sysprefs.sql > is sorted alphabetically, can you please move the new pref line into the > right spot? > > 2) opac.pref > Doesn't quite work yet as a sentence and there is a little typo on 'no'. > Maybe: > > Now: > +- pref: PatronEmailValidationMXrecord > + choices: > + yes: Require > + no: "Dont't require" > +- "Mail Exchange (MX) records are DNS records that are > necessary for delivering email to Patron." > +- > > Suggestion: > +- pref: PatronEmailValidationMXrecord > + choices: > + yes: Require > + no: "Don't require" > +- "email address entered on patron self registration to pass > Mail Exchange (MX) record check." > > 3) As we allow to use every patron email address as the 'to' address we sent > email to (see AutoEmailPrimaryAddress), I'd suggest to make this change for > all the email address fields. Thank Katrin for QA will do the changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26067] Member email validation based on MX record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26067 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- Hi Amit, 1) sysprefs.sql is sorted alphabetically, can you please move the new pref line into the right spot? 2) opac.pref Doesn't quite work yet as a sentence and there is a little typo on 'no'. Maybe: Now: +- pref: PatronEmailValidationMXrecord + choices: + yes: Require + no: "Dont't require" +- "Mail Exchange (MX) records are DNS records that are necessary for delivering email to Patron." +- Suggestion: +- pref: PatronEmailValidationMXrecord + choices: + yes: Require + no: "Don't require" +- "email address entered on patron self registration to pass Mail Exchange (MX) record check." 3) As we allow to use every patron email address as the 'to' address we sent email to (see AutoEmailPrimaryAddress), I'd suggest to make this change for all the email address fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419
Katrin Fischer changed:
What|Removed |Added
CC||oleon...@myacpl.org
--- Comment #6 from Katrin Fischer ---
Hi David,
there are some issues here:
1) QA test tools
There are some missing filters the QA tools complain about (excuse the bad
formatting):
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
FAIL filters
missing_filter at line 269 ([%
Koha.Preference('IntranetAcquisitionsHomeHTML') %])
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tt
FAIL filters
missing_filter at line 30 ([%
Koha.Preference('IntranetAuthoritiesHomeHTML') %])
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
FAIL filters
missing_filter at line 302 ([%
Koha.Preference('IntranetCatalogingHomeHTML') %])
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
FAIL filters
missing_filter at line 517 ([%
Koha.Preference('IntranetPatronsHomeHTML') %])
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
FAIL filters
missing_filter at line 403 ([%
Koha.Preference('IntranetPOSHomeHTML') %])
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt
FAIL filters
missing_filter at line 45 ([%
Koha.Preference('IntranetSerialsHomeHTML') %])
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
FAIL filters
missing_filter at line 772 ([%
Koha.Preference('IntranetListsHomeHTML') %])
I think we probably needs a $raw here, as we expect the content to be HTML
I am adding Owen to see if he is planning to move the intranet related content
prefs to the news editor as well.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26283] New: dateexpiry is missing in the new modal for PatronSelfModificationBorrowerUnwantedField and others
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26283 Bug ID: 26283 Summary: dateexpiry is missing in the new modal for PatronSelfModificationBorrowerUnwantedField and others Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The dateexpiry has the markup for being hidden, but you can't do it using the PatronSelfModificationBorrowerUnwantedField pref as it's missing in the column list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26222] Ability to show membership registration and membership renewal date on opac-memberentry.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26222 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hi Amit, please take a look at the markup for the other fields: it should be possible to hide the new fields using the PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField system preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26222] Ability to show membership registration and membership renewal date on opac-memberentry.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26222 Katrin Fischer changed: What|Removed |Added Attachment #108364|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #108889|0 |1 is obsolete|| --- Comment #45 from Katrin Fischer --- Created attachment 108929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108929=edit Bug 25728: Use a svc script instead of the REST API endpoint The try to implement correctly the REST API endpoint for authorised values failed. This patch uses an easy to implement svc script for the POST route. Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #108922|0 |1 is obsolete|| --- Comment #47 from Katrin Fischer --- Created attachment 108931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108931=edit Bug 25728: Don't prefill av's code Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #108890|0 |1 is obsolete|| --- Comment #46 from Katrin Fischer --- Created attachment 108930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108930=edit Bug 25728: fix rebase issues Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #108886|0 |1 is obsolete|| --- Comment #42 from Katrin Fischer --- Created attachment 108926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108926=edit Bug 25728: Don't explode in the advanced editor Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #108887|0 |1 is obsolete|| --- Comment #43 from Katrin Fischer --- Created attachment 108927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108927=edit Bug 25728: Fix the clone field feature Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #108885|0 |1 is obsolete|| --- Comment #41 from Katrin Fischer --- Created attachment 108925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108925=edit Bug 25728: Create AV when cataloguing an authority record Test plan: Same as the first patch but when cataloguing an authority record Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #10|0 |1 is obsolete|| --- Comment #44 from Katrin Fischer --- Created attachment 108928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108928=edit Bug 25728: Don't explode if no CAN_* var defined Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #108884|0 |1 is obsolete|| --- Comment #40 from Katrin Fischer --- Created attachment 108924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108924=edit Bug 25728: Create AV when adding a new item We do a bit of refactoring to make the code reusable. Test plan: Same as the first patch but when adding/editing an item QA note: There is a warning from the QA tools FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL js_in_body A
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Attachment #108883|0 |1 is obsolete|| --- Comment #39 from Katrin Fischer --- Created attachment 108923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108923=edit Bug 25728: Create AV when cataloguing a bibliographic record This whole patch set adds the ability to create a new authorised value directly from the cataloguing module. It will prevent the cataloger to leave and reload the page if they need a new one. Test plan: If you are logged in with a patron with the manage_authorised_values subpermission you will be able to: * Edit a bibliographic record * Search for a subfield linked to an authorised values (not the "fake" AV like itemtypes, branches, cn) * Click the dropdown list and start searching for a value that does not exist * Click enter * Fill the fields in the popup * Save => Your dropdown list has the new AV :) Note: This does not work for the advanced editor. It does not have select2 applied to the selects. I have hardly tried but failed. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #93 from Katrin Fischer --- Patch no longer applies cleanly, please rebase! (should not be hard for someone getting the logic there) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
--- Comment #77 from Katrin Fischer ---
Spotted something else:
self.$error.html(_('Sorry, nothing found.'));
Is not translatable (in .js). Just needs another _
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #76 from Katrin Fischer ---
1) Copyright date changed
The patch set changes the size on coyprightdate and add a pattern check:
-
+
I am not sure about this one, especially since it causes issues as Lisette
noted on comment#75. The message is just: Please match the requested format.
The label and the check also don't match and add a bit to the confusion - we
ask for "date" but expect "year".
I think adding a hint on the field with the expected format or improving the
validation feedback, would be a worthwhile addition here to complement the new
check.
I am not sure if we can agree on this, but maybe we can discuss renaming
Copyright date to publication year? I think this is the only context we use
this specific term. (not blocker, asking for opinion and can file separately)
2) Translations in .js files
This trick is no longer necessary, you can now wrap translations in js files in
__( ) to make them translatable. As Owen is just working hard on switching all
the old constructs to the new one, we should avoid adding more work for him.
Can you please change that?
+var MSG_UNDO_AUTOFILL_SUGGESTION = _("Undo");
+var MSG_SEARCH_GOOGLE_BOOKS = _("Search Google Books");
3) Undo
Not blocker, but wondering if "Clear form" or similar would work a bit better
in this case and be more specific for translations.
Failing for 2) and a missing hint on 1). Really close and works nicely already,
hope to see this come back soon!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #38 from Jonathan Druart --- Created attachment 108922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108922=edit Bug 25728: Don't prefill av's code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26157] Redirect expected DBI warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26157 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26157] Redirect expected DBI warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26157 Katrin Fischer changed: What|Removed |Added Attachment #108802|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 108921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108921=edit Bug 26157: Hide expected DBI warnings from tests We must redirect them to /dev/null if we know they will appear. Test plan: prove the different test files and confirm that the output is clean when this patch is applied Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #63 from Katrin Fischer --- (In reply to Jonathan Druart from comment #50) > In the following patch: > Bug 25630: (follow-up) Fix capitalization and terminology for system > preferences > > We removed the nice indentation we had in > koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc > > Is there a good reason? Fixed I hope, would be happy if you could have another look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108269|0 |1 is obsolete|| --- Comment #61 from Katrin Fischer --- Created attachment 108919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108919=edit Bug 25630: Fix capitalization and terminology for Accounting, Administration and Serials system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AccountAutoReconcile (Do not to Don't for consistency with other prefs) - IndependentBranchesPatronModifications (p) - IndependentBranchesTransfers (p) - GoogleOpenIDConnect (google to Google) - UsageStatsLibrariesInfo (c) - opacSerialDefaultTab (c) - StaffSerialIssueDisplayCount (staff interface) - SubscriptionDuplicateDroppedInput (c) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108268|0 |1 is obsolete|| --- Comment #60 from Katrin Fischer --- Created attachment 108918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108918=edit Bug 25630: Fix capitalization and terminology for Authorities and Cataloging system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AuthDisplayHierarchy (biblio to bibliographic) - MARCAuthorityControlField008 (p) - UNIMARCAuthorityField100 (p) - LinkerModule (c) - LinkerOptions (p) - SpineLabelShowPrintOnBibDetails (bib to bibliographic) - DefaultLanguageField008 (p) - DefaultCountryField008 (p) - SubfieldsToAllowForRestricted* (p, rephrase) - URLLinkText (added 'and items' - new with 20.05) - IntranetBiblioDefaultView (c) - MergeReportFields (rephrase) - BibtexExportAdditionalFields (marc to MARC) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108270|0 |1 is obsolete|| --- Comment #62 from Katrin Fischer --- Created attachment 108920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108920=edit Bug 25630: (follow-up) Fix capitalization and terminology for system preferences Additional capitalization, punctuation, terminolgy and improvements to text for system preferences: - Punctuation (such as full stops at the end of sentences) - Capitalization - Terminology (staff interface, use of "Don't" instead of "Do not") - Rearranged/rephrased for better readability To test: - Verify that the changes listed are consistent and make sense. - Check that on the staff interface home page that the window title says "Koha staff interface". - Verify that in system preferences the name of the tab for Staff interface displays correctly, and that clicking on it brings up the staff interface preferences. - For Patrons > CollapseFieldsPatronAddForm check that the edit and add patron form works correctly (edit a patron, add a new patron, check that labels display correctly). Staff interface home page - - Change the page title in browser from "Koha staff client" to "Koha staff interface". Administration -- Google OpenID Connect: . GoogleOpenIDConnectAutoRegister: change "Don't Allow" to "Don't allow" and change "users" to "patrons". . GoogleOpenIDConnectDefaultBranch: move the input field to the end of the sentence. . GoogleOpenIDConnectDefaultCategory: move the input field to the end of the sentence. . GoogleOpenIDConnectDomain: reword to "Restrict Google OpenID Connect to domain (or subdomain of this domain): . Leave blank for all Google domains.". Interface options: . SendAllEmailsTo: add a full stop. Share anonymous usage statistics: . UsageStatsLibrariesInfo: change "Do not share" to "Don't share"; add a full stop; for note "Don't share" should be "No". . most preferences: for note "Don't share" should be "No" (don't share) (for preferences UsageStatsCountry, UsageStatsGeolocation, UsageStatsLibrariesInfo, UsageStatsLibraryName, UsageStatsLibraryType, and UsageStatsLibraryUrl), various edits to make more readable and consistent. Authorities --- General . AuthorityControlledIndicators: change "biblio field" to "bibliographic field". . AutoCreateAuthorities: change "do not generate" to "don't generate". Linker: . CatalogModuleRelink: change "Do not" to "Don't". . LinkerKeepStale: change "Do not" to "Don't". . LinkerModule: change "Default" to "default". . LinkerOptions: add a full stop. . LinkerRelink: change "Do not" to "Don't". Cataloguing --- Display: . MergeReportFields: change "example:" to "Example:" Exporting: . BibtexExportAdditionalFields and RisExportAdditionalFields: change "Include following" to "Include the following"; add ":" at end of sentence, change "specificy" to "specify", and add full stops at end of complete sentences. Interface: . EnableAdvancedCatalogingEditor: format NOTE in bold. Record structure: . AlternateHoldingsField: change "(This" to "(this", change "; for instance" to ", for example", remove full stop. , MarcFieldForCreatorId: format NOTE in bold. . SubfieldsToAllowForRestrictedBatchmod: change "pref" to "system preference". Circulation --- Batch checkout: . BatchCheckoutsValidCategories: add a full stop. Checkin policy: . CalculateFinesOnReturn: only bold "NOTE", not the whole sentence (x2). . StoreLastBorrower: change "opacreadinghistory/AnonymousPatron" to "the opacreadinghistory and AnonymousPatron". . UpdateItemLocationOnCheckin: change note "for these locations only can location and permanent_location differ," to "for these locations the location and permanent_location can differ," . UpdateNotForLoanStatusOnCheckin: change "E.g.," to "For example," Checkout policy: . AgeRestrictionMarker: change "E.g.," to ". For example," . AllFinesNeedOverride: change "system preference noissuescharge" to "the noissuescharge system preference". . AllowFineOverride: add "the" before "noissuescharge". . AllowRenewalLimitOverride: change "with respect to" to "for". . AutoRemoveOverduesRestrictions: change "Do not" to "Don't". . DefaultLongOverdueChargeValue: change "user" to "patron". . ItemsDeniedRenewal: change . "e.g.," to "For example:", format the note the same as other notes with NOTE in bold. . OnSiteCheckoutsForce: change "on-site" to "on-site checkout", "(Even" to "(even", and "user" to "patron". . RentalFeesCheckoutConfirmation: change "do not ask" to "don't ask". . RestrictionBlockRenewing: change "If patron" to "If a patron", change "Allow" and "Block" to "allow" and "block". . UseTransportCostMatrix: "Transport" to "the transport".
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108267|0 |1 is obsolete|| --- Comment #59 from Katrin Fischer --- Created attachment 108917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108917=edit Bug 25630: Fix capitalization and terminology for Circulation system preferences - (Ending) punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - CircSidebar (c) - itemBarcodeInputFilter (from to form) - HoldsToPullStartDate (preference to system preference) - NoticeCSS (c) - UpdateTotalIssuesOnCirc (issues to checkouts) - ExportRemovefields (p) - AllowItemsOnHoldCheckoutSIP (c) - OnSiteCheckoutAutoCheck (onsite to on-site) - AllowOfflineCirculation (plugin to add-on) - AllowFineOverride (add 'system preference') - AutomaticItemReturn (returned to checked in) - UseTransportCostMatrix (branches to libraries) - AllowReturnToBranch (materials to items, return to checkin) - RenewalSendNotice (clarify 'messaging preference for 'Item checkout') - TransfersMaxDaysWarning (c) - noissuescharge (books to items) - *NoissuesCharge (add 'system preference') - ReturnBeforeExpiry (books to items) - NoticeBcc (p) - OverdueNoticeCalendar (c, p) - OverduesBlockCirc (p) - DefaultLongOverdueChargeValue (whitespace after :) - OPACFineNoRenewalsBlockAutoRenew (c) - RenewAccruingItemWhenPaid (p, c, syspref to system preference) - RenewAccruingItemInOpac (p, c, syspref to system preference) - HoldsSplitQueue (staff interface) - StaffSearchResultsDisplayBranch (staff interface, rephrase) - HidePersonalPatronDetailOnCirculation (rephrase) - StoreLastBorrower (add 'system preferences') - HoldsSplitQueue (& to and, staff interface) - HouseboundModule (p) - StockRotation (p) - ArticleRequests* (p) - ClaimReturnedLostValue (rephrase) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108262|0 |1 is obsolete|| --- Comment #54 from Katrin Fischer --- Created attachment 108912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108912=edit Bug 25630: Fix capitalization and terminology for Acquisitions and Tools system preferences - Adds some ending punctuation - Fixes capitalization - Consistent use of "staff interface" To test: - Verify: - NewsAuthorDisplay - EmailPurchaseSuggestions - UseACQFrameworkForBiblioRecords - AcqItemSetSubfieldsWhenReceived - AcqItemSetSubfieldsWhenReceiptIsCancelled - OrderPriceRounding - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108266|0 |1 is obsolete|| --- Comment #58 from Katrin Fischer --- Created attachment 108916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108916=edit Bug 25630: Fix capitalization and terminology for Logs and I18N system preferences - (Ending) punctuation (p) - Capitalization (p) - Terminology To test: - Verify: - alphabet (p) - TranslateNotics (c) - IllLog (p) - ReturnLog (returned to checked in) - DumpTemplateVars* (HTML) - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108265|0 |1 is obsolete|| --- Comment #57 from Katrin Fischer --- Created attachment 108915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108915=edit Bug 25630: Fix capitalization and terminology for OPAC system preferences - Ending punctuation (p) - Capitalization (c) - Terminology: library instead of branch, patron instead of borrower, system preferences instead of syspref To test: - Verify: - OPACUserSummary (p, rephrase: mainpage) - HighlightOwnItemsOnOPACWhich (library) - OPACXSLTListsDisplay (p) - OPACXSLTResultsDisplay (p) - OPACXSLTDetailsDisplay (p) - OpacNoItemTypeImages (p) - NotHighlightedWords (p) - opaclayoutstylesheet (CSS) - OPACReportProblem (c) - OpacBrowser (p) - OpacCloud (p) - SocialNetworks (p) - QuoteOfTheDay (c,p) - OpacNewsLibrarySelect (library) - OPACFineNoRenewalsIncludeCredits (p) - AllowPurchaseSuggestionBranchChoice (p) - OpacHiddenItemsExceptions (p, patron) - OpacAllowPublicListCreation (p) - OpacAllowSharingPrivateLists (p) - BlockExpiredPatronOpacActions (whitespace) - MaxOpenSuggestions (p) - AnonSuggestions (p) - OPACPrivacy (p, whitespace) - AnonymousPatron (c,p) - TrackClicks (p) - RestrictedPageLocalIPs (p) - RestrictedPageTitle (p) - OpacAdvSearchOptions (p) - OpacAdvSearchMoreOptions (p) - PayPal* (p) - OPACUserSummary (mainpage to OPAC start page) - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108263|0 |1 is obsolete|| --- Comment #55 from Katrin Fischer --- Created attachment 108913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108913=edit Bug 25630: Fix capitalization and terminology for Enhanced content and Web services system preferences - Fixes capitalization, including URL and OPAC - Consistent use of "staff interface" - Ending punctuation - Spelling: web service To test: - Verify: - Enhanced content page heading - Babeltheque_url_js - Babeltheque_url_update - FRBRizeEditions - BakerTaylorEnabled - NovelistSelectStaffProfile - NovelistSelectStaffEnabled - CustomCoverImages - LocalCoverImages - IntranetCoce - AutoShareWithMana - OAI-PMH:AutoUpdateSets - IdRef - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108264|0 |1 is obsolete|| --- Comment #56 from Katrin Fischer --- Created attachment 108914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108914=edit Bug 25630: Fix capitalization and terminology for Patrons system preferences - Consistent use of 'staff interface' - Ending punctuation - Rearranged/rephrased for better readability To test: - Verify: - patronimages - PatronsPerPage (rearranged) - PatronQuickAddFields (rearranged) - PrefillGuaranteeField (punctuation) - borrowerRelationship (punctuation) - GDPR_Policy - CollapseFieldsPatronAddForm - read correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108261|0 |1 is obsolete|| --- Comment #53 from Katrin Fischer --- Created attachment 108911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108911=edit Bug 25630: Fix capitalization and terminology fixes for Searching system preferences - Rephrases LoadSearchHistoryToTheFirstLoggedUser system preference - Consistently use "staff interface" - Add ending punctuation to some preferences To test: - Read through the Searching system preferences - Verify consistent use of staff interface - Verify LoadSearchHistoryToTheFirstLoggedUser description is improved Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What|Removed |Added Attachment #108260|0 |1 is obsolete|| --- Comment #52 from Katrin Fischer --- Created attachment 108910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108910=edit Bug 25630: Fix capitalization and terminology for Staff interface system preferences This changes "staff client" to "staff interface" and fixes capitalization in a couple of cases. For terminology changes see: https://wiki.koha-community.org/wiki/Terminology#S To test: - Read through the preferences of the "staff interface" tab. - Staff interface should be used consistently. - Firefox "PlugIn" was changed to "add-on" reflecting Mozilla's own terminology. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #37 from Katrin Fischer --- I've now tested in authorities and cataloguing too. I still feel like we should not pre-fill the authorised value with the text entered, but only the description. Otherwise this works really nicely. Codes should be picked wisely, I think that would better support this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #36 from Katrin Fischer --- Talked to Joubu: - We indeed to not have these fields are required on the admin screen, so we just match the behaviour in the modal. - We also do not keep people from adding values that won't work... so validation should be handled separately as well. - The JS error from the QA script was checked and is ok (see comment#34) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Attachment #107120|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 108909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108909=edit Bug 24683: IsAvailableForItemLevelRequest sub description expanded Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683
Katrin Fischer changed:
What|Removed |Added
Attachment #107116|0 |1
is obsolete||
--- Comment #31 from Katrin Fischer ---
Created attachment 108905
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108905=edit
Bug 24683: Subroutine name changed (fix), no code logic changed This is the
intermediate refactor: renamed subroutine only.
Naming mistake came because this sub is used to detect if anything
available for hold, but it used in "if ANY UNAVAILABLE rule", so actually
results of this sub negated (see below "return" in the code).
In details:
when previous refactor was done, name for subroutine was chosen
wrongly in "opposite" direction from what it actually does:
it was named "ItemsAnyAvailableForHold", but this subroutine gave
truth (1) if at least one of the items available on shelf, not lost,
not on loan, not held, and not restricted by smart rules and damaged
status. So, if this sub says that item is still "available", this
actually PREVENTS item from hold in parent sub (see negated return):
sub IsAvailableForItemLevelRequest {
...
my $any_available = ItemsAnyAvailableAndNotRestricted...
return $any_available ? 0 : 1;
# ^^^ if any available and not restricted - we don't allow
# on-shelf holds
...
I.e. like it named now: "ItemsAnyAvailableAndNotRestricted".
Small aside fix: white space for '&&' inside brackets added to join
operation by priority visually.
Testing plan not needed: all places where sub used it just renamed.
More: all this places/code was introduced in one older commit so there
is also no overlaps or other calls/uses for this subroutine.
Signed-off-by: Agustin Moyano
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Attachment #107117|0 |1 is obsolete|| --- Comment #32 from Katrin Fischer --- Created attachment 108906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108906=edit Bug 24683: Optimize loop in ItemsAnyAvailableAndNotRestricted Add cut-off shortcut (return from inside the loop) when first "Any Available And Not Restricted" item found, because one is enough for "Any". Testing: no change visible for code behavior/results, it is just faster because won't loop over the whole set. Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683
Katrin Fischer changed:
What|Removed |Added
Attachment #107118|0 |1
is obsolete||
--- Comment #33 from Katrin Fischer ---
Created attachment 108907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108907=edit
Bug 24683: Fix for take smart rules into account in "if all unavailable"
Inside of ItemsAnyAvailableAndNotRestricted was no effect from main set
of smart rules (per record and other limits): i.e. call to
"CanItemBeReserved" was absent totally.
Because of this there was a bug: for example none of two items were
allowed to be held when first was allowed by one smart rule, BUT on loan,
and second was disallowed by another smart rule (for example,
0 "Holds per record"),
i.e. in this case both items unavailable: so on-shelf holds setting
"allow hold if all unavailable" should allow to hold first one, and not
the second one. But it was that both wasn't allowed to be held.
Solution: call to sub "CanItemBeReserved" added so it checked for
"...->{status} ne 'OK'" so now if item restricted by smart rule it also
accounted as "unavailable" and "AnyAvailavble" not counts it.
How to reproduce:
1. Add 2 smart rules (/cgi-bin/koha/admin/smart-rules.pl) with "on shelf
holds": "if all unavailable" for all rules, no "item level holds", and
set "holds per record" to 2 for "books" and "0" for "computer files".
2. Create only 2 items for one biblio, but different types, "book"
and "computer file". For example in misc4dev env:
/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additem
3. Check out that item of type "book" to some person, for example,
in misc4dev:
/cgi-bin/koha/circ/circulation.pl?borrowernumber=2=30001
4. Open reserve/request, for example, for item 1 and patron 1 in misc4dev
env (/cgi-bin/koha/reserve/request.pl?biblionumber=1=1)
5. It does not allow to hold, both red crossed, but computer file says
"Exceeded max holds per record" because of "0" limit set on step 1.
6. Apply the patch.
7. Reload page on step 5 and see that "book" will be available for hold,
but "computer file" still will be red-crossed "Exceeded max holds
per record", now that's correct because both items unavailable:
one because on load, another because of "0" limit for computer files.
8. Check-in book from step 3 so it will be returned to the library,
9. Reload page on step 5 and see that again no any holds available,
but it's now also correct: "book" now returned but "on shelf holds"
set to "if all unavailable".
Signed-off-by: Agustin Moyano
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Katrin Fischer changed: What|Removed |Added Attachment #107119|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 108908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108908=edit Bug 24683: whole test formatted by 'perltidy' This is complementary patch using styling from bundled /xt/perltidyrc file Almost no code change except a few long constant strings broken to parts by concatenation. Signed-off-by: Agustin Moyano Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #51 from Katrin Fischer --- (In reply to Jonathan Druart from comment #50) > In the following patch: > Bug 25630: (follow-up) Fix capitalization and terminology for system > preferences > > We removed the nice indentation we had in > koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc > > Is there a good reason? I think this was due to rebasing - I didn't remove the indentation - it was added in between. I will try to fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26268] Remove items.paidfor once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #12 from Katrin Fischer ---
I see that there is a lot of history here, but I am not quite following yet.
1) Before dropping the column: Did we move the information stored there in
previous developments?
If we didn't, we might just want to print a warning if there is any content to
be found in the db and ask people to drop themselves. It has been done in the
past with some of the columns in borrowers (ethnicity?) I think. If there is no
data, we can drop it in the update.
2) Looking for "paidfor" I found some more references this patch is not taking
care of:
catalogue/moredetail.pl:# Add paidfor info
catalogue/moredetail.pl:$item->{paidfor} = { patron => $patron,
created_on => $payment_offset->created_on };
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt:
[% IF ( ITEM_DAT.paidfor ) %]Paid for?: [%
INCLUDE 'patron-title.inc' patron=ITEM_DAT.paidfor.patron
hide_patron_infos_if_needed=1 %] on [% ITEM_DAT.paidfor.created_on | $KohaDates
%][% END %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
