[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #77 from Martin Renvoize  ---
*** Bug 15335 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Julian Maurice  changed:

   What|Removed |Added

 Blocks||16563


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16563
[Bug 16563] Translatability: Issues in opac-account.tt (sentence splitting)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16473


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16473
[Bug 16473] Tiny typo: there was _an_ problem ...
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||16129


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16129
[Bug 16129] Remove URL::Encode dependency
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #76 from Kyle M Hall  ---
(In reply to Brendan Gallagher from comment #75)
> I had pushed this to Master.  But there is an issue with the URL::Encode... 
> 
> An Assist from Galen suggests.
> 
> Please see http://stackoverflow.com/a/9690930, which lists some various ways
> of handling application/x-www-form-urlencoded content, several of which make
> use of modules that are already required by Koha.
> 
> Regards,
> 
> Galen 
> 
> Can we fix that up?  This will be a candidate for reverting if we don't
> solve the package issue.
> 
> Thanks,
> Brendan

I've looked into that article and the only reasonable solution is to use
URL::Encode. The good news is that the only dependency that URL::Encode has is
Carp, so it should be very easy to package. Now we just need an easy to follow
guide for the packaging ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #75 from Brendan Gallagher  ---
I had pushed this to Master.  But there is an issue with the URL::Encode... 

An Assist from Galen suggests.

Please see http://stackoverflow.com/a/9690930, which lists some various ways of
handling application/x-www-form-urlencoded content, several of which make use
of modules that are already required by Koha.

Regards,

Galen 

Can we fix that up?  This will be a candidate for reverting if we don't solve
the package issue.

Thanks,
Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15987


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987
[Bug 15987] Acq module fails with undefined subroutine ::GetCurrency
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Julian Maurice  changed:

   What|Removed |Added

 Blocks||15616


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15616
[Bug 15616] Spelling mistake in opac-account.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #74 from Kyle M Hall  ---
Pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #73 from Kyle M Hall  ---
Created attachment 46151
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46151=edit
Bug 11622 [QA Follouwp] - Display payment block only if there is something to
pay

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #70 from Kyle M Hall  ---
Created attachment 46148
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46148=edit
Bug 11622 [QA Followup] - Use Koha's active currency for PayPal

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #66 from Kyle M Hall  ---
Created attachment 46144
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46144=edit
Bug 11622 [QA Followup]

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #71 from Kyle M Hall  ---
Created attachment 46149
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46149=edit
Bug 11622 [QA Followup] - Show ability to pay only if JavaScript is enabled

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #68 from Kyle M Hall  ---
Created attachment 46146
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46146=edit
Bug 11622 [QA Followup] - Display payment messages directly on opac account
view

Fixed spelling of "Receive" in preferences.

Signed-off-by: David Kuhn 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #67 from Kyle M Hall  ---
Created attachment 46145
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46145=edit
Bug 11622 [QA Followup] - Show amount to be paid near make payment button

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #44419|0   |1
is obsolete||
  Attachment #44420|0   |1
is obsolete||
  Attachment #44421|0   |1
is obsolete||
  Attachment #44422|0   |1
is obsolete||
  Attachment #44423|0   |1
is obsolete||
  Attachment #44424|0   |1
is obsolete||
  Attachment #44425|0   |1
is obsolete||
  Attachment #44426|0   |1
is obsolete||
  Attachment #44427|0   |1
is obsolete||

--- Comment #65 from Kyle M Hall  ---
Created attachment 46143
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46143=edit
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

Signed-off-by: Carol Corrales 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #69 from Kyle M Hall  ---
Created attachment 46147
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46147=edit
Bug 11622 [QA Followup] - Payment message always displays on opac-account.pl

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #72 from Kyle M Hall  ---
Created attachment 46150
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46150=edit
Bug 11622 [QA Followup] - Fix currency issue, add error template

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #64 from Kyle M Hall  ---
(In reply to Martin Stenberg from comment #63)
> Unaware of this patch, I made Bug 15335 which is very similar, with the
> differences that Bug 15335 allows patron to select which fines to pay (i.e.
> as a patron you don't have to pay all your fines at once) and uses DIBS as a
> payment provider instead of Paypal.
> 
> do you think it's worth merging these patches to get the best of both?

Sure! I would recommend you add this bug as a 'depends on' for bug 15335. After
that you can adjust your patch set to work on top of this patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Martin Stenberg  changed:

   What|Removed |Added

 CC||mar...@bugs.koha-community.
   ||org.xinxidi.net

--- Comment #63 from Martin Stenberg 
 ---
Unaware of this patch, I made Bug 15335 which is very similar, with the
differences that Bug 15335 allows patron to select which fines to pay (i.e. as
a patron you don't have to pay all your fines at once) and uses DIBS as a
payment provider instead of Paypal.

do you think it's worth merging these patches to get the best of both?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #62 from Kyle M Hall  ---
(In reply to Robin Sheat from comment #61)
> Would URI::Escape work, which is already a Koha dependency?
> 
> https://metacpan.org/pod/URI::Escape

I'm afraid not. The note only uses url_encode, but also url_params_mixed which
URI::Escape does not provide.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Robin Sheat  changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #61 from Robin Sheat  ---
Would URI::Escape work, which is already a Koha dependency?

https://metacpan.org/pod/URI::Escape

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #60 from Robin Sheat  ---
(In reply to Kyle M Hall from comment #1)
> Created attachment 24753 [details] [review]
> Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> 
> This patch adds the ability for a logged in user to pay fines and
> fees from the OPAC via PayPal.

Kyle, if you're adding a dependency, you need to read this:

http://wiki.koha-community.org/wiki/Building_Debian_Dependencies/Dependency_Guidelines

or the email equivalent that went out in May: 

http://lists.koha-community.org/pipermail/koha-devel/2015-May/041464.html

This won't be able to go into master until I package URL::Encode and Debian
allows it to be added, which may (or may not) take some time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #52 from Kyle M Hall  ---
Created attachment 44420
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44420=edit
Bug 11622 [QA Followup]

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #59 from Kyle M Hall  ---
Created attachment 44427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44427=edit
Bug 11622 [QA Follouwp] - Display payment block only if there is something to
pay

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #56 from Kyle M Hall  ---
Created attachment 44424
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44424=edit
Bug 11622 [QA Followup] - Use Koha's active currency for PayPal

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #54 from Kyle M Hall  ---
Created attachment 44422
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44422=edit
Bug 11622 [QA Followup] - Display payment messages directly on opac account
view

Fixed spelling of "Receive" in preferences.

Signed-off-by: David Kuhn 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #58 from Kyle M Hall  ---
Created attachment 44426
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44426=edit
Bug 11622 [QA Followup] - Fix currency issue, add error template

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42857|0   |1
is obsolete||
  Attachment #42858|0   |1
is obsolete||
  Attachment #42859|0   |1
is obsolete||
  Attachment #42860|0   |1
is obsolete||
  Attachment #42861|0   |1
is obsolete||
  Attachment #42862|0   |1
is obsolete||
  Attachment #42863|0   |1
is obsolete||
  Attachment #42864|0   |1
is obsolete||
  Attachment #42865|0   |1
is obsolete||

--- Comment #51 from Kyle M Hall  ---
Created attachment 44419
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44419=edit
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

Signed-off-by: Carol Corrales 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #53 from Kyle M Hall  ---
Created attachment 44421
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44421=edit
Bug 11622 [QA Followup] - Show amount to be paid near make payment button

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #55 from Kyle M Hall  ---
Created attachment 44423
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44423=edit
Bug 11622 [QA Followup] - Payment message always displays on opac-account.pl

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #57 from Kyle M Hall  ---
Created attachment 44425
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44425=edit
Bug 11622 [QA Followup] - Show ability to pay only if JavaScript is enabled

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #45 from Jonathan Druart  
---
Created attachment 42861
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42861=edit
Bug 11622 [QA Followup] - Payment message always displays on opac-account.pl

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #44 from Jonathan Druart  
---
Created attachment 42860
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42860=edit
Bug 11622 [QA Followup] - Display payment messages directly on opac account
view

Fixed spelling of "Receive" in preferences.

Signed-off-by: David Kuhn 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #46 from Jonathan Druart  
---
Created attachment 42862
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42862=edit
Bug 11622 [QA Followup] - Use Koha's active currency for PayPal

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #43 from Jonathan Druart  
---
Created attachment 42859
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42859=edit
Bug 11622 [QA Followup] - Show amount to be paid near make payment button

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #42 from Jonathan Druart  
---
Created attachment 42858
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42858=edit
Bug 11622 [QA Followup]

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42241|0   |1
is obsolete||
  Attachment #42649|0   |1
is obsolete||
  Attachment #42702|0   |1
is obsolete||
  Attachment #42715|0   |1
is obsolete||
  Attachment #42733|0   |1
is obsolete||
  Attachment #42777|0   |1
is obsolete||
  Attachment #42778|0   |1
is obsolete||
  Attachment #42842|0   |1
is obsolete||
  Attachment #42843|0   |1
is obsolete||

--- Comment #41 from Jonathan Druart  
---
Created attachment 42857
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42857=edit
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

Signed-off-by: Carol Corrales 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #49 from Jonathan Druart  
---
Created attachment 42865
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42865=edit
Bug 11622 [QA Follouwp] - Display payment block only if there is something to
pay

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #47 from Jonathan Druart  
---
Created attachment 42863
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42863=edit
Bug 11622 [QA Followup] - Show ability to pay only if JavaScript is enabled

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #48 from Jonathan Druart  
---
Created attachment 42864
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42864=edit
Bug 11622 [QA Followup] - Fix currency issue, add error template

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #50 from Jonathan Druart  
---
Note for RM: Since only 2 patches have a signoff, feel free to ask for another
one on the whole patch set, if you think it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #38 from Kyle M Hall  ---
Created attachment 42842
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42842=edit
Bug 11622 [QA Followup] - Fix currency issue, add error template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #39 from Kyle M Hall  ---
Created attachment 42843
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42843=edit
Bug 11622 [QA Follouwp] - Display payment block only if there is something to
pay

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #40 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #37)
> Unfortunately, it does not work.
> warn $response->decoded_content logs
> 
> opac-account-pay-paypal-return.pl:
> TIMESTAMP=2015%2d09%2d22T16%3a57%3a10Z=e76fcad1465da=Failur
> e=82%2e0=00_ERRORCODE0=10444_SHORTMESSAGE0=Transaction%
> 20refused%20because%20of%20an%20invalid%20argument%2e%20See%20additional%20er
> ror%20messages%20for%20details%2e_LONGMESSAGE0=The%20transaction%20currency
> %20specified%20must%20be%20the%20same%20as%20previously%20specified%2e_SEVE
> RITYCODE0=Error at /home/koha/src/opac/opac-account-pay-paypal-return.pl
> line 84.

Fixed! Paypal wants the currency code both and initiation and at verification.

> I also think that the Payment block should not be displayed if there is
> nothing to pay.

Done!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Jonathan Druart  
---
Unfortunately, it does not work.
warn $response->decoded_content logs

opac-account-pay-paypal-return.pl:
TIMESTAMP=2015%2d09%2d22T16%3a57%3a10Z=e76fcad1465da=Failure=82%2e0=00_ERRORCODE0=10444_SHORTMESSAGE0=Transaction%20refused%20because%20of%20an%20invalid%20argument%2e%20See%20additional%20error%20messages%20for%20details%2e_LONGMESSAGE0=The%20transaction%20currency%20specified%20must%20be%20the%20same%20as%20previously%20specified%2e_SEVERITYCODE0=Error
at /home/koha/src/opac/opac-account-pay-paypal-return.pl line 84.

I also think that the Payment block should not be displayed if there is nothing
to pay.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Jonathan Druart  
---
There are 2 major issues:

1/ The amount is not updated and the "Make payment" button is always disabled
if javascript is disabled.
I think we should not allow to pay via Paypal (ie. not display "Pay selected
fines and charges" block) in this case.

2/ The currency is never displayed and the user does not know how much he is
going to pay.
>From my testing, the currency used seems to be USD, even if my Paypal balance
is in EUR. I did not find where we could change that, but this behavior is not
acceptable for users outside the USD zone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #32 from Kyle M Hall  ---
Created attachment 42774
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42774=edit
Bug 11622 [QA Followup] - Use Koha's active currency for PayPal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #33 from Kyle M Hall  ---
Created attachment 42775
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42775=edit
Bug 11622 [QA Followup] - Show ability to pay only if JavaScript is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42774|0   |1
is obsolete||
  Attachment #42775|0   |1
is obsolete||

--- Comment #34 from Kyle M Hall  ---
Created attachment 42777
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42777=edit
Bug 11622 [QA Followup] - Use Koha's active currency for PayPal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #36 from Kyle M Hall  ---
> 1/ The amount is not updated and the "Make payment" button is always
> disabled if javascript is disabled.
> I think we should not allow to pay via Paypal (ie. not display "Pay selected
> fines and charges" block) in this case.

Agreed. Followup added!

> 2/ The currency is never displayed and the user does not know how much he is
> going to pay.
> From my testing, the currency used seems to be USD, even if my Paypal
> balance is in EUR. I did not find where we could change that, but this
> behavior is not acceptable for users outside the USD zone.

Also agreed! The followup for this one worked for me using USD. Please give it
a try!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #35 from Kyle M Hall  ---
Created attachment 42778
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42778=edit
Bug 11622 [QA Followup] - Show ability to pay only if JavaScript is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #30 from Kyle M Hall  ---
Created attachment 42733
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42733=edit
Bug 11622 [QA Followup] - Payment message always displays on opac-account.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

techservs...@gmail.com changed:

   What|Removed |Added

  Attachment #42705|0   |1
is obsolete||

--- Comment #28 from techservs...@gmail.com ---
Created attachment 42715
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42715=edit
Bug 11622 [QA Followup] - Display payment messages directly on opac account
view

Fixed spelling of "Receive" in preferences.

Signed-off-by: David Kuhn 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

techservs...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from techservs...@gmail.com ---
The phrase "Payment applied: your payment of payment_error has been applied to
your account" displays on the fines and charges page before you actually make a
payment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #26 from Kyle M Hall  ---
Created attachment 42702
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42702=edit
Bug 11622 [QA Followup] - Show amount to be paid near make payment button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #27 from Kyle M Hall  ---
Created attachment 42705
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42705=edit
Bug 11622 [QA Followup] - Display payment messages directly on opac account
view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #23 from Kyle M Hall  ---
> 2/ Testing the feature:
> click on "Make payment", I am redirected to the login paypal page, then I
> arrived on:
> ===
> Modes de paiement
> Mode de paiement
> Solde PayPal
> Taux de change PayPal au 17 sep 2015 : 1 Euro = 1,29364 Dollars USD
> Carte cadeau, récompense ou autre remise PayPal
> Coordonnées
> jo.dru.pro-bu...@gmail.com
> Vous avez presque terminé. Vous confirmerez votre paiement sur my library.
> ===
> Sorry, in French...
> But globally, alright, give me the money! (But how much??)
> 
> Then click continue and I am redirected to my Koha install with this message:
> 
> Error: there was an problem processing your payment
> Unable to verify payment.
> Please contact the library to verify your payment.

Looks like the utf8 flag for cgi was breaking the feature. I've updated and
squashed the followups.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42351|0   |1
is obsolete||
  Attachment #42352|0   |1
is obsolete||
  Attachment #42594|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall  ---
Created attachment 42649
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42649=edit
Bug 11622 [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #21 from Jonathan Druart  
---
1/ Trying to generate a debian packe for URL::Encode fails:

% dh-make-perl --pkg-perl --build --cpan URL::Encode
  [skip output]
% sudo dpkg -i liburl-encode-perl_0.03-1_all.deb
(Reading database ... 66746 files and directories currently installed.)
Preparing to unpack liburl-encode-perl_0.03-1_all.deb ...
Unpacking liburl-encode-perl (0.03-1) ...
dpkg: error processing archive liburl-encode-perl_0.03-1_all.deb (--install):
 trying to overwrite
'/home/koha/perl5/lib/perl5/i586-linux-gnu-thread-multi-64int/perllocal.pod',
which is also in package libtemplate-plugin-stash-perl 1.006-1
Errors were encountered while processing:
 liburl-encode-perl_0.03-1_all.deb


2/ Testing the feature:
click on "Make payment", I am redirected to the login paypal page, then I
arrived on:
===
Modes de paiement
Mode de paiement
Solde PayPal
Taux de change PayPal au 17 sep 2015 : 1 Euro = 1,29364 Dollars USD
Carte cadeau, récompense ou autre remise PayPal
Coordonnées
jo.dru.pro-bu...@gmail.com
Vous avez presque terminé. Vous confirmerez votre paiement sur my library.
===
Sorry, in French...
But globally, alright, give me the money! (But how much??)

Then click continue and I am redirected to my Koha install with this message:

Error: there was an problem processing your payment
Unable to verify payment.
Please contact the library to verify your payment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #24 from Jonathan Druart  
---
Ok thanks, it's fixed.
But the amount is *never* displayed unless at the end of the payment process
"Payment applied: your payment of 4.00 has been applied to your account".

It would be good to inform the patron how much he is going to pay :)

Something else: Cannot we avoid the screen opac-account-pay-paypal-return.pl?
We would imagine the get the confirmation message on top of the fines page
(opac-account.pl) and save 1 click :)

And what about the debian package build?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #25 from Jonathan Druart  
---
+ Execute the QA script on this patch set, there are 2 warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #19 from Kyle M Hall  ---
Created attachment 42594
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42594=edit
Bug 11622 [QA Followup] - Use Modern::Perl and ditch utf8 pragma

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #20 from Kyle M Hall  ---
> 1/ use strict;use warnings; should be replaced with use Modern::Perl;
> 2/ You are using the utf8 pragma but there is no need of it, you don't have
> non-ASCII characters in the file.

I see what you mean. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #18 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #17)
> (In reply to Jonathan Druart from comment #14)
> > (In reply to Galen Charlton from comment #5)
> > > Comment on attachment 24754 [details] [review] [review] [review]
> > > Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> > > 
> > > Review of attachment 24754 [details] [review] [review] [review]:
> > > -
> > > 
> > > ::: opac/opac-account-pay-paypal-return.pl
> > > @@ +20,5 @@
> > > > +
> > > > +use strict;
> > > > +use warnings;
> > > > +use utf8;
> > > > +
> > 
> > > Modern::Perl
> > > I see no non-ASCII characters in the source.
> > 
> > Still exists.
> > 
> 
> I'm not sure what this means. Can you explain?

1/ use strict;use warnings; should be replaced with use Modern::Perl;
2/ You are using the utf8 pragma but there is no need of it, you don't have
non-ASCII characters in the file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #15 from Kyle M Hall  ---
Created attachment 42351
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42351=edit
Bug 11622 [QA Followup] - Add new module dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #17 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Galen Charlton from comment #5)
> > Comment on attachment 24754 [details] [review] [review]
> > Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> > 
> > Review of attachment 24754 [details] [review] [review]:
> > -
> > 
> > ::: opac/opac-account-pay-paypal-return.pl
> > @@ +20,5 @@
> > > +
> > > +use strict;
> > > +use warnings;
> > > +use utf8;
> > > +
> 
> > Modern::Perl
> > I see no non-ASCII characters in the source.
> 
> Still exists.
> 

I'm not sure what this means. Can you explain?


> > ::: opac/opac-account-pay.pl
> > @@ +19,5 @@
> > > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> > > +
> > > +use strict;
> > > +use warnings;
> > > +use utf8;
> 
> > Modern::Perl
> > I see no non-ASCII characters in the source.
> 
> Still exists.

Same as above


> > @@ +94,5 @@
> > > +'PAYMENTREQUEST_0_PAYMENTACTION'=> 'Sale',
> > > +'PAYMENTREQUEST_0_ALLOWEDPAYMENTMETHOD' => 'InstantPaymentOnly',
> > > +'PAYMENTREQUEST_0_DESC' =>
> > > +  C4::Context->preference('PayPalChargeDescription'),
> > > +};
> > 
> > It seems like using Business::PayPal::API might offer some protection
> > against API changes.
> 
> Answer needed.

That's what I tried first when I began writing this feature. It did not go
well. PayPal doesn't change existing APIs anyway. They have an API versioning
system so that applications don't break with changes to the API.

> 
> +use CGI;
> 
> Should be replaced by CGI qw( -utf8 ) unless you have a good reason.
> 

Fixed!

> 
> > 3) Create a paypal developer account
> 
> How? Should I need a paypal account to do so?

I don't think you need a regular paypal account, but you do need an account on
https://developer.paypal.com/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #16 from Kyle M Hall  ---
Created attachment 42352
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42352=edit
Bug 11622 [QA Followup] - Add utf8 flag for CGI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #14 from Jonathan Druart  
---
(In reply to Galen Charlton from comment #5)
> Comment on attachment 24754 [details] [review]
> Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> 
> Review of attachment 24754 [details] [review]:
> -
> 
> ::: opac/opac-account-pay-paypal-return.pl
> @@ +20,5 @@
> > +
> > +use strict;
> > +use warnings;
> > +use utf8;
> > +

> Modern::Perl
> I see no non-ASCII characters in the source.

Still exists.

> ::: opac/opac-account-pay.pl
> @@ +19,5 @@
> > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> > +
> > +use strict;
> > +use warnings;
> > +use utf8;

> Modern::Perl
> I see no non-ASCII characters in the source.

Still exists.

> @@ +94,5 @@
> > +'PAYMENTREQUEST_0_PAYMENTACTION'=> 'Sale',
> > +'PAYMENTREQUEST_0_ALLOWEDPAYMENTMETHOD' => 'InstantPaymentOnly',
> > +'PAYMENTREQUEST_0_DESC' =>
> > +  C4::Context->preference('PayPalChargeDescription'),
> > +};
> 
> It seems like using Business::PayPal::API might offer some protection
> against API changes.

Answer needed.


+use CGI;

Should be replaced by CGI qw( -utf8 ) unless you have a good reason.


> 3) Create a paypal developer account

How? Should I need a paypal account to do so?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #40523|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall  ---
Created attachment 42241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42241=edit
[SIGNED-OFF] Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

Signed-off-by: Carol Corrales 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

techservs...@gmail.com changed:

   What|Removed |Added

 CC||techservs...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #40520|0   |1
is obsolete||
  Attachment #40521|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40522
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40522action=edit
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #40522|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40523
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40523action=edit
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #24754|0   |1
is obsolete||
  Attachment #24756|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40520
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40520action=edit
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40521
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40521action=edit
Bug 11622 [DB Update] - Add ability to pay fees and fines from OPAC via PayPal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on|6427|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
This latest version of this patch no longer depends on the accounts rewrite. I
hadn't anticipated the length of time getting it into community Koha would
take, so let's not hold up the opac paypal payments any longer!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Cab Vinton direc...@plaistowlibrary.com changed:

   What|Removed |Added

 CC||direc...@plaistowlibrary.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Galen Charlton from comment #5)
 Comment on attachment 24754 [details] [review]
 Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
 
 Review of attachment 24754 [details] [review]:
 -
[SNIP]
 
 @@ +65,5 @@
  +
  +my $opac_base_url = C4::Context-preference('OPACBaseURL');
  +
  +my $return_url =
  +  URI-new( http://;
 
 This should be checking whether the OPAC is using SSL.

Can someone please look at bug 5010 so we can avoid this mess of https/http
concatentation/detection?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
fatal: sha1 information is lacking or useless (Koha/Accounts/CreditTypes.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11622 - Add ability to pay fees and fines from OPAC
via PayPa

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

jdem...@roseville.ca.us jdem...@roseville.ca.us changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Comment on attachment 24754
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24754
Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

Review of attachment 24754:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11622attachment=24754)
-

::: opac/opac-account-pay-paypal-return.pl
@@ +1,5 @@
 +#!/usr/bin/perl
 +
 +# Copyright Katipo Communications 2002
 +# Copyright Biblibre 2007,2010
 +#

This seems unlikely.

@@ +18,5 @@
 +# with Koha; if not, write to the Free Software Foundation, Inc.,
 +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 +
 +use strict;
 +use warnings;

Modern::Perl

@@ +20,5 @@
 +
 +use strict;
 +use warnings;
 +use utf8;
 +

I see no non-ASCII characters in the source.

::: opac/opac-account-pay.pl
@@ +1,4 @@
 +#!/usr/bin/perl
 +
 +# Copyright Katipo Communications 2002
 +# Copyright Biblibre 2007,2010

This seems unlikely.

@@ +18,5 @@
 +# with Koha; if not, write to the Free Software Foundation, Inc.,
 +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 +
 +use strict;
 +use warnings;

Modern::Perl

@@ +19,5 @@
 +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 +
 +use strict;
 +use warnings;
 +use utf8;

I see no non-ASCII characters in the source.

@@ +65,5 @@
 +
 +my $opac_base_url = C4::Context-preference('OPACBaseURL');
 +
 +my $return_url =
 +  URI-new( http://;

This should be checking whether the OPAC is using SSL.

@@ +94,5 @@
 +'PAYMENTREQUEST_0_PAYMENTACTION'= 'Sale',
 +'PAYMENTREQUEST_0_ALLOWEDPAYMENTMETHOD' = 'InstantPaymentOnly',
 +'PAYMENTREQUEST_0_DESC' =
 +  C4::Context-preference('PayPalChargeDescription'),
 +};

It seems like using Business::PayPal::API might offer some protection against
API changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Depends on||6427
  Change sponsored?|--- |Sponsored
   Assignee|oleon...@myacpl.org |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/