subject:"\[Koha\-bugs\] \[Bug 12461\] Add patron clubs feature"

[Koha-bugs] [Bug 12461] Add patron clubs feature

2024-01-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35942

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2024-01-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||35941

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2023-05-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||33553


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553
[Bug 33553] Unecessary GetCategories calls in template
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-09-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19275


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275
[Bug 19275] clubs table broken at the opac if public enrollment is not allowed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-09-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19214


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19214
[Bug 19214] Patron clubs: Template process failed: undef error - Cannot use
"->find" in list context
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-08-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18836


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836
[Bug 18836] MySQL 5.7 - Table 'koha_library.club_enrollments' doesn't exist
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-08-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19019


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19019
[Bug 19019] Patron clubs feature needs documentation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-07-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870
[Bug 18870] Patron Clubs breaks when creating a club
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18647


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18647
[Bug 18647] Internal server error on moremember.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This features would add the |This features adds the
  release notes|ability to create clubs |ability to create clubs
   |which patrons may be|which patrons may be
   |enrolled in. It would be|enrolled in. It is
   |particularly useful for |particularly useful for
   |tracking summer reading |tracking summer reading
   |programs, book clubs and|programs, book clubs and
   |other such clubs.   |other such clubs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
  Text to go in the||This features would add the
  release notes||ability to create clubs
   ||which patrons may be
   ||enrolled in. It would be
   ||particularly useful for
   ||tracking summer reading
   ||programs, book clubs and
   ||other such clubs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Brenda Turnbull  changed:

   What|Removed |Added

 CC||bturnbull@livewirewarringto
   ||n.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #85 from Katrin Fischer  ---
This won't get ported back to 16.11.x as it is a new feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559
[Bug 18559] Koha::Clubs - methods should not get the return type in parameter
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18558


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18558
[Bug 18558] Koha::Clubs::get_enrollable explodes if no patron given
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18557


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557
[Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #84 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #83)
> I do not understand the $return_scalar argument you use for
> get_club_enrollments and get_enrollable_clubs. Could you please explain?
> 
> It seems useless, I suggest to remove it.

It is a hack solution to an big issue with template toolkit. Basically, when
calling a method from Template Toolkit that would return a Koha::Objects
derived class, the result will always be returned in list context. I've tried
using the scalar plugin for TT but had no luck.

Even worse, if the list has only 1 element, TT will convert it to just being
that element with no list context. Then, if you try to call a TT list method (
such as 'size' ), it will try to call that method on the object instead and
you'll get an error!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #83 from Jonathan Druart  
---
I do not understand the $return_scalar argument you use for
get_club_enrollments and get_enrollable_clubs. Could you please explain?

It seems useless, I suggest to remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18553


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553
[Bug 18553] Incorrect "Loading..." tag on  moremember.tt when no clubs defined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Owen Leonard  changed:

   What|Removed |Added

 Blocks||18530


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530
[Bug 18530] Remove event attributes from patron clubs templates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-05-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Owen Leonard  changed:

   What|Removed |Added

 Blocks||18529


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18529
[Bug 18529] Template cleanup of patron clubs pages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18510

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #82 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #81 from Nick Clemens  ---
Created attachment 62815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62815=edit
Bug 12461 - (QA Followup)

Club enrollments should only list active enrollments
Confirms should warn of cascading delete
Branch limited clubs should only be available to members of that
branch
Fix breadcrumbs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #80 from Nick Clemens  ---
Created attachment 62814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62814=edit
Bug 12461 [QA Followup]

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Nick Clemens  changed:

   What|Removed |Added

  Attachment #62778|0   |1
is obsolete||
  Attachment #62779|0   |1
is obsolete||

--- Comment #79 from Nick Clemens  ---
Created attachment 62813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62813=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60624|0   |1
is obsolete||

--- Comment #77 from Kyle M Hall  ---
Created attachment 62778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62778=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #78 from Kyle M Hall  ---
Created attachment 62779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62779=edit
Bug 12461 [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #76 from Nick Clemens  ---
a/clubs/clubs-add-modify.pl
47 my $stored = $cgi->param('name') ? $id ? 'updated' : 'stored' : undef;

*This is confusing

a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt 
85 This item is on hold for another borrower.

*Should be patron

Koha/Template/Plugin/AuthorisedValues.pm
38  my ( $self, $category, $selected, $opac ) = @_;
39  return GetAuthorisedValues( $category, $selected, $opac );

*I think this is rebase error, no 'selected' param now


koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:
[% IF borrower.get_club_enrollments_count.size ||
borrower.get_enrollable_clubs(1).size %]

*causes error - The method size is not covered by tests

*same as above in:
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt


koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt

* borrower.FirstValidEmailAddress is not covered by tests, I think you mean
borrower.first_valid_email_address

When viewing tools/clubs.pl
1 - The 'New club' button has an empty dropdown until a template is defined, it
should be disabled
2 - Once the first template is defined the Clubs table says: " No club
templates defined. " - should say "No clubs defined"
3 - Dates for clubs should show in clubs table

When adding patrons to clubs - 
1 - If no fields are associated with a club you click 'Enroll' then have a new
screen with no additional info and must click 'Enroll' again - should be
clearer 'Finish enrollment' or something
2 - You should not be able to add a patron to club that is out of date, or they
should be hidden by default

The feature adds valuable info for reporting, but I think it should have at
least one default view, a link from the clubs table to "See patrons enrolled in
this club" 
That link should be copied on the patrons club enrollement tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #75 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #74)
> (In reply to Liz Rea from comment #71)
> > Did you mean to push this to master?
> 
> It has been pushed and reverted...

Yes, my bad. Accidentally applied a followup to my working branch instead of
master so it went along for the ride! As much as I'd love for this to be in
master it's not quite ready ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461
Bug 12461 depends on bug 18171, which changed state.

Bug 18171 Summary: Patron Clubs feature breaks logging in/display of logged in 
users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18171

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz
 Depends on||18171
   Severity|new feature |critical
   Severity|critical|new feature

--- Comment #71 from Liz Rea  ---
Did you mean to push this to master?

--- Comment #72 from Liz Rea  ---
Changed to critical for the feature it blocks, but this is not a blocker
anymore.

--- Comment #73 from Liz Rea  ---
Doh wrong bug.

--- Comment #74 from Jonathan Druart  
---
(In reply to Liz Rea from comment #71)
> Did you mean to push this to master?

It has been pushed and reverted...


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18171
[Bug 18171] Patron Clubs feature breaks logging in/display of logged in users
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60618|0   |1
is obsolete||

--- Comment #70 from Kyle M Hall  ---
Created attachment 60624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60624=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Mirko Tietgen  changed:

   What|Removed |Added

 CC|mi...@abunchofthings.net|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60617|0   |1
is obsolete||

--- Comment #69 from Kyle M Hall  ---
Created attachment 60618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60618=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #68 from Kyle M Hall  ---
Still needs unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60617|Squashed patch set for ease |Bug 12461 - Add patron
description|and simplicity. |clubs feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60610|0   |1
is obsolete||
  Attachment #60611|0   |1
is obsolete||
  Attachment #60612|0   |1
is obsolete||
  Attachment #60613|0   |1
is obsolete||
  Attachment #60614|0   |1
is obsolete||
  Attachment #60615|0   |1
is obsolete||
  Attachment #60616|0   |1
is obsolete||

--- Comment #67 from Kyle M Hall  ---
Created attachment 60617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60617=edit
Squashed patch set for ease and simplicity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #63 from Kyle M Hall  ---
Created attachment 60613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60613=edit
Bug 12461 - Template updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #65 from Kyle M Hall  ---
Created attachment 60615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60615=edit
Bug 12461 - Return to clubs home after save

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #64 from Kyle M Hall  ---
Created attachment 60614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60614=edit
Bug 12461 - Fix 'for=' and param issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #66 from Kyle M Hall  ---
Created attachment 60616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60616=edit
Bug 12461 - Remote collates from branchcode rows, add IGNORE for inserts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #62 from Kyle M Hall  ---
Created attachment 60612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60612=edit
Bug 12461 - Revert changes to circulation.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #61 from Kyle M Hall  ---
Created attachment 60611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60611=edit
Bug 12461 - Use snake case

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #60519|0   |1
is obsolete||
  Attachment #60520|0   |1
is obsolete||
  Attachment #60521|0   |1
is obsolete||

--- Comment #60 from Kyle M Hall  ---
Created attachment 60610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60610=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #59 from Kyle M Hall  ---
Thanks! That helps a lot!

(In reply to Jonathan Druart from comment #57)
> Kyle,
> 
> I did not write the different failures because most of them are obvious:
> 
> 1. There are no tests
> 2. CamelCase instead of snake_case for methods of Koha::Clubs and
> Koha::Patron
> 3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just
> call ->count
> 4. You should not need to add GetBranches to the Branches TT plugin. Take a
> look at options_for_libraries
> 5. Subroutine added to Koha TT plugin (UserEnv), but not used.
> 6. Changes to circ/circulation.pl are not needed. A variable 'patron' is
> already passed to the template.
> 7. All the labels of the form has the same value for the "for" attribute.
> 8. Tables on clubs/clubs.pl are ugly (missing datatables.css?)
> 9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input
> at the end of the form.
> 8. CGI->param must not be called in scalar context
> 9. When I save a form, I get "Your club was created" with a link to "Return
> to patron clubs". That sounds weird. Especially because the box is yellow.
> I'd suggest to behave as everywhere else in Koha: Save and get the list.
> I guess it's because there are too many small scripts, maybe it would have
> been easier to have a bigger one and have the different action handled in it
> (as everywhere else in admin scripts).
> 10. INSERT statements should have IGNORE in update db process
> 11. +  `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL,
> you should not need to specify the COLLATE here.
> 12. QA tests do not pass
>   FAIL   Koha/Patron.pm
>   FAIL   forbidden patterns
>  forbidden pattern: merge marker (>>>) (line 647)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #58 from Jonathan Druart  
---
When I hit /circ/circulation.pl?borrowernumber=42, I get a software error:
Template process failed: undef error - The method category_type is not covered
by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.


Yes I think another signoff is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #57 from Jonathan Druart  
---
Kyle,

I did not write the different failures because most of them are obvious:

1. There are no tests
2. CamelCase instead of snake_case for methods of Koha::Clubs and Koha::Patron
3. GetClubEnrollmentsCount and GetEnrollableClubsCount are not needed, just
call ->count
4. You should not need to add GetBranches to the Branches TT plugin. Take a
look at options_for_libraries
5. Subroutine added to Koha TT plugin (UserEnv), but not used.
6. Changes to circ/circulation.pl are not needed. A variable 'patron' is
already passed to the template.
7. All the labels of the form has the same value for the "for" attribute.
8. Tables on clubs/clubs.pl are ugly (missing datatables.css?)
9. On /clubs/clubs-add-modify.pl?club_template_id=1, there is an empty input at
the end of the form.
8. CGI->param must not be called in scalar context
9. When I save a form, I get "Your club was created" with a link to "Return to
patron clubs". That sounds weird. Especially because the box is yellow. I'd
suggest to behave as everywhere else in Koha: Save and get the list.
I guess it's because there are too many small scripts, maybe it would have been
easier to have a bigger one and have the different action handled in it (as
everywhere else in admin scripts).
10. INSERT statements should have IGNORE in update db process
11. +  `branchcode` varchar(10) COLLATE utf8_unicode_ci NULL DEFAULT NULL,
you should not need to specify the COLLATE here.
12. QA tests do not pass
  FAIL   Koha/Patron.pm
  FAIL   forbidden patterns
 forbidden pattern: merge marker (>>>) (line 647)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #56 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #55)
> In my opinion, this patchset is not ready to be QAed. Lot of changes should
> be done to meet our coding guidelines.

Jonathan, can you be more specific? That sounds like QA to me ; )

I've been working on the feature since 2012. It's already gone through one full
rewrite because Koha's coding guidelines had moved on so much since it was
initially written.

If you want another signoff, that's fine. But you specifically wrote "Lot of
changes should be done to meet our coding guidelines" which is not a task for a
signer. That's a task for a QA'er and I'll really need some actionable comments
if I am to make any changes!

If you want another sign-off, please set status to needs sign-off. Otherwise
the status can go back to failed qa.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #55 from Jonathan Druart  
---
In my opinion, this patchset is not ready to be QAed. Lot of changes should be
done to meet our coding guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #53 from Kyle M Hall  ---
Created attachment 60520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60520=edit
Bug 12461 [QA Followup] - Changes based on suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #59272|0   |1
is obsolete||
  Attachment #59273|0   |1
is obsolete||

--- Comment #52 from Kyle M Hall  ---
Created attachment 60519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60519=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #54 from Kyle M Hall  ---
Created attachment 60521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60521=edit
Bug 12461 [QA Followup] - Changes based on Koha standard interface pattern

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #51 from Kyle M Hall  ---
Thanks! That helps a lot!

(In reply to Josef Moravec from comment #50)
> (In reply to Kyle M Hall from comment #49)
> > (In reply to Josef Moravec from comment #48)
> > > Kyle, could you please provide followup due to bug 16239?
> > > 
> > > See https://wiki.koha-community.org/wiki/Interface_patterns
> > 
> > Josef, can you please be more specific?
> > 
> > Thanks!
> 
> Of course, you need to use new btn classes due to Bootstrap 3 - "btn" is not
> enough, you need to change it to  "btn btn-default" also btn size classes
> were renamed: 
>   "btn-mini" -> "btn-xs" 
>   "btn-small" -> "btn-sm"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #50 from Josef Moravec  ---
(In reply to Kyle M Hall from comment #49)
> (In reply to Josef Moravec from comment #48)
> > Kyle, could you please provide followup due to bug 16239?
> > 
> > See https://wiki.koha-community.org/wiki/Interface_patterns
> 
> Josef, can you please be more specific?
> 
> Thanks!

Of course, you need to use new btn classes due to Bootstrap 3 - "btn" is not
enough, you need to change it to  "btn btn-default" also btn size classes were
renamed: 
  "btn-mini" -> "btn-xs" 
  "btn-small" -> "btn-sm"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-02-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #49 from Kyle M Hall  ---
(In reply to Josef Moravec from comment #48)
> Kyle, could you please provide followup due to bug 16239?
> 
> See https://wiki.koha-community.org/wiki/Interface_patterns

Josef, can you please be more specific?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #48 from Josef Moravec  ---
Kyle, could you please provide followup due to bug 16239?

See https://wiki.koha-community.org/wiki/Interface_patterns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #47 from Luke Honiss  ---
You have left in the '>>> BUG X' when resolving the conflicts in
Koha/Patron.pm (line 644) and installer/data/mysql/kohastructure.sql (lines
4077 and 4078).

I cannot work out how to add a patron to a club however. If you could walk me
through the process that would be awesome.

Also when adding another field in the creation of a template there is no colon
after the field name unlike the default fields when editing the club. There is
also an extra full stop in the tools homepage under the 'Patron clubs' link.

Looks like it will be a great feature when finished!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58819|0   |1
is obsolete||
  Attachment #58820|0   |1
is obsolete||

--- Comment #45 from Kyle M Hall  ---
Created attachment 59272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59272=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #46 from Kyle M Hall  ---
Created attachment 59273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59273=edit
Bug 12461 [QA Followup] - Changes based on suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Luke Honiss  changed:

   What|Removed |Added

 CC||luke.hon...@gmail.com

--- Comment #44 from Luke Honiss  ---
There are a large amount of conflicts when applying patch which makes it rather
difficult to test. If these could be fixed that would help.

Cheers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58818|0   |1
is obsolete||

--- Comment #41 from Kyle M Hall  ---
Created attachment 58819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58819=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #43 from Kyle M Hall  ---
(In reply to Chris Cormack from comment #39)
> Kyle, we would like to get the academy students testing this again, but the
> patches do not apply. If you have a chance to rebase before Monday please
> do, otherwise please remove the Academy tag

Done!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #42 from Kyle M Hall  ---
Created attachment 58820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58820=edit
Bug 12461 [QA Followup] - Changes based on suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #50422|0   |1
is obsolete||
  Attachment #50427|0   |1
is obsolete||

--- Comment #40 from Kyle M Hall  ---
Created attachment 58818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58818=edit
Bug 12461 [QA Followup] - Changes based on suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2017-01-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #39 from Chris Cormack  ---
Kyle, we would like to get the academy students testing this again, but the
patches do not apply. If you have a chance to rebase before Monday please do,
otherwise please remove the Academy tag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-12-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-07-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #38 from Katrin Fischer  ---
I am sorry, there are too many conflicts for me to feel comfortable trying to
fix:
CONFLICT (content): Merge conflict in opac/opac-user.pl
Auto-merging members/moremember.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging installer/data/mysql/kohastructure.sql
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql
Auto-merging circ/circulation.pl
CONFLICT (content): Merge conflict in circ/circulation.pl
Auto-merging Koha/Schema/Result/Borrower.pm
Auto-merging Koha/Patron.pm
CONFLICT (content): Merge conflict in Koha/Patron.pm

Please take a look!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-06-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Cindy Murdock Ames  changed:

   What|Removed |Added

 CC||cmurd...@ccfls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-04-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #37 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #32)
> Some first tests:
> 1) New permissions need to be added to the permissions.inc file for
> translation.

Fixed!

> 2) Datatables on the new tools page are broken.

Fixed!

> 3) Misses tools sidebar navigation.

Fixed!

> I feel like the templates look a bit odd - maybe it would be better to have
> the different parts in separate boxes? Once this is progressed a bit
> further, we can worry about prettying thing up :)

I agree. The presentation of this feature requires layouts that have not been
used in Koha before. However, this followup goes a very long way to putting
elements into a more "Koha-like" display. I think you'll find all your concerns
have been addressed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #50426|0   |1
is obsolete||

--- Comment #36 from Kyle M Hall  ---
Created attachment 50427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50427=edit
Bug 12461 [QA Followup] - Changes based on suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #50423|0   |1
is obsolete||

--- Comment #35 from Kyle M Hall  ---
Created attachment 50426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50426=edit
Bug 12461 [QA Followup] - Changes based on suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #34 from Kyle M Hall  ---
Created attachment 50423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50423=edit
Bug 12461 [QA Followup] - Changes based on suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #49121|0   |1
is obsolete||

--- Comment #33 from Kyle M Hall  ---
Created attachment 50422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50422=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-03-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #32 from Katrin Fischer  ---
Some first tests:
1) New permissions need to be added to the permissions.inc file for
translation.
2) Datatables on the new tools page are broken.
3) Misses tools sidebar navigation.

I feel like the templates look a bit odd - maybe it would be better to have the
different parts in separate boxes? Once this is progressed a bit further, we
can worry about prettying thing up :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-03-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #31 from Katrin Fischer  ---
Comment on attachment 49121
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49121
Bug 12461 - Add patron clubs feature

Review of attachment 49121:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12461=49121)
-

Did a first code review - not a lot of findings and mostly minor. Haven't
tested the code yet.

Patch doesn't apply atm - not sure why the modules appear in the general
syspref.pm?

<<< HEAD
use C4::Log;
===
use Koha::Clubs;
use Koha::Club::Enrollments;
>>> Bug 12461 - Add patron clubs feature

::: Koha/Template/Plugin/AuthorisedValues.pm
@@ +30,4 @@
>  
>  sub Get {
>  my ( $self, $category, $selected, $opac ) = @_;
> +warn "GET( $self, $category, $selected, $opac )";

Unconditional warn - please remove.

::: koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt
@@ +32,5 @@
> +
> +
> +[% IF stored %]
> +
> +Your club was [% IF stored == 'updated' %] updated [% 
> ELSE %] saved [% END %]

Please avoid constructing sentences like that - it's hard to translate, because
grammar and work order is different in other languages.

::: koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt
@@ +23,5 @@
> +} ));
> +});
> +
> +function ConfirmDeleteTemplate( id, name, a ) {
> +if ( confirm( _("Are you sure you want to delete the club template") 
> + name + "?" ) ) {

It would be nicer for translations to use the new Javascript syntax with
placeholders here.

@@ +41,5 @@
> +}
> +}
> +
> +function ConfirmDeleteClub( id, name, a ) {
> +if ( confirm( _("Are you sure you want to delete the club ") + name 
> + "?" ) ) {

Same as above - placeholders preferrable!

::: koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt
@@ +9,5 @@
>

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Marc Véron  changed:

   What|Removed |Added

  Attachment #49110|0   |1
is obsolete||

--- Comment #30 from Marc Véron  ---
Created attachment 49121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49121=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #29 from Kyle M Hall  ---
All QA script issues should be fixed with this latest patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47856|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall  ---
Created attachment 49110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49110=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Marc Véron  changed:

   What|Removed |Added

  Attachment #47825|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=813

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #26 from Kyle M Hall  ---
(In reply to Marc Véron from comment #24)
> Created attachment 47825 [details]
> Problem with authorized values (in staff client)
> 
> With an authorized value defined as YES_NO, I get a strnge drop down when I
> want to enroll a patron in staff client. (Drop down list appears OK in OPAC).

Good catch! Should be fixed in this latest patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47824|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall  ---
Created attachment 47856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47856=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #27 from Marc Véron  ---
Went through test plan, works as expected.

However QA tools complain:

 FAIL   installer/data/mysql/kohastructure.sql
   FAIL   charset_collate
The table club_fields does not have the current charset collate
(see bug 11944)
The table club_template_enrollment_fields does not have the
current charset collate (see bug 11944)
The table club_enrollments does not have the current charset
collate (see bug 11944)
The table club_enrollment_fields does not have the current
charset collate (see bug 11944)
The table club_template_fields does not have the current
charset collate (see bug 11944)
The table club_templates does not have the current charset
collate (see bug 11944)
The table clubs does not have the current charset collate (see
bug 11944)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43428|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall  ---
Created attachment 47821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47821=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #24 from Marc Véron  ---
Created attachment 47825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47825=edit
Problem with authorized values (in staff client)

With an authorized value defined as YES_NO, I get a strnge drop down when I
want to enroll a patron in staff client. (Drop down list appears OK in OPAC).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47821|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall  ---
Created attachment 47824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47824=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the "Patron clubs" link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2016-02-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

--- Comment #23 from Kyle M Hall  ---
(In reply to Bernardo Gonzalez Kriegel from comment #20)
> (In reply to Kyle M Hall from comment #18)
> > Updated patch merges constraints into table creation, fixes merge conflicts.
> > Tested with fresh install and upgrade!
> 
> Hi, testing again.
> There are small conflicts. I fixed that and also have 2 follow-ups,
> one for koha-qa and the other to fix atomicupdate (you missed
> new permissions there)
> 
> But I'm stuck with the test plan.
> Don't know how to do 7 and 9-13. I can't see any place to enroll or enable a
> club for OPAC.
> 
> Could you explain?

There was a bug that was preventing the Clubs tab from displaying on the opac
side. Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 136 matches

Mail list logo