https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Aleisha Amohia changed:
What|Removed |Added
Version(s)|20.11.00, 20.05.05 |20.11.00, 20.05.05,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Lucas Gass changed:
What|Removed |Added
Version(s)|20.11.00|20.11.00, 20.05.05
rele
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
koha-US bug tracker changed:
What|Removed |Added
CC|bugzi...@koha-us.org|
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #76 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #75 from Marcel de Rooy ---
Looks good to me now.
Cant resist saying that the support of holds with and without holds queue in
Koha seems kind of a source of bugs on itself to me ;)
The design of the two tables tmpholdsqu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Attachment #109222|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #74 from Marcel de Rooy ---
Created attachment 109645
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109645&action=edit
Bug 18958: (QA follow-up) Fix number of tests
In HoldsQueue.t
Signed-off-by: Mar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Attachment #109061|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Attachment #108937|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Attachment #108936|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Attachment #108499|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #68 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #67 from Nick Clemens ---
(In reply to Katrin Fischer from comment #63)
> (In reply to Nick Clemens from comment #62)
> > Created attachment 109061 [details] [review] [review]
> > Bug 18958: DO NOT PUSH - Schema updates
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #66 from Nick Clemens ---
Created attachment 109222
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109222&action=edit
Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold
types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #65 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #64)
> Coming back here soon ;)
Happily leaving it for you ;)
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #64 from Marcel de Rooy ---
Coming back here soon ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #63 from Katrin Fischer ---
(In reply to Nick Clemens from comment #62)
> Created attachment 109061 [details] [review]
> Bug 18958: DO NOT PUSH - Schema updates
I guess you are trying to tell me I should have run dbic? ;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #62 from Nick Clemens ---
Created attachment 109061
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109061&action=edit
Bug 18958: DO NOT PUSH - Schema updates
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Kyle M Hall changed:
What|Removed |Added
Assignee|k...@bywatersolutions.com |n...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #61 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #58)
> The test worked for me, but the reserve_id column remained NULL at all times
> - can you please explain?
Making sure this is seen after I added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #60 from Katrin Fischer ---
Created attachment 108937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108937&action=edit
Bug 18958: (QA follow-up) Add missing comma to kohastructure.sql
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Katrin Fischer changed:
What|Removed |Added
Attachment #108500|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #58
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #108473|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #108497|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Attachment #108474|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #53 from Nick Clemens ---
Created attachment 108474
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108474&action=edit
Bug 18958: Make hold_fill_targets specific to reserves
After looking at Marcel's co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Attachment #107584|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Attachment #108256|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #50 from Nick Clemens ---
Created attachment 108256
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108256&action=edit
Bug 18958: [alternate] Make hold_fill_targets specific to reserves
After looking at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #49 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #48)
> Just puzzled by this change. Since CheckReserves is such a vital routine.
> How is it possible that we just now need to add waiting and transit hol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #48
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #47 from Marcel de Rooy ---
Just for reference:
PASS t/db_dependent/Circulation.t
PASS t/db_dependent/Holds.t
PASS t/db_dependent/Holds/HoldFulfillmentPolicy.t
PASS t/db_dependent/Holds/HoldItemtypeLimit.t
PASS t/db_depe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #46 from Marcel de Rooy ---
This is so horrible. Just checking occurrences of CheckReserves calls. Here we
are in Circulation::CanBookBeRenewed.
First we call CheckReserves, but then note the $itemholds=search call and
re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #45 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #44)
> Marcel - maybe 3rd time this will pass? :) Do you want to continue here?
Will do
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #44 from Katrin Fischer ---
Marcel - maybe 3rd time this will pass? :) Do you want to continue here?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Kyle M Hall changed:
What|Removed |Added
Attachment #107576|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #43 from Kyle M Hall ---
Created attachment 107586
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107586&action=edit
Bug 18958: (follow-up) Also find waiting holds for the current item/patron
In the fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #42 from Kyle M Hall ---
Created attachment 107585
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107585&action=edit
Bug 18958: Unit tests
Signed-off-by: Bonnie Gardner
Signed-off-by: Bouzid Fergani
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #40 from Nick Clemens ---
Created attachment 107582
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107582&action=edit
Bug 18958: (follow-up) Also find waiting holds for the current item/patron
In the f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #39 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #36)
> (In reply to Marcel de Rooy from comment #15)
> > Failing QA because this patch has side-effects when you cancel a hold from
> > the confirm hold p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Attachment #93216|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #38 from Nick Clemens ---
Created attachment 107577
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107577&action=edit
Bug 18958: Unit tests
Signed-off-by: Bonnie Gardner
Signed-off-by: Bouzid Fergani
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_20_11_target|
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_20_05_candidate |rel_20_11_target
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
koha-US bug tracker changed:
What|Removed |Added
CC||bugzi...@koha-us.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #36 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #15)
> Failing QA because this patch has side-effects when you cancel a hold from
> the confirm hold popup. Before we called GetOtherReserves and now we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_19_11_candidate |
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_20_05_target
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #35 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_19_11_candidate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #34 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Bouzid Fergani changed:
What|Removed |Added
Attachment #93113|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Bouzid Fergani changed:
What|Removed |Added
Attachment #93111|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Bouzid Fergani changed:
What|Removed |Added
Attachment #93112|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Bonnie Gardner changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
ByWater Sandboxes changed:
What|Removed |Added
Attachment #93106|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
ByWater Sandboxes changed:
What|Removed |Added
Attachment #93108|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
ByWater Sandboxes changed:
What|Removed |Added
Attachment #93107|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #26 from Nick Clemens ---
(In reply to Bonnie Gardner from comment #22)
> Kyle,
>
> I tested this at koha-US 2019 and it worked properly.
> When we tried to sign it off in the BWS sandboxes we got this message:
Hi Bonni
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #25 from Nick Clemens ---
Created attachment 93108
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93108&action=edit
Bug 18958: Make check reserves find in transit holds
To test:
Imagine you have a reco
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Attachment #72348|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #24 from Nick Clemens ---
Created attachment 93107
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93107&action=edit
Bug 18958: Unit tests
--
You are receiving this mail because:
You are watching all b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Bonnie Gardner changed:
What|Removed |Added
CC||bgard...@cityoflewiston.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Severity|normal |major
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #20 from Nick Clemens ---
Created attachment 92159
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92159&action=edit
Bug 18958: Unit tests
--
You are receiving this mail because:
You are watching all b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #21 from Nick Clemens ---
Created attachment 92160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92160&action=edit
Bug 18958: Make check reserves find in transit holds
To test:
Imagine you have a reco
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Andrew changed:
What|Removed |Added
CC||and...@bywatersolutions.com
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Joel Sasse changed:
What|Removed |Added
CC||jsa...@plumcreeklibrary.net
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #18 from Marcel de Rooy ---
(In reply to Kyle M Hall from comment #17)
> Could you restate what the change in behavior is? I'm not sure I understand.
> Thanks!
Holds are not easy :)
See: Failing QA because this patch has
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #17 from Kyle M Hall ---
(In reply to Marcel de Rooy from comment #16)
> [With patch]
> Three items
> 2 record level for patron A
> 1 item level for patron B on CPL item
> Goto RMA Checkin CPL item, confirm for patron A W
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #16 from Marcel de Rooy ---
[Without patch]
Three items (CPL MPL RMA)
2 record level patron A and item level from patron B (CPL)
Checkin CPL item at RMA
Confirm
Waiting OK
Checkin this item again and Cancel
Finally reprod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #15
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
QA Contact|josef.mora...@gmail.com |m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Attachment #72210|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #14 from Marcel de Rooy ---
Created attachment 72349
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72349&action=edit
Bug 18958: (Follow-up) Pass patron to template for confirm hold
Removing the FIXME.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #12 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #11 from Marcel de Rooy ---
QA: Looking here
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Kyle M Hall changed:
What|Removed |Added
Status|In Discussion |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #10 from Kyle M Hall ---
Created attachment 72211
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72211&action=edit
Bug 18958 [QA Followup] - Bring back data needed for the diffbranch block of
the templa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Kyle M Hall changed:
What|Removed |Added
Attachment #71232|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #8 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #7)
> (In reply to Jonathan Druart from comment #6)
> > Hum, I am going to postpone this change for my mental health (holds...)
> >
> > But at first glan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #7 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #6)
> Hum, I am going to postpone this change for my mental health (holds...)
>
> But at first glance there is something wrong: the diffbranch flag will n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Sally Healey changed:
What|Removed |Added
CC||sally.healey@cheshireshared
1 - 100 of 119 matches
Mail list logo