[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29329


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329
[Bug 29329] stray "s" in opac-detail
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||28537


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537
[Bug 28537] Improve HTML generated by OverDrive integration
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Lucas Gass  changed:

   What|Removed |Added

 Blocks||28868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28868
[Bug 28868] Masthead.inc is missing class name
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||28679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679
[Bug 28679] Unable to click "Log in to your account" when  GoogleOpenIDConnect 
is enabled
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||28193


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193
[Bug 28193] OpacLoginInstructions news block broken by Bug 20168
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||27881


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881
[Bug 27881] Markup error in masthead-langmenu.inc
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||27814


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27814
[Bug 27814] Improve responsive behavior of the user page in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27200


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200
[Bug 27200] "Browse search" is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||26665


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665
[Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||27072


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072
[Bug 27072] Don't process staff interface CSS with rtlcss
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

  Text to go in the||This patch upgrades the
  release notes||version of the Bootstrap
   ||library used by the OPAC
   ||from version 2.3.1 to
   ||version 4.5.0. The
   ||Bootstrap library provides
   ||a framework of JavaScript
   ||and CSS to support
   ||responsive layouts and
   ||interface elements like
   ||toolbars, menus, buttons,
   ||etc. Although some aspects
   ||of the interface have been
   ||updated, the changes are
   ||largely invisible to the
   ||user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Nick Clemens  changed:

   What|Removed |Added

 Blocks||26810


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26810
[Bug 26810] OpacCustomSearch is no longer a system preference, we must use the
template variable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26758


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26758
[Bug 26758] Correct OPAC ILL requests page markup
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26752


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752
[Bug 26752] OPAC list download button broken by Bootstrap 4 upgrade
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26749


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26749
[Bug 26749] Correct dropdown markup in OPAC cart
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26735


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26735
[Bug 26735] Overdrive login modal broken in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

David Nind  changed:

   What|Removed |Added

 Blocks||26720


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26720
[Bug 26720] OPAC lists - button display
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26519


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26519
[Bug 26519] Clean up OPAC buttons with incorrect classes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26512


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26512
[Bug 26512] Display issue with buttons for OPAC checkout note
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26505


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26505
[Bug 26505] Suspend hold modal broken in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26478
[Bug 26478] Display issue with buttons on the self checkout screens
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26465


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26465
[Bug 26465] Generated RTL CSS files should be committed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #32 from Lucas Gass  ---
enhancement will not be backported to 20.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26419


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26419
[Bug 26419] Replace OPAC Koha logo with SVG
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||26164


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26164
[Bug 26164] Replace OPAC table sort icons with SVG
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Version(s)||20.11.00
released in||

--- Comment #31 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_20_11_target,   |
   |RM_priority |
 Status|Signed Off  |Passed QA

--- Comment #30 from Jonathan Druart  
---
I've decided to push this (with 2 follow-ups) to have time for catching issues
before the 20.11 release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #29 from Jonathan Druart  
---
I don't see any good reasons to have is set to "opac.css", however I would add
the test in the template instead of modifying the pref (can be a follow-up bug
report).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #28 from Owen Leonard  ---
(In reply to Owen Leonard from comment #27)
> [% IF ( Koha.Preference('opaclayoutstylesheet') !== "opac.css" ) %]

More accurately:

[% IF ( Koha.Preference('opaclayoutstylesheet') &&
Koha.Preference('opaclayoutstylesheet') != "opac.css" ) %]

The only reason I bring up the idea of changing the default value of
opaclayoutstylesheet is because I don't understand why we set it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #27 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #26)
> Owen, there is a problem with the dropdown-menu:
> https://snipboard.io/wcETBt.jpg

We talked about this on IRC, but I'll repeat it here for posterity: The problem
is that the opaclayoutstylesheet system preference is filled by default with
"opac.css." I didn't expect this--I thought the default was blank and that
checking for the existence of a value in the preference was enough to determine
whether a custom stylesheet was being used.

We could change the way the default it set -- I'm not sure there is a reason to
put a value in the preference by default.

I could also modify the check in doc-head-close.inc. Where it is currently:

[% IF ( Koha.Preference('opaclayoutstylesheet') ) %] 

We could change it to:

[% IF ( Koha.Preference('opaclayoutstylesheet') !== "opac.css" ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #26 from Jonathan Druart  
---
Owen, there is a problem with the dropdown-menu:
https://snipboard.io/wcETBt.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #25 from Owen Leonard  ---
I've pushed an update to my GitLab branch that incorporates this into the gulp
process: https://rtlcss.com. This will auto-generate RTL versions of the CSS
files generated from SCSS.

I've made some corresponding changes to the way RTL CSS is included on the
affected pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #24 from Jonathan Druart  
---
The RTL version (tested with ar-Arab) is broken indeed.

First there is a leftover in doc-head-close.inc
 10 [% Asset.css("lib/bootstrap/css/bootstrap-rtl.min.css") | $raw %]
This file has been removed.

Then you can see:
mainpage before: https://snipboard.io/0tgXu7.jpg
mainpage after : https://snipboard.io/uBinZp.jpg

search result before: https://snipboard.io/MjyfO2.jpg
search result after : https://snipboard.io/Mmh0os.jpg

Things to try:
https://bootstrapper.ir/
https://github.com/MahdiMajidzadeh/bootstrap-v4-rtl
https://bootstrap.rtlcss.com/

I don't think we should push this change without RTL support.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #23 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #21)
> Also can you confirm the following 3 errors are not valid?
> 
>  FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>FAIL   forbidden patterns
>  FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>FAIL   forbidden patterns

These templates contain links to external (non-Koha) JavaScript assets:
LibraryThing and Babeltheque. 

>  FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
>FAIL   forbidden patterns
> forbidden pattern: Font Awesome icons need the aria-hidden
> attribute for accessibility purpose (see bug 25166)  (line 124)

That's a valid warning and has been corrected.

(In reply to Jonathan Druart from comment #22)
> 1. https://snipboard.io/9kNAL8.jpg
> Don't you think the login inputs are too wide?

I've added a max-width to the form.

> 2. https://snipboard.io/TlIkcu.jpg
> The relevance dropdown is too wide

Fixed.

> 3. https://snipboard.io/apKe35.jpg
> Why did you change the order of the filters at the bottom of the adv search
> page?

I made a lot of changes when working on the responsive behavior of this page. I
think the change in the order is unintentional.

> 4. https://snipboard.io/vq2I57.jpg
> The [+][i] links don't behave correctly.

Fixed.

> 5. https://snipboard.io/H3xOZK.jpg
> I was surprised by the brightness of the green and noticed that there is a
> change.
> Compare the "Go" button (in the header):

I made changes across the board to buttons to make them more consistent with
each other. The buttons in your example screenshot have been made to match the
style of the "Go" button in the header. Other buttons, like the "Search"
buttons on the advanced search page, have been styled the same where previously
they used out-of-the-box Bootstrap "btn-success" colors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #22 from Jonathan Druart  
---
1. https://snipboard.io/9kNAL8.jpg
Don't you think the login inputs are too wide?

2. https://snipboard.io/TlIkcu.jpg
The relevance dropdown is too wide

3. https://snipboard.io/apKe35.jpg
Why did you change the order of the filters at the bottom of the adv search
page?


4. https://snipboard.io/vq2I57.jpg
The [+][i] links don't behave correctly. This is the screen after 1 click on
[+]

5. https://snipboard.io/H3xOZK.jpg
I was surprised by the brightness of the green and noticed that there is a
change.
Compare the "Go" button (in the header):
background-color: #85ca11;
background-image: linear-gradient(180deg,#85ca11,#77b50f);
background-position: 0;

With now:
background-color: #71ac0e;
background-image: linear-gradient(180deg,#7dbf0f,#71ac0e);
border-color: #61940c;
box-shadow: 0 0 0 1px #7dbf0f;

Is that expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #21 from Jonathan Druart  
---
Also can you confirm the following 3 errors are not valid?

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
   FAIL   forbidden patterns   
   
   forbidden
pattern: Do *not* include full path to js files, use the Asset TT plugin (bug
20538) (line 1174) 
   forbidden pattern: Do *not* include
full path to js files, use the Asset TT plugin (bug 20538) (line 1180)

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
   FAIL   forbidden patterns
forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 625)  

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
   FAIL   forbidden patterns
forbidden pattern: Font Awesome icons need the aria-hidden
attribute for accessibility purpose (see bug 25166)  (line 124)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #20 from Jonathan Druart  
---
I think the patches should be squashed. The first patch contain a lot of merge
marker conflicts, that will make further conflicts a nightmare to resolve.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #19 from Jonathan Druart  
---
There are merge marker conflicts left in the last patch

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt:<<< HEAD
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt:<<< HEAD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #18 from Owen Leonard  ---
I've rebased and made corrections on the remote branch:


https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-05-14-opac-bootstrap-4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |
 Status|Signed Off  |ASSIGNED
 CC||tomasco...@gmail.com

--- Comment #17 from Tomás Cohen Arazi  ---
I've submitted to a branch on our gitlab a follow-up that makes the gulpfile
and package.json back to master's, and also sets bootstrap version to 4.5.2.
Regardless, there's a problem on search results paging, which Owen is already
working on. Setting to ASSIGNED in the meantime.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #16 from Jonathan Druart  
---
yarn install
yarn build
yarn build --view=opac

all works ok for me on KTD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #15 from Katrin Fischer  ---
I've tried testing this from the branch, but there is an error on the yarn
build:

$ yarn build --view opac
yarn run v1.22.4
$ node_modules/.bin/gulp build --view opac
[10:47:07] Using gulpfile ~/kohaclone/gulpfile.js
[10:47:07] Starting 'build'...
Error in plugin 'sass'
Message:
koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
Error: File to import not found or unreadable:
../../../../../node_modules/bootstrap/scss/functions.
on line 39 of koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
from line 1 of koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>> @import "../../../../../node_modules/bootstrap/scss/functions";

   ^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #14 from Martin Renvoize  ---
OK.. Well.. I ran this for the better part of a day and worked through most
pages.. I'm happy that I didn't find any real bugs..

Please add my SO line to the patches on the branch :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #13 from Owen Leonard  ---
(In reply to Martin Renvoize from comment #12)

> * The search bar doesn't react properly when shrinking and growing the
> window width however.

This has been fixed in the remote branch.

> * I'm not sure about the increase in whitespace and sizes...

I'm happy to reevaluate this if others are bothered by it. I think it might be
a difference in Bootstrap defaults.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #12 from Martin Renvoize  ---
Generally I'm liking it so far...

* The search bar doesn't react properly when shrinking and growing the window
width however.
* I'm not sure about the increase in whitespace and sizes.. the login modal
looks huge and the space from the top of the page to the start of content seems
to have increased considerable with various increases in padding for each
element?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Martin Renvoize  changed:

   What|Removed |Added

URL||https://gitlab.com/koha-dev
   ||/koha-dev/-/tree/wip-2020-0
   ||5-14-opac-bootstrap-4
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #11 from Owen Leonard  ---
I've rebased and updated the remote branch with some fixes:

 - Fixed markup of navbar item "Log in to create your own lists"
 - Improved consistency of input and link focus borders (needs
   more improvement).
 - Corrected style of disabled link buttons in the Cart.

(In reply to Lucas Gass from comment #10)

> On the item details page the More Searches dropdown (inside
> #ulactioncontainer) is not a dropdown.

This is a problem because the Bootstrap dropdown markup changed in version 4.
I'm still puzzling over this... There is probably a CSS solution, preferable to
trying to add a db update which tries to correct existing values in the system
preference.

Currently for it to work properly you have to update the  OPACSearchForTitleIn
preference with this text, removing the 's and adding a "dropdown-item"
class to the links:


https://worldcat.org/search?q={TITLE};
target="_blank">Other Libraries (WorldCat)
https://scholar.google.com/scholar?q={TITLE};
target="_blank">Other Databases (Google Scholar)
https://www.bookfinder.com/search/?author={AUTHOR}title={TITLE}st=xlac=qr;
target="_blank">Online Stores (Bookfinder.com)
https://openlibrary.org/search?author=({AUTHOR})=({TITLE})"
target="_blank">Open Library (openlibrary.org)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
Initial impressions:

In the navbar when there are no added lists and the user is NOT logged in the
text breaks ‘Log in to create your own lists’.
(https://snipboard.io/YZdXTv.jpg) This seems to look fine once you have a list,
even if the list name is long: (https://snipboard.io/9CAMFl.jpg)

On the item details page the More Searches dropdown (inside #ulactioncontainer)
is not a dropdown. Maybe its missing a div container with the dropdown-menu
class? (https://snipboard.io/jcB4Mf.jpg)

There are many inputs that get a Koha green border when focused that now also
get the Bootstrap blue border, they look odd when paired:
(https://snipboard.io/6KajBs.jpg)

When you view your cart (basket ) the remove, add to list, place hold buttons
are blue when disabled and blue when enabled so its hard to tell the
difference. They used to be grey when disabled.
(https://snipboard.io/uE7zwb.jpg)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #9 from Owen Leonard  ---
Remote branch has been rebased on master, including:

Bug 18911, Option to set preferred language in OPAC
Bug 22672, Replace  tags with  AND  tags with  in the OPAC
Bug 22807, Accessibility: Add 'Skip to main content' link
Bug 24156, Basket - Make sort order and number of items to display configurable
Bug 25151, Accessibility: The 'Your cart' page does not contain a level-one
header
Bug 25154, Accessibility: The 'Search results' page does not use heading markup
where content is introduced
Bug 25238, Accessibility: Multiple 'H1' headings exist in the full record
display

Some QA tool warnings have been fixed. There seem to be several false positives
too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25775


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25775
[Bug 25775] Add DataTables controls to user's checkouts table in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25771


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25771
[Bug 25771] Allow the user to sort checkouts by the renew column in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #8 from Owen Leonard  ---
Remote branch:


https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-05-14-opac-bootstrap-4

Information and test plan:

This patch updates the version of Bootstrap in the OPAC from 2.3.1 to
4.5.0. The Bootstrap JavaScript files have been replaced with custom
builds of the 4.5.0 JavaScript source files. The Bootstrap CSS is now
built into the OPAC CSS by loading the required Bootstrap 4.5.0 SCSS
files in node_modules.

OPAC SCSS now starts with Bootstrap customizations:

/* Bootstrap variable customizations */
$headings-color: #727272;
...

Followed by loading the necessary Bootstrap SCSS files:

/* Bootstrap imports */
@import "../../../../../node_modules/bootstrap/scss/functions";
@import "../../../../../node_modules/bootstrap/scss/variables";
...

Followed by our CSS. The build process for generating compiled CSS now
creates a file which bundles Bootstrap CSS and ours. Removed from the
Koha source: Bootstrap CSS files, Bootstrap "glyphicons" images.

The upgrade to Bootstrap 4 involved a lot of markup changes to conform
with new Bootstrap classes, especially in classes related to the grid.
Besides duplicating the grid we used before, this upgrade adds some new
features made possible by Bootstrap 4.5's use of flexbox as a layout
tool. This includes custom ordering of columns based on class names:
https://getbootstrap.com/docs/4.5/layout/grid/#order-classes.

Other areas where the most changes have been made: Navigation menus,
breadcrumb menus, buttons, dropdowns.

Unrelated changes: Indentation corrections, removal of invalid

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #7 from Katrin Fischer  ---
Hi Owen, is this ready for testing or are you still working on it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #6 from Owen Leonard  ---
Work in progress:

https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-05-14-opac-bootstrap-4

If you test, you'll need to run 'yarn install' before running 'yarn build
--view opac'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 Depends on||14862


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862
[Bug 14862] Upgrade jQuery from 1.7 to 3.4.1 in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Arslan Farooq  changed:

   What|Removed |Added

 CC||arslan...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

   Assignee|elias.deh...@thulb.uni-jena |oleon...@myacpl.org
   |.de |
 Status|ASSIGNED|NEW
Version|17.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #5 from Owen Leonard  ---
(In reply to Elias from comment #0)
> I'm currently working on updating the bootstrap template to bootstrap v4.

Is this something you're still working on?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #4 from Owen Leonard  ---
*** Bug 18031 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #3 from Katrin Fischer  ---
Please also avoid one big change patch - smaller steps are always easier to
test and integrate! Not sure, maybe it would make sense to split jQuery update
and Bootstrap update into 2 separate bugs and patch sets?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Katrin Fischer  changed:

   What|Removed |Added

Summary|update of the OPAC  |Update of the OPAC
   |bootstrap template to   |bootstrap template to
   |bootstrap v4|bootstrap v4
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

--- Comment #2 from Owen Leonard  ---
Consider also how your work might conflict with these in-progress patches:

https://bugs.koha-community.org/bugzilla3/buglist.cgi?bug_status=Needs%20Signoff_status=Signed%20Off_status=Passed%20QA=OPAC_id=228043_format=advanced

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Owen Leonard  changed:

   What|Removed |Added

  Component|Templates   |OPAC
 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |elias.deh...@thulb.uni-jena
   ||.de

--- Comment #1 from Owen Leonard  ---
Please base your work on master! The patch would not be accepted on a stable
release branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20168] update of the OPAC bootstrap template to bootstrap v4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Elias  changed:

   What|Removed |Added

Summary|update the OPAC to  |update of the OPAC
   |bootstrap v4|bootstrap template to
   ||bootstrap v4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/