[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #58 from Katrin Fischer --- One thing for next time :) Please take care of always writing good commit messages and the format of the subject line spefically: https://wiki.koha-community.org/wiki/Commit_messages These patches have a lot of history, being started in 2012. It works alright now in my eyes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #57 from Katrin Fischer --- Created attachment 73818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73818&action=edit Bug 8643: (follow-up) Move input field up below mandatory Changes sequence of input fields to be more logical by grouping repeatable, mandatory, important, like it's already done for the subfield configuration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #56 from Katrin Fischer --- Created attachment 73817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73817&action=edit Bug 8643: (QA follow-up) Use paler yellow and better column order Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #55 from Katrin Fischer --- Created attachment 73816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73816&action=edit Bug 8643: (QA follow-up) Fix alert, clean up patch, improve db update * Field 'important' now added after 'mandatory' in table marc_tag_structure * Removed modification on table serialitems in kohastructure.sql * Removed bogus line in marctagstructure.tt * Fixed the missing tag number in the alert message Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #52 from Katrin Fischer --- Created attachment 73813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73813&action=edit Bug 8643: (follow-up) Atomic update Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #53 from Katrin Fischer --- Created attachment 73814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73814&action=edit Bug 8643: Add hint for important fields and implemented it for item fields Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #54 from Katrin Fischer --- Created attachment 73815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73815&action=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Fixed small conflict Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #72157|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #73591|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #72154|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #72155|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #72156|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #73812|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Patch complexity|Small patch |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #73811|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #73808|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #73810|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Attachment #73809|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #51 from Katrin Fischer --- Created attachment 73812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73812&action=edit Bug 8643: (QA follow-up) Move input field up below mandatory Changes sequence of input fields to be more logical by grouping repeatable, mandatory, important, like it's already done for the subfield configuration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #50 from Katrin Fischer --- Created attachment 73811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73811&action=edit Bug 8643: (QA follow-up) Use paler yellow and better column order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #49 from Katrin Fischer --- Created attachment 73810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73810&action=edit Bug 8643: (QA follow-up) Fix alert, clean up patch, improve db update * Field 'important' now added after 'mandatory' in table marc_tag_structure * Removed modification on table serialitems in kohastructure.sql * Removed bogus line in marctagstructure.tt * Fixed the missing tag number in the alert message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #48 from Katrin Fischer --- Created attachment 73809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73809&action=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Fixed small conflict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #47 from Katrin Fischer --- Created attachment 73808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73808&action=edit Bug 8643: Add hint for important fields and implemented it for item fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #46 from Charles Farmer --- Tried again with a fresh database: I could see the 'important' field dialog box ONLY after correcting every mandatory field warnings. I don't have much cues to give otherwise. It could either be a javascript problem, or a forgotten atomicupdate? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #45 from Charles Farmer --- Created attachment 73591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73591&action=edit Bug 8643 - Paler yellow and better column order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #44 from Katrin Fischer ---
Hi Charles,
a lighter yellow would work for me.
I retested, but I can't get the message to show up now, neither for an
important field or subfield. Can you please check?
Tiny thing: marc_tag_structure - maybe move the new field after mandatory?
+-- $dbh->do("ALTER TABLE marc_tag_structure ADD COLUMN important
TINYINT(4) NOT NULL DEFAULT 0 AFTER frameworkcode");
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer changed: What|Removed |Added Assignee|maxime.beaul...@inlibro.com |charles.far...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #43 from Charles Farmer --- Hi Katrin, Thank you once again for commenting! I've tackled points 1 to 4 of comment#38. It'd be great if this version could once again be tested. For point #5, from what I see in the code, you're correct: highlighting is only applied to subfields. On the issue of changing the CSS class to highlight important fields differently from mandatory fields, it sounds like an idea I can get behind. Do you have a color suggestion for those fields? Clearer yellow? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #42 from Charles Farmer --- Created attachment 72157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72157&action=edit Bug 8643 - QA Follow-up * Field 'important' now added after 'mandatory' in table marc_tag_structure * Removed modification on table serialitems in kohastructure.sql * Removed bogus line in marctagstructure.tt * Fixed the missing tag number in the alert message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer changed: What|Removed |Added Attachment #65149|0 |1 is obsolete|| --- Comment #40 from Charles Farmer --- Created attachment 72155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72155&action=edit Bug 8643 - Added hint for important fields and implemented it for item fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer changed: What|Removed |Added Attachment #60555|0 |1 is obsolete|| --- Comment #39 from Charles Farmer --- Created attachment 72154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72154&action=edit Bug 8643: (follow-up) atomic update Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer changed: What|Removed |Added Attachment #65682|0 |1 is obsolete|| --- Comment #41 from Charles Farmer --- Created attachment 72156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72156&action=edit Bug 8643 - Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Fixed small conflict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #38 from Katrin Fischer --- There are some things odd about this patch set: 1) In the database update the new columns are added in different spots: +ALTER TABLE marc_subfield_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory; +ALTER TABLE marc_tag_structure ADD COLUMN important TINYINT(4) NOT NULL DEFAULT 0 AFTER frameworkcode; Why not have marc_tag_structure.important after mandatory too? This is mostly cosmetic, but I was wondering about the inconsistency. 2) There is a change on the serialitems table in kohastructure.sql, that needs to be removed from this patch set: @@ -2456,7 +2458,7 @@ DROP TABLE IF EXISTS `serialitems`; CREATE TABLE `serialitems` ( `itemnumber` int(11) NOT NULL, `serialid` int(11) NOT NULL, -PRIMARY KEY (`itemnumber`), +UNIQUE KEY `serialitemsidx` (`itemnumber`), 3) In marctagstructure.tt the following line is added, I think also accidentally? +Authorized value: [% authorised_value %] (if you select a value here, the indicators will be limited to the authorized value list) Also, when testing I noticed that the important field shows up below the authorised value. I think it should be right below mandatory here too, to be consistent with the subfield configuration. 4) The number of the tab is missing from the alert: A few important fields are not filled: * tag 245 subfield b Zusatz zum Titel in tab Are you sure you want to save? 5) The hightlighting seems to only work for subfields, not for fields, is that correct? I think it would be nice if the important fields highlighted in a different color to the mandatory ones (totally not blocker). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Philippe Audet-Fortin changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Philippe Audet-Fortin changed: What|Removed |Added Attachment #60554|0 |1 is obsolete|| --- Comment #37 from Philippe Audet-Fortin --- Created attachment 65682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65682&action=edit Bug 8643 - Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Fixed small conflict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #36 from Katrin Fischer --- Hm, there are changes in kohastructure.sql to the table serialitems causing a conflict when applying the patch: Bug 8643 - Add important constraint to marc subfields 60554 - Bug 8643 - Add important constraint to marc subfields 60555 - Bug 8643: (follow-up) atomic update 65149 - Bug 8643 - Added hint for important fields and implemented it for item fields Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8643 - Add important constraint to marc subfields .git/rebase-apply/patch:22: trailing whitespace. FROM marc_tag_structure .git/rebase-apply/patch:23: trailing whitespace. WHERE frameworkcode=? .git/rebase-apply/patch:42: trailing whitespace. FROM marc_subfield_structure .git/rebase-apply/patch:43: trailing whitespace. WHERE frameworkcode=? .git/rebase-apply/patch:194: trailing whitespace. FROM marc_tag_structure warning: squelched 10 whitespace errors warning: 15 lines add whitespace errors. Using index info to reconstruct a base tree... M C4/Biblio.pm M admin/marc_subfields_structure.pl M cataloguing/addbiblio.pl M installer/data/mysql/kohastructure.sql .git/rebase-apply/patch:22: trailing whitespace. FROM marc_tag_structure .git/rebase-apply/patch:23: trailing whitespace. WHERE frameworkcode=? .git/rebase-apply/patch:42: trailing whitespace. FROM marc_subfield_structure .git/rebase-apply/patch:43: trailing whitespace. WHERE frameworkcode=? .git/rebase-apply/patch:194: trailing whitespace. FROM marc_tag_structure warning: squelched 10 whitespace errors warning: 15 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging cataloguing/addbiblio.pl Auto-merging admin/marc_subfields_structure.pl Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 8643 - Add important constraint to marc subfields The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8643---Add-important-constraint-to-marc-subfie-FP83NQ.patch Are those changes related to the patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #35 from Philippe Audet-Fortin --- Sorry for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #34 from Philippe Audet-Fortin --- Created attachment 65149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65149&action=edit Bug 8643 - Added hint for important fields and implemented it for item fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Philippe Audet-Fortin changed: What|Removed |Added Attachment #65148|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #33 from Katrin Fischer --- Hi Philippe, I think you attached the wrong patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Philippe Audet-Fortin changed: What|Removed |Added CC||philippe.audet-fortin@inlib ||ro.com Status|Failed QA |Needs Signoff --- Comment #32 from Philippe Audet-Fortin --- Hi Katrin, I implemented the important constraint to item fields and added the hint. However, for the point number 2, I wasn't sure what to do because it has the same behaviour has the mandatory constraint. Maybe an other ticket should be open for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #31 from Philippe Audet-Fortin --- Created attachment 65148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65148&action=edit Bug 17639 - Remove white filling inside of Koha logo This patch modifies the Koha logo SVG file to remove the fill from two letters. This patch also optimizes the file and converts the text object to paths for better cross-platform portability. To test you could: - Open the file in an editor and confirm that the change is correct - or - - Open the file in a browser and use the code inspector to add a background-color attribute to the top-level tag. The logo should appear transparent, with no white fills. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #30 from Katrin Fischer --- Tested this a bit and it appears to work ok. Some things found: 1) Doesn't work on item fields, would be nice to see it implemented there as well. Maybe for now we could add a hint to the setting to avoid confusion -"Currently not implemented for items"? 2) I marked 001 as important but it didn't trigger the message. I had to mark the subfield @ important to make it work. Would be nice if this could be fixed. 3) It would be nice to have some visual hint on the important fields and subfields, atm it seems only visible when saving a record. 4) At the moment it will first tell you about the mandatory missing and then after fixing those about the important ones. It would be nicer if the checks were done altogether, to avoid the repeated action. Marking failed QA for 1) and 2), but hopefully those should not be hard to fix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Mehdi Hamidi changed: What|Removed |Added CC||mehdi.ham...@inlibro.com --- Comment #29 from Mehdi Hamidi --- Hello everyone, I rebased the patch and removed two patches that were not necessary. I also addressed some of the the comments : (In reply to Jonathan Druart from comment #23) > ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt > @@ -111,4 @@ > > > value="1" /> > > [% END %] > > > > -Authorized value: [% > > authorised_value %] (if you select a value here, the indicators will be > > limited to the authorized value list) > > Why do you remove this line? I put back the line, as for why it was removed, I'm not sure. (In reply to Jonathan Druart from comment #24) > QA comments: > 1/ You have to deal with the items' fields too. I can mark a 995/952 field > as important, but the behavior is not implemented when adding items. > 2/ If a field is marked as important and mandatory, there are 2 stars (1 red > and 1 black), is it the expected behavior? Maybe the importance of a field > can be ignored if it is also marked as mandatory. I did not fix the first point as it requires more development, but for your second point I fixed it and it won't show important if the field is also mandatory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Mehdi Hamidi changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #28 from Mehdi Hamidi --- Created attachment 60555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60555&action=edit Bug 8643: (follow-up) atomic update Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Mehdi Hamidi changed: What|Removed |Added Attachment #45834|0 |1 is obsolete|| Attachment #45835|0 |1 is obsolete|| Attachment #45836|0 |1 is obsolete|| Attachment #45837|0 |1 is obsolete|| --- Comment #27 from Mehdi Hamidi --- Created attachment 60554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60554&action=edit Bug 8643 - Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Fixed small conflict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added Comment #25 is|1 |0 private|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #26 from Katrin Fischer --- (In reply to Katrin Fischer from comment #25) > Hm, the feature is not working (see bug 2280) - but would be better to fix > or remove in a separate bug. Ignore - wrong bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #25 from Katrin Fischer --- Hm, the feature is not working (see bug 2280) - but would be better to fix or remove in a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #24 from Jonathan Druart --- QA comments: 1/ You have to deal with the items' fields too. I can mark a 995/952 field as important, but the behavior is not implemented when adding items. 2/ If a field is marked as important and mandatory, there are 2 stars (1 red and 1 black), is it the expected behavior? Maybe the importance of a field can be ignored if it is also marked as mandatory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #23 from Jonathan Druart --- Comment on attachment 45835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45835 [SIGNED-OFF] Bug 8643: Removed the use of CGI::checkbox for "Important" subfield and duplicate authorized tag Review of attachment 45835: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8643&attachment=45835) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt @@ -111,4 @@ > /> > [% END %] > > -Authorized value: [% > authorised_value %] (if you select a value here, the indicators will be > limited to the authorized value list) Why do you remove this line? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #22 from Bernardo Gonzalez Kriegel --- Created attachment 45837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45837&action=edit Bug 8643: (follow-up) atomic update Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #41261|0 |1 is obsolete|| --- Comment #20 from Bernardo Gonzalez Kriegel --- Created attachment 45835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45835&action=edit [SIGNED-OFF] Bug 8643: Removed the use of CGI::checkbox for "Important" subfield and duplicate authorized tag Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #41265|0 |1
is obsolete||
--- Comment #21 from Bernardo Gonzalez Kriegel ---
Created attachment 45836
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45836&action=edit
[SIGNED-OFF] Bug 8643: Removed all uses of CGI::Checkbox in
marc_subfields_structure.pl
To test this patch :
1) Apply all patches
2) Run ./installer/data/mysql/updatedatabase.pl
3) Go to More > Administration > MARC bibliographic framework > default
framework ("MARC structure")
4) Search for tag 100 > Click subfields
5) Edit the "a" field and check the "reapeatable","mandatory","important" and
"Is a URL" checkboxes
6) Click save an validate that the constraints for field "a" were modified
properly.
Signed-off-by: Bernardo Gonzalez Kriegel
All checkboxes work, verified on db
No errors
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #40237|0 |1 is obsolete|| --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 45834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45834&action=edit [SIGNED-OFF] Bug 8643 - Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Fixed small conflict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Rémi Mayrand-Provencher changed: What|Removed |Added Attachment #41264|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643
--- Comment #18 from Rémi Mayrand-Provencher
---
Created attachment 41265
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41265&action=edit
Bug8643 - Removed all uses of CGI::Checkbox in marc_subfields_structure.pl
To test this patch :
1) Apply all patches
2) Run ./installer/data/mysql/updatedatabase.pl
3) Go to More > Administration > MARC bibliographic framework > default
framework ("MARC structure")
4) Search for tag 100 > Click subfields
5) Edit the "a" field and check the "reapeatable","mandatory","important" and
"Is a URL" checkboxes
6) Click save an validate that the constraints for field "a" were modified
properly.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643
--- Comment #17 from Rémi Mayrand-Provencher
---
Created attachment 41264
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41264&action=edit
Did I just make everyone happy =D?
Bug8643 - Removed all uses of CGI::Checkbox in marc_subfields_structure.pl
To test this patch :
1) Apply all patches
2) Run ./installer/data/mysql/updatedatabase.pl
3) Go to More > Administration > MARC bibliographic framework > default
framework ("MARC structure")
4) Search for tag 100 > Click subfields
5) Edit the "a" field and check the "reapeatable","mandatory","important" and
"Is a URL" checkboxes
6) Click save an validate that the constraints for field "a" were modified
properly.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Rémi Mayrand-Provencher changed: What|Removed |Added Attachment #41259|0 |1 is obsolete|| --- Comment #16 from Rémi Mayrand-Provencher --- Created attachment 41261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41261&action=edit Bug8643 - Removed the use of CGI::checkbox for "Important" subfield and duplicate authorized tag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #15 from Rémi Mayrand-Provencher --- Created attachment 41259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41259&action=edit Bug8643 - Removed the use of CGI::checkbox for "Important" subfield and duplicate authorized tag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi --- (In reply to Rémi Mayrand-Provencher from comment #13) > Also, CGI::checkbox is used for other subfields too. I don't think the aim > of this patch is to remove CGI::checkbox from marc_subfields_structure.pl. I discourage patches adding HTML building stuff on the .pl files. It is true that you don't need to remove the existing ones, but please don't add new :-D A followup removing the already present would make people happy too :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Rémi Mayrand-Provencher changed: What|Removed |Added CC||remi.mayrand-provencher@inL ||ibro.com Status|Failed QA |Needs Signoff --- Comment #13 from Rémi Mayrand-Provencher --- The patch applied properly for me, so I do not think that it needs a rebase. Also, CGI::checkbox is used for other subfields too. I don't think the aim of this patch is to remove CGI::checkbox from marc_subfields_structure.pl. Could you be clearer on what are the changes you would like to see in this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Blou changed: What|Removed |Added Assignee|simith.dolive...@inlibro.co |maxime.beaul...@inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Failed QA --- Comment #12 from M. Tompsett --- Oh, and don't added CGI::checkbox! HTML code should be in the template, so it is easier to translate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #11 from M. Tompsett --- Sorry, the Authorized Dropdown is HASH now. I'll attempt to fix later, unless simith.dolive...@inlibro.com wants to post a rebase. That would make everyone happy. I dislike "Patch doesn't apply". :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 M. Tompsett changed: What|Removed |Added Attachment #40232|0 |1 is obsolete|| --- Comment #10 from M. Tompsett --- Created attachment 40237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40237&action=edit Bug 8643 - Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 M. Tompsett changed: What|Removed |Added Attachment #31032|0 |1 is obsolete|| --- Comment #9 from M. Tompsett --- Created attachment 40232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40232&action=edit Bug 8643 - Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Nick Clemens changed: What|Removed |Added CC||n...@quecheelibrary.org Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Nick Clemens --- Applying: Bug 8643 - Add important constraint to marc subfields Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging cataloguing/addbiblio.pl Auto-merging admin/marctagstructure.pl Auto-merging admin/marc_subfields_structure.pl Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 8643 - Add important constraint to marc subfields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 simith.dolive...@inlibro.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #30640|0 |1 is obsolete|| --- Comment #7 from simith.dolive...@inlibro.com --- Created attachment 31032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31032&action=edit Bug 8643 - Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #11622|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Owen Leonard --- Applying: Bug 8643 /home/oleonard/kohaclone/.git/rebase-apply/patch:388: trailing whitespace. Tab:[% subfield.tab %] | $[% subfield.tagsubfield %] warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... :388: trailing whitespace. Tab:[% subfield.tab %] | $[% subfield.tagsubfield %] warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging cataloguing/addbiblio.pl Auto-merging admin/marctagstructure.pl CONFLICT (content): Merge conflict in admin/marctagstructure.pl Auto-merging admin/marc_subfields_structure.pl Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 8643 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 simith.dolive...@inlibro.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #5 from simith.dolive...@inlibro.com --- Created attachment 30640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30640&action=edit Bug 8643 - Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 simith.dolive...@inlibro.com changed: What|Removed |Added CC||francois.charbonnier@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Eric Bégin changed: What|Removed |Added CC||eric.be...@inlibro.com Assignee|pelletiermax...@gmail.com |simith.dolive...@inlibro.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maxime Pelletier changed: What|Removed |Added Assignee|gmcha...@gmail.com |pelletiermax...@gmail.com --- Comment #4 from Maxime Pelletier --- This clearly doesn't apply in master. Will do a new patch someday. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maxime Pelletier changed: What|Removed |Added Attachment #11621|0 |1 is obsolete|| --- Comment #3 from Maxime Pelletier --- Created attachment 11622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11622&action=edit patch with fixed updatedatabase Well sorry for that. New patch without backticks and that doesn't do 2 queries in 1 line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #2 from Jared Camins-Esakov --- Unfortunately the database update does not work. I got the following error message: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ALTER TABLE `marc_tag_structure` ADD COLUMN `important` TINYINT(4) NOT NULL DEFA' at line 2 at installer/data/mysql/updatedatabase.pl line 5640. Upgrade to XXX done (Add mandatory to marc frameworks) Also, please do not use backticks in the updatedatabase.pl script. Although it is a MySQL-only file, Marc Balmer is in the process of making it database-agnostic, so that it will work with Postgres as well. I am very excited to use this feature! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #1 from Maxime Pelletier --- Created attachment 11621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11621&action=edit proposed enhancement patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
