[Koha-devel] Signoff request

2024-04-16 Thread Marcel de Rooy via Koha-devel
Hello all, I need help on the following bugs (signoffs), all related to acquisition, although some marked as architectural: 36002 Koha Acquisit m.de.r...@rijksmuseum.nl Need --- enh Get rid of aqorders.purchaseordernumber 2024-02-06 36018 Koha Architec m.de.r...@rijksmuseum.nl Need --- enh

Re: [Koha-devel] Finding invalid XML characters in Koha data via SQL

2024-04-12 Thread Marcel de Rooy via Koha-devel
+1 Van: Koha-devel namens David Cook via Koha-devel Verzonden: vrijdag 12 april 2024 03:36 Aan: 'Koha-devel' Onderwerp: [Koha-devel] Finding invalid XML characters in Koha data via SQL Hi all, I just wanted to share a (MariaDB) SQL report that I wrote for

Re: [Koha-devel] Random XSLT knowledge

2024-03-11 Thread Marcel de Rooy via Koha-devel
Cool. Nice example. Thanks. From: David Cook Sent: Monday, March 11, 2024 12:27 AM To: Marcel de Rooy ; 'Koha Devel' Subject: RE: [Koha-devel] Random XSLT knowledge Hi Marcel, Sure! Before Koha started using “http://exslt.org/strings” to encode URIs, I used to use register_function to add

Re: [Koha-devel] Random XSLT knowledge

2024-03-07 Thread Marcel de Rooy via Koha-devel
Hi David, Thanks for sharing. Would you have an example of how you use register_function with Koha functions to share? Marcel Van: Koha-devel namens David Cook via Koha-devel Verzonden: vrijdag 8 maart 2024 03:02 Aan: 'Koha Devel' Onderwerp: [Koha-devel]

Re: [Koha-devel] koha SIP" over HTTPS

2024-03-07 Thread Marcel de Rooy via Koha-devel
Look for stunnel. This seems to be the usual way to secure SIP2 traffic. Van: Koha-devel namens Mark Hofstetter via Koha-devel Verzonden: donderdag 7 maart 2024 09:21 Aan: koha-devel@lists.koha-community.org Onderwerp: [Koha-devel] koha SIP" over HTTPS Hi,

Re: [Koha-devel] Koha CSRF protection

2024-03-03 Thread Marcel de Rooy via Koha-devel
Great work! From: Koha-devel On Behalf Of Nick Clemens via Koha-devel Sent: Friday, March 1, 2024 2:26 PM To: Koha Devel ; Koha Subject: [Koha-devel] Koha CSRF protection Hello all! We have pushed the CSRF work from 34478 and related bugs today. We know there are more follow-ups needed,

[Koha-devel] Translation

2024-01-24 Thread Marcel de Rooy via Koha-devel
Hi, I came across this link on opac-detail in our Dutch OPAC: Dalbajewa, Birgit [contributor] As you may see, various class names, attribute names etc. are being translated (while they should not have been translated). In the PO file it just says for instance msgstr "contributor", so things

Re: [Koha-devel] REMINDER: Development IRC meeting 13 December 2023

2023-12-12 Thread Marcel de Rooy via Koha-devel
How late btw? Van: Koha-devel namens Fischer, Katrin via Koha-devel Verzonden: dinsdag 12 december 2023 10:10 Aan: koha-devel@lists.koha-community.org Onderwerp: [Koha-devel] REMINDER: Development IRC meeting 13 December 2023 Hi all, we have a development IRC

[Koha-devel] FW: [Koha] Koha 23.11 released

2023-12-05 Thread Marcel de Rooy via Koha-devel
Great, Tomas! Note btw that I still do not receive a lot of mails on koha-devel on my MS email address (like this one too). Yes, I know what you want to say  Marcel Van: Marcel de Rooy Verzonden: dinsdag 5 december 2023 16:55 Aan: Marcel de Rooy Onderwerp

Re: [Koha-devel] stuck emails to koha-devel?

2023-09-12 Thread Marcel de Rooy
For some time already I do only see a part of the messages via Microsoft 365, and more via Google. "Advanced security"  ? Van: Koha-devel namens Tomas Cohen Arazi Verzonden: maandag 11 september 2023 19:32 Aan: Philippe Blouin CC:

[Koha-devel] Signoff please

2023-07-14 Thread Marcel de Rooy
Hi, My patches below are waiting since May in the NSO queue. Could you have a look plese? Checked if they still apply just yet. 33837 Koha  Architecm.de.r...@rijksmuseum.nl  Need  ---   enh    Objects->filter_by_last_update: Does not allow time comparison2023-05-26 33843 Koha  

Re: [Koha-devel] Tidy your code! And run the QA script!

2023-07-14 Thread Marcel de Rooy
Great job, Tomas. Keep pushing; your queue is not empty yet  As this is the first mention about requiring perl tidied code, I would assume that we will be enforcing it (as QA team) only on code that was submitted from now on. And we need some common sense too imo. We shouldnt reject patches

Re: [Koha-devel] Synchronizing a Koha database with kohastructure.sql (Bug 34064)

2023-06-20 Thread Marcel de Rooy
We already have misc/devel/update_dbix_class_files.pl. Copy your Koha/Schema/Result before running. Or run it on a gitified install. Compare changes. Van: David Cook Verzonden: dinsdag 20 juni 2023 06:36 Aan: 'koha-devel' CC: Marcel de Rooy ; 'Tomas Cohen Arazi

Re: [Koha-devel] A case against our release dates

2023-06-02 Thread Marcel de Rooy
I opt for keeping the release dates as-is. There will be no date that suits everyone. A hackfest in March allows you to sign off on all stuff that gets in the queues after say December, and could reach .05. New devs from the hackfest should not be pushed hastily in the .05 but have all chance

Re: [Koha-devel] Koha 23.05 released

2023-06-01 Thread Marcel de Rooy
Really great, Tomas. Thanks! Van: Koha-devel namens Tomas Cohen Arazi Verzonden: woensdag 31 mei 2023 21:49 Aan: koha-devel Onderwerp: [Koha-devel] Koha 23.05 released The Koha community is proud to announce the release of Koha 23.05.00. Koha 23.05.00 is a

Re: [Koha-devel] Imports leading to case sensitivity issues on branchcode: finish fixing the UI or revert existing UI fix and fix imports problem root?

2023-04-12 Thread Marcel de Rooy
Fixing case in the import seems simpler than doing it everywhere else, I suppose  Marcel Van: Koha-devel namens tuxayo Verzonden: donderdag 13 april 2023 00:39 Aan: koha-devel Onderwerp: Re: [Koha-devel] Imports leading to case sensitivity issues on

[Koha-devel] Koha objects

2023-04-04 Thread Marcel de Rooy
Hi, Just a dumb question. But what is the best way to get a column from a joined table in the results of a Koha objects search? Or is it entirely impossible and should I switch back to DBIx stuff with +columns and the like ? Thanks, Marcel ___

[Koha-devel] Request for signoff

2023-03-02 Thread Marcel de Rooy
Hi all, I could use some help getting two patches further: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Sync comments in database with schema https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32426 Allow plugin to generate userid when creating patrons Thanks in

Re: [Koha-devel] Compiled files removal from source tree

2023-02-16 Thread Marcel de Rooy
Thx Tomas. Whats the plan for stable, oldstable, etc ? Marcel Van: Koha-devel namens Tomas Cohen Arazi Verzonden: vrijdag 10 februari 2023 15:59 Aan: koha-devel Onderwerp: [Koha-devel] Compiled files removal from source tree Hi all, there's been chatter and

[Koha-devel] Bug 31908

2023-01-13 Thread Marcel de Rooy
Hi all, There was a lot of miscommunication and not reading comments etc. on the last security fixes. I forgot to add the keyword for the backports. I did write it on the report and also added a diff. But these were just ignored. Hopefully, we do better next time. To fix 21.11 I added three

Re: [Koha-devel] Formally give up on trying to provide PostgreSQL DB support?

2022-12-07 Thread Marcel de Rooy
Yes, we already gave up years ago. But we never said so  Van: Koha-devel namens Fridolin SOMERS Verzonden: dinsdag 6 december 2022 22:37 Aan: koha-devel@lists.koha-community.org Onderwerp: Re: [Koha-devel] Formally give up on trying to provide PostgreSQL DB

Re: [Koha-devel] Good enough?

2022-12-05 Thread Marcel de Rooy
%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=bxdii78avAYEIcecc8o0tQZ4v7atwVTkmbJMYPe1Dek%3Dreserved=0 Le lun. 5 déc. 2022 à 11:34, Marcel de Rooy a écrit : > > Could you provide more info on those git hooks? A wiki URL? > > Marcel >

Re: [Koha-devel] Good enough?

2022-12-05 Thread Marcel de Rooy
Could you provide more info on those git hooks? A wiki URL? Marcel -Original Message- From: Koha-devel On Behalf Of Jonathan Druart Sent: Friday, December 2, 2022 3:43 PM To: koha-devel Subject: [Koha-devel] Good enough? Hi devs, I was wondering... How good is your "good enough"?

[Koha-devel] FW: ERM - workflow change

2022-11-10 Thread Marcel de Rooy
notice: Changes not staged for commit: modified: package.json modified: yarn.lock Untracked files: package-lock.json How should we handle those? Marcel Van: Marcel de Rooy Verzonden: donderdag 10 november 2022 08:50 Aan: Jonathan Druart

Re: [Koha-devel] ERM - workflow change

2022-11-09 Thread Marcel de Rooy
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'build_js' Van: Jonathan Druart Verzonden: donderdag 10 november 2022 08:39 Aan: Marcel de Rooy CC: Koha Devel Onderwerp: Re: [Koha-devel] ERM - workflow change Run the yarn commands at the root

Re: [Koha-devel] ERM - workflow change

2022-11-09 Thread Marcel de Rooy
Does this need some envvar for a path to the Koha's package.json or so ? When I ran yarn build_js, I did not have any valuable results. Van: Koha-devel namens Renvoize, Martin Verzonden: woensdag 9 november 2022 18:33 Aan: Koha Devel Onderwerp: Re:

[Koha-devel] Sign off request

2022-07-06 Thread Marcel de Rooy
Hi all, This is about bug 30933 Add a designated owner for shared and public lists at patron deletion It is imo a nice extension to the two PQA list bugs 11889 and 25498. But it still needs a signoff ! And after that some QA

Re: [Koha-devel] My dev list for 22.05

2021-12-17 Thread Marcel de Rooy
Sorry for the delay. I already responded to your points. But here are a few points from me. Note that a list like this is just like a photograph. I need help on the following bugs (signoffs): Without advertizing them, some even very small patches unfortunately may be in the NSO queue for

Re: [Koha-devel] Fwd: Rabbitmq

2021-11-16 Thread Marcel de Rooy
sues with rabbit failing to start. >> See also https://github.com/ONLYOFFICE/Docker-DocumentServer/issues/92 >> Seems that ktd could use it too ? >> >> Marcel >> -- Forwarded message - >> Van: Marcel de Rooy >> Date: di 16 nov. 2021 om

[Koha-devel] Fwd: Rabbitmq

2021-11-16 Thread Marcel de Rooy
ICE/Docker-DocumentServer/issues/92 Seems that ktd could use it too ? Marcel -- Forwarded message - Van: Marcel de Rooy Date: di 16 nov. 2021 om 14:11 Subject: Rabbitmq To: koha-devel Hi all, Nobody seeing things like this? mkdir: cannot create directory ‘/var/run/rabbitmq’: Permiss

Re: [Koha-devel] Rabbitmq

2021-11-16 Thread Marcel de Rooy
No. In a Docker container with a gitified package install. Op di 16 nov. 2021 om 14:27 schreef Jonathan Druart < jonathan.dru...@bugs.koha-community.org>: > Are you seeing this in koha-testing-docker? > > Le mar. 16 nov. 2021 à 14:11, Marcel de Rooy a > écrit : > > &g

[Koha-devel] Rabbitmq

2021-11-16 Thread Marcel de Rooy
Hi all, Nobody seeing things like this? mkdir: cannot create directory ‘/var/run/rabbitmq’: Permission denied Failed to create directory: /var/run/rabbitmq /usr/lib/rabbitmq/bin/rabbitmq-server: 51: /usr/lib/rabbitmq/bin/rabbitmq-server: cannot create /var/run/rabbitmq/pid: Permission denied

Re: [Koha-devel] New developers at BibLibre

2021-09-10 Thread Marcel de Rooy
Great! Welcome, bienvenue ! xxx ​Please think before you print Van: Koha-devel namens Paul Poulain Verzonden: vrijdag 10 september 2021 11:14 Aan: koha-devel@lists.koha-community.org CC: marion.dur...@biblibre.com ; florian.bonte...@biblibre.com ;

[Koha-devel] System administration, permissions and the like

2021-09-10 Thread Marcel de Rooy
Hi all, A discussion on bug 28882 triggered me to open the following reports: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28989 Allow viewing systempreferences only https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990 Allow changes for a configurable subset of

Re: [Koha-devel] Monthly Community Meeting

2021-09-02 Thread Marcel de Rooy
Semi annual voting on new roles too ? Op wo 1 sep. 2021 om 16:31 schreef Renvoize, Martin < martin.renvo...@ptfs-europe.com>: > Hi all, > > We had our monthly general meeting today, as usual, hosted on IRC. > Attendance has been very low for a while now and we mooted the idea of > dropping it

[Koha-devel] Bug 28705 Article requests / renewal

2021-07-14 Thread Marcel de Rooy
Hi all, Submitted a POC patch for checking current article requests when renewing an item. Would appreciate any feedback before finishing up. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Marcel ___ Koha-devel mailing list

[Koha-devel] QA tools

2021-07-08 Thread Marcel de Rooy
Tiny bug in QohA/File/Template.pm for template dir (OPAC) sub check_valid_template $template_dir = File::Spec->rel2abs("koha-tmpl/$interface/prog/en/modules"); This is wrong, but the variable is no longer used. Can be removed. ___ Koha-devel

Re: [Koha-devel] False qa tools warning?

2021-06-29 Thread Marcel de Rooy
25 juni 2021 16:11 Aan: Marcel de Rooy CC: koha-devel Onderwerp: Re: [Koha-devel] False qa tools warning? I've answered on the bug report. It's a valid error. Le lun. 21 juin 2021 à 15:37, Marcel de Rooy a écrit : > > Hi all, > > I am looking at bug 27944 and see the follo

[Koha-devel] Request for two signoffs

2021-06-25 Thread Marcel de Rooy
Hi all, The following two bugs have been waiting for attention for some time already: Bug 20310 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Article requests: Can we redirect article records without items to host record? Has been adjusted after earlier feedback. Bug 26302

[Koha-devel] False qa tools warning?

2021-06-21 Thread Marcel de Rooy
Hi all, I am looking at bug 27944 and see the following qa warn: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid FAIL valid_template

Re: [Koha-devel] Follow-up patches and why not to use them

2021-06-18 Thread Marcel de Rooy
Yeah I probably missed it while catching up ;) What you say makes sense, but the problem probably boils down to the gap between theory and practice. Op vr 18 jun. 2021 om 09:36 schreef Joonas Kylmälä < joonas.kylm...@helsinki.fi>: > Hi Marcel, > > On 18/06/2021 09:45, Marce

Re: [Koha-devel] Follow-up patches and why not to use them

2021-06-18 Thread Marcel de Rooy
Agree with Julian here. It depends. You could squash follow-up patches yourself too before reverting them? In some cases patches tell us a nice story, in a lot of cases it might be confusing or messy.. RIJKS MUSEUM ​T/m 18 jaar gratis ​ ​Kijk hier de nieuwste

[Koha-devel] pqf.properties / Zebra / Z3950

2021-06-18 Thread Marcel de Rooy
Hi all, Looking at bug 8280. I am wondering why we should have two pqf.properties files. They are already not exactly the same. Could we let the new daemon use the pqf file from the Zebra folder ? Marcel ___ Koha-devel mailing list

Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins

2021-04-09 Thread Marcel de Rooy
Hi Victor, I will be addressing your question on the bug itself. Marcel ​T/m 18 jaar gratis ​ ​Kijk hier de nieuwste aflevering van Rijksmuseum Unlocked x! xxx ​Please think before you print Van: Koha-devel namens Victor Grousset/tuxayo Verzonden:

Re: [Koha-devel] REST API / MARC fields

2021-01-22 Thread Marcel de Rooy
: Marcel de Rooy CC: koha-devel Onderwerp: Re: [Koha-devel] REST API / MARC fields We could have a route to overlay the MARC representation of a biblio (if acceptable). We could use PATCH /biblios/:biblio_id Content-Type: application/marc-in-json { ... El vie., 22 ene. 2021 6:20, Marcel de Rooy

[Koha-devel] REST API / MARC fields

2021-01-22 Thread Marcel de Rooy
Hi all, Any thoughts here about how we should handle updating fields in MARC which have no specific corresponding database field. I am thinking about e.g. a persistent identifier in MARC21 field 024 or an OCLC number in field 035. Could we add REST API entries for such changes as well? They will

[Koha-devel] Signoff request

2020-07-29 Thread Marcel de Rooy
Hi all, I submitted patches on bug 20472. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 Add digital scan as optional format to Article Requests Please have a look. More work to follow. Marcel ___ Koha-devel mailing list

[Koha-devel] sample_notices.yml instead of sql

2020-07-28 Thread Marcel de Rooy
Hi all, What is the current procedure around changing notices and translation? I see that we have an English yml file, but I see sql files in the translated languages. Like de-DE/mandatory/sample_notices.sql We dont have a coding guideline yet about this. Should it be added? If I change an

[Koha-devel] Persistent identifiers in MARC record?

2020-07-20 Thread Marcel de Rooy
Hi all, Last couple of weeks I had a discussion with David about this subject on bug 24544. Please see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544 What do you think? If your authority, biblio or item has a PID, should we save it in MARC too? Noting that MARC is just a

Re: [Koha-devel] Deploying Koha at scale

2020-06-12 Thread Marcel de Rooy
+! Sounds very promising ! ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs :

[Koha-devel] Room Booking RFC

2020-06-08 Thread Marcel de Rooy
Hi all, I stumbled over this RFC: https://wiki.koha-community.org/wiki/RoomBookingRFC It appears that Kyle wrote it in 2017? Is there any news on this front? It might be even more interesting due to corona restrictions? Thanks, Marcel ___ Koha-devel

[Koha-devel] Just a test

2020-01-30 Thread Marcel de Rooy
Testing from another address. ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs :

[Koha-devel] Signoff request for bug 21190 [GDPR logging]

2020-01-30 Thread Marcel de Rooy
Hi, See bug 21190. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 GDPR: Log successful/unsuccessful login attempts [part 1] Some people asked for it. I wrote something. I do not really need it myself. I waited three months, but to no avail. This is my last resort ;) If you

[Koha-devel] Coding guidelines

2020-01-29 Thread Marcel de Rooy
Referring to the dev meeting and bug 22407, I propose the following rewording: PERL15 Using Koha::Object[s] PERL15(a) Code added to the Koha:: namespace should be object-oriented unless there is a very good reason to do otherwise. In that case the reason should be documented clearly. PERL15(b)

Re: [Koha-devel] [Koha] run koha without mpm_itk

2020-01-21 Thread Marcel de Rooy
Would this be interesting too for containerization? Make it possible to run Koha in Docker without cap-add's ? ​Museumstraat 1 Postbus 74888 1070 DN Amsterdam Rijksmuseum.nl ​ ​Nu te zien: ​Rembrandt-Velázquez. Nederlandse & Spaanse meesters Document Nederland: Martijn van de Griendt

Re: [Koha-devel] Koha 19.11.00 Released

2019-12-02 Thread Marcel de Rooy
Great job! Thanks. ​Museumstraat 1 Postbus 74888 1070 DN Amsterdam Rijksmuseum.nl ​ ​Nu te zien: ​Rembrandt-Velázquez. Nederlandse & Spaanse meesters Louise Bourgeois in de Rijksmuseumtuinen Rineke Dijkstra: Night Watching Document Nederland: Martijn van de Griendt ON/OFF Operatie

Re: [Koha-devel] mariadb versions and koha

2019-11-06 Thread Marcel de Rooy
See also the discussion on the dev meeting of Nov 6 now. I just saw another bug (23960) about an issue with MariaDB 10.3. Can't we add a keyword in Bugzilla to mark such ones to find them back easier ? sql_version_dependent or something ? ​Museumstraat 1 Postbus 74888 1070 DN Amsterdam

Re: [Koha-devel] API use in intranet and OPAC

2019-10-07 Thread Marcel de Rooy
Yeah I guess we reached the point that we just need javascript in OPAC ? ​Museumstraat 1 Postbus 74888 1070 DN Amsterdam Rijksmuseum.nl ​ ​Nu te zien: ​​​Louise Bourgeois in de Rijksmuseumtuinen ​Operatie Nachtwacht ​ ​Verwacht: ​Rembrandt-Velázquez. Nederlandse & Spaanse meesters ​ ​ ​T/m 18

Re: [Koha-devel] API use in intranet and OPAC

2019-10-07 Thread Marcel de Rooy
ean footprint, there would have been a fuzzy figure resembling a space suit trying to get up. Marcel de Rooy, the generous soul who passedQA the solution patch, complained (and he was absolutely right) about a couple of things: 1. That there was no comunication about this in dev channel before impl

Re: [Koha-devel] A case against some uses of C4::Context->userenv

2019-09-28 Thread Marcel de Rooy
Sounds good to me. But as you know, refactoring a large codebase is a tedious process. ​Museumstraat 1 Postbus 74888 1070 DN Amsterdam Rijksmuseum.nl ​ ​Nu te zien: ​​12x Erwin Olaf ​Louise Bourgeois in de Rijksmuseumtuinen ​Operatie Nachtwacht ​ ​T/m 18 jaar

Re: [Koha-devel] [Koha] Koha 19.05.00 Released

2019-05-30 Thread Marcel de Rooy
Great, Nick. Congrats. Please correct the link to the release notes btw. https://koha-community.org/koha-19-05-release/ Marcel Van: koha-devel-boun...@lists.koha-community.org namens Joy Nelson Verzonden: donderdag 30 mei 2019 18:10 Aan: Lucas Gass CC:

[Koha-devel] Signoff request

2019-04-26 Thread Marcel de Rooy
Hi all, I have a few bugs waiting for quite some time in the queue and I need your help to get them further. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310 Article requests Just 3 simple patches Wrote them more than a year ago, last rebase May 2018

Re: [Koha-devel] koha-testing-docker - production use

2019-04-18 Thread Marcel de Rooy
Hi Waylon, I am running Koha from debian stretch slim container (with a mariadb container based on Ubuntu). For Koha choosing Debian is always safer. I had to allow two kernel privileges to get things working at 'docker run' time to start the Koha container: --cap-add=SYS_NICE

Re: [Koha-devel] Cache::Memory must be removed (21955)

2018-12-21 Thread Marcel de Rooy
Look at XSLT_Handler ? Van: koha-devel-boun...@lists.koha-community.org namens Paul Poulain Verzonden: vrijdag 21 december 2018 17:01 CC: koha-devel Onderwerp: Re: [Koha-devel] Cache::Memory must be removed (21955) Great, thanks ! An idea: couldn't we also

Re: [Koha-devel] Cache::Memory must be removed (21955)

2018-12-05 Thread Marcel de Rooy
+1 Van: koha-devel-boun...@lists.koha-community.org namens Jonathan Druart Verzonden: woensdag 5 december 2018 20:20:35 Aan: koha-devel Onderwerp: [Koha-devel] Cache::Memory must be removed (21955) Hi devs, I am still recovering from my holidays and I think

Re: [Koha-devel] What is biblioitemnumber for?

2018-11-19 Thread Marcel de Rooy
Three levels in BIBFrame again ? Van: koha-devel-boun...@lists.koha-community.org Namens Tomas Cohen Arazi Verzonden: maandag 19 november 2018 14:02 Aan: Paul Poulain CC: koha-devel Onderwerp: Re: [Koha-devel] What is biblioitemnumber for? Great info, Paul! We now removed the marc/marcxml

[Koha-devel] Signoff request

2018-11-14 Thread Marcel de Rooy
Hi all, Please help getting bug 21774 into the next release by signing off. Marked as critical last week. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21774 Thanks, Marcel ___ Koha-devel mailing list Koha-devel@lists.koha-community.org

Re: [Koha-devel] New Rest API RFCs

2018-10-23 Thread Marcel de Rooy
+1 Just glacing through I saw external_id for barcode. Not sure if that is a good choice btw. I do not recognize external as meaning barcode, rfid or qr code. What about something with tag, label ? And id or code ? Checkout availability is kind of a hard term to me? Loanable ? And

Re: [Koha-devel] QA script is now able to catch missing filters!

2018-10-02 Thread Marcel de Rooy
Great ! ___ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs :

Re: [Koha-devel] git trailers: should we use more of them ?

2018-09-19 Thread Marcel de Rooy
> Should we use Reported-By ? Could be added optionally imo. No problem. Replace By with by btw. > Should we replace Signed-off-by by Tested-By (for testers) and Reviewed-By > (for QA) ? > Should we use Signed-off-by as suggested in the git-commit manpage ? Bit late in the project to make this

[Koha-devel] Dashboard

2018-05-25 Thread Marcel de Rooy
I like the Koha dashboard, but I would not mind if someone else (...) removed the patch status changes box and the patches pushed for release 18.05 list. (The last one is not updated in a longer time.) Removing should not be that hard for the maintainer himself ? I am focusing on Koha in the

Re: [Koha-devel] Roles for 18.11 | REST API 'module maintainer'

2018-05-09 Thread Marcel de Rooy
+1 # REST API needs to move forward ___ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs :

[Koha-devel] Signoff

2018-05-07 Thread Marcel de Rooy
Hi all, Would be nice to see two small bug fixes still get further this week: Bug 11943 Prevent double accepts in Koha::Virtualshelfshare https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Bug 20695 Upload does not show all results when uploading multiple files

Re: [Koha-devel] Koha now requires Perl 5.20

2018-04-17 Thread Marcel de Rooy
5.20 is the perl version on Jessie. And we stopped supporting Wheezy. I am not even sure if Koha still really supported 5.10. Here and there some higher language level constructs may have sneaked in. Imo no need to revert; this is just formalizing the current state of things. If people run older

Re: [Koha-devel] [Koha] RFC for MARC holdings record support

2018-04-06 Thread Marcel de Rooy
If I am reading about possible impact on holds functionality, I guess that we could better prioritize finishing REST API and moving to DBIx/Koha::Object. ___ Koha-devel mailing list Koha-devel@lists.koha-community.org

[Koha-devel] Two authority reports that need your help

2018-02-19 Thread Marcel de Rooy
Hi all, I need some help on two authority reports. [1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 Auth_subfield_structure changes hidden attribute Marked Major. Easy patch that deals with the logic to display or hide authority subfields. The current situation may turn hidden

Re: [Koha-devel] 0000-00-00 is expired?

2018-02-14 Thread Marcel de Rooy
Sounds to me like NULL was meant ? Using -12-31 resulted in expensive date calculations previously. Van: koha-devel-boun...@lists.koha-community.org namens Jonathan Druart

Re: [Koha-devel] Plack only

2018-02-06 Thread Marcel de Rooy
+1 Implicitly we came there Van: koha-devel-boun...@lists.koha-community.org namens Tomas Cohen Arazi Verzonden: dinsdag 6 februari 2018 14:31:47 Aan: koha-devel Onderwerp: [Koha-devel] Plack

Re: [Koha-devel] Bug 18539 - Forbid Koha::Objects->find calls in list context

2017-12-13 Thread Marcel de Rooy
Find is supposed for retrieving one result not multiple ones. Use search instead. Using find in a list context is not correct. Van: koha-devel-boun...@lists.koha-community.org namens Julian Maurice

Re: [Koha-devel] Test: planned count or done_testing()

2017-11-15 Thread Marcel de Rooy
Less strict, but more pragmatic. I think we spend more time on rebasing test counts than we will probably spend on checking tests that passed but should have failed on counts. We can always add a count where we really want it. No objection from me.

Re: [Koha-devel] Vote request for Bug 18483 Customised help: Enhance staff client with news based, easily editable help system (Passed QA -> In Discussion)

2017-10-30 Thread Marcel de Rooy
> The Enhancement was ready for Sign off on 2017-04-30, was signed off on > 2017-05-02, and, after some discussion, passed QA on 2017-10-27, and the same > day was set to "In Discussion". Can imagine that it does not make you very happy ;) It obviously is rather sad that patches are sitting so

Re: [Koha-devel] BibLibre new staff & intern

2017-10-12 Thread Marcel de Rooy
Great news, Paul. Welcome Victor ! -Oorspronkelijk bericht- Van: koha-devel-boun...@lists.koha-community.org [mailto:koha-devel-boun...@lists.koha-community.org] Namens Paul Poulain Verzonden: donderdag 12 oktober 2017 12:31 Aan: koha-devel@lists.koha-community.org CC:

Re: [Koha-devel] Request for SO: Koha to MARC mappings

2017-10-04 Thread Marcel de Rooy
> I’m afraid this is getting too time consuming. After 15 minutes, I’m still > not sure where I’m supposed to start. I’ve applied 10306 in preparation for > applying 19096, but I don’t know if I’m supposed to do some set up first from > 10306 before applying 19096 or starting its tet plans.

[Koha-devel] Request for SO: Koha to MARC mappings

2017-10-03 Thread Marcel de Rooy
Hi all, I wrote a few reports for extending Koha to MARC mappings to allow for multiple mappings (e.g. map 260c and 264c to copyrightdate). The first part bug 10306 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 is waiting for QA. The second part bug 19096

Re: [Koha-devel] QA sprint day - Friday, September 1st

2017-08-30 Thread Marcel de Rooy
Great ;) Why not start with signing off https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 ? Van: koha-devel-boun...@lists.koha-community.org namens Jonathan Druart

[Koha-devel] [SIGNED_OFF] labels

2017-08-25 Thread Marcel de Rooy
Hi all, I would favor stopping the use of adding [SIGNED_OFF] labels to patches when it is not strictly needed (which normally is the case). Only when (exceptionally) a few patches are signed and a few are not on one report, I could see its use. At this moment they need to be obsoleted

Re: [Koha-devel] FW: Where is the BIG RED WARNING button?

2017-08-11 Thread Marcel de Rooy
+1 for improving the dashboard Instead of listing the oldest bugs, which may not be that interesting, we should list the critical ones on top. The need to click on that line should be removed. See them rightaway. Maybe we can put these oldies somewhere down on the page in order to not forget

Re: [Koha-devel] MARC frameworks in Koha

2017-08-10 Thread Marcel de Rooy
> Christopher got me thinking: For 260 and 264 are repeatable, as a side effect > of cataloguing rule changes, they might even appear both in a record (even if > they shouldn't). Which year will be given priority? For display purposes in > the brief views, only one year should be displayed.

Re: [Koha-devel] MARC frameworks in Koha

2017-08-09 Thread Marcel de Rooy
> Thank you for clarifying my understanding. It sounds like Koha will > simultaneously pull and display copyright date information from more than one > MARC subfield and that's great. What would happen if a MARC record only has, > for example, a 264$c and no 260$c? Will Koha throw an error if

[Koha-devel] FW: Where is the BIG RED WARNING button?

2017-08-09 Thread Marcel de Rooy
> As written in it, without an agreement we will find all together, no new > enhancements are going > to be pushed. I am not sure which 'agreement' you are seeking here. The time for a critical bug to become part of master, just depends on involvement of people and the publicity made for it

Re: [Koha-devel] MARC frameworks in Koha

2017-08-09 Thread Marcel de Rooy
> Thank you for seeking input from the Koha Community before making this > decision. Thanks for responding :) > If I understand your message correctly, you are saying that if the "Default" > MARC framework has kohafield mappings which are configured to pull copyright > date from MARC 260$c

[Koha-devel] MARC frameworks in Koha

2017-08-07 Thread Marcel de Rooy
Hi developers or librarians, If you are interested in say sorting search results or lists by publication date based on 260 and RDA 264, please read further. OR If you use varying kohafield mappings across your MARC frameworks. Say you connected biblio.copyrightdate to 260$c in framework A, but

[Koha-devel] QA Tools

2017-08-03 Thread Marcel de Rooy
Hi Jonathan, Got this warning from qa tools: POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Looking at the code in qa tools, I come across: } elsif ( $before->{rating} > $after->{rating} ) { # Not sure we can reach this

Re: [Koha-devel] OpacHiddenItems behaviour | Bug 10584

2017-07-27 Thread Marcel de Rooy
> Is this a desired behaviour? Should biblios be hidden if all items they > contain are marked to be hidden? I would say No. This should not be the general rule, I guess. But I feel another pref coming soon ;) Marcel ___ Koha-devel mailing list

[Koha-devel] FW: AUTO_INCREMENT fix - prevent data lost

2017-07-21 Thread Marcel de Rooy
Added bug 18970 for the test each new issue id - approach. Van: Marcel de Rooy Verzonden: vrijdag 21 juli 2017 07:58 Aan: koha-devel@lists.koha-community.org Onderwerp: Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost Not sure if 18966 is the way to go

Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

2017-07-20 Thread Marcel de Rooy
Not sure if 18966 is the way to go, "halting the system" until we fixed the autoincrement. The solution of merging the tables, as David refers to, is the ideal one, but it seems too big to implement right now, as we need to fix stable branches right now. The renumbering fix depended on

Re: [Koha-devel] Public list permissions

2017-07-05 Thread Marcel de Rooy
David, List permissions have been discussed regularly. What always comes up, is the privacy issue (especially on private lists). Seems to me that adding a granular permission like Change contents of public lists like we have Delete public lists already would not be that controversial.

Re: [Koha-devel] Suggestions requested for a feature / enhancement based around opac-retrieve-file.pl

2017-06-26 Thread Marcel de Rooy
Sounds as an acceptable improvement. Could be handled with a syspref of course. Would be the easiest solution to implement. But we could also extend the meaning of Public here. And make a division between Private, Restricted and Public. Restricted could be handled by allowing patron types, as

Re: [Koha-devel] HEA : Error whith the script share_usage_with_koha_community.pl -f

2017-06-22 Thread Marcel de Rooy
HEA changed from http to https. I got the same error. Please check if your UsageStats.pm still contains http. Van: koha-devel-boun...@lists.koha-community.org [mailto:koha-devel-boun...@lists.koha-community.org] Namens BOUIS Sonia Verzonden: donderdag 22 juni 2017 10:34 Aan:

Re: [Koha-devel] [QA] QA sprint needed

2017-06-06 Thread Marcel de Rooy
> * Bug 17600 - Standardize the EXPORT > Needing QA we need it ASAP to know if it is the way to go and catch errors. One of the first on my list . ___ Koha-devel mailing list Koha-devel@lists.koha-community.org

  1   2   3   4   >