Re: hi, may I ask some help on the paravirtualization of KVM?

2010-03-23 Thread Amit Shah
On (Sun) Mar 21 2010 [20:18:53], Liang YANG wrote: I want to set up the virtio-net for the GuestOS on KVM. Following is my steps: 1.Compile the kvm-88 and make, make install. 2.Compile the GuestOS(redhat) with kernel version 2.6.27.45(with virtio support). The required option are all

Re: Question on copy paste

2010-04-15 Thread Amit Shah
On (Thu) Apr 15 2010 [08:45:23], Stephen Liu wrote: Hi folks, host - Debian 5.04 What will the easy way to enable copy_and_paste function between guest and hosts? Also among guests. TIA This doesn't exist yet, but something should be available in a few months. Amit --

Re: [PATCH] vhost-net: fix reversed logic in mask notifiers

2010-05-25 Thread Amit Shah
it to mask the vector. This, unless vector is already masked which unassigns irqfd already. The logic in unassign was reversed, which left kvm irqfd assigned. This patch is qemu-kvm only as irqfd is not upstream. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reported-by: Amit Shah amit.s

Re: Multiple Port Support for virtio-console

2009-09-10 Thread Amit Shah
On (Wed) Sep 09 2009 [13:41:59], Amit Shah wrote: Hello all, Here is a new iteration of the patch series that implements a transport for guest and host communications. I've tested for compatibility (old qemu new kernel, new qemu old kernel, new qemu new kernel) and it all works fine

Re: eepro100.c

2009-09-22 Thread Amit Shah
On (Tue) Sep 22 2009 [13:31:11], Michal Filka wrote: I don't want to corrupt present kvm installation, or better to say, I want to modify it as small as possible. Could you suggest me what should I replace or how to run new compilation instead of old one without installing? You can

Re: Release plan for 0.12.0

2009-09-29 Thread Amit Shah
On (Tue) Sep 29 2009 [18:54:53], Anthony Liguori wrote: Hi, Now that 0.11.0 is behind us, it's time to start thinking about 0.12.0. I'd like to do a few things different this time around. I don't think the -rc process went very well as I don't think we got more testing out of it. I'd

Re: Release plan for 0.12.0

2009-09-30 Thread Amit Shah
On (Wed) Sep 30 2009 [08:04:17], Anthony Liguori wrote: Amit Shah wrote: On (Tue) Sep 29 2009 [18:54:53], Anthony Liguori wrote: o multiport virtio-console support Assuming we can get the kernel drivers straightened out, I think it's certainly reasonable for 0.12. The kernel

Re: Release plan for 0.12.0

2009-09-30 Thread Amit Shah
On (Wed) Sep 30 2009 [09:47:22], Anthony Liguori wrote: Amit Shah wrote: On (Wed) Sep 30 2009 [08:04:17], Anthony Liguori wrote: Amit Shah wrote: On (Tue) Sep 29 2009 [18:54:53], Anthony Liguori wrote: o multiport virtio-console support Assuming we can get the kernel

Re: [Alacrityvm-devel] [PATCH v2 2/4] KVM: introduce xinterface API for external interaction with guests

2009-10-06 Thread Amit Shah
On (Tue) Oct 06 2009 [11:18:59], Ira W. Snyder wrote: The limitation I have is that memory made available from the host system (PCI card) as PCI BAR1 must not be migrated around in memory. I can only change the address decoding to hit a specific physical address. AFAIK, this means it cannot

Re: [PATCH 1/2] virtio: Add detach unused buffer from vring

2009-12-24 Thread Amit Shah
will be the first user. Signed-off-by: Shirley Ma x...@us.ibm.com Acked-By: Amit Shah amit.s...@redhat.com Amit -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/2] virtio_net: Defer skb allocation in receive path

2009-12-24 Thread Amit Shah
On (Thu) Dec 17 2009 [23:44:49], Shirley Ma wrote: virtio_net receives packets from its pre-allocated vring buffers, then it delivers these packets to upper layer protocols as skb buffs. So it's not necessary to pre-allocate skb for each mergable buffer, then frees extra skbs when buffers

Re: [PATCH v2 -mm 0/2] x86: per-device dma_mapping_ops

2008-05-22 Thread Amit Shah
On Monday 19 May 2008 12:01:27 FUJITA Tomonori wrote: This is an updated version of the patchset to add per-device dma_mapping_ops support for CONFIG_X86_64 like POWER architecture does: http://lkml.org/lkml/2008/5/13/36 This is against 2.6.26-rc2-mm1 (the changes since the v1 are pretty

Re: PVDMA interrupt injection fix.

2008-05-25 Thread Amit Shah
[Use the new kvm list address] On Thursday 22 May 2008 18:22:43 Ben-Ami Yassour wrote: Amit, Attached is a fix for pvdma interrupt injection, and it seems to work fine with an e1000 NIC. The interrupt injection is generic for pci-passthrough and not just for pvdma (it'll work the same for

Re: PCI-passthrough: interrupt work structure per device

2008-05-29 Thread Amit Shah
On Thursday 29 May 2008 23:39:37 Mark McLoughlin wrote: @@ -184,16 +190,27 @@ out: static irqreturn_t kvm_pci_pt_dev_intr(int irq, void *dev_id) { struct kvm *kvm = (struct kvm *) dev_id; + struct kvm_pci_pt_dev_list *pci_pt_dev; if (!test_bit(irq, pt_irq_handled))

[PATCH 1/3] KVM: Expose get_eoi_gsi for IRQ acking for assigned devices.

2008-05-30 Thread Amit Shah
Also add kvm_ prefix. Signed-off-by: Amit Shah [EMAIL PROTECTED] --- virt/kvm/ioapic.c |4 ++-- virt/kvm/ioapic.h |1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index 99a1736..4c41a00 100644 --- a/virt/kvm/ioapic.c +++ b/virt

[PATCH 3/3] KVM: Handle devices assigned to the guest

2008-05-30 Thread Amit Shah
From: Amit Shah [EMAIL PROTECTED] From: Ben-Ami Yassour [EMAIL PROTECTED] This patch adds support for handling PCI devices that are assigned to the guest (PCI passthrough). The device to be assigned to the guest is registered in the host kernel and interrupt delivery is handled. It is expected

[PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest

2008-06-02 Thread Amit Shah
From: Or Sagi [EMAIL PROTECTED] From: Nir Peleg [EMAIL PROTECTED] From: Amit Shah [EMAIL PROTECTED] From: Glauber de Oliveira Costa [EMAIL PROTECTED] We can assign a device from the host machine to a guest. The original code comes from Neocleus. A new command-line option, -pcidevice is added

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest

2008-06-02 Thread Amit Shah
On Monday 02 June 2008 19:27:31 Anthony Liguori wrote: Amit Shah wrote: We can assign a device from the host machine to a guest. The original code comes from Neocleus. A new command-line option, -pcidevice is added. For example, to invoke it for an Ethernet device sitting at PCI

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest

2008-06-04 Thread Amit Shah
On Wednesday 04 June 2008 19:49:21 Avi Kivity wrote: Amit Shah wrote: Dynamically unbinding devices is prone to a lot of errors and assumptions and such policy shouldn't be enforced. We should either fail the assignment and let the administrator take care of doing the right thing

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest

2008-06-04 Thread Amit Shah
On Wednesday 04 June 2008 20:23:53 Avi Kivity wrote: Amit Shah wrote: I was thinking of putting the device in suspend state. However, I checked a few drivers and not all release resources during suspend. However, even if this is possible, it becomes an enforced policy that a user may

Re: PCI PT: irq issue

2008-06-23 Thread Amit Shah
On Monday 23 June 2008 11:34:43 Han, Weidong wrote: Amit Shah wrote: Amit, it doesn't work with VT-d even passing correct IRQ. The output is as follows: irq 16: nobody cared (try booting with the irqpoll option) Pid: 0, comm: swapper Not tainted 2.6.26-rc3-00988-g6d9586a-dirty #5 Call

Re: [PATCH 3/4][VTD] vt-d hooks in generic KVM sources

2008-06-23 Thread Amit Shah
On Saturday 21 June 2008 10:27:50 Han, Weidong wrote: Avi Kivity wrote: Kay, Allen M wrote: vt-d hooks in generic KVM sources for mapping guest memory with vt-d page table. Signed-off-by: Allen M. Kay [EMAIL PROTECTED] diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile

Re: PCI PT: irq issue

2008-06-23 Thread Amit Shah
On Saturday 21 June 2008 09:41:18 Han, Weidong wrote: Amit Shah wrote: A couple of notes for the VT-d patch: - The pci_dev struct is now available in the pci_pt kernel structure, so just use that information each time you want to add a device instead of searching for it each time

Re: PCI PT: irq issue

2008-06-24 Thread Amit Shah
On Monday 23 June 2008 20:46:18 Han, Weidong wrote: Amit Shah wrote: On Saturday 21 June 2008 09:41:18 Han, Weidong wrote: Amit Shah wrote: A couple of notes for the VT-d patch: - The pci_dev struct is now available in the pci_pt kernel structure, so just use that information each time

PCI device assignment to guests

2008-06-25 Thread Amit Shah
This patchset introduces support for assigning PCI devices to guests (kernel part). The main difference from the last version is reserving the PCI device for our exclusive use so that multiple device assignment will fail, as will device assignment when a driver for the device being assigned

[PATCH 1/3] KVM: Introduce kvm_set_irq to inject interrupts in guests

2008-06-25 Thread Amit Shah
This function injects an interrupt into the guest given the kvm struct, the (guest) irq number and the interrupt level. Signed-off-by: Amit Shah [EMAIL PROTECTED] --- arch/x86/kvm/irq.c | 11 +++ arch/x86/kvm/irq.h |2 ++ 2 files changed, 13 insertions(+), 0 deletions(-) diff

[PATCH 2/3] KVM: Introduce a callback routine for IOAPIC ack handling

2008-06-25 Thread Amit Shah
This will be useful for acking irqs of assigned devices Signed-off-by: Amit Shah [EMAIL PROTECTED] --- virt/kvm/ioapic.c |3 +++ virt/kvm/ioapic.h |1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index 9d02136..4759d77 100644

Re: [PATCH 2/3] KVM: Introduce a callback routine for IOAPIC ack handling

2008-06-25 Thread Amit Shah
On Wednesday 25 June 2008 12:49:39 Amit Shah wrote: This will be useful for acking irqs of assigned devices Signed-off-by: Amit Shah [EMAIL PROTECTED] --- virt/kvm/ioapic.c |3 +++ virt/kvm/ioapic.h |1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/virt/kvm

Re: PCI PT: irq issue

2008-06-25 Thread Amit Shah
On Wednesday 25 June 2008 15:03:11 Han, Weidong wrote: Amit Shah wrote: On Monday 23 June 2008 20:46:18 Han, Weidong wrote: Amit Shah wrote: On Saturday 21 June 2008 09:41:18 Han, Weidong wrote: Amit Shah wrote: A couple of notes for the VT-d patch: - The pci_dev struct is now

[PATCH] KVM: update gitignore

2008-06-26 Thread Amit Shah
The new coalesced_mmio.[ch] files need to be ignored in the userspace kernel/ directory. Signed-off-by: Amit Shah [EMAIL PROTECTED] --- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 48edae1..fee15ed 100644 --- a/.gitignore

[PATCH 2/4] KVM: Introduce a callback routine for IOAPIC ack handling

2008-06-27 Thread Amit Shah
This will be useful for acking irqs of assigned devices Signed-off-by: Amit Shah [EMAIL PROTECTED] --- virt/kvm/ioapic.c |3 +++ virt/kvm/ioapic.h |1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c index 9d02136..6d99a35 100644

[PATCH 4/4] KVM: Handle device assignment to guests

2008-06-27 Thread Amit Shah
From: Amit Shah [EMAIL PROTECTED] From: Ben-Ami Yassour [EMAIL PROTECTED] From: Han, Weidong [EMAIL PROTECTED] This patch adds support for handling PCI devices that are assigned to the guest (PCI passthrough). The device to be assigned to the guest is registered in the host kernel and interrupt

[PATCH 1/2] KVM/userspace: Support for assigning PCI devices to guest

2008-06-27 Thread Amit Shah
From: Or Sagi [EMAIL PROTECTED] From: Nir Peleg [EMAIL PROTECTED] From: Amit Shah [EMAIL PROTECTED] From: Glauber de Oliveira Costa [EMAIL PROTECTED] We can assign a device from the host machine to a guest. The original code comes from Neocleus. A new command-line option, -pcidevice is added

Re: [PATCH 4/4] KVM: Handle device assignment to guests

2008-07-02 Thread Amit Shah
Added locking (kvm-lock) around the initialization of function pointers for irq structures. So the new 4/4 patch is: Subject: [PATCH] KVM: Handle device assignment to guests From: Amit Shah [EMAIL PROTECTED] From: Ben-Ami Yassour [EMAIL PROTECTED] From: Han, Weidong [EMAIL PROTECTED

Re: [PATCH 4/8] KVM: PCIPT: fix interrupt handling

2008-07-23 Thread Amit Shah
* On Wednesday 16 Jul 2008 18:47:01 Ben-Ami Yassour wrote: This patch fixes a few problems with the interrupt handling for passthrough devices. 1. Pass the interrupt handler the pointer to the device, so we do not need to lock the pcipt lock in the interrupt handler. 2. Remove the

Re: [PATCH 4/8] KVM: PCIPT: fix interrupt handling

2008-07-24 Thread Amit Shah
* On Thursday 24 Jul 2008 16:58:57 Ben-Ami Yassour wrote: On Wed, 2008-07-23 at 19:07 +0530, Amit Shah wrote: * On Wednesday 16 Jul 2008 18:47:01 Ben-Ami Yassour wrote: This patch fixes a few problems with the interrupt handling for passthrough devices. 1. Pass the interrupt handler

Re: e1000 and PXE issues

2008-07-28 Thread Amit Shah
* On Sunday 27 Jul 2008 23:02:06 Farkas Levente wrote: Greg Kurtzer wrote: On Sat, Jul 26, 2008 at 1:12 AM, Avi Kivity [EMAIL PROTECTED] wrote: Greg Kurtzer wrote: Hello, I noticed some problems with the e1000 implementation in kvm = 70. At first glance it seemed liked a PXE problem

Re: [PATCH 2/4] KVM: pci device assignment

2008-07-28 Thread Amit Shah
* On Tuesday 22 Jul 2008 17:43:53 Ben-Ami Yassour wrote: Based on a patch from: Amit Shah [EMAIL PROTECTED] This patch adds support for handling PCI devices that are assigned to the guest. The device to be assigned to the guest is registered in the host kernel and interrupt delivery

Re: [PATCH 3/5] KVM: pci device assignment

2008-07-29 Thread Amit Shah
* On Monday 28 Jul 2008 21:56:26 Ben-Ami Yassour wrote: +static int kvm_vm_ioctl_assign_device(struct kvm *kvm, + struct kvm_assigned_pci_dev *assigned_dev) +{ + if (pci_enable_device(dev)) { + printk(KERN_INFO %s: Could not enable PCI

Re: [PATCH 2/5] KVM: Add irq ack notifier list

2008-07-29 Thread Amit Shah
* On Tuesday 29 Jul 2008 12:44:17 Yang, Sheng wrote: On Tuesday 29 July 2008 00:26:25 Ben-Ami Yassour wrote: FROM: Avi Kivity [EMAIL PROTECTED] This can be used by kvm subsystems that are interested in when interrupts are acked, for example time drift compenstation. [Ben: add

Re: [PATCH 2/5] KVM: Add irq ack notifier list

2008-07-29 Thread Amit Shah
* On Tuesday 29 July 2008 15:26:45 Yang, Sheng wrote: On Tuesday 29 July 2008 17:34:47 Amit Shah wrote: rename irq_request_opaque to struct* kvm in struct kvm_pic, and modify all irq_request() calling(three of them in all) with (void *)kvm. 'opaque' fields can be later made to point

Re: [PATCH 3/5] KVM: pci device assignment

2008-07-30 Thread Amit Shah
* On Tuesday 29 July 2008 15:08:27 Ben-Ami Yassour wrote: On Tue, 2008-07-29 at 14:49 +0530, Amit Shah wrote: * On Monday 28 Jul 2008 21:56:26 Ben-Ami Yassour wrote: +static int kvm_vm_ioctl_assign_device(struct kvm *kvm, + struct kvm_assigned_pci_dev

Re: [PATCH] reserved-ram for pci-passthrough without VT-d capable hardware

2008-07-30 Thread Amit Shah
* On Tuesday 29 July 2008 18:47:35 Andi Kleen wrote: I'm not so interested to go there right now, because while this code is useful right now because the majority of systems out there lacks VT-d/iommu, I suspect this code could be nuked in the long run when all systems will ship with that,

[PATCH] KVM: Device assignment: Check for privileges before assigning irq

2008-08-13 Thread Amit Shah
Even though we don't share irqs at the moment, we should ensure regular user processes don't try to allocate system resources. We check for capability to access IO devices (CAP_SYS_RAWIO) before we request_irq on behalf of the guest. Noticed by Avi. Signed-off-by: Amit Shah [EMAIL PROTECTED

Re: [PATCH] KVM: x86: Use kvm_set_irq to inject interrupts

2008-08-18 Thread Amit Shah
* On Monday 18 Aug 2008 17:08:20 Avi Kivity wrote: Configuration problem? Strange! Maybe the server I sent it from did something bad; I had sent another patch just some time ago and that didn't get mangled. Avi Kivity doesn't think he wrote: From: Amit Shah [EMAIL PROTECTED] ... instead

Re: where can i find the current pci passthrough patches

2008-08-18 Thread Amit Shah
Hello, * On Monday 18 Aug 2008 18:28:07 [EMAIL PROTECTED] wrote: Hi, i want to make some test with qemu and pci passthrough with the VT-d feature. In the linux-kernel git (http://git.kernel.org/; linux/kernel/git/amit/kvm-userspace.git) repository i only found a 6 weeks old version. How

Re: [PATCH] KVM: Fix wrong KVM_GET_LAPIC

2008-08-20 Thread Amit Shah
* On Monday 18 Aug 2008 08:45:40 Yang, Sheng wrote: From a8ca7dd8f5fe0125e7b7d0a21f5caddacd754911 Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Mon, 18 Aug 2008 11:04:22 +0800 Subject: [PATCH] KVM: Fix wrong KVM_GET_LAPIC Which caused migration fail in recent commits.

Re: [PATCH] KVM: Fix wrong KVM_GET_LAPIC

2008-08-20 Thread Amit Shah
* On Wednesday 20 Aug 2008 12:40:57 Avi Kivity wrote: Amit Shah wrote: * On Monday 18 Aug 2008 08:45:40 Yang, Sheng wrote: From a8ca7dd8f5fe0125e7b7d0a21f5caddacd754911 Mon Sep 17 00:00:00 2001 From: Sheng Yang [EMAIL PROTECTED] Date: Mon, 18 Aug 2008 11:04:22 +0800 Subject: [PATCH] KVM

Re: [PATCH 2/2] KVM: Device assignemnt with VT-d

2008-08-21 Thread Amit Shah
* On Thursday 07 Aug 2008 19:44:47 Ben-Ami Yassour wrote: Based on a patch by: Kay, Allen M [EMAIL PROTECTED] This patch enables pci device assignment based on VT-d support. When a device is assigned to the guest, the guest memory is pinned and the mapping is updated in the VT-d IOMMU.

Re: [PATCH 2/2] KVM: Device assignemnt with VT-d

2008-08-21 Thread Amit Shah
* On Thursday 21 Aug 2008 16:35:57 Ben-Ami Yassour wrote: On Thu, 2008-08-21 at 12:13 +0530, Amit Shah wrote: * On Thursday 07 Aug 2008 19:44:47 Ben-Ami Yassour wrote: Based on a patch by: Kay, Allen M [EMAIL PROTECTED] This patch enables pci device assignment based on VT-d support

[PATCH] KVM: Device Assignment with VT-d

2008-08-22 Thread Amit Shah
-by: Weidong Han [EMAIL PROTECTED] Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED] Signed-off-by: Amit Shah [EMAIL PROTECTED] --- arch/x86/kvm/Makefile |3 + arch/x86/kvm/vtd.c | 203 arch/x86/kvm/x86.c | 11 +++ include/asm-x86

[PATCH] VT-d: changes to support KVM

2008-08-22 Thread Amit Shah
From: Kay, Allen M [EMAIL PROTECTED] This patch extends the VT-d driver to support KVM [Ben: fixed memory pinning] Signed-off-by: Kay, Allen M [EMAIL PROTECTED] Signed-off-by: Weidong Han [EMAIL PROTECTED] Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED] Signed-off-by: Amit Shah [EMAIL

Re: VT-d support for device assignment

2008-08-22 Thread Amit Shah
* On Friday 22 Aug 2008 19:24:13 Byron Stanoszek wrote: On Fri, 22 Aug 2008, Amit Shah wrote: The following two patches contain VT-d support for device assignment for KVM guests. The first patch contains the changes that are required to the generic VT-d code. The second patch

Re: [PATCH 2/2] KVM: Device assignemnt with VT-d

2008-08-23 Thread Amit Shah
* On Friday 22 Aug 2008 23:48:42 Avi Kivity wrote: Amit Shah wrote: diff --git a/include/linux/kvm.h b/include/linux/kvm.h index d9ef7d3..2956e35 100644 --- a/include/linux/kvm.h +++ b/include/linux/kvm.h @@ -495,4 +495,6 @@ struct kvm_assigned_irq { __u32 flags

Re: VT-d support for device assignment

2008-08-23 Thread Amit Shah
* On Friday 22 Aug 2008 23:51:15 Avi Kivity wrote: Amit Shah wrote: The following two patches contain VT-d support for device assignment for KVM guests. The first patch contains the changes that are required to the generic VT-d code. The second patch contains the changes to KVM

Re: [PATCH 2/2] KVM: Device assignemnt with VT-d

2008-08-23 Thread Amit Shah
* On Saturday 23 Aug 2008 14:58:50 Avi Kivity wrote: Amit Shah wrote: Also, is KVM_CAP_foo needed for this? This is the only #define that'll be used and we can simply do something like #ifdef KVM_DEV_ASSIGN_USE_VTD flags |= KVM_DEV_ASSIGN_USE_VTD #endif ? That only detects

Re: VT-d support for device assignment

2008-08-23 Thread Amit Shah
* On Saturday 23 Aug 2008 15:03:46 Avi Kivity wrote: Amit Shah wrote: * On Friday 22 Aug 2008 23:51:15 Avi Kivity wrote: Amit Shah wrote: The following two patches contain VT-d support for device assignment for KVM guests. The first patch contains the changes that are required

Re: VT-d support for device assignment

2008-08-23 Thread Amit Shah
* On Saturday 23 Aug 2008 15:27:47 Muli Ben-Yehuda wrote: On Fri, Aug 22, 2008 at 10:10:52AM +0300, Amit Shah wrote: The second patch contains the changes to KVM. I've updated the 2nd patch to use VT-d only when requested by a parameter on the command line, making it easier to support

Re: VT-d support for device assignment

2008-08-23 Thread Amit Shah
* On Saturday 23 Aug 2008 16:10:54 Muli Ben-Yehuda wrote: On Sat, Aug 23, 2008 at 03:55:25PM +0530, Amit Shah wrote: The authorship info and the commit log stays the same; just contains my signoff. Actually, unless you add an explicit 'From:' header, the email From header is used by git

Re: VT-d support for device assignment

2008-08-23 Thread Amit Shah
* On Saturday 23 Aug 2008 17:41:32 Muli Ben-Yehuda wrote: On Sat, Aug 23, 2008 at 04:41:02PM +0530, Amit Shah wrote: * On Saturday 23 Aug 2008 16:10:54 Muli Ben-Yehuda wrote: On Sat, Aug 23, 2008 at 03:55:25PM +0530, Amit Shah wrote: The authorship info and the commit log stays the same

[PATCH 2/2] KVM: Device Assignment with VT-d

2008-08-26 Thread Amit Shah
KVM_CAP_IOMMU so we can check if an IOMMU is present and also control enable/disable from userspace] Signed-off-by: Kay, Allen M [EMAIL PROTECTED] Signed-off-by: Weidong Han [EMAIL PROTECTED] Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED] Signed-off-by: Amit Shah [EMAIL PROTECTED] --- arch/x86/kvm/Makefile

[PATCH 1/2] VT-d: changes to support KVM

2008-08-26 Thread Amit Shah
From: Kay, Allen M [EMAIL PROTECTED] This patch extends the VT-d driver to support KVM [Ben: fixed memory pinning] Signed-off-by: Kay, Allen M [EMAIL PROTECTED] Signed-off-by: Weidong Han [EMAIL PROTECTED] Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED] Signed-off-by: Amit Shah [EMAIL

Re: [PATCH 2/2] KVM: Device Assignment with VT-d

2008-08-26 Thread Amit Shah
* On Tuesday 26 Aug 2008 15:58:42 Zhang, Xiantao wrote: Maybe vtd.c should be put @ virt/kvm so that ia64 can share it to avoid future code move. As of now, device assignment resides inside the x86 directory and is only tested in x86 environment. Once we support ia64, we'll have a lot of files

Re: [PATCH 2/2] KVM: Device Assignment with VT-d

2008-08-26 Thread Amit Shah
* On Tuesday 26 Aug 2008 16:12:56 Zhang, Xiantao wrote: Amit Shah wrote: * On Tuesday 26 Aug 2008 15:58:42 Zhang, Xiantao wrote: Maybe vtd.c should be put @ virt/kvm so that ia64 can share it to avoid future code move. As of now, device assignment resides inside the x86 directory

Re: VT-d support for device assignment

2008-08-26 Thread Amit Shah
* On Tuesday 26 Aug 2008 14:40:57 Avi Kivity wrote: Amit Shah wrote: The following two patches contain VT-d support for device assignment for KVM guests. The first patch contains the changes that are required to the generic VT-d code. The second patch contains the changes to KVM

[PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guests

2008-08-26 Thread Amit Shah
From: Or Sagi [EMAIL PROTECTED] From: Nir Peleg [EMAIL PROTECTED] From: Amit Shah [EMAIL PROTECTED] From: Ben-Ami Yassour [EMAIL PROTECTED] From: Glauber de Oliveira Costa [EMAIL PROTECTED] With this patch, we can assign a device on the host machine to a guest. A new command-line option

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devicesto guests

2008-08-28 Thread Amit Shah
* On Wednesday 27 Aug 2008 18:18:54 Ben-Ami Yassour wrote: On Tue, 2008-08-26 at 18:29 +0300, Amit Shah wrote: +#define assigned_dev_ioport_read(suffix) \ + static uint32_t assigned_dev_ioport_read##suffix(void *opaque, uint32_t addr

Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devicesto guests

2008-08-28 Thread Amit Shah
* On Wednesday 27 Aug 2008 19:16:40 Muli Ben-Yehuda wrote: On Wed, Aug 27, 2008 at 03:48:54PM +0300, Ben-Ami Yassour1 wrote: On Tue, 2008-08-26 at 18:29 +0300, Amit Shah wrote: From: Or Sagi [EMAIL PROTECTED] From: Nir Peleg [EMAIL PROTECTED] From: Amit Shah [EMAIL PROTECTED] From

[PATCH] KVM: Device Assignment: Free device structures if IRQ allocation fails

2008-08-29 Thread Amit Shah
When an IRQ allocation fails, we free up the device structures and disable the device so that we can unregister the device in the userspace and not expose it to the guest at all. Signed-off-by: Amit Shah [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 98

Re: Test with VT-d patches

2008-09-03 Thread Amit Shah
Hello, * On Wednesday 03 September 2008 14:07:36 [EMAIL PROTECTED] wrote: Hi, i make some more tests with 1) an old APCI1500/PCI card no linux driver support - so i don't need to unload the module. 2) my second network-card Realtek 10/100 MBit. Both don't work at all. Only my first

Re: PLIP doesn't work under kvm

2008-09-08 Thread Amit Shah
* On Sunday 07 September 2008 08:52:29 holio-dslab wrote: Hi all, I'm trying to communicate between two computers, said A and B, with PLIP (Parallel Line IP). It works correct(both can ping each other) when both run the PLIP on the physical host os, so the cable and the configurations should

VT-d support for device assignment

2008-09-09 Thread Amit Shah
These are based on the patches Weidong just sent, with some whitespace cleanups and one checkpatch fix for the 2/2 patch. Please apply. Amit. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2/2] KVM: Device Assignment with VT-d

2008-09-09 Thread Amit Shah
KVM_CAP_IOMMU so we can check if an IOMMU is present and also control enable/disable from userspace] Signed-off-by: Kay, Allen M [EMAIL PROTECTED] Signed-off-by: Weidong Han [EMAIL PROTECTED] Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED] Signed-off-by: Amit Shah [EMAIL PROTECTED] Acked-by: Mark Gross

[PATCH 1/2] VT-d: Changes to support KVM

2008-09-09 Thread Amit Shah
From: Kay, Allen M [EMAIL PROTECTED] This patch extends the VT-d driver to support KVM [Ben: fixed memory pinning] Signed-off-by: Kay, Allen M [EMAIL PROTECTED] Signed-off-by: Weidong Han [EMAIL PROTECTED] Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED] Signed-off-by: Amit Shah [EMAIL

[PATCH 2/2] KVM: Device Assignment with VT-d

2008-09-09 Thread Amit Shah
KVM_CAP_IOMMU so we can check if an IOMMU is present and also control enable/disable from userspace] Signed-off-by: Kay, Allen M [EMAIL PROTECTED] Signed-off-by: Weidong Han [EMAIL PROTECTED] Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED] Signed-off-by: Amit Shah [EMAIL PROTECTED] Acked-by: Mark Gross

[PATCH 1/2] VT-d: Changes to support KVM

2008-09-09 Thread Amit Shah
From: Kay, Allen M [EMAIL PROTECTED] This patch extends the VT-d driver to support KVM [Ben: fixed memory pinning] Signed-off-by: Kay, Allen M [EMAIL PROTECTED] Signed-off-by: Weidong Han [EMAIL PROTECTED] Signed-off-by: Ben-Ami Yassour [EMAIL PROTECTED] Signed-off-by: Amit Shah [EMAIL

[PATCH] KVM: Device Assignment: Free device structures if IRQ allocation fails

2008-09-14 Thread Amit Shah
When an IRQ allocation fails, we free up the device structures and disable the device so that we can unregister the device in the userspace and not expose it to the guest at all. Signed-off-by: Amit Shah [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 86

[PATCH] KVM: x86: Fix compile when CONFIG_DMAR is not defined

2008-09-16 Thread Amit Shah
intel_iommu_found() is not defined if CONFIG_DMAR is not defined Signed-off-by: Amit Shah [EMAIL PROTECTED] --- include/linux/kvm_host.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 6252802..5b9d713 100644

[PATCH] KVM: x86: Fix compile when CONFIG_DMAR is not defined

2008-09-16 Thread Amit Shah
intel_iommu_found() is not defined if CONFIG_DMAR is not defined Signed-off-by: Amit Shah [EMAIL PROTECTED] --- include/linux/intel-iommu.h | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h index 1490fc0

Re: [PATCH] KVM: Device Assignment: Free device structures if IRQ allocation fails

2008-09-16 Thread Amit Shah
* On Tuesday 16 Sep 2008 22:55:29 Avi Kivity wrote: Amit Shah wrote: When an IRQ allocation fails, we free up the device structures and disable the device so that we can unregister the device in the userspace and not expose it to the guest at all. Still doesn't apply. What did you

[PATCH] KVM/userspace: Support for assigning PCI devices to guests

2008-09-16 Thread Amit Shah
[This still doesn't include some fixes to review comments. I'm posting this just so that people can use this to test or base their work off the latest patch.] From: Or Sagi [EMAIL PROTECTED] From: Nir Peleg [EMAIL PROTECTED] From: Amit Shah [EMAIL PROTECTED] From: Ben-Ami Yassour [EMAIL PROTECTED

Re: [PATCH] KVM/userspace: Support for assigning PCI devices to guests

2008-09-16 Thread Amit Shah
* On Wednesday 17 Sep 2008 11:15:16 Zhang, Xiantao wrote: Seems it lacks device-assignment.[c,h] ? Xiantao Hmm, here is the version with the files. From cd82862ef7493afd3431e538b85adb9771f94da6 Mon Sep 17 00:00:00 2001 From: Amit Shah [EMAIL PROTECTED] Date: Tue, 16 Sep 2008 23:09:23 +0530

Re: [PATCH] KVM/userspace: Support for assigning PCI devices to guests

2008-09-17 Thread Amit Shah
* On Wednesday 17 Sep 2008 11:24:52 Zhang, Xiantao wrote: Amit Shah wrote: [This still doesn't include some fixes to review comments. I'm posting this just so that people can use this to test or base their work off the latest patch.] From: Or Sagi [EMAIL PROTECTED] From: Nir Peleg

Re: [PATCH] KVM/userspace: Support for assigning PCI devices to guests

2008-09-17 Thread Amit Shah
* On Wednesday 17 Sep 2008 12:03:54 Zhang, Xiantao wrote: Could you move this part to libkvm.c? it should be shared by all archs, I think. Yes, I have noted this comment from you when you sent it previously as well; sorry for not having replied then. When are you planning on ia64

Re: [PATCH] KVM/userspace: Support for assigning PCI devices to guests

2008-09-19 Thread Amit Shah
Hello Weidong, - Weidong Han [EMAIL PROTECTED] wrote: Amit, There are a few format issues in your patch, and this patch doesn't work. Flag KVM_DEV_ASSIGN_ENABLE_IOMMU is not set correctly. My comment inline. +#ifdef KVM_CAP_IOMMU + /* We always enable the IOMMU if

Re: mmotm 2008-09-22-01-36 uploaded (kvm)

2008-09-23 Thread Amit Shah
* On Tuesday 23 Sep 2008 03:40:26 Andrew Morton wrote: On Mon, 22 Sep 2008 14:58:52 -0700 Jesse Barnes [EMAIL PROTECTED] wrote: On Monday, September 22, 2008 12:52 pm Andrew Morton wrote: On Mon, 22 Sep 2008 11:19:47 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: On Mon, 22 Sep 2008

[PATCH 2/7] qemu: Introduce pci_map_irq to get irq nr from pin number for a PCI device

2008-09-23 Thread Amit Shah
Signed-off-by: Amit Shah [EMAIL PROTECTED] --- qemu/hw/pci.c |5 + qemu/hw/pci.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/qemu/hw/pci.c b/qemu/hw/pci.c index 07d37a8..61ff0f6 100644 --- a/qemu/hw/pci.c +++ b/qemu/hw/pci.c @@ -560,6 +560,11 @@ static void

[PATCH 3/7] qemu: piix: Introduce functions to get pin number from irq and vice versa

2008-09-23 Thread Amit Shah
Signed-off-by: Amit Shah [EMAIL PROTECTED] --- qemu/hw/piix_pci.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/qemu/hw/piix_pci.c b/qemu/hw/piix_pci.c index 6fbf47b..dc12c8a 100644 --- a/qemu/hw/piix_pci.c +++ b/qemu/hw/piix_pci.c @@ -243,6 +243,25

[PATCH 1/7] KVM/userspace: Device Assignment: Add ioctl wrappers needed for assigning devices

2008-09-23 Thread Amit Shah
Signed-off-by: Amit Shah [EMAIL PROTECTED] --- libkvm/libkvm.c | 13 + libkvm/libkvm.h | 27 +++ 2 files changed, 40 insertions(+), 0 deletions(-) diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c index 63fbcba..7744daa 100644 --- a/libkvm/libkvm.c +++ b

[V6] Userspace patches for PCI device assignment

2008-09-23 Thread Amit Shah
This patchset enables device assignment for KVM hosts for PCI devices. It uses the Intel IOMMU by default if available. Major changes since the last send: - More error checking - Change data structure names to match qemu style - Add support for hot-adding devices (this works, but is currently

[PATCH 6/7] KVM/userspace: Build vtd.c for Intel IOMMU support

2008-09-23 Thread Amit Shah
Signed-off-by: Amit Shah [EMAIL PROTECTED] --- kernel/x86/Kbuild |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kernel/x86/Kbuild b/kernel/x86/Kbuild index 8dc0483..a4cd00c 100644 --- a/kernel/x86/Kbuild +++ b/kernel/x86/Kbuild @@ -5,6 +5,9 @@ kvm-objs := kvm_main.o

[PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Amit Shah
From: Or Sagi [EMAIL PROTECTED] From: Nir Peleg [EMAIL PROTECTED] From: Amit Shah [EMAIL PROTECTED] From: Ben-Ami Yassour [EMAIL PROTECTED] From: Weidong Han [EMAIL PROTECTED] From: Glauber de Oliveira Costa [EMAIL PROTECTED] With this patch, we can assign a device on the host machine to a guest

[PATCH 4/7] qemu: Include hw.h in qemu/hw/isa.h to fix compile issues

2008-09-23 Thread Amit Shah
Signed-off-by: Amit Shah [EMAIL PROTECTED] --- qemu/hw/isa.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu/hw/isa.h b/qemu/hw/isa.h index 222e4f3..e4a1326 100644 --- a/qemu/hw/isa.h +++ b/qemu/hw/isa.h @@ -2,6 +2,8 @@ #define HW_ISA_H /* ISA bus */ +#include

Re: [PATCH 7/7] KVM/userspace: Device Assignment: Support for hot plugging PCI devices

2008-09-23 Thread Amit Shah
* On Tuesday 23 Sep 2008 22:02:04 Anthony Liguori wrote: Amit Shah wrote: This patch adds support for hot-plugging host PCI devices into guests Instead of using assigned, it should probably be host. Yes, that's a good name. -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [PATCH 6/7] KVM/userspace: Build vtd.c for Intel IOMMU support

2008-09-23 Thread Amit Shah
* On Tuesday 23 Sep 2008 22:01:10 Anthony Liguori wrote: Amit Shah wrote: Signed-off-by: Amit Shah [EMAIL PROTECTED] --- kernel/x86/Kbuild |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kernel/x86/Kbuild b/kernel/x86/Kbuild index 8dc0483..a4cd00c 100644

Re: [PATCH 4/7] qemu: Include hw.h in qemu/hw/isa.h to fix compile issues

2008-09-23 Thread Amit Shah
* On Tuesday 23 Sep 2008 21:43:44 Anthony Liguori wrote: Amit Shah wrote: Signed-off-by: Amit Shah [EMAIL PROTECTED] --- qemu/hw/isa.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu/hw/isa.h b/qemu/hw/isa.h index 222e4f3..e4a1326 100644 --- a/qemu

Re: [PATCH 3/7] qemu: piix: Introduce functions to get pin number from irq and vice versa

2008-09-23 Thread Amit Shah
* On Tuesday 23 Sep 2008 21:43:26 Anthony Liguori wrote: Amit Shah wrote: Signed-off-by: Amit Shah [EMAIL PROTECTED] --- qemu/hw/piix_pci.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/qemu/hw/piix_pci.c b/qemu/hw/piix_pci.c index

Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests

2008-09-23 Thread Amit Shah
* On Tuesday 23 Sep 2008 22:00:32 Anthony Liguori wrote: Amit Shah wrote: diff --git a/qemu/Makefile.target b/qemu/Makefile.target index 72f3db8..40eb273 100644 --- a/qemu/Makefile.target +++ b/qemu/Makefile.target @@ -616,6 +616,7 @@ OBJS+= ide.o pckbd.o ps2.o vga.o $(SOUND_HW) dma.o

Re: Remaining passthrough/VT-d tasks list

2008-09-24 Thread Amit Shah
* On Wednesday 24 Sep 2008 13:21:25 Han, Weidong wrote: Amit Shah wrote: - Add dummy driver to hide/unbind passthrough device from host kernel This isn't needed; we currently don't assign the device to the guest if we find that a driver is already loaded. I intend to change

Re: Remaining passthrough/VT-d tasks list

2008-09-24 Thread Amit Shah
* On Wednesday 24 Sep 2008 14:08:14 Han, Weidong wrote: Amit Shah wrote: * On Wednesday 24 Sep 2008 13:21:25 Han, Weidong wrote: Amit Shah wrote: - Add dummy driver to hide/unbind passthrough device from host kernel This isn't needed; we currently don't assign the device

  1   2   3   4   >