Here's my proposed TAP solution:
- The user specifies MAC ranges and may or may not specify corresponding IP
ranges.
- VMs are always given MAC addresses from the user specified MAC ranges.
- MAC address ranges must be unique to each host running KVM tests -- there
must be no overlap between
-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_utils.py | 110 -
1 files changed, 108 insertions(+), 2 deletions(-)
diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
index e897e78..5d8291f 100644
--- a/client/tests
are provided by the user, specify
'always_use_tcpdump = yes'.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_address_pools.cfg.sample |8 +++
client/tests/kvm/kvm_preprocessing.py |3 +-
client/tests/kvm/kvm_utils.py | 28 +++-
client
be done inside 'qemu-ifup' as well, but this sample script
doesn't do it.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/qemu-ifup |8
1 files changed, 8 insertions(+), 0 deletions(-)
create mode 100644 client/tests/kvm/qemu-ifup
diff --git a/client/tests/kvm
').
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_cdkeys.cfg.sample | 16
client/tests/kvm/kvm_tests.cfg.sample | 10 +++---
2 files changed, 19 insertions(+), 7 deletions(-)
create mode 100644 client/tests/kvm/kvm_cdkeys.cfg.sample
diff --git
. 'script_dir' should normally be the KVM test local dir.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_preprocessing.py |8 ++-
client/tests/kvm/kvm_tests.cfg.sample |6 ++
client/tests/kvm/kvm_vm.py| 95 +++-
3 files
-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_subprocess.py | 54 ---
1 files changed, 49 insertions(+), 5 deletions(-)
diff --git a/client/tests/kvm/kvm_subprocess.py
b/client/tests/kvm/kvm_subprocess.py
index c15e779..df1d562 100644
I'm not entirely sure this is needed:
- How often do tests fail due to unsupported flags? I thought the -mem-path
problem was only due to a temporary typo (I'm not sure how temporary).
Once it's fixed, will we ever encounter that misspelling again?
- A typo is a bug too, so maybe we shouldn't make
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Wed, Jul 29, 2009 at 9:18 AM, Avi Kivitya...@redhat.com wrote:
On 07/16/2009 01:26 PM, Yolkfull Chow wrote:
Signed-off-by: Yolkfull Chowyz...@redhat.com
---
client/tests/kvm/kvm_vm.py | 11 +++
1 files changed, 11
It looks like you're using opensshd with cygwin -- not the one we normally
install on guests, but rather one that outputs colorful text. Is that right?
Which server are you using exactly?
There's not much I can do against colorful text, because it's difficult to
automatically strip the weird
- sudhir kumar smalik...@gmail.com wrote:
This patch does two small things.
1. Prints the guest login command to debug messages.
Why do we want to do that?
2. Changes the guest login timeout to 240 seconds. I see the timeout
for
*.wait_for() functions in boot test is 240 seconds,
for the first line.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_subprocess.py |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/client/tests/kvm/kvm_subprocess.py
b/client/tests/kvm/kvm_subprocess.py
index 413bdaa..c15e779 100644
- sudhir kumar smalik...@gmail.com wrote:
On Fri, Jul 24, 2009 at 5:54 PM, Michael Goldishmgold...@redhat.com
wrote:
- sudhir kumar smalik...@gmail.com wrote:
This patch does two small things.
1. Prints the guest login command to debug messages.
Why do we want to do that?
- Dor Laor dl...@redhat.com wrote:
On 07/20/2009 06:07 PM, Michael Goldish wrote:
1) Log into a guest.
2) Take a time reading from the guest and host.
3) Run load on the guest and host.
4) Take a second time reading.
5) Stop the load and rest for a while.
6) Take a third time
- Dor Laor dl...@redhat.com wrote:
On 07/20/2009 06:07 PM, Michael Goldish wrote:
Currently the test will only run on Windows.
It should be able to run on Linux just as well, but if I understand
correctly,
testing time drift on Linux is less interesting.
Linux is interesting too
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
Currently we have our kvm test control file and configuration file,
having them split like this makes it harder for users to edit it,
let's
say, using the web frontend.
So it might be good to merge the control file and the config file,
- Ryan Harper ry...@us.ibm.com wrote:
* Michael Goldish mgold...@redhat.com [2009-07-21 07:38]:
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
Currently we have our kvm test control file and configuration
file,
having them split like this makes it harder for users
- David Huff dh...@redhat.com wrote:
Michael Goldish wrote:
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
Currently we have our kvm test control file and configuration
file,
having them split like this makes it harder for users to edit it,
let's
say, using the web
- Yolkfull Chow yz...@redhat.com wrote:
On Mon, Jul 20, 2009 at 06:07:19PM +0300, Michael Goldish wrote:
1) Log into a guest.
2) Take a time reading from the guest and host.
3) Run load on the guest and host.
4) Take a second time reading.
5) Stop the load and rest for a while
The following patch series includes all the patches I sent that have not been
applied yet. They are all rebased against the latest HEAD (including the recent
UUID patch).
Some new things are included too, such as a simple time drift test for Windows.
Sorry for posting so many commits at once.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_preprocessing.py | 27 ++--
client/tests/kvm/kvm_vm.py| 111 +++-
2 files changed, 59 insertions(+), 79 deletions(-)
diff --git a/client/tests/kvm/kvm_preprocessing.py
b
SSH/SCP/Telnet sessions cannot be reused by tests following the one in
which they are opened.
The new module provides a solution to these two problems, and also saves some
code by reusing common code required both for QEMU processes and SSH/SCP/Telnet
processes.
Signed-off-by: Michael Goldish
Also remove a reference to kvm_log that was left behind.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_utils.py | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
index
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.py |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py
index 2d11fed..5991aed 100644
--- a/client/tests/kvm/kvm_tests.py
These are now provided by kvm_subprocess.py.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_utils.py | 477 +
1 files changed, 2 insertions(+), 475 deletions(-)
diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm
The name 'debug_dir' makes it clearer that it corresponds to test.debugdir.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_guest_wizard.py | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/client/tests/kvm
Currently parameters for barrier_2() are extracted from 'params' in the main
run_steps() test routine, and then passed to barrier_2().
Instead, let barrier_2() extract parameters from 'params' as it sees fit.
This will make adding new parameters slightly easier and cleaner.
Signed-off-by: Michael
history is removed, so eventually the remaining files
are only those of the (last) failed barrier, if any.
- keep_all_history: if equals 'yes', screendump history is not removed upon
barrier success. The test leaves behind all the collected screendump history.
Signed-off-by: Michael Goldish mgold
' or 'keep_ppm_files_on_error = yes'
(or explicitly set to 'no', if it was set to 'yes' on a higher level in the
config hierarchy).
This patch also makes small cosmetic changes to the 'keep_ppm_files' feature.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm
.)
The 'keep_ppm_files' and 'keep_ppm_files_on_error' settings are commented out
so the user can easily enable them if desired.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.cfg.sample |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/client/tests/kvm
.
If the drift after the rest period is higher than a user-specified value,
fail.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm.py |1 +
client/tests/kvm/kvm_tests.py | 161 -
2 files changed, 160 insertions(+), 2
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_config.py | 99 +---
1 files changed, 52 insertions(+), 47 deletions(-)
diff --git a/client/tests/kvm/kvm_config.py b/client/tests/kvm/kvm_config.py
index 99ccb2a..7e8b1db 100755
Allow kvm_config to parse weird lines that seem to contain several operators,
such as:
time_filter_re = (?=TIME: ...)
The '?=' is recognized as the operator instead of the '='.
To fix this, select the operator closest to the beginning of the line.
Signed-off-by: Michael Goldish mgold
be last).
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.cfg.sample | 46 ++--
1 files changed, 37 insertions(+), 9 deletions(-)
diff --git a/client/tests/kvm/kvm_tests.cfg.sample
b/client/tests/kvm/kvm_tests.cfg.sample
index 1288952
'redirs' and 'vnc_port' might be used before they're defined, if
make_qemu_command() is called before create(). To make sure this doesn't
happen, define them in the VM constructor.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_vm.py |2 ++
1 files changed, 2
- Yolkfull Chow yz...@redhat.com wrote:
On Thu, Jul 16, 2009 at 08:49:30AM -0400, Michael Goldish wrote:
I'd do this a little differently, because of the constraints imposed
by the different purposes of VM.create() and VM.make_qemu_command().
- Yolkfull Chow yz...@redhat.com
- sudhir kumar smalik...@gmail.com wrote:
On Thu, Jul 16, 2009 at 8:12 AM, Yolkfull Chowyz...@redhat.com
wrote:
On 07/15/2009 09:36 PM, Dor Laor wrote:
On 07/15/2009 12:12 PM, Yolkfull Chow wrote:
Would submit this patch which is from our internal kvm-autotest
patches submitted by
- sudhir kumar smalik...@gmail.com wrote:
Thats great Michael !!
On Wed, Jul 15, 2009 at 8:56 PM, Michael Goldishmgold...@redhat.com
wrote:
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Wed, Jul 8, 2009 at 4:46 AM, Michael
Goldishmgold...@redhat.com
wrote:
I'm
I'd do this a little differently, because of the constraints imposed by the
different purposes of VM.create() and VM.make_qemu_command().
- Yolkfull Chow yz...@redhat.com wrote:
Signed-off-by: Yolkfull Chow yz...@redhat.com
---
client/tests/kvm/kvm_vm.py | 11 +++
1 files
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Wed, Jul 8, 2009 at 4:46 AM, Michael Goldishmgold...@redhat.com
wrote:
I'm resending the message because it probably got filtered out due
to the
attached setup.bat file.
The contents of setup.bat were:
copy D:\rss.exe C:\
- Lukáš Doktor ldok...@redhat.com wrote:
Hi,
the way how kvm_autotest currently handle pre_command/post_command it
don't allow to specify more than one command. BASH can handle this
itself with a small change in the framework , as shown in the
attachment.
Why do you say the
I don't think you need to explicitly check for a memory allocation
failure in VM.create() (qemu produced some output ...).
VM.create() already makes sure the VM is started successfully, and
prints informative failure messages if there's any problem.
- Lukáš Doktor ldok...@redhat.com wrote:
. If you think this isn't a proper
solution, or if you can suggest a better one, please let me know.
Lucas: if we commit this, where should it go? Under tests/kvm/src maybe?
Thanks,
Michael// Simple remote shell server
// Author: Michael Goldish mgold...@redhat.com
// Much of the code here
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Thu, 2009-06-18 at 17:50 -0400, David Huff wrote:
Second pass at the unattended install test. Both Linux and Windows
guests are
working however currently it just uses the existing boot test and
extends
timeouts. We still need a
- look...@gmail.com wrote:
Reviewers: lmr,
Message:
Hi Michael, this is my first review of your patch series. The module
kvm_subprocess looks pretty good and carefully written, I made some
minor comments (some of them are more of general wonderings).
After reviewing this, I began
BTW, thank you for the thorough review.
I realize that was quite a lot of code to go over.
- Original Message -
From: Michael Goldish mgold...@redhat.com
To: look...@gmail.com, michael goldish mgold...@redhat.com,
autot...@test.kernel.org, kvm@vger.kernel.org
Sent: Thursday, June 18
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Thu, 2009-06-18 at 07:58 -0400, Michael Goldish wrote:
- look...@gmail.com wrote:
Reviewers: lmr,
Message:
Hi Michael, this is my first review of your patch series. The
module
kvm_subprocess looks pretty good
documentation.
(currently none, writeback, or writethrough are supported.)
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_vm.py |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
index 9aea3fb
it on the same living VM, and repeat this procedure without
having to shutdown/boot the VM every time.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm.py |1 +
client/tests/kvm/kvm_tests.py | 37 +
2 files changed, 38
nicely, the postprocessor will take care of it.
Also added 'kill_vm_on_error = yes' to 'setup' tests, because if a setup test
fails, shutdown will not run, so the setup test must take care of shutting the
VM down. Install tests already have this defined.
Signed-off-by: Michael Goldish mgold
' or 'keep_ppm_files_on_error = yes'
(or explicitly set to 'no', if it was set to 'yes' on a higher level in the
config hierarchy).
This patch also makes small cosmetic changes to the 'keep_ppm_files' feature.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm
.)
The 'keep_ppm_files' and 'keep_ppm_files_on_error' settings are commented out
so the user can easily enable them if desired.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.cfg.sample |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/client/tests/kvm
- Alexey Eromenko aerom...@redhat.com wrote:
Michael I don't fully understand why shutdown test is needed; Shutdown
is tested during reboot, where GuestOS must de-init itself.
The main motivation for a shutdown test is that it allows us to choose
whether VMs should be kept alive after the
- Uri Lublin u...@redhat.com wrote:
On 06/15/2009 10:45 PM, Michael Goldish wrote:
Currently parameters for barrier_2() are extracted from 'params' in
the main
run_steps() test routine, and then passed to barrier_2().
Instead, let barrier_2() extract parameters from 'params
SSH/SCP/Telnet sessions cannot be reused by tests following the one in
which they are opened.
The new module provides a solution to these two problems, and also saves some
code by reusing common code required both for QEMU processes and SSH/SCP/Telnet
processes.
Signed-off-by: Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_preprocessing.py | 17 +-
client/tests/kvm/kvm_vm.py| 103 +
2 files changed, 44 insertions(+), 76 deletions(-)
diff --git a/client/tests/kvm/kvm_preprocessing.py
b
Also remove a reference to kvm_log that was left behind.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_utils.py | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
index
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_tests.py |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py
index 54d2a7a..ffe9116 100644
--- a/client/tests/kvm/kvm_tests.py
These are now provided by kvm_subprocess.py.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_utils.py | 477 +
1 files changed, 2 insertions(+), 475 deletions(-)
diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm
The following patches make some changes to step file tests:
* Rename parameter output_dir in barrier_2() to debug_dir.
* Move some code from run_steps() into barrier_2().
* Add a new feature (keep_screendump_history) which allows the user to see
exactly what went wrong with a step file test.
The name 'debug_dir' makes it clearer that it corresponds to test.debugdir.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm/kvm_guest_wizard.py | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/client/tests/kvm
Currently parameters for barrier_2() are extracted from 'params' in the main
run_steps() test routine, and then passed to barrier_2().
Instead, let barrier_2() extract parameters from 'params' as it sees fit.
This will make adding new parameters slightly easier and cleaner.
Signed-off-by: Michael
This should be rather harmless because the history does not take up much space,
and is only kept for the failed barriers in failed tests, by default.
It should significantly ease debugging of failed step file tests.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm
history is removed, so eventually the remaining files
are only those of the (last) failed barrier, if any.
- keep_all_history: if equals 'yes', screendump history is not removed upon
barrier success. The test leaves behind all the collected screendump history.
Signed-off-by: Michael Goldish mgold
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
Signed-off-by: Lucas Meneghel Rodrigues l...@redhat.com
---
client/tests/kvm/kvm_config.py | 14 +++---
client/tests/kvm/kvm_tests.py | 12 ++--
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
The 'autotest' kvm subtest was relying on autotest output, that
now has the logging line prefixes. The logging line prefixes
breaks the results parser, so we would either have to make the
parser to strip the logging prefixes or read
- Yolkfull Chow yz...@redhat.com wrote:
Michael, these are the backtrace messages:
...
20090611-064959
no_boundary.local_stg.RHEL.5.3-server-64.no_ksm.boot_vms.e1000.user.size_1024:
ERROR: run_once: Test failed: [Errno 12] Cannot allocate memory
20090611-064959
- Yolkfull Chow yz...@redhat.com wrote:
On 06/09/2009 05:44 PM, Michael Goldish wrote:
The test looks pretty nicely written. Comments:
1. Consider making all the cloned VMs use image snapshots:
curr_vm = vm1.clone()
curr_vm.get_params()[extra_params] += -snapshot
I'm
- Yolkfull Chow yz...@redhat.com wrote:
On 06/10/2009 06:03 PM, Michael Goldish wrote:
- Yolkfull Chowyz...@redhat.com wrote:
On 06/09/2009 05:44 PM, Michael Goldish wrote:
The test looks pretty nicely written. Comments:
1. Consider making all the cloned VMs
Looks fine to me.
BTW, I think debug_print() should be prefixed by a single underscore, not two.
A double underscore should be used only when name mangling is required -- at
least that's what I understood from PEP 8.
Let me know what you think.
Thanks,
Michael
- Original Message -
Looks fine to me.
- Original Message -
From: Lucas Meneghel Rodrigues l...@redhat.com
To: autot...@test.kernel.org
Cc: kvm@vger.kernel.org
Sent: Tuesday, June 9, 2009 7:33:29 PM (GMT+0200) Auto-Detected
Subject: [Autotest] [KVM-AUTOTEST PATCH 4/4] Fix bad logging calls
During the
Looks fine to me.
- Original Message -
From: Lucas Meneghel Rodrigues l...@redhat.com
To: autot...@test.kernel.org
Cc: kvm@vger.kernel.org, Lucas Meneghel Rodrigues l...@redhat.com
Sent: Tuesday, June 9, 2009 7:33:28 PM (GMT+0200) Auto-Detected
Subject: [KVM-AUTOTEST PATCH 3/4] Fix bad
The test looks pretty nicely written. Comments:
1. Consider making all the cloned VMs use image snapshots:
curr_vm = vm1.clone()
curr_vm.get_params()[extra_params] += -snapshot
I'm not sure it's a good idea to let all VMs use the same disk image.
Or maybe you shouldn't add -snapshot yourself,
- Yaniv Kaul yk...@redhat.com wrote:
Hi,
This test will boot VMs until one of them becomes unresponsive, and
records the maximum number of VMs successfully started.
Can you clarify what this test is exactly testing? Is it any of the
tests on
1. It would also be nice to add a '#!/usr/bin/python' line at the beginning of
the file, so I can make the file executable and run it without the 'python'
prefix.
2. I think you missed the exception raised in parse_file().
3. Wouldn't it be a good idea to define our own ConfigError exception
1. Inside parentheses there is no need to fix anything. e.g. the following code
is fine:
logging.info(Copying %s.tar.bz2 to guest (file is missing or has a
different size)... % test_name)
and also looks cleaner than the new version with the backslash and weird
format_str_for_message() is meant to be appended to the end of a string, with
no spaces or newlines immediately preceding it -- its job is to add spaces or
newlines as necessary.
So instead of:
logging.debug(Timeout elapsed or process terminated. Output: %s,
Small correction to 1: '#!/usr/bin/env python' instead of '#!/usr/bin/python'.
I'm not really sure what's better, but we used the one with 'env' before the
merge. We still use it in stepeditor.
Also CCing Autotest.
- Original Message -
From: Michael Goldish mgold...@redhat.com
with Autotest):
- For kvm_vm.py, kvm_utils.py, kvm_tests.py:
Uri Lublin (u...@redhat.com)
Dror Russo (dru...@redhat.com)
Michael Goldish (mgold...@redhat.com)
- For make_html_report.py:
Dror Russo (dru...@redhat.com)
(may already be there)
- For scan_results.py, calc_md5sum_1m.py, fix_cdkeys.py:
Uri Lublin
Looks good to me -- thanks.
- Original Message -
From: Yolkfull Chow yz...@redhat.com
To: kvm@vger.kernel.org
Cc: sudhir kumar smalik...@gmail.com, yogi anant...@linux.vnet.ibm.com,
Uri Lublin u...@redhat.com, kvm@vger.kernel.org
Sent: Tuesday, May 26, 2009 5:35:35 AM (GMT+0200)
Hi Lucas,
Before the merge with Autotest we used kvm_log.py to log formatted messages.
Each message contained the current test's 'shortname' (e.g.
Fedora.8.32.install), the current date and time (down to a 1 sec resolution)
and the message itself. In addition, debug messages contained the name
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Mon, 2009-06-08 at 11:15 -0700, Martin Bligh wrote:
if it's specific to one test or whatever, you could also just put
it inside the message?
No, because the test's 'shortname' contains both the test type and some
minimal information
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Mon, 2009-06-08 at 04:48 -0400, Michael Goldish wrote:
Hi Lucas,
I'm bothering you with technicalities again unfortunately:
1. I'm not sure if it's customary to add @author tags to other
modules except the main kvm.py one
it.
- Original Message -
From: sudhir kumar smalik...@gmail.com
To: kvm-devel kvm@vger.kernel.org
Cc: Uri Lublin u...@redhat.com, Michael Goldish mgold...@redhat.com,
David Huff dh...@redhat.com, Lucas Meneghel Rodrigues
mrodr...@redhat.com, Ryan Harper ry...@us.ibm.com
Sent: Saturday, June 6
- Avi Kivity a...@redhat.com wrote:
David Huff wrote:
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all the prameters in preprocess for passing
arguments to the script.
+
- Uri Lublin u...@redhat.com wrote:
On 05/10/2009 08:15 PM, sudhir kumar wrote:
Hi Uri,
Any comments?
-- Forwarded message --
From: sudhir kumarsmalik...@gmail.com
The kvm-autotest shows the following PASS results for migration,
while the VM was crashed and
- Avi Kivity a...@redhat.com wrote:
Michael Goldish wrote:
- Avi Kivity a...@redhat.com wrote:
David Huff wrote:
This patch will run pre and post scripts
defined in config file with the parameter pre_command
and post_command post_command.
Also exports all
- Avi Kivity a...@redhat.com wrote:
Michael Goldish wrote:
- What if we're interested in the status for some reason? Its
value
may indicate what went wrong with the child process.
Put it in the exception string.
But I want its value
- Avi Kivity a...@redhat.com wrote:
Michael Goldish wrote:
I think it's very rare to want to let the test continue even if
some
command fails.
Can you give examples?
Some commands are not critical, like one that converts the
screendumps
from PPM to PNG format. We
- Lucas Meneghel Rodrigues l...@redhat.com wrote:
On Sun, 2009-05-24 at 18:46 +0300, Michael Goldish wrote:
kvm_vm.py: add function VM.get_name().
kvm_preprocessing.py: use VM.get_name() instead of directly
accessing the .name
attribute.
Are there any advantages of creating
Regardless of whether the idea should be implemented, I think the code
can be simplified a bit, to look something like this:
type = params.get(type)
routine_obj = self.test_routines.get(type)
if routine_obj:
module_name = routine_obj.module_name
routine_name = routine_obj.routine_name
else:
and 30 will probably work
well enough.
On Sun, May 24, 2009 at 9:16 PM, Michael Goldish mgold...@redhat.com
wrote:
1. Make the 'login:' regular expression stricter so it doesn't
match
'Last login: ...' messages.
2. Make the 'password:' regular expression stricter.
3. Handle 'Connection
- sudhir kumar smalik...@gmail.com wrote:
On Sun, May 24, 2009 at 9:16 PM, Michael Goldish mgold...@redhat.com
wrote:
VM.create() does a few things (such as finding free ports) which are
not safe
to execute in parallel. Use a lock file to make sure this doesn't
happen. The
lock
not absolutely sure we'll have Windows 7 step files. It
depends on how well unattended installations will work, and how important it
will be to simulate user interaction with Windows 7.
On Sun, May 24, 2009 at 9:16 PM, Michael Goldish mgold...@redhat.com
wrote:
Signed-off-by: Michael Goldish mgold
(assuming it gets some testing to make sure it doesn't
break anything).
On Tue, May 5, 2009 at 1:12 AM, Michael Goldish mgold...@redhat.com
wrote:
Thanks for the new patch. I'll comment on it later because I want to
take some more time to review it.
The login prompt problem is my fault -- please
- Avi Kivity a...@redhat.com wrote:
Michael Goldish wrote:
Signed-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/kvm_vm.py | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/client/tests/kvm_runtest_2/kvm_vm.py
Fix the first barrier to include the 'boot:' prompt. This is crucial because
the guest accepts keyboard input only after this prompt appears.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
.../tests/kvm_runtest_2/steps/RHEL-4.7-i386.steps |2 +-
.../kvm_runtest_2/steps/RHEL-4.7
Fix the initial boot barriers to include the 'boot:' prompt.
Also fix a barrier in 5.3 of a dialog that sometimes appears at an unexpected
location.
Signed-off-by: Michael Goldish mgold...@redhat.com
---
.../tests/kvm_runtest_2/steps/RHEL-5.3-i386.steps | 12 ++--
.../kvm_runtest_2
Signed-off-by: Michael Goldish mgold...@redhat.com
---
.../kvm_runtest_2/steps/WinXP-32-setupssh.steps| 10 --
client/tests/kvm_runtest_2/steps/WinXP-32.steps|4 +++-
client/tests/kvm_runtest_2/steps/WinXP-64.steps|3 +--
3 files changed, 12 insertions(+), 5
-off-by: Michael Goldish mgold...@redhat.com
---
client/tests/kvm_runtest_2/stepeditor.py | 59 ++
1 files changed, 28 insertions(+), 31 deletions(-)
diff --git a/client/tests/kvm_runtest_2/stepeditor.py
b/client/tests/kvm_runtest_2/stepeditor.py
index de9a2b1
501 - 600 of 630 matches
Mail list logo
