Re: [kvm-devel] [PATCH] Don't explicitly set BAR values for VMware VGA

2008-02-22 Thread andrzej zaborowski
On 23/02/2008, Anthony Liguori <[EMAIL PROTECTED]> wrote: > andrzej zaborowski wrote: > > I have a very similar patch on my HD but I haven't included it because > > it causes my testing Ms Windows install to stop detecting the card. I > > just tested your patch and the same thing happens, i.e.

Re: [kvm-devel] [PATCH] Don't explicitly set BAR values for VMware VGA

2008-02-22 Thread Anthony Liguori
andrzej zaborowski wrote: > On 22/02/2008, Anthony Liguori <[EMAIL PROTECTED]> wrote: > >> Right now we set explict base addresses for the PCI IO regions in the VMware >> VGA device. We don't register the second region at all and instead directly >> map the physical memory. >> >> The problem

Re: [kvm-devel] [PATCH] Don't explicitly set BAR values for VMware VGA

2008-02-22 Thread andrzej zaborowski
On 22/02/2008, Anthony Liguori <[EMAIL PROTECTED]> wrote: > Right now we set explict base addresses for the PCI IO regions in the VMware > VGA device. We don't register the second region at all and instead directly > map the physical memory. > > The problem is, the addresses we're setting in th

Re: [kvm-devel] [PATCH] Don't explicitly set BAR values for VMware VGA

2008-02-22 Thread Anthony Liguori
Anthony Liguori wrote: > Right now we set explict base addresses for the PCI IO regions in the VMware > VGA device. We don't register the second region at all and instead directly > map the physical memory. > > The problem is, the addresses we're setting in the BAR is not taken into > account in t

[kvm-devel] [PATCH 15/15] provide _EJ0 method for processor removal

2008-02-22 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- bios/acpi-dsdt.dsl| 14 ++ qemu/pc-bios/bios.bin | Bin 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl index 4ce7b6a..33adfce 100755 --- a/bios/acpi-dsdt.dsl +++ b/bios/

[kvm-devel] [PATCH 13/15] provide _MAT to acpi processor

2008-02-22 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- bios/acpi-dsdt.dsl | 154 +++- 1 files changed, 140 insertions(+), 14 deletions(-) diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl index bdb591a..4ce7b6a 100755 --- a/bios/acpi-dsdt.dsl +++

[kvm-devel] [PATCH 14/15] start a new cpu thread

2008-02-22 Thread Glauber Costa
spin up a new cpu thread if not yet running. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/acpi.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c index 038e993..93cbc68 100644 --- a/qemu/hw/acpi.c +++ b/qemu/h

[kvm-devel] [PATCH 11/15] manipulate the gpe bits and send sci up the os.

2008-02-22 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/acpi.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c index 60d3094..038e993 100644 --- a/qemu/hw/acpi.c +++ b/qemu/hw/acpi.c @@ -534,10

[kvm-devel] [PATCH 12/15] isolate cpu thread creation in qemu-kvm.c

2008-02-22 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/qemu-kvm.c |9 +++-- qemu/qemu-kvm.h |1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c index ffc59d5..59fe9df 100644 --- a/qemu/qemu-kvm.c +++ b/qemu/qemu-kvm.c @@ -351,6 +351

[kvm-devel] [PATCH 10/15] handle gpe data for pio

2008-02-22 Thread Glauber Costa
actually grab and return data, instead of just being two bogus functions. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/acpi.c | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c index 02f6bab.

[kvm-devel] [PATCH 8/15] isolate cpu initialization function in hw/pc.c

2008-02-22 Thread Glauber Costa
This patch wraps up the piece of code in hw/pc.c that actually allocates and initializates a cpu. After that, plan is to be able to start it later on. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/pc.c | 40 +++- qemu/hw/pc.h |1 + 2 files

[kvm-devel] [PATCH 9/15] initialize hot add system.

2008-02-22 Thread Glauber Costa
Register the pios, and grab cpu_model for future usage. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/acpi.c | 35 +++ qemu/hw/pc.c |1 + 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c index 18

[kvm-devel] [PATCH 7/15] implement method _L00 for GPE0

2008-02-22 Thread Glauber Costa
This corresponds to the cpu hotplug functionality Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- bios/acpi-dsdt.dsl | 114 1 files changed, 114 insertions(+), 0 deletions(-) diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl index d73

[kvm-devel] [PATCH 6/15] provide operation region for pio to the gpes

2008-02-22 Thread Glauber Costa
Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- bios/acpi-dsdt.dsl |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl index 7c954c3..d738b2f 100755 --- a/bios/acpi-dsdt.dsl +++ b/bios/acpi-dsdt.dsl @@ -27,6 +27,13 @@ Definiti

[kvm-devel] [PATCH 4/15] mark processors as presents

2008-02-22 Thread Glauber Costa
mark processors as present through the _STA method Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- bios/acpi-dsdt.dsl | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl index e900795..cd42e23 100755 --- a/bios/a

[kvm-devel] [PATCH 3/15] introduce cpu_set to qemu monitor

2008-02-22 Thread Glauber Costa
in this patch, cpu_set is introduced to qemu monitor semantics is : cpu_set x online|offline. it will then tell the acpi backend to signal cpu x. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/acpi.c |3 +++ qemu/monitor.c | 16 qemu/sysemu.h |3 +++ 3

[kvm-devel] [PATCH 5/15] provide gpe _L0x methods

2008-02-22 Thread Glauber Costa
provide methods for gpe blk 0, even though they do nothing atm Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- bios/acpi-dsdt.dsl | 51 +++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.ds

[kvm-devel] [PATCH 2/15] mark extra cpus as present

2008-02-22 Thread Glauber Costa
Mark cpus over smp_cpus as present, but disable. The OS can then recognize it and make room for future hotplug Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- bios/rombios.h |2 ++ bios/rombios32.c | 21 + 2 files changed, 15 insertions(+), 8 deletions(-) diff --

[kvm-devel] [PATCH 0/15] Review: acpi processor hotplug

2008-02-22 Thread Glauber Costa
Hi, In this series, I'm sending the result-so-far of my work with acpi for processor hotplug. I'm able to put a cpu up and down (with the help of some udev scripts I wrote), but it still has some known bugs and issues. For x86_64 linux machines (because the kernel supports it), you can plug cpus t

[kvm-devel] [PATCH 1/15] Make a GPE register block be acessible.

2008-02-22 Thread Glauber Costa
gpe is acessible when its address listed by BIOS is !0. This patch makes gpe blk 0 available, and 4 bytes in length Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- bios/rombios32.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/bios/rombios32.c b/bios/rombios32.c i

[kvm-devel] [ kvm-Bugs-1899961 ] NIC not working properly with WS2008 RC1 x64

2008-02-22 Thread SourceForge.net
Bugs item #1899961, was opened at 2008-02-22 16:19 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1899961&group_id=180599 Please note that this message will contain a full copy

[kvm-devel] [PATCH] fix screen corruption bug in vga_draw_graphic()

2008-02-22 Thread Andreas Winkelbauer
hi, the attached patch fixes the screen corruption issues which were reported by others, see: http://article.gmane.org/gmane.comp.emulators.kvm.devel/13543 http://article.gmane.org/gmane.comp.emulators.kvm.devel/13409 The bug is kvm specific and can only be observed in graphics mode using re

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-22 Thread Marcelo Tosatti
On Fri, Feb 22, 2008 at 08:45:00PM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > >Another source of problems in this area is that the TSC_OFFSET is > >initialized to represent zero at different times for VCPU0 (at boot) and > >the remaining ones (at APIC_DM_INIT). > > > > > > I added tsc s

[kvm-devel] vmwarevga on recent X

2008-02-22 Thread Mark Bidewell
I posted about this on the Qemu mailing list as this behavior occurs on non-kvm Qemu as well, but has anyone used vmwarevga with recent X such as F9 alpha? When I try to run X with vmwarevga I get an error that no supported adapters were found. Has anyone else seen this? Mark Bidewell --

[kvm-devel] [PATCH] Don't explicitly set BAR values for VMware VGA

2008-02-22 Thread Anthony Liguori
Right now we set explict base addresses for the PCI IO regions in the VMware VGA device. We don't register the second region at all and instead directly map the physical memory. The problem is, the addresses we're setting in the BAR is not taken into account in the e820 mapping. This patch remov

[kvm-devel] [PATCH 1/3] Move common VGAState attributes to VGA_STATE_COMMON

2008-02-22 Thread Anthony Liguori
vmware_vga.c uses functions in vga.c to do some things. They need to agree on which parts of their state struct is common and which aren't, otherwise they'll overwrite parts of each other's state. This patch makes it so. Signed-off-by: Soren Hansen <[EMAIL PROTECTED]> Reviewed-by: Anthony Liguori

[kvm-devel] [PATCH 2/3] Factor out the VGA vram mapping updating routine

2008-02-22 Thread Anthony Liguori
This function is useful for enabling KVM support in VMware VGA. Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]> diff --git a/qemu/hw/vga.c b/qemu/hw/vga.c index 222a39c..1cfc154 100644 --- a/qemu/hw/vga.c +++ b/qemu/hw/vga.c @@ -1813,6 +1813,36 @@ typedef struct PCIVGAState { VGAState vga

[kvm-devel] [PATCH 3/3] Enable VGA optimization for VMware VGA

2008-02-22 Thread Anthony Liguori
After the previous patches, this patch is pretty straight forward. Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]> diff --git a/qemu/hw/vmware_vga.c b/qemu/hw/vmware_vga.c index ec7b1cd..f2a298e 100644 --- a/qemu/hw/vmware_vga.c +++ b/qemu/hw/vmware_vga.c @@ -36,6 +36,9 @@ # include "vga_int.

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-22 Thread Avi Kivity
Marcelo Tosatti wrote: > Another source of problems in this area is that the TSC_OFFSET is > initialized to represent zero at different times for VCPU0 (at boot) and > the remaining ones (at APIC_DM_INIT). > > I added tsc sync in the guest bios some time ago, so this should be solved now. >>

[kvm-devel] [PATCH] QEMU/KVM: report paravirt features on cpuid

2008-02-22 Thread Marcelo Tosatti
Report paravirt features on cpuid. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm-userspace/qemu/qemu-kvm-x86.c === --- kvm-userspace.orig/qemu/qemu-kvm-x86.c +++ kvm-userspace/qemu/qemu-kvm-x86.c @@ -20,6 +20,8 @@

[kvm-devel] [patch 4/4] KVM: VMX cr3 cache support (v3)

2008-02-22 Thread Marcelo Tosatti
Add support for the cr3 cache feature on Intel VMX CPU's. This avoids vmexits on context switch if the cr3 value is cached in one of the entries (currently 4 are present). This is especially important for Xenner, where each guest syscall involves a cr3 switch. v1->v2: - handle the race which happ

[kvm-devel] [patch 3/4] KVM: hypercall batching (v3)

2008-02-22 Thread Marcelo Tosatti
Batch pte updates and tlb flushes in lazy MMU mode. v1->v2: - report individual hypercall error code, have multicall return number of processed entries. - cover entire multicall duration with slots_lock instead of acquiring/reacquiring. v2->v3: - change to one ioctl per paravirt feature Signed-o

[kvm-devel] [patch 2/4] KVM: hypercall based pte updates and TLB flushes (v3)

2008-02-22 Thread Marcelo Tosatti
Hypercall based pte updates are faster than faults, and also allow use of the lazy MMU mode to batch operations. Don't report the feature if two dimensional paging is enabled. v1->v2: - guest passes physical destination addr, which is cheaper than doing v->p translation in the host. - infer size

[kvm-devel] [patch 1/4] KVM: add basic paravirt support (v3)

2008-02-22 Thread Marcelo Tosatti
Add basic KVM paravirt support. Avoid vm-exits on IO delays. v1->v2: - replace KVM_CAP_CLOCKSOURCE with KVM_CAP_PARA_FEATURES - cover FEATURE_CLOCKSOURCE v2->v3: - switch to one ioctl per paravirt feature Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> Index: kvm.paravirt3/arch/x86/Kconfig =

[kvm-devel] [patch 0/4] KVM paravirt MMU updates and cr3 caching (v3)

2008-02-22 Thread Marcelo Tosatti
The following patchset, based on earlier work by Anthony and Ingo, adds paravirt_ops support for KVM guests enabling hypercall based pte updates, hypercall batching and cr3 caching. -- - This SF.net email is sponsored by: M

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-22 Thread Marcelo Tosatti
On Fri, Feb 22, 2008 at 06:16:16PM +0200, Avi Kivity wrote: > > 2. The critical one. In normal condition, VCPU0 migrated much more > > frequently than other VCPUs. And the patch add more "delta" (always > > negative > > if host TSC is stable) to TSC_OFFSET each > > time migrated. Then after boo

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-22 Thread Avi Kivity
[copying Thomas for a question about CONSTANT_TSC, below] Yang, Sheng wrote: > I believe I have found the root cause of SMP RHEL5.1 PAE guest can't boot up > issue. The problem was caused by > kvm:6685637b211ad67bdce21bfd9f91bc888b3acb4f > "KVM: VMX: Ensure vcpu time stamp counter is monotonous"

Re: [kvm-devel] Clock off in guest

2008-02-22 Thread Steven Mooij
Koen Vermeer vermeer.tv> writes: > > I upgraded the guest kernel to 2.6.24, and the clock now seems to be > fine (at least 'sleep 10' takes about 10 seconds on the wall clock). > Thanks for all the help! > I upgraded to kernel version 2.6.24 as well (and am using kvm version 60) and time on gu

Re: [kvm-devel] vmwarevga doesn't work: "get_dirty _pages returned -2"

2008-02-22 Thread Andreas Winkelbauer
hi, > This is a known issue. I've sent a patch to this list (twice, actually) > that fixes it, but for some reason, it hasn't been applied. Search for > posts from me with "vga" or something in the subject. I applied the patch from http://people.ubuntu.com/~soren/0001-Move-common-VGAState-attrib

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-22 Thread Leslie Mann
Arne Brutschy ulb.ac.be> writes: > > BTW, Leslie: Which patch did you use? I attached a second patch as > Andreas forgot to include the changes in hw/pc.h. > All provided along with an edit to hw/pc.h, same as your second patch. Les

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-22 Thread Andreas Winkelbauer
hi, >> @Arne: Could you please test the patch with your setup? I hope it works >> this time... > Yesno. It does (at least kvm does not crash), but it shows the same > dialog problems as reported by Leslie: I'm quite sure that this issue isn't related to the widescreen fixes. This "visual bug" s

[kvm-devel] [PATCH] fix widescreen resolution issues (v3)

2008-02-22 Thread Andreas Winkelbauer
hi, I'm sorry for messing up the last patch, I shouldn't work that late... I added the changes to pc.h (VGA_RAM_SIZE) and split up the patch in a qemu part and a vgabios part. cheers, Andi --- kvm-61.orig/qemu/hw/vga_int.h 2008-02-19 15:58:28.0 +0100 +++ kvm-61/qemu/hw/vga_int.h 2008-

Re: [kvm-devel] [PATCH] Move common VGAState attributes to VGA_STATE_COMMON

2008-02-22 Thread Chris Wedgwood
On Fri, Feb 22, 2008 at 11:12:42AM +0100, Soren Hansen wrote: > vmware_vga.c uses functions in vga.c to do some things. They > need to agree on which parts of their state struct is common > and which aren't, otherwise they'll overwrite parts of each > other's state. This patch makes it so. I trie

Re: [kvm-devel] vmwarevga doesn't work: "get_dirty_pages returned -2"

2008-02-22 Thread Soren Hansen
On Fri, Feb 22, 2008 at 11:44:21AM +0200, Avi Kivity wrote: > I did provide feedback last time: > > The changes to last_ch_attr, map_addr, etc. are gratuitous and will > > cause merge conflicts in the future. Please change only the > > relevant lines. > You probably didn't see it, since you have M

Re: [kvm-devel] [PATCH] Move common VGAState attributes to VGA_STATE_COMMON

2008-02-22 Thread Soren Hansen
vmware_vga.c uses functions in vga.c to do some things. They need to agree on which parts of their state struct is common and which aren't, otherwise they'll overwrite parts of each other's state. This patch makes it so. Signed-off-by: Soren Hansen <[EMAIL PROTECTED]> --- qemu/hw/cirrus_vga.c |

Re: [kvm-devel] vmwarevga doesn't work: "get_dirty_pages returned -2"

2008-02-22 Thread Avi Kivity
Soren Hansen wrote: > On Thu, Feb 21, 2008 at 02:23:07PM +0100, Andreas Winkelbauer wrote: > >>> Most likely it only works with Linux; it was probably written by >>> reverse-engineering the Linux driver. >>> >> actually -vmwarevga works for me when using pure qemu (latest cvs >> snapshot)

[kvm-devel] KVM Test result, kernel d664df6.., userspace 70d2a9d..

2008-02-22 Thread Zhao, Yunfeng
Hi,All This is today's KVM test result against kvm.git d664df6bbf0b6212824340bc70a9b888461dcd36 and kvm-userspace.git 70d2a9dc3594446f3ad66b32abc94c08b74118d. There's no new issue. Five old issues: 1. Fails to save/restore guests https://sourceforge.net/tracker/index.php?func=detail&aid=1824525&g

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-22 Thread Arne Brutschy
Hi all, On Fr, 2008-02-22 at 03:11 +0100, Andreas Winkelbauer wrote: > I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The > crash was caused by a really _dirty_ hack in a kvm specific part of > vga.c (it took me at least an hour to find this amazing piece of code... > at le

Re: [kvm-devel] vmwarevga doesn't work: "get_dirty_pages returned -2"

2008-02-22 Thread Soren Hansen
On Thu, Feb 21, 2008 at 02:23:07PM +0100, Andreas Winkelbauer wrote: >> Most likely it only works with Linux; it was probably written by >> reverse-engineering the Linux driver. > actually -vmwarevga works for me when using pure qemu (latest cvs > snapshot) without kqemu (-no-kqemu), but it does no

[kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-22 Thread Yang, Sheng
I believe I have found the root cause of SMP RHEL5.1 PAE guest can't boot up issue. The problem was caused by kvm:6685637b211ad67bdce21bfd9f91bc888b3acb4f "KVM: VMX: Ensure vcpu time stamp counter is monotonous" (It didn't take me much time to found the solution, but a lot of time to find the pr