Re: [kvm-devel] [kvm-ppc-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-28 Thread Avi Kivity
Hollis Blanchard wrote: It doesn't have to be a package; it can be as simple as a tarball that people have to make; sudo make install before compiling kvm, the same as other prerequisite libraries. Sure. Let's put that tarball inside the qemu directory, and then have it extracted

Re: [kvm-devel] [PATCH] Fix qemu PPC breakage in monitor.c

2008-02-28 Thread Avi Kivity
Jerone Young wrote: Recent pull of qemu_cvs has added function qemu_system_cpu_hot_add to the function do_cput_set_nr in monitor.c . Issue is qemu_system_cpu_hot_add is defined in acpi.c which is only compiled for arch with target base i386 (which are i386 x86-64). Applied, thanks.

Re: [kvm-devel] [kvm-ppc-devel] [PATCH] Fix qemu PPC breakage in monitor.c

2008-02-28 Thread Avi Kivity
Hollis Blanchard wrote: On Wed, 2008-02-27 at 16:14 -0600, Jerone Young wrote: # HG changeset patch # User Jerone Young [EMAIL PROTECTED] # Date 1204150440 21600 # Branch merge # Node ID f255b23b6ef9461be4ee18fa0745f30c4fb66e6a # Parent 64a281615f436e65ca7fb2f3c2721c374fbfc8be Fix

Re: [kvm-devel] [PATCH] Add --disable-cpu-emulation to qemu help screen

2008-02-28 Thread Avi Kivity
Jerone Young wrote: This patch adds a line to the help screen of configure for qemu to show the option --disable-cpu-emulation Applied, thanks. -- error compiling committee.c: too many arguments to function - This

Re: [kvm-devel] Booting from Virtio block device

2008-02-28 Thread Avi Kivity
Haydn Solomon wrote: I didn't create the initrd with the modules preloaded. Still not working yet but I'm wondering... will this work with LVM volumes? It's actually easier since you don't have to change your root= line. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [ANNOUNCE] kvm-62 release

2008-02-27 Thread Avi Kivity
Jim Paris wrote: Hi, - add file:// migration protocol (Uri Lublin) commit 70d2a9dc3594446f3ad66b32abc94c08b74118d4 Author: Uri Lublin [EMAIL PROTECTED] Date: Thu Feb 21 15:00:50 2008 +0200 kvm: qemu: migration: added file:// migration protocol Instead of writing

Re: [kvm-devel] [PATCH] Fix PowerPC Qemu CPU initilization when using target-ppc/fake-exec.c

2008-02-27 Thread Avi Kivity
Jerone Young wrote: # HG changeset patch # User Jerone Young [EMAIL PROTECTED] # Date 1204046245 21600 # Branch merge # Node ID 1980deb2bddff30c2f798d33937759a7ce91c242 # Parent e1260182b60d6d6716870c3bff82f503fad868fb Fix PowerPC Qemu CPU initilization when using target-ppc/fake-exec.c

Re: [kvm-devel] [ANNOUNCE] kvm-62 release

2008-02-27 Thread Avi Kivity
Uri Lublin wrote: Opening a file, and writing into it is simpler anyway. I too do not know yet why exec:dd sometimes fails. It might be SIGCHLD raise after dd's death. We ought to block it. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH 0/15] acpi processor hotplug

2008-02-27 Thread Avi Kivity
Glauber Costa wrote: Hi, I'm resending the series with avi's few comments merged, and a couple of others on my own: * _STA returns 0xF instead of 0x1. According to the specification, it means that the device, besides present, is also functional, enabled, and a couple of other cool

Re: [kvm-devel] kvm-60: kexec in guest crashes the host

2008-02-27 Thread Avi Kivity
Dan Aloni wrote: On Wed, Feb 20, 2008 at 11:09:44AM +0200, Avi Kivity wrote: Dan Aloni wrote: It happens at 100% of the times I invoke kexec. Can you provide a commandline which triggers this? I'm completely ignorant wrt kexec. I managed to verify

Re: [kvm-devel] KVM Test result, KVM62-RC2

2008-02-27 Thread Avi Kivity
Marcelo Tosatti wrote: On Wed, Feb 27, 2008 at 11:12:03AM +0100, Farkas Levente wrote: You can workaround these problems by using a different, less problematic clocksource such as acpipm, until the TSC/migration issues are fully resolved. Add clocksource=acpi_pm to the kernel options.

Re: [kvm-devel] kvm-60: kexec in guest crashes the host

2008-02-27 Thread Avi Kivity
Avi Kivity wrote: Dan Aloni wrote: On Wed, Feb 20, 2008 at 11:09:44AM +0200, Avi Kivity wrote: Dan Aloni wrote: It happens at 100% of the times I invoke kexec. Can you provide a commandline which triggers this? I'm completely ignorant wrt kexec

Re: [kvm-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Avi Kivity
Hollis Blanchard wrote: It is a centrally co-ordinated effort, but it is not a package a distro would carry. It is code shared by anything that needs to load a PowerPC Linux kernel, for example: the kernel bootwrapper (part of the Linux source tree), u-boot firmware, Xend, and now qemu.

Re: [kvm-devel] [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()

2008-02-27 Thread Avi Kivity
() to anon_inode_allocfd() so that any code using the old interface breaks at compilation rather than failing in a strange way. Fix up all the in-kernel users to use the new interface. The kvm changes are Acked-by: Avi Kivity [EMAIL PROTECTED] -- Any sufficiently difficult bug is indistinguishable from

Re: [kvm-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-27 Thread Avi Kivity
Hollis Blanchard wrote: I think it's obvious that Linux and uboot will never use this. Unless someone steps up to continue PowerPC Xen development, neither will Xen. So you've now narrowed down the use case to dtc (which is libfdt upstream) and qemu. Is Xen ppc discontinued? Whose

Re: [kvm-devel] [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd()

2008-02-27 Thread Avi Kivity
Roland Dreier wrote: http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=49be4f8114e6ff0efdab10ebba2493fb67bc3034 Actually, looking closer at the kvm changes here, I think that create_vcpu_fd() needs the same treatment as kvm_dev_ioctl_create_vm() gets in the patch

Re: [kvm-devel] still seeing network freezes with rtl8139 nic

2008-02-26 Thread Avi Kivity
david ahern wrote: Almost 7 hours and the uniprocessor case is still chugging along. How long does it usually take to hang? How do I go about reproducing this? apachebench (host) against httpd (guest) doesn't seem to trigger it. -- error compiling committee.c: too many arguments to

Re: [kvm-devel] KVM Test result, KVM62-RC2

2008-02-26 Thread Avi Kivity
Yang, Sheng wrote: One new issue: 1. qcow based smp linux guests likely hang https://sourceforge.net/tracker/index.php?func=detailaid=1901980group_ id=180599atid=893831 We found the issue while booting qcow based rhel5.1 smp guest. It likely hangs at the first booting. If using raw disk

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-26 Thread Avi Kivity
Dong, Eddie wrote: I don't know if the patch was still needed now, since it was posted long ago(I don't know which issue it solved). I'd like to post a revert patch if necessary. I believe the patch is still necessary, since we still need to guarantee that a vcpu's tsc is

Re: [kvm-devel] [PATCH] KVM: detect if VCPU triple faults

2008-02-26 Thread Avi Kivity
Joerg Roedel wrote: In the current inject_page_fault path KVM only checks if there is another PF pending and injects a DF then. But it has to check for a pendig DF too to detect a shutdown condition in the VCPU. If this is not detected the VCPU goes to a PF - DF - PF loop when it should triple

Re: [kvm-devel] still seeing network freezes with rtl8139 nic

2008-02-26 Thread Avi Kivity
Avi Kivity wrote: david ahern wrote: Almost 7 hours and the uniprocessor case is still chugging along. How long does it usually take to hang? How do I go about reproducing this? apachebench (host) against httpd (guest) doesn't seem to trigger it. ab (on host) against httpd (on guest

[kvm-devel] [ANNOUNCE] kvm-62 release

2008-02-26 Thread Avi Kivity
Fixes the longstanding RHEL 5 i386 smp boot problem as well as the recent Intel Core regression. Large page support improves performance for dedicated virtualization hosts, while vmware vga and more std-vga resolutions should improve the home user experience. Changes from kvm-61: - fix oops

Re: [kvm-devel] still seeing network freezes with rtl8139 nic

2008-02-26 Thread Avi Kivity
david ahern wrote: Usually within a few hours, sometimes within 30 minutes. Load averages as computed by sysstat in the nightly sar files: rxpck/s txpck/s rxbyt/s txbyt/s eth0975.18 1188.34 82044.06 171655.38 Interrupts come in at 1830/sec for eth0, 250/sec for the

Re: [kvm-devel] [PATCH] KVM: detect if VCPU triple faults

2008-02-26 Thread Avi Kivity
Joerg Roedel wrote: In the current inject_page_fault path KVM only checks if there is another PF pending and injects a DF then. But it has to check for a pendig DF too to detect a shutdown condition in the VCPU. If this is not detected the VCPU goes to a PF - DF - PF loop when it should triple

Re: [kvm-devel] still seeing network freezes with rtl8139 nic

2008-02-25 Thread Avi Kivity
david ahern wrote: I've run a lot more tests: - if I remove the if (!change) return optimization from pci_set_irq the rtl8139 nic worked fine for 16+ hours. I'm not recommending this as a fix, just confirming that the problem goes away. Interesting. What can cause this to happen? -

Re: [kvm-devel] Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies

2008-02-25 Thread Avi Kivity
Jerone Young wrote: The top level directory of kvm-userspace is starting to get a little crowded as we start to bring in more external dependencies. Perhaps we can create a folder tools and move directories: bios extboot vgabios The reason I mention this is soon I will be sending a patch

Re: [kvm-devel] KVM Test result, kernel 81e4400.., userspace 08385e4.. , One new issue

2008-02-25 Thread Avi Kivity
Yang, Sheng wrote: On Monday 25 February 2008 16:41:25 Zhao, Yunfeng wrote: Hi, all, This is today's KVM test result against kvm.git 81e4400b4df4e597a81c19c1161aa03c73613710 and kvm-userspace.git 08385e49dcff3585f597870af67301d7659a1ecb. One new issue has been found in today's testing:

Re: [kvm-devel] Status of FreeBSD 6.3 as a guest

2008-02-25 Thread Avi Kivity
Colin Paul Adams wrote: Avi == Avi Kivity [EMAIL PROTECTED] writes: Avi Colin Paul Adams wrote: This isn't mentioned on the guest status page. I went ahead and tried it anyway (32-bit). It works fine if I don't specify -smp 2. But qemu

Re: [kvm-devel] KVM Test result, kernel 81e4400.., userspace 08385e4.. , One new issue

2008-02-25 Thread Avi Kivity
Alexander Graf wrote: On Feb 25, 2008, at 10:34 AM, Avi Kivity wrote: Yang, Sheng wrote: On Monday 25 February 2008 16:41:25 Zhao, Yunfeng wrote: Hi, all, This is today's KVM test result against kvm.git 81e4400b4df4e597a81c19c1161aa03c73613710 and kvm-userspace.git

Re: [kvm-devel] [PATCH 4/15] mark processors as presents

2008-02-25 Thread Avi Kivity
Glauber Costa wrote: There is now code in rombios32.c to do this. It needs to be removed. See acpi_build_processor_ssdt(). Building the table by hand is trivial in the case where the processors are just _listed_, and can be easily justified. This first patch just add the _STA method,

Re: [kvm-devel] [kvm-ia64-devel] [PATCH] Using kzalloc to avoid allocatingkvm_regs from kernel stack

2008-02-25 Thread Avi Kivity
Zhang, Xiantao wrote: Updated one. Sorry for inconvenience. Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all challenges.

Re: [kvm-devel] [PATCH] KVM: release bad page on MSR_KVM_SYSTEM_TIME

2008-02-25 Thread Avi Kivity
Marcelo Tosatti wrote: Subject says it all. Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual

Re: [kvm-devel] KVM Test result, kernel 81e4400.., userspace 08385e4.. , One new issue

2008-02-25 Thread Avi Kivity
Alexander Graf wrote: The ebx store was done because of PIC code, which does not allow ebx to get clobbered. If we are not in PIC code, =r contains ebx as GPR though, so the assumption that ebx needs to be restored was wrong then. This new version only enables the store/restore code if

Re: [kvm-devel] still seeing network freezes with rtl8139 nic

2008-02-25 Thread Avi Kivity
david ahern wrote: david ahern wrote: Avi Kivity wrote: - the in-kernel ioapic is buggy and needs the extra kicking the optimization prevents. Can be checked by re-adding the optimization to kvm_ioapic_set_irq() (keeping it removed in qemu). If it works, the problem

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-25 Thread Avi Kivity
Farkas Levente wrote: Avi Kivity wrote: Farkas Levente wrote: will be a new release in the near future? since many of us waiting for this bug to be fixed on quad and other multi core cpus. Certainly. Can you try out the attached patch? thanks. it works

Re: [kvm-devel] KVM Test result, kernel 81e4400.., userspace 08385e4.. , One new issue

2008-02-25 Thread Avi Kivity
Alexander Graf wrote: On Feb 25, 2008, at 6:40 PM, Avi Kivity wrote: Alexander Graf wrote: The ebx store was done because of PIC code, which does not allow ebx to get clobbered. If we are not in PIC code, =r contains ebx as GPR though, so the assumption that ebx needs to be restored

Re: [kvm-devel] [PATCH 1/3] Move common VGAState attributes to VGA_STATE_COMMON

2008-02-24 Thread Avi Kivity
Anthony Liguori wrote: vmware_vga.c uses functions in vga.c to do some things. They need to agree on which parts of their state struct is common and which aren't, otherwise they'll overwrite parts of each other's state. This patch makes it so. Signed-off-by: Soren Hansen [EMAIL PROTECTED]

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v3)

2008-02-24 Thread Avi Kivity
Andreas Winkelbauer wrote: hi, I'm sorry for messing up the last patch, I shouldn't work that late... I added the changes to pc.h (VGA_RAM_SIZE) and split up the patch in a qemu part and a vgabios part. Applied, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-24 Thread Avi Kivity
Farkas Levente wrote: will be a new release in the near future? since many of us waiting for this bug to be fixed on quad and other multi core cpus. Certainly. Can you try out the attached patch? -- error compiling committee.c: too many arguments to function diff --git

Re: [kvm-devel] Status of FreeBSD 6.3 as a guest

2008-02-24 Thread Avi Kivity
Colin Paul Adams wrote: This isn't mentioned on the guest status page. I went ahead and tried it anyway (32-bit). It works fine if I don't specify -smp 2. But qemu rejects -m 2048. -m 1024 is fine. I had over 3GB available memory (I presume all the memory is pae-fixed to avoid both host and

Re: [kvm-devel] [PATCH 4/15] mark processors as presents

2008-02-24 Thread Avi Kivity
Glauber Costa wrote: mark processors as present through the _STA method Signed-off-by: Glauber Costa [EMAIL PROTECTED] --- bios/acpi-dsdt.dsl | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl index

Re: [kvm-devel] [PATCH 3/15] introduce cpu_set to qemu monitor

2008-02-24 Thread Avi Kivity
Glauber Costa wrote: in this patch, cpu_set is introduced to qemu monitor semantics is : cpu_set x online|offline. it will then tell the acpi backend to signal cpu x. index e21ded0..18561e0 100644 --- a/qemu/hw/acpi.c +++ b/qemu/hw/acpi.c @@ -533,3 +533,6 @@ void

Re: [kvm-devel] [PATCH 0/15] Review: acpi processor hotplug

2008-02-24 Thread Avi Kivity
Glauber Costa wrote: Hi, In this series, I'm sending the result-so-far of my work with acpi for processor hotplug. I'm able to put a cpu up and down (with the help of some udev scripts I wrote), but it still has some known bugs and issues. For x86_64 linux machines (because the kernel

Re: [kvm-devel] [PATCH] qemu: implicit precedence for logical operator in has_work

2008-02-24 Thread Avi Kivity
Carlo Marcelo Arenas Belon wrote: janitorial fix for : qemu/qemu-kvm.c: In function `has_work': qemu/qemu-kvm.c:140: warning: suggest parentheses around within || Applied, thanks. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [PATCH] qemu: implicit precedence for logical operator in has_work

2008-02-24 Thread Avi Kivity
Alexander Graf wrote: On Feb 20, 2008, at 9:30 AM, Carlo Marcelo Arenas Belon wrote: janitorial fix for : qemu/qemu-kvm.c: In function `has_work': qemu/qemu-kvm.c:140: warning: suggest parentheses around within || Signed-off-by: Carlo Marcelo Arenas Belon [EMAIL PROTECTED] ---

Re: [kvm-devel] still seeing network freezes with rtl8139 nic

2008-02-24 Thread Avi Kivity
david ahern wrote: I know this issue has been discussed on this list before, but I am still experiencing network freezes in a guest that requires a restart to clear. When the network freezes in the guest I no longer see the network interrupts counter incrementing (i.e., the eth0 counter in

Re: [kvm-devel] [PATCH] Allow kvm to use more than 4 VCPUs

2008-02-24 Thread Avi Kivity
Anthony Liguori wrote: This patch actually allows KVM to be used with more than 4 VCPUs. The change in qemu-kvm.c was pretty difficult to find because it was using an open coded array size of 4. I changed that array to be 256 since that's the real maximum on x86 and the additional storage

Re: [kvm-devel] [PATCH 1/3] Move common VGAState attributes to VGA_STATE_COMMON

2008-02-24 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: The trick to passing through patches is to have a From: Original Author [EMAIL PROTECTED] line in the beginning, which git picks up and uses to maintain authorship information. Also, sign-off normally. Acked-by means I know the author while

Re: [kvm-devel] [PATCH] KVM: large page support

2008-02-23 Thread Avi Kivity
Marcelo Tosatti wrote: Create large pages mappings if the guest PTE's are marked as such and the underlying memory is hugetlbfs backed. Gives a consistent 2% improvement for data copies on ram mounted filesystem, without NPT/EPT. Applied, thanks (as well as the qemu part). -- error

Re: [kvm-devel] [PATCH] fix screen corruption bug in vga_draw_graphic()

2008-02-23 Thread Avi Kivity
Andreas Winkelbauer wrote: hi, the attached patch fixes the screen corruption issues which were reported by others, see: http://article.gmane.org/gmane.comp.emulators.kvm.devel/13543 http://article.gmane.org/gmane.comp.emulators.kvm.devel/13409 The bug is kvm specific and can only be

Re: [kvm-devel] [PATCH] Don't explicitly set BAR values for VMware VGA

2008-02-23 Thread Avi Kivity
Anthony Liguori wrote: Right now we set explict base addresses for the PCI IO regions in the VMware VGA device. We don't register the second region at all and instead directly map the physical memory. The problem is, the addresses we're setting in the BAR is not taken into account in the

Re: [kvm-devel] [PATCH] Move common VGAState attributes to VGA_STATE_COMMON

2008-02-23 Thread Avi Kivity
Soren Hansen wrote: vmware_vga.c uses functions in vga.c to do some things. They need to agree on which parts of their state struct is common and which aren't, otherwise they'll overwrite parts of each other's state. This patch makes it so. Applied, thanks. -- error compiling

Re: [kvm-devel] vmwarevga doesn't work: get_dirty_pages returned -2

2008-02-22 Thread Avi Kivity
Soren Hansen wrote: On Thu, Feb 21, 2008 at 02:23:07PM +0100, Andreas Winkelbauer wrote: Most likely it only works with Linux; it was probably written by reverse-engineering the Linux driver. actually -vmwarevga works for me when using pure qemu (latest cvs snapshot) without kqemu

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-22 Thread Avi Kivity
[copying Thomas for a question about CONSTANT_TSC, below] Yang, Sheng wrote: I believe I have found the root cause of SMP RHEL5.1 PAE guest can't boot up issue. The problem was caused by kvm:6685637b211ad67bdce21bfd9f91bc888b3acb4f KVM: VMX: Ensure vcpu time stamp counter is monotonous (It

Re: [kvm-devel] The SMP RHEL 5.1 PAE guest can't boot up issue

2008-02-22 Thread Avi Kivity
Marcelo Tosatti wrote: Another source of problems in this area is that the TSC_OFFSET is initialized to represent zero at different times for VCPU0 (at boot) and the remaining ones (at APIC_DM_INIT). I added tsc sync in the guest bios some time ago, so this should be solved now. This

Re: [kvm-devel] [PATCH] Fix host_cpuid() in qemu/qemu-kvm-x86.c

2008-02-21 Thread Avi Kivity
Bernhard Kaindl wrote: Hi, I found that on kvm-61 the cpuid in the guest was reported incorrectly when qemu-kvm was compiled with gcc-4.1 or 4.3. This resulted in linux-64bit not booting, complaining that it is not running on a 64-bit machine. Symptom: Unexpected behaviour after the

Re: [kvm-devel] [PATCH] fix widescreen resolution issues

2008-02-21 Thread Avi Kivity
Andreas Winkelbauer wrote: hi, the attached patch fixes the issues with widescreen resolutions for me when using -std-vga. in vgabios/vbetables-gen.c I changed the video memory from 8MB to 16MB which is sufficient for resolutions up to 2560x1600. I've also added some more video modes

Re: [kvm-devel] [PATCH] kvm: sparse fixes for kvm/x86.c

2008-02-21 Thread Avi Kivity
Harvey Harrison wrote: In two case statements, use the ever popular 'i' instead of index: arch/x86/kvm/x86.c:1063:7: warning: symbol 'index' shadows an earlier one arch/x86/kvm/x86.c:1000:9: originally declared here arch/x86/kvm/x86.c:1079:7: warning: symbol 'index' shadows an earlier one

Re: [kvm-devel] vmwarevga doesn't work: get_dirty_pages returned -2

2008-02-21 Thread Avi Kivity
Andreas Winkelbauer wrote: hi, I tried using the -vmwarevga switch but I didn't succeed. I've tested it with kvm-snapshot-20080218, kvm-60 and kvm-61. as soon as the VM (guest os is windows xp) switches from text mode to graphics mode lots of messages kvm: get_dirty_pages returned -2

Re: [kvm-devel] [PATCH] Fix host_cpuid() in qemu/qemu-kvm-x86.c

2008-02-21 Thread Avi Kivity
Alexander Graf wrote: This version fixes a wrong identifier (%0 instead of %1) and makes things work without touching the stack. This works by using %esi as backup-register for %ebx. It furthermore moves function directly to eax, without relying on gcc optimizations to realize this.

Re: [kvm-devel] [PATCH] Implement dummy values for MSR_PERF_STATUS

2008-02-21 Thread Avi Kivity
Alexander Graf wrote: Hi, this is mostly the same patch I sent to the list several weeks ago, but with fixed whitespaces and comments. It implements a dummy value for the MSR_PERF_STATUS MSR. Darwin relies on this and ceases to work without. Applied, thanks. -- error compiling

Re: [kvm-devel] [patch 2/5] KVM: hypercall based pte updates and TLB flushes (v2)

2008-02-21 Thread Avi Kivity
Marcelo Tosatti wrote: Hypercall based pte updates are faster than faults, and also allow use of the lazy MMU mode to batch operations. Don't report the feature if two dimensional paging is enabled. +static int kvm_hypercall_mmu_write(struct kvm_vcpu *vcpu, gpa_t addr, +

Re: [kvm-devel] [patch 1/5] KVM: add basic paravirt support (v2)

2008-02-21 Thread Avi Kivity
Marcelo Tosatti wrote: Add basic KVM paravirt support. Avoid vm-exits on IO delays. Add KVM_GET_PARA_FEATURES ioctl so paravirt features can be reported in a single bitmask. This allows the host to disable features on runtime if appropriate, which would require one ioctl per feature

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching (v2)

2008-02-21 Thread Avi Kivity
Marcelo Tosatti wrote: Batch pte updates and tlb flushes in lazy MMU mode. v1-v2: - report individual hypercall error code, have multicall return number of processed entries. - cover entire multicall duration with slots_lock instead of acquiring/reacquiring. But not all hypercalls

Re: [kvm-devel] [patch 4/5] KVM: ignore zapped root pagetables (v2)

2008-02-21 Thread Avi Kivity
Marcelo Tosatti wrote: Mark zapped root pagetables as invalid and ignore such pages during lookup. This is a problem with the cr3-target feature, where a zapped root table fools the faulting code into creating a read-only mapping. The result is a lockup if the instruction can't be emulated.

Re: [kvm-devel] [patch 1/5] KVM: add basic paravirt support (v2)

2008-02-21 Thread Avi Kivity
Marcelo Tosatti wrote: One ioctl per feature sounded like unnecessary code duplication. I have no problems with it though. So you prefer that way? Yes. I think we can avoid code duplication. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching (v2)

2008-02-21 Thread Avi Kivity
Marcelo Tosatti wrote: On Thu, Feb 21, 2008 at 05:52:25PM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: Batch pte updates and tlb flushes in lazy MMU mode. v1-v2: - report individual hypercall error code, have multicall return number of processed entries. - cover entire

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching (v2)

2008-02-21 Thread Avi Kivity
Marcelo Tosatti wrote: On Thu, Feb 21, 2008 at 08:30:04PM +0200, Avi Kivity wrote: Perhaps you want to move that enforcement to the host. This allows batching of future hypercalls (if appropriate) to be easy. I'm still uneasy about it, though I have no rational reasons left

Re: [kvm-devel] large page support for kvm

2008-02-21 Thread Avi Kivity
Marcelo Tosatti wrote: I don't follow. Can you describe the scenario in more detail? The state of the guest and shadow page tables, and what actually happens? Have a kernel level-3 table at guest physical address 0x280. The kernel direct translation which maps to that

Re: [kvm-devel] [PATCH] fix reading from character devices

2008-02-21 Thread Avi Kivity
Jan Kiszka wrote: I think this got lost somehow. Find refreshed patch below. Avi, could you apply it kvm-userland to fix the still existent regression? Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [kvm-devel] [PATCH] fix widescreen resolution issues (v2)

2008-02-21 Thread Avi Kivity
Andreas Winkelbauer wrote: hi, I found out what crashed kvm when I increased VGA_RAM_SIZE in pc.h. The crash was caused by a really _dirty_ hack in a kvm specific part of vga.c (it took me at least an hour to find this amazing piece of code... at least the HACK ALERT was a good hint ;-)

Re: [kvm-devel] [PATCH] call write_guest_time as soon as we register the paravirt clock.

2008-02-21 Thread Avi Kivity
Glauber de Oliveira Costa wrote: From: Glauber Costa [EMAIL PROTECTED] In situations, like, cpu hotplugging, a cpu can arrive later on the game and register its paravirt clock while everything else is already running, which will lead to breakage, since the time readings will return bogus

Re: [kvm-devel] kvm-60: kexec in guest crashes the host

2008-02-20 Thread Avi Kivity
Dan Aloni wrote: It happens at 100% of the times I invoke kexec. Can you provide a commandline which triggers this? I'm completely ignorant wrt kexec. -- Any sufficiently difficult bug is indistinguishable from a feature.

Re: [kvm-devel] Out-of-box kvm-61 driver crash, first kvm problem ever, boo hoo...

2008-02-20 Thread Avi Kivity
Avi Kivity wrote: [EMAIL PROTECTED] wrote: EIP: [f8b8dcd2] vmx_set_efer+0xa2/0xb0 [kvm_intel] SS:ESP 0068:f4a63ed4 Not completely unexpected. You are running a Core (not 2) processor which doesn't support nx or x86_64, so it doesn't have the EFER register. kvm-61 adds support

Re: [kvm-devel] Out-of-box kvm-61 driver crash, first kvm problem ever, boo hoo...

2008-02-20 Thread Avi Kivity
[EMAIL PROTECTED] wrote: EIP: [f8b8dcd2] vmx_set_efer+0xa2/0xb0 [kvm_intel] SS:ESP 0068:f4a63ed4 Not completely unexpected. You are running a Core (not 2) processor which doesn't support nx or x86_64, so it doesn't have the EFER register. kvm-61 adds support for the EFER on i386, but

Re: [kvm-devel] howto set up a virtual firewall?

2008-02-20 Thread Avi Kivity
Kurt Neufeld wrote: Hey there, I've searched high and low but can't find an answer to my problem and I find it hard to believe that I'm the only person that wants to do this. I would like to setup a virtual machine that is my firewall. So far I've got Shorewall setup in a virtual machine

Re: [kvm-devel] build #365 issue for v2.6.25-rc2-342-g5d9c4a7 in ./arch/x86/kvm/kvm.ko

2008-02-20 Thread Avi Kivity
Avi Kivity wrote: Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... HOSTCC arch/x86/boot/tools/build BUILD arch/x86/boot/bzImage Root device is (3, 8) Setup is 12280 bytes (padded to 12288 bytes). System is 2192 kB Kernel: arch/x86/boot/bzImage

Re: [kvm-devel] build #365 issue for v2.6.25-rc2-342-g5d9c4a7 in ./arch/x86/kvm/kvm.ko

2008-02-20 Thread Avi Kivity
Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... HOSTCC arch/x86/boot/tools/build BUILD arch/x86/boot/bzImage Root device is (3, 8) Setup is 12280 bytes (padded to 12288 bytes). System is 2192 kB Kernel: arch/x86/boot/bzImage is ready

Re: [kvm-devel] mmdrop external module oops

2008-02-20 Thread Avi Kivity
Andrea Arcangeli wrote: A 2.6.25-rc based kernel spawned an oops in mmdrop when kvm quit so that reminded me of this: Applied, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature. - This

Re: [kvm-devel] large page support for kvm

2008-02-20 Thread Avi Kivity
Marcelo Tosatti wrote: + /* +* Largepage creation is susceptible to a upper-level +* table to be shadowed and write-protected in the +* area being mapped. If that is the case, invalidate +*

Re: [kvm-devel] [PATCH] enable gfxboot on VMX

2008-02-19 Thread Avi Kivity
Anthony Liguori wrote: Keep in mind, this is not big real mode. The gfxboot code here was actually rewritten to not use big real mode so that it worked with Xen. It works with Xen because Xen uses vm86 mode within the host whereas KVM uses vm86 mode in the guest's VT context. I don't

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching

2008-02-19 Thread Avi Kivity
Hollis Blanchard wrote: Kernel data is physically contiguous (true for per-cpu data as well?), so no there's issue here. So this is an addition to the ABI, that the data must be physically contiguous. That's a pretty subtle implicit requirement, and it's easy to resolve the issue by

Re: [kvm-devel] [RFC] Performance monitoring units and KVM

2008-02-19 Thread Avi Kivity
Markus Armbruster wrote: Balaji Rao [EMAIL PROTECTED] writes: Hi all! Earlier it was suggested that we go ahead with emulating Perf Mon Events in exposing it to the guest. The serious limitation in this approach is that we end up exposing only a small number of events to the guest,

[kvm-devel] [ANNOUNCE] kvm-61 release

2008-02-19 Thread Avi Kivity
Long time since the last release, hence the long changelog. If you have an AMD Barcelona, you should see a very significant performance boost from the Nested Page Table feature. Changes from kvm-60: - paravirtualized clock (Glauber de Oliveira Costa) - mmu debug compile fix (Marcelo Tosatti) -

Re: [kvm-devel] [PATCH 3/3] x86, kvm: make register_address_increment and JMP_REL static inlines

2008-02-19 Thread Avi Kivity
Harvey Harrison wrote: Change to jmp_rel now that it is a function. Applied all three patches, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Microsoft

Re: [kvm-devel] Widescreen troubles again

2008-02-19 Thread Avi Kivity
Arne Brutschy wrote: Hi, thanks for the response! On Di, 2008-02-19 at 15:08 +, Andreas Winkelbauer wrote: well, I think it is very unlikely that the vgabios is located at /usr/share/kvm or so. It actually is, and qemu is using it correctly. I contacted the author of the

Re: [kvm-devel] kvm-60: kexec in guest crashes the host

2008-02-19 Thread Avi Kivity
Dan Aloni wrote: Hello, I have a host running kvm-60-git (fc9e77f83b26089d6228e149605be69228905dc7) and a guest running a modified 2.6.16 kernel. Both are of the x86_64 arch. kvm-userspace is e978013e3a121aae54ad4c47be5e92a23b8084a4. When the guest invokes kexec, the host crashes with

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching

2008-02-18 Thread Avi Kivity
Hollis Blanchard wrote: On Sat, 2008-02-16 at 17:09 -0500, Marcelo Tosatti wrote: plain text document attachment (kvm-multicall) Batch pte updates and tlb flushes in lazy MMU mode. Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Cc: Anthony Liguori [EMAIL PROTECTED] Index:

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching

2008-02-18 Thread Avi Kivity
Christian Borntraeger wrote: Am Montag, 18. Februar 2008 schrieb Avi Kivity: AFAICS there is no guarantee about page-alignment here... Kernel data is physically contiguous (true for per-cpu data as well?), so no there's issue here. Modules are loaded into vmalloc

Re: [kvm-devel] compile error

2008-02-18 Thread Avi Kivity
Zhao, Yunfeng wrote: Today’s IA32e KVM build fails, here is the error message: libqemu.a(kvm-tpr-opt.o): In function `enable_vapic': /workspace/ia32e/nightly/kvm-master-2.6.22-rc4-20080218000132559/kvm-userspace/qemu/kvm-tpr-opt.c:232: undefined reference to `kvm_enable_vapic'

Re: [kvm-devel] compile error

2008-02-18 Thread Avi Kivity
Zhao, Yunfeng wrote: I am using TIP. I found that if try to compile twice, the first time has no problem but the second time (make clean./configuremake) will meet the error. Yes, 'make clean' was too eager. Fixed. -- error compiling committee.c: too many arguments to function

Re: [kvm-devel] [kvm-ppc-devel] upstream PowerPC qemu breakage

2008-02-18 Thread Avi Kivity
Hollis Blanchard wrote: Unfortunately I wasn't able to get an F8 ppc rescue cd ISO to boot with qemu 0.9.0. Can you point me to a working combination? It's difficult to get anything booting with upstream PowerPC qemu, mostly because of the unmaintained firmware they use (called Open

Re: [kvm-devel] [PATCH] enable gfxboot on VMX

2008-02-17 Thread Avi Kivity
Alexander Graf wrote: Emulating all of the real mode shouldn't be too much of a problem on the performance side. I wouldn't be surprised if the vmenter/exits take about as much time as the emulation overhead. For the bootstrap process emulation is good enough, since the process is short

Re: [kvm-devel] [patch 2/5] KVM: hypercall based pte updates and TLB flushes

2008-02-17 Thread Avi Kivity
Marcelo Tosatti wrote: Hypercall based pte updates are faster than faults, and also allow use of the lazy MMU mode to batch operations. Don't report the feature if two dimensional paging is enabled. Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] +/* + * We only need to hook operations

Re: [kvm-devel] [patch 2/5] KVM: hypercall based pte updates and TLB flushes

2008-02-17 Thread Avi Kivity
Marcelo Tosatti wrote: Hypercall based pte updates are faster than faults, and also allow use of the lazy MMU mode to batch operations. Don't report the feature if two dimensional paging is enabled. Signed-off-by: Marcelo Tosatti [EMAIL PROTECTED] Cc: Anthony Liguori [EMAIL PROTECTED]

Re: [kvm-devel] [patch 3/5] KVM: hypercall batching

2008-02-17 Thread Avi Kivity
Marcelo Tosatti wrote: Batch pte updates and tlb flushes in lazy MMU mode. I am slightly uneasy about generic hypercall batching. An alternative way to do it would be to define a kvm_mmu_op structure (with an embedded opcode) and have a single hypercall execute a number of these (and not

Re: [kvm-devel] [patch 4/5] KVM: ignore zapped root pagetables

2008-02-17 Thread Avi Kivity
Marcelo Tosatti wrote: Mark zapped root pagetables as invalid and ignore such pages during lookup. This is a problem with the cr3-target feature, where a zapped root table fools the faulting code into creating a read-only mapping. The result is a lockup if the instruction can't be emulated.

Re: [kvm-devel] fastcall removal

2008-02-17 Thread Avi Kivity
Andrea Arcangeli wrote: This allows compiling the external module against linux.git (fastcall has finally become the default and only choice). Applied, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature.

Re: [kvm-devel] large page support for kvm

2008-02-17 Thread Avi Kivity
Marcelo Tosatti wrote: On Wed, Feb 13, 2008 at 08:45:51AM +0200, Avi Kivity wrote: gfn_to_page() needs to grab the struct page corresponding to the large page, not the offset struct page for the faulting 4k address within the large frame. Since gfn_to_page can sleep, there is no way to do

Re: [kvm-devel] [PATCH] KVM: move alloc_apic_access_page() outside of non-preemptable region

2008-02-17 Thread Avi Kivity
Marcelo Tosatti wrote: alloc_apic_access_page() can sleep, while vmx_vcpu_setup is called inside a non preemptable region. Move it after put_cpu(). Applied, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature.

<    3   4   5   6   7   8   9   10   11   12   >