Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-18 Thread Avi Kivity
Marcelo Tosatti wrote: On Mon, Mar 17, 2008 at 04:41:18PM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: While aging is not too hard to do, I don't think it would add much in practice; we rarely observe mmu shadow pages being recycled due to memory pressure. So this is mostly

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-17 Thread Marcelo Tosatti
On Sun, Mar 16, 2008 at 01:28:43PM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: On Wed, Mar 12, 2008 at 08:13:41PM +0200, Izik Eidus wrote: this patch simply register the mmu cache with the shrinker. Hi Izik, Nice. I think you want some sort of aging mechanism here.

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-17 Thread Avi Kivity
Marcelo Tosatti wrote: While aging is not too hard to do, I don't think it would add much in practice; we rarely observe mmu shadow pages being recycled due to memory pressure. So this is mostly helpful for preventing a VM from pinning memory when under severe memory pressure, where we

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-17 Thread Marcelo Tosatti
On Mon, Mar 17, 2008 at 04:41:18PM +0200, Avi Kivity wrote: Marcelo Tosatti wrote: While aging is not too hard to do, I don't think it would add much in practice; we rarely observe mmu shadow pages being recycled due to memory pressure. So this is mostly helpful for preventing a VM from

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-16 Thread Avi Kivity
Marcelo Tosatti wrote: On Wed, Mar 12, 2008 at 08:13:41PM +0200, Izik Eidus wrote: this patch simply register the mmu cache with the shrinker. Hi Izik, Nice. I think you want some sort of aging mechanism here. Walk through all translations of a shadow page clearing the

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-13 Thread Marcelo Tosatti
On Thu, Mar 13, 2008 at 01:23:23AM +0200, Izik Eidus wrote: Marcelo Tosatti wrote: On Wed, Mar 12, 2008 at 08:13:41PM +0200, Izik Eidus wrote: this patch simply register the mmu cache with the shrinker. Hi Izik, Hello Marcelo, Nice. I think you want some sort of aging

[kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-12 Thread Izik Eidus
this patch simply register the mmu cache with the shrinker. 0004-KVM-register-the-kvm-mmu-cache-with-the-shrinker.patch Description: application/mbox - This SF.net email is sponsored by: Microsoft Defy all challenges.

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-12 Thread Anthony Liguori
Izik Eidus wrote: this patch simply register the mmu cache with the shrinker. Please inline patches in the future as it makes it easier to review. The implementation looks good and I think it's a good idea. One is that there is one shrinker for all VMs but you run through the list of VMs in

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-12 Thread Marcelo Tosatti
On Wed, Mar 12, 2008 at 08:13:41PM +0200, Izik Eidus wrote: this patch simply register the mmu cache with the shrinker. Hi Izik, Nice. I think you want some sort of aging mechanism here. Walk through all translations of a shadow page clearing the referenced bit of all mappings it holds (and

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-12 Thread Izik Eidus
Marcelo Tosatti wrote: On Wed, Mar 12, 2008 at 08:13:41PM +0200, Izik Eidus wrote: this patch simply register the mmu cache with the shrinker. Hi Izik, Hello Marcelo, Nice. I think you want some sort of aging mechanism here. well it is long time in the todo list to do some

Re: [kvm-devel] [PATCH] shrinker support for the mmu cache

2008-03-12 Thread Izik Eidus
Anthony Liguori wrote: Izik Eidus wrote: this patch simply register the mmu cache with the shrinker. Please inline patches in the future as it makes it easier to review. I knew this time will come when ppl will force me to send patchs inline (will happen next time )... :) The