Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-19 Thread Alexander Graf
On 19.09.16 09:52, Andrew Jones wrote: > On Fri, Sep 16, 2016 at 09:36:42PM +0200, Alexander Graf wrote: >> >> >>> Am 16.09.2016 um 15:46 schrieb Andrew Jones : >>> On Fri, Sep 16, 2016 at 03:30:27PM +0200, Christoffer Dall wrote: > On Fri, Sep 16, 2016 at 02:31:42PM +0200, Paolo Bonzini

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-19 Thread Christoffer Dall
On Mon, Sep 19, 2016 at 12:51:46PM +0200, Alexander Graf wrote: > > > On 16.09.16 15:30, Christoffer Dall wrote: [...] > > > > That being said, I'm not categorically against these patches, but I > > share Marc's view that we've already seen that non-vgic support had been > > broken for multipl

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-19 Thread Alexander Graf
On 16.09.16 15:30, Christoffer Dall wrote: > On Fri, Sep 16, 2016 at 02:31:42PM +0200, Paolo Bonzini wrote: >> >> >> On 16/09/2016 14:30, Christoffer Dall wrote: >> This patch set allows user space to receive vtimer events as well as mask >> them, so that we can handle all vtimer related

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-19 Thread Andrew Jones
On Fri, Sep 16, 2016 at 09:36:42PM +0200, Alexander Graf wrote: > > > > Am 16.09.2016 um 15:46 schrieb Andrew Jones : > > > >> On Fri, Sep 16, 2016 at 03:30:27PM +0200, Christoffer Dall wrote: > >>> On Fri, Sep 16, 2016 at 02:31:42PM +0200, Paolo Bonzini wrote: > >>> > >>> > >>> On 16/09/2016

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-17 Thread Ard Biesheuvel
On 17 September 2016 at 16:38, Peter Maydell wrote: > On 17 September 2016 at 16:28, Ard Biesheuvel > wrote: >> Another thing to keep in mind is that GICv2 >> compatibility is disabled on the non-secure side if the secure side >> elects to configure its view of the GIC as v3 (i.e., in order to >

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-17 Thread Peter Maydell
On 17 September 2016 at 16:28, Ard Biesheuvel wrote: > Another thing to keep in mind is that GICv2 > compatibility is disabled on the non-secure side if the secure side > elects to configure its view of the GIC as v3 (i.e., in order to > support >8 cores) If I'm reading the 'legacy configurations

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-17 Thread Ard Biesheuvel
On 16 September 2016 at 13:44, Alexander Graf wrote: > >> On 16 Sep 2016, at 14:40, Paolo Bonzini wrote: >> >> >> >> On 16/09/2016 14:29, Christoffer Dall wrote: It may be useful for migrating a gicv2 VM to a gicv3 host without gicv2 emulation as well. >>> >>> I don't see why you'd do

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Alexander Graf
> Am 16.09.2016 um 15:46 schrieb Andrew Jones : > >> On Fri, Sep 16, 2016 at 03:30:27PM +0200, Christoffer Dall wrote: >>> On Fri, Sep 16, 2016 at 02:31:42PM +0200, Paolo Bonzini wrote: >>> >>> >>> On 16/09/2016 14:30, Christoffer Dall wrote: >>> This patch set allows user space to receive

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 15:46, Andrew Jones wrote: > > But I haven't even looked at the patches in detail, I was just replying > > to the comment about testing. > > This may be a great time to start encouraging feature writers to submit > kvm-unit-tests patches at the same time as the feature (Hi Alex :-)

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Gerd Hoffmann
Hi, > That being said, I'm not categorically against these patches, but I > share Marc's view that we've already seen that non-vgic support had been > broken for multiple versions without anyone complaining, Oh, did this ever work? Work as in "can actually run a virtual machine", not as in "kv

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Andrew Jones
On Fri, Sep 16, 2016 at 03:30:27PM +0200, Christoffer Dall wrote: > On Fri, Sep 16, 2016 at 02:31:42PM +0200, Paolo Bonzini wrote: > > > > > > On 16/09/2016 14:30, Christoffer Dall wrote: > > > > > > This patch set allows user space to receive vtimer events as well > > > > > > as mask > > > > >

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Christoffer Dall
On Fri, Sep 16, 2016 at 02:31:42PM +0200, Paolo Bonzini wrote: > > > On 16/09/2016 14:30, Christoffer Dall wrote: > > > > > This patch set allows user space to receive vtimer events as well as > > > > > mask > > > > > them, so that we can handle all vtimer related interrupt injection > > > > >

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 14:44, Alexander Graf wrote: > >> On 16 Sep 2016, at 14:40, Paolo Bonzini >> wrote: >> >> >> >> On 16/09/2016 14:29, Christoffer Dall wrote: It may be useful for migrating a gicv2 VM to a gicv3 host without gicv2 emulation as well. >>> >>> I don't see why you'd do th

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Alexander Graf
> On 16 Sep 2016, at 14:40, Paolo Bonzini wrote: > > > > On 16/09/2016 14:29, Christoffer Dall wrote: >>> It may be useful for migrating a gicv2 VM to a gicv3 host without gicv2 >>> emulation as well. >> >> I don't see why you'd do this; the VGIC hardware can perfectly well be >> used for ne

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Alexander Graf
> On 16 Sep 2016, at 14:29, Christoffer Dall > wrote: > > On Fri, Sep 16, 2016 at 02:25:01PM +0200, Alexander Graf wrote: >> >>> On 16 Sep 2016, at 12:20, Marc Zyngier wrote: >>> >>> Hi Alex, >>> >>> On 16/09/16 07:26, Alexander Graf wrote: Some systems out there (well, one type in par

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 14:29, Christoffer Dall wrote: > > It may be useful for migrating a gicv2 VM to a gicv3 host without gicv2 > > emulation as well. > > I don't see why you'd do this; the VGIC hardware can perfectly well be > used for nesting as well, and this works rather well. Can GICv3 emulate G

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 14:30, Christoffer Dall wrote: > > > > This patch set allows user space to receive vtimer events as well as > > > > mask > > > > them, so that we can handle all vtimer related interrupt injection from > > > > user > > > > space, enabling us to use architected timer with user space

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Christoffer Dall
On Fri, Sep 16, 2016 at 02:18:45PM +0200, Paolo Bonzini wrote: > > > On 16/09/2016 12:20, Marc Zyngier wrote: > > > This patch set allows user space to receive vtimer events as well as mask > > > them, so that we can handle all vtimer related interrupt injection from > > > user > > > space, enab

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Christoffer Dall
On Fri, Sep 16, 2016 at 02:25:01PM +0200, Alexander Graf wrote: > > > On 16 Sep 2016, at 12:20, Marc Zyngier wrote: > > > > Hi Alex, > > > > On 16/09/16 07:26, Alexander Graf wrote: > >> Some systems out there (well, one type in particular - the Raspberry Pi > >> series) > >> do have virtualiz

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Alexander Graf
> On 16 Sep 2016, at 12:20, Marc Zyngier wrote: > > Hi Alex, > > On 16/09/16 07:26, Alexander Graf wrote: >> Some systems out there (well, one type in particular - the Raspberry Pi >> series) >> do have virtualization capabilities in the core, but no ARM GIC interrupt >> controller. >> >> To

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Paolo Bonzini
On 16/09/2016 12:20, Marc Zyngier wrote: > > This patch set allows user space to receive vtimer events as well as mask > > them, so that we can handle all vtimer related interrupt injection from user > > space, enabling us to use architected timer with user space gic emulation. > > I have already

Re: [PATCH v3 0/2] KVM: ARM: Enable vtimers with user space gic

2016-09-16 Thread Marc Zyngier
Hi Alex, On 16/09/16 07:26, Alexander Graf wrote: > Some systems out there (well, one type in particular - the Raspberry Pi > series) > do have virtualization capabilities in the core, but no ARM GIC interrupt > controller. > > To run on these systems, the cleanest route is to just handle all >