Re: [Lazarus] Masks: the naming of ...

2021-11-03 Thread Maxim Ganetsky via lazarus
03.11.2021 1:24, Bart via lazarus пишет: Untracked files: (use "git add ..." to include in what will be committed) components/lazutils/test/backup/ components/lazutils/test/testmasks.or I changed lazutils test projects to make their output to `units` subdirectory (it is

Re: [Lazarus] Masks: the naming of ...

2021-11-03 Thread Bart via lazarus
On Wed, Nov 3, 2021 at 7:30 PM Juha Manninen via lazarus wrote: > Here it gives an error from procedure TestWindows. Fixed now. (Adjusted some tests, since DefaultMaskOpCodes changed, fixed the wqFileNameEnd error.) > I don't see commits from you in the TestMasks project. Because as it turned

Re: [Lazarus] Masks: the naming of ...

2021-11-03 Thread Juha Manninen via lazarus
On Wed, Nov 3, 2021 at 12:27 AM Bart via lazarus < lazarus@lists.lazarus-ide.org> wrote: > Whilst doing that I fiddled around with bot the tests and the masks unit. > I then wanted to commit (push) these changes seperately. > I got stuck. > In svn I could commit a single file, then another. > I

Re: [Lazarus] Masks: the naming of ...

2021-11-03 Thread Bart via lazarus
On Tue, Nov 2, 2021 at 10:59 PM Bart wrote: > 2. Remove wqFilenameEnd from DefaultWindowsQuirks and describe that > adding that quirk implies that mocAnyCharOrNone will be enabled. Or a variant of this: remove it foem default and when added , aslo add mocAnyCharOrNone ... -- Bart --

Re: [Lazarus] Masks: the naming of ...

2021-11-03 Thread wkitty42--- via lazarus
On 11/2/21 6:24 PM, Bart via lazarus wrote: Untracked files: (use "git add ..." to include in what will be committed) components/lazutils/test/backup/ components/lazutils/test/testmasks.or nothing added to commit but untracked files present (use "git add" to track) Is

Re: [Lazarus] Masks: the naming of ...

2021-11-03 Thread Bart via lazarus
On Tue, Nov 2, 2021 at 10:59 PM Bart wrote: > I see 2 solutions: > 1. On TWindows* mocAnyCharOrNone will be enabled by default, while it > is not on TMask* > 2. Remove wqFilenameEnd from DefaultWindowsQuirks and describe that > adding that quirk implies that mocAnyCharOrNone will be enabled. > >

Re: [Lazarus] Masks: the naming of ...

2021-11-02 Thread Juha Manninen via lazarus
I am away from my development computer now. Short comments about the git issues: I use "git gui" for commits. It shows untracked files in a separate pane which does not bother much. IIRC there is a setting to not show them at all. You can make many commits and push them sometime later. Actually

Re: [Lazarus] Masks: the naming of ...

2021-11-02 Thread Bart via lazarus
On Tue, Nov 2, 2021 at 8:21 PM Juha Manninen via lazarus wrote: > I fixed its compilation in 3c7586c0f8 but many tests fail. Thank you for that (a bit late, but nevertheless). -- Bart -- ___ lazarus mailing list lazarus@lists.lazarus-ide.org

Re: [Lazarus] Masks: the naming of ...

2021-11-02 Thread Bart via lazarus
On Tue, Nov 2, 2021 at 8:21 PM Juha Manninen via lazarus wrote: > Bart, please run the TMask unit test project while you change the code. Whilst doing that I fiddled around with bot the tests and the masks unit. I then wanted to commit (push) these changes seperately. I got stuck. In svn I

Re: [Lazarus] Masks: the naming of ...

2021-11-02 Thread Bart via lazarus
On Tue, Nov 2, 2021 at 9:43 PM Bart wrote: > How to run that exactly without having to run the entire test suite? OK, looked at the wrong test folder... I fixed the filename 'a[b]c' not matching the mask 'a[b]c' in DisableRange. TestSpecial: to test this feature mocAnyCharOrNone must be

Re: [Lazarus] Masks: the naming of ...

2021-11-02 Thread Juha Manninen via lazarus
Bart, please run the TMask unit test project while you change the code. I fixed its compilation in 3c7586c0f8 but many tests fail. A unit test is especially useful with such text manipulation code. It is a good idea to run the tests after every change. Keep the test project open when changing.

Re: [Lazarus] Masks: the naming of ...

2021-10-29 Thread Bart via lazarus
On Wed, Oct 27, 2021 at 11:56 PM Maxim Ganetsky via lazarus wrote: > > Opinions please. > > Looks good to me. Done. -- Bart -- ___ lazarus mailing list lazarus@lists.lazarus-ide.org https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Masks: the naming of ...

2021-10-27 Thread Maxim Ganetsky via lazarus
27.10.2021 18:50, Bart via lazarus пишет: Hi, I thought I better start a new therad for this one, otherwise I get lost in the previous "TMask revisited" thread. I would like to rename some stuff, now we still can. Easier to remeber IMO: WindowsQuirksAllAllowed -> AllWindowsQuirks

[Lazarus] Masks: the naming of ...

2021-10-27 Thread Bart via lazarus
Hi, I thought I better start a new therad for this one, otherwise I get lost in the previous "TMask revisited" thread. I would like to rename some stuff, now we still can. Easier to remeber IMO: WindowsQuirksAllAllowed -> AllWindowsQuirks WindowsQuirksDefaultAllowed -> DefaultWindowsQuirks