Re: [LEDE-DEV] [PATCH] brcm2708: USB tethering by default

On 16 May 2018 at 23:22, Christo Nedev wrote: > Signed-off-by: Christo Nedev Why? Also: answer should be already in a commit body. ___ Lede-dev mailing list Lede-dev@lists.infradead.org

Re: [LEDE-DEV] [PATCH] brcm2708: switch to the kernel 4.14

On 16 May 2018 at 00:00, Christo Nedev wrote: > Signed-off-by: Christo Nedev Nack. Please exclude unrelated changes and send them as separated patches. ___ Lede-dev mailing list

Re: [LEDE-DEV] new ath79 target

On 8 May 2018 at 14:53, Lucian Cristian wrote: > I added this PR https://github.com/openwrt/openwrt/pull/931 > > the forum discussion is here > https://forum.lede-project.org/t/is-anybody-working-on-linux-4-14-for-ar71xx-platform-porting-guide/13013/35 > > maybe someone has a

Re: [LEDE-DEV] [PATCH] ath79: relicense DTS files to the GPL 2.0+ / MIT

On 7 May 2018 at 10:46, Felix Fietkau <n...@nbd.name> wrote: > On 2018-05-07 09:47, Rafał Miłecki wrote: >> From: Rafał Miłecki <ra...@milecki.pl> >> >> Some maintainers prefer DTS files licensed under permissive license like >> MIT / BSD. As all DT bindings

[LEDE-DEV] [PATCH] ath79: use the new DT fixed partitions syntax

From: Rafał Miłecki <ra...@milecki.pl> This new syntax is slightly better designed & uses "compatible" string. For details see Documentation/devicetree/bindings/mtd/partition.txt . Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- target/linux/ath79/dts/ar7161

[LEDE-DEV] [PATCH V2] ath79: relicense DTS files to the GPL 2.0+ / MIT

From: Rafał Miłecki <ra...@milecki.pl> Some maintainers prefer DTS files licensed under permissive license like MIT / BSD. As all DT bindings should be OS independent and DTS files are pretty separated from Linux code it probably makes sense to share them across projects. The safest so

[LEDE-DEV] [PATCH] ath79: relicense DTS files to the GPL 2.0+ / MIT

From: Rafał Miłecki <ra...@milecki.pl> Some maintainers prefer DTS files licensed under permissive license like MIT / BSD. As all DT bindings should be OS independent and DTS files are pretty separated from Linux code it probably makes sense to share them across projects. The safest so

[LEDE-DEV] [PATCH] brcm47xx: switch to the kernel 4.14

From: Rafał Miłecki <ra...@milecki.pl> The biggest (and the only?) disadventage of this is obviously an increased image size. For mips74k the size of vmlinux goes up from 4186684 B to 4701436 B. Most devices use LZMA compressed kernel so probably more important is vmlinux.lzma size which g

[LEDE-DEV] [PATCH fstools] libfstools: move mount points when switching to JFFS2

From: Rafał Miłecki <ra...@milecki.pl> Switching from "tmpfs" to "jffs2" happens after JFFS2 formatting is done. During that time user can use filesystem (thanks to RAM) and the role of switch2jffs() is to copy all changes to the JFFS2 overlay partition. What wasn't

[LEDE-DEV] [PATCH fstools] libfstools: add "const" to char pointer arguments in mount_move()

From: Rafał Miłecki <ra...@milecki.pl> That function never modifies these strings so it can/should use consts. It makes it a bit more flexible as now callers can also pass consts. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- libfstools/libfstools.h | 2 +- libfstools/moun

[LEDE-DEV] [PATCH fstools] libfstools: fix foreachdir() to pass dir with a trailing slash

From: Rafał Miłecki <ra...@milecki.pl> Commit cc63723d886fd ("overlay: use lstat rather than stat and make sure there are no trailing spaces") changed behavior of foreachdir() breaking some callbacks. Before that modification all callbacks were getting directory with a trail

[LEDE-DEV] [PATCH iwinfo] nl80211: fix code calculating average signal and rate

From: Rafał Miłecki <ra...@milecki.pl> Using average of previous average and the next value is highly imprecise. E.g. for values 20, 20, 20, 180 it would result in /average/ of 100 (instead of 60). Fix it by storing & using an info of how many samples were used for the previous c

[LEDE-DEV] [PATCH] kernel: b53: look for NVRAM's "robo_reset" entry on every platform

From: Rafał Miłecki <ra...@milecki.pl> Since kernel 4.1 bcm47xx_nvram_gpio_pin() is now defined in a global header and can be safely called even on non-Broadcom platforms. This change makes b53 look for "robo_reset" on ARCH_BCM_5301X and slightly simplifies the code. Sign

[LEDE-DEV] [PATCH] kernel: drop patch hacking bridge to accept EAP only locally

From: Rafał Miłecki <ra...@milecki.pl> EAPOL frames have wireless interface address specified as destination. That makes "dst->is_local" condition true for them and results in upstream code processing frames the same way as OpenWrt/LEDE's hack. This code could be needed year

[LEDE-DEV] [PATCH] base-files: fix off-by-one in counting seconds for factory reset

From: Rafał Miłecki <ra...@milecki.pl> There was a mismatch between indicating factory reset and code actually starting it. After 5 seconds status LED started blinking rapidly letting user know it's ready to release reset button. In practice button had to stay pressed for another second in

Re: [LEDE-DEV] Spectre vulnerability & LEDE 17.01 release

On 27 February 2018 at 11:37, Rafał Miłecki <zaj...@gmail.com> wrote: > There has been some talk on upcoming 17.01 fix release and Meltdown/Spectre. You may also want to check/read discussion in Zoltan's patch e-mail thread: https://patchwork.ozlabs.org/cov

[LEDE-DEV] Spectre vulnerability & LEDE 17.01 release

There has been some talk on upcoming 17.01 fix release and Meltdown/Spectre. Quick summary: 1) Most of LEDE supported devices aren't affected 2) For most LEDE use cases these vulnerabilities don't matter 3) 17.01 uses 4.4.116 which includes Meltdown fixes 4) Spectre mitigation requires newer GCC

[LEDE-DEV] [PATCH mountd] mount: drop duplicated includes

From: Rafał Miłecki <ra...@milecki.pl> All these headers are being included few lines above. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- mount.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mount.c b/mount.c index 00fe91d..1d581ea 100644 --- a/mount.c +++ b/mount

Re: [LEDE-DEV] [PATCH] ar71xx: fix flash fast read for flash chips > 16 MB

On 22 February 2018 at 20:13, Christian Beier wrote: > From: Christian Beier > > SPI fast flash read only is supported on devices using 3-byte-addressing. > As chips bigger than 16MB use 4-byte-addressing, reading fails with > -EOPNOTSUPP. > > This

[LEDE-DEV] [PATCH mountd 2/2] mount: call hotplug-call with ACTION=remove before trying to unmount

From: Rafał Miłecki <ra...@milecki.pl> This increases a chance of successfully unmounting a drive as calling hotplug.d scripts may result in stopping applications using it. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- mount.c | 9 + 1 file changed, 5 insertions(+),

[LEDE-DEV] [PATCH mountd 1/2] mount: try lazy unmount if normal one fails

From: Rafał Miłecki <ra...@milecki.pl> If umount calls fails (e.g. because of some application accessing old path) the only chance of getting mount entry cleaned is receiving autofs expire packet. This isn't fully reliable: 1) Sometimes expire can happen before closing all handles. In suc

Re: [LEDE-DEV] [OpenWrt-Devel] 18.03/4

On 16 February 2018 at 13:46, John Crispin wrote: > whats on the critical todo list for the upcoming release ? i still have a > few minor things that I'll be adding shortly, apart from that I am currently > not aware of any huge problems. the release will be a mix between 4.9

[LEDE-DEV] [PATCH] mount: create not working symlink when unmounting fails

From: Rafał Miłecki <ra...@milecki.pl> If device disappears but there is still some application trying to access it, unmounting will fail with the EBUSY errno. Unlinking /tmp/mounts/ would succeed but things could go wrong depending on the application accessing that path. If some app d

[LEDE-DEV] [PATCH mountd] mount: reorder deleting code in the mount_enum_drives()

From: Rafał Miłecki <ra...@milecki.pl> Make it execute required unmount code first and then take care of removing entry from the internal list. This is a small cleanup grouping code by their purpose. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- mount.c | 8 +--- 1 fil

[LEDE-DEV] [PATCH mountd 2/2] mount: drop duplicated rmdir() call from the mount_enum_drives()

From: Rafał Miłecki <ra...@milecki.pl> Call to rmdir() for the same path is already executed in the mount_dev_del(). Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- mount.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mount.c b/mount.c index aa346ff..bf

[LEDE-DEV] [PATCH mountd 1/2] mount: drop duplicated unlink() call from the mount_dev_del()

From: Rafał Miłecki <ra...@milecki.pl> There is no need to call unlink() there as mount_enum_drives() does it too, soon after calling mount_dev_del(). Also mount_enum_drives() does that for STATUS_EXPIRED - which is expected - as there is no unlink() call when device expires. Sign

[LEDE-DEV] [PATCH mountd 1/2] mount: struct mount: replace "mounted" and "ignore" fileds with a "status"

From: Rafał Miłecki <ra...@milecki.pl> There is no need to store status using these 2 separated fields. Obviously ignored mount should never get mounted. This change will also allow adding more statuses easily in the future if needed. Signed-off-by: Rafał Miłecki <ra...@milecki.pl>

[LEDE-DEV] [PATCH mountd 2/2] mount: fix removing mount point if it's expired

From: Rafał Miłecki <ra...@milecki.pl> Kernel can report mount point as expired and when that happens mountd unmounts it. It's still important to: 1) Cleanup directories 2) Call hotplug scripts when device for such a mount disappears. Fix this by adding a new EXPIRED status and checking i

[LEDE-DEV] [PATCH mountd] mount: change mount_dev_del() argument to struct mount *

From: Rafał Miłecki <ra...@milecki.pl> Caller of mount_dev_del() already has struct mount * so there is no point in passing matchin device and then looking for struct mount * again. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- mount.c | 28 1 file

Re: [LEDE-DEV] [PATCH mountd] mount: don't mount device that is already mounted

On 8 February 2018 at 18:34, Rafał Miłecki <zaj...@gmail.com> wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > It may happen that on mountd start some devices are already mounted. > This could due to killing previous mountd instance or just a crash. In > such case dev

[LEDE-DEV] [PATCH mountd] autofs: don't check if /tmp/run/mountd/ mount point exists

From: Rafał Miłecki <ra...@milecki.pl> First of all this check was never working. Mount points are stored without trailing slash so passing "/tmp/run/mountd/" as argument was a mistake. This could get fixed but that would make mountd refuse to start in situations people used to

[LEDE-DEV] [PATCH mountd] mount: don't mount device that is already mounted

From: Rafał Miłecki <ra...@milecki.pl> It may happen that on mountd start some devices are already mounted. This could due to killing previous mountd instance or just a crash. In such case device shouldn't get remounted but added to the list with a mounted flag set. That will make mountd m

[LEDE-DEV] [PATCH 1/2] mount: improve handling mounts table size

From: Rafał Miłecki <ra...@milecki.pl> This is static array with a size set to MAX_MOUNTED. Old code: 1) Was never using the last table entry/row 2) Was logging the same message for every mount entry above limit This fixes off-by-one, moves limit check to the proper place and uses "

[LEDE-DEV] [PATCH 2/2] mount: rename /proc/mount parser to mount_update_mount_list()

From: Rafał Miłecki <ra...@milecki.pl> Using "update" in the function name should better match its role than "check". The main purpose of this function is to update content of the "mounted" array. Signed-off-by: Rafał Miłecki <ra...@milecki.pl>

Re: [LEDE-DEV] A state of network acceleration

On 17 January 2018 at 16:25, Rafał Miłecki <zaj...@gmail.com> wrote: > The problem with all existing implementations was they used various > non-upstream patches for kernel integration. Some were less invasive, > some a bit more. They weren't properly reviewed by kernel developer

[LEDE-DEV] A state of network acceleration

Getting better network performance (mostly for NAT) using some kind of acceleration was always a hot topic and people are still looking/asking for it. I'd like to write a short summary and share my understanding of current state so that: 1) People can undesrtand it better 2) We can have some rough

[LEDE-DEV] [PATCH] ipq806x: replace linux, part-probe with a proper partitions subnode

From: Rafał Miłecki <ra...@milecki.pl> This solution is more upstream compatible as it only requires specifying of_match_table in the parser code and doesn't depend on linux,part-probe which is solution made generic by a LEDE downstream patch that can't be upstreamed. Signed-off-by:

[LEDE-DEV] [PATCH fstools] libfstools: optimize building directory string for glob

From: Rafał Miłecki <ra...@milecki.pl> glob should handle paths like /foo/bar//* so we probably don't need this extra check & code. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- This optimization/simplification was suggested by Jo while reviewing [PATCH] libfstools: su

[LEDE-DEV] [PATCH] libfstools: support file paths longer than 255 chars

From: Rafał Miłecki <ra...@milecki.pl> Alloc globdir buffer dynamically and simply use realloc when needed. This fixes e.g. segmentation fault in jffs2reset due to an infinite recurrency when dealing with longs paths. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- libfstools/ov

[LEDE-DEV] [PATCH mountd 2/3] mount: remove directory if mounting fails

From: Rafał Miłecki <ra...@milecki.pl> Aside from just cleaning up mountd's tmp dir it's also important for autofs support. With such an empty directory autofs_process_request believed device is mounted and it kept replying AUTOFS_IOC_READY to the kernel. It was causing a log storm like:

[LEDE-DEV] [PATCH mountd 3/3] mount: check if block was mounted before cleaning it up

From: Rafał Miłecki <ra...@milecki.pl> Calling an extra rmdir and unlink isn't a big issue but triggering hotplug.d scripts for devices that weren't mounted could be misleading for listeners. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- mount.c | 12 +++- 1 fil

[LEDE-DEV] [PATCH mountd 1/3] mount: call hotplug mount scripts only on success

From: Rafał Miłecki <ra...@milecki.pl> If mounting fails for whatever reason (like unsupported file system or something) hotplug.d scripts shouldn't be called. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- mount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[LEDE-DEV] [PATCH] brcm47xx: image: build firmware for Asus WL-500g Deluxe

From: Rafał Miłecki <ra...@milecki.pl> It's a device based on BCM5365P (0x5365 package 0x00). This SoC has USB 1.1 controller but device has two USB 2.0 parts. They are handled by PCI-based controllers: 1106:3038 UHCI and 1106:3104 EHCI. Signed-off-by: Rafał Miłecki <ra...@m

[LEDE-DEV] [PATCH fstools] libblkid-tiny: add support for NTFS superblock

From: Rafał Miłecki <ra...@milecki.pl> Its copied from the util-linux project and its libblkid. Call to the blkid_probe_set_utf8label was commented out due to libblkid-tiny not supporting it yet. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- CMakeLists.txt| 1

[LEDE-DEV] Question of replacing mountd with blockd

Hi, looking at: commit 7e4b869c45138 ("fstools: add blockd") commit 6a772cb953c4c ("mountd: drop in favour of blockd") I'd expect blockd to provide the same functionality as mountd did. I don't think it's the case though. With mountd installed (e.g. in LEDE 17.01) plugging in USB storage device

Re: [LEDE-DEV] [PATCH] bcm53xx: use iflag=skip_bytes for dd command during sysupgrade

On 2017-12-24 00:26, Etienne Champetier wrote: 2017-12-23 14:14 GMT-08:00 Rafał Miłecki <zaj...@gmail.com>: From: Rafał Miłecki <ra...@milecki.pl> Since BusyBox 1.25.0 dd command supports iflag=skip_bytes which allows skipping requested amount of bytes without reducing block

[LEDE-DEV] [PATCH] bcm53xx: use iflag=skip_bytes for dd command during sysupgrade

From: Rafał Miłecki <ra...@milecki.pl> Since BusyBox 1.25.0 dd command supports iflag=skip_bytes which allows skipping requested amount of bytes without reducing blocksize. Thanks to this we can leave default blocksize and let dd work more efficiently. On Netgear R6250 "dd sk

Re: [LEDE-DEV] [PATCH rpcd] iwinfo: add info about frequency restrictions

On 15 August 2017 at 12:49, Rafał Miłecki <zaj...@gmail.com> wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > Example frequency: > { > "channel": 1, > "mhz": 2412, > "restricted&q

[LEDE-DEV] [PATCH packages] lxc: add lxc-unprivileged helper package for unprivileged containers

From: Rafał Miłecki <ra...@milecki.pl> LXC requires newuidmap and newguidmap with SUID to run unprivileged containers. This package should help users make sure they are available. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- utils/lxc/Makefile

[LEDE-DEV] [PATCH] opkg: fix PKG_CONFIG_DEPENDS to include version.mk entries

From: Rafał Miłecki <ra...@milecki.pl> Including version.mk sets PKG_CONFIG_DEPENDS to config entries used for VERSION_SED command. We should keep these configs to make sure package gets refreshed when needed. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/system/opkg/

[LEDE-DEV] [PATCH] sdk: restrict base feed repo to public git for CONFIG_BUILDBOT only

From: Rafał Miłecki <ra...@milecki.pl> This allows people to build SDK from custom repository (git access using ssh) and keep original URL in SDK's feeds.conf.default. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- target/sdk/Makefile | 3 ++- 1 file changed, 2 insertions(+)

[LEDE-DEV] [PATCH packages] rpcd-mod-lxc: info: return NOT_FOUND if container doesn't exist

From: Rafał Miłecki <ra...@milecki.pl> It allow distinction between not existing and stopped container. So far querying for not existing container was resulting in: > ubus call lxc info '{ "name": "foo" }' { "name": "foo", "

[LEDE-DEV] [PATCH 4/4] otrx: fix memory leak in otrx_create_append_zeros

From: Rafał Miłecki <ra...@milecki.pl> A "free" call was missing after allocating a buffer. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/utils/otrx/src/otrx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/utils/otrx/src/otrx.c b/package

[LEDE-DEV] [PATCH 2/4] otrx: bump buffer size in otrx_create_append_file

From: Rafał Miłecki <ra...@milecki.pl> Usually this function is called for appending some small files only (like fs marks) but let's just make it more generic and capable of handling bigger files easily. Increasing buffer to 1 KiB shouldn't hurt. Signed-off-by: Rafał Miłecki <ra...@m

[LEDE-DEV] [PATCH 3/4] otrx: print and return errno if fopen fails

From: Rafał Miłecki <ra...@milecki.pl> Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/utils/otrx/src/otrx.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/package/utils/otrx/src/otrx.c b/package/utils/otrx/src/otrx.c inde

[LEDE-DEV] [PATCH 1/4] otrx: drop unused otrx_create_parse_options function

From: Rafał Miłecki <ra...@milecki.pl> It was there in case of adding some "create" command options that should be parsed before actually creating the output image. It seems we don't need any at this point so let's drop this function for now. Signed-off-by: Rafał Miłecki &

[LEDE-DEV] [PATCH 2/2] bcm53xx: use otrx for creating TRX images

From: Rafał Miłecki <ra...@milecki.pl> The advantage is that we don't have to specify max TRX size anymore and otrx doesn't allocate a buffer of that size. It saves us allocating 32 MiB for every image we generate. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- target/linux/b

[LEDE-DEV] [PATCH 1/2] firmware-utils: add otrx tool for handling TRX images

From: Rafał Miłecki <ra...@milecki.pl> It can be a replacement for the trx tool. The advantage is that otrx doesn't alloc buffer for the whole TRX which can be a nice optimization when creating big images. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- tools/firmware-utils/Make

[LEDE-DEV] [PATCH packages 2/2] shadow: add packages for newgidmap and newuidmap applets

From: Rafał Miłecki <ra...@milecki.pl> They are needed by LXC for unprivileged containers. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- utils/shadow/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/utils/shadow/Makefile b/utils/shadow/Ma

[LEDE-DEV] [PATCH packages 1/2] shadow: use proper fix for checking subordinate IDs support

From: Rafał Miłecki <ra...@milecki.pl> During 4.2.1 version update support for subordinate IDs has been disabled. It was handled by: 1) Adding --disable-subordinate-ids to avoid: configure: error: cannot run test program while cross compiling 2) Adding patch 003-fix-disabling-subids

[LEDE-DEV] [PATCH] otrx: always align image to 0x1000

From: Rafał Miłecki <ra...@milecki.pl> This seems to match what the original trx tool and mjn3's replacement do. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/utils/otrx/src/otrx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/package/utils/otrx/src/otrx

[LEDE-DEV] [PATCH 2/3] otrx: optimize memory usage when creating TRX image

From: Rafał Miłecki <ra...@milecki.pl> There is no need to allocate buffer as big as the whole image in order to calculate CRC32. It's enough to use small buffer and just read file content block by block. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/utils/otrx/src

[LEDE-DEV] [PATCH 1/3] otrx: use helper function when checking image's CRC32

From: Rafał Miłecki <ra...@milecki.pl> This requires changing this helper to accept initial/current CRC32 value as argument but it allows dropping duplicated (complex?) code calculating the CRC32. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/utils/otrx/src

Re: [LEDE-DEV] Problem with iwinfo rpcd plugin and nl80211 (CONFIG_PACKAGE_rpcd-mod-iwinfo=m CONFIG_PACKAGE_rpcd-mod-lxc=y)

On 9 November 2017 at 11:00, Rafał Miłecki <zaj...@gmail.com> wrote: > I've found a problem with iwinfo that appears only with a very specific > config. > > What happens: > ubus call iwinfo info '{ "device": "wlan0" }' > Above call fails to get i

[LEDE-DEV] Problem with iwinfo rpcd plugin and nl80211 (CONFIG_PACKAGE_rpcd-mod-iwinfo=m CONFIG_PACKAGE_rpcd-mod-lxc=y)

I've found a problem with iwinfo that appears only with a very specific config. What happens: ubus call iwinfo info '{ "device": "wlan0" }' Above call fails to get interface details using nl80211 and fallbacks to the wext. My last debugging attempt pointed to nlmsg_alloc() returning NULL which

[LEDE-DEV] [PATCH packages] rpcd-mod-lxc: add "info" ubus method (similar to the lxc-info)

From: Rafał Miłecki <ra...@milecki.pl> This method allows getting basic info about a queried container. It's based on the lxc-info command-line tool. Example output: > ubus call lxc info '{ "name": "foo" }' { "name": "foo", &quo

[LEDE-DEV] [PATCH mountd 0/2] mount: improve handling unsupported filesystems

From: Rafał Miłecki <ra...@milecki.pl> While debugging mountd through adding some prints, I noticed that mount_dev_add will be called every second for unsupported filesystems. Even though LEDE's master branch switched to the blockd, mountd may be still used by some (e.g. LEDE 17.01 release

[LEDE-DEV] [PATCH mountd 2/2] mount: add mount with ignore=1 for unsupported filesystems

From: Rafał Miłecki <ra...@milecki.pl> So far a check for unsupported filesystem was in the mount_add_list which was simply stopping mount from being added to the global list. This resulted in mount_dev_add continuously not being able to find a mount for the given block device and trying

[LEDE-DEV] [PATCH mountd 1/2] mount: drop duplicated filesystem check from mount_add_list

From: Rafał Miłecki <ra...@milecki.pl> At the very beginning of this function there is following code: if(fs <= MBR || fs > LASTFS) return; There is no point in checking for the same range again as these checks will always evaluate into true. Signed-off-by: Rafał

Re: [LEDE-DEV] Broken USB LED trigger on LEDE 17.01.4?

On 2017-10-28 21:59, Florian Fainelli wrote: I recently updated my Netgear WNDR4300 to LEDE 17.01.4 and the only thing that appears broken is the USB LED trigger. The LED works fine and while the USB port is detected, functional, setting it as a trigger does not make the LED blink. Was there any

[LEDE-DEV] Info about MTD_SPI_NOR_USE_4K_SECTORS

Few people asked me about the MTD_SPI_NOR_USE_4K_SECTORS. Somehow I got responsible for it ;) It doesn't seem like a big thing, but since I was asked, let me describe it. So initially this feature was added by Gabor in: generic: disable 'small sector' erase in m25p80 driver

Re: [LEDE-DEV] [PATCH] kernel: fix VDSO problem on MIPS

On 11 August 2017 at 00:14, Hauke Mehrtens wrote: > This fixes the VDSO problems on the Lantiq VR9 MIPS SoC. > The gettimeofday() sometimes returned old data because of a cache > aliasing problems on MIPS CPUs, to work around this problem VDSO > gettimeofday support was

[LEDE-DEV] [PATCH] brcm47xx: include wpad-mini only for devices with WiFi supported

From: Rafał Miłecki <ra...@milecki.pl> This saves some flash space for the others. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- target/linux/brcm47xx/Makefile | 2 +- target/linux/brcm47xx/image/Makefile | 141 ++- 2 files changed, 7

Re: [LEDE-DEV] Backporting support for DT USB LED setup to 17.01?

On 17 August 2017 at 11:26, Rafał Miłecki <zaj...@gmail.com> wrote: > In master branch there is a support for USB LED setup through DT. It was > added 1,5 month ago. It's handed by: > commit 318f2d61016e6 ("kernel: fix of_node handling in LEDs core code") > commit 76c4

[LEDE-DEV] [PATCH iwinfo] nl80211: request split information about frequencies

From: Rafał Miłecki <ra...@milecki.pl> This allows kernel send more details including all the NL80211_FREQUENCY_ATTR_NO_* flags. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- iwinfo_nl80211.c | 38 -- 1 file changed, 36 insertions(+),

[LEDE-DEV] [PATCH iwinfo 2/3] Allow storing more info about each frequency

From: Rafał Miłecki <ra...@milecki.pl> This adds flags field which may be used to mark frequency not available under some conditions. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- include/iwinfo.h | 8 1 file changed, 8 insertions(+) diff --git a/include/iwinfo

[LEDE-DEV] [PATCH iwinfo 1/3] nl80211: support receiving split frequencies

From: Rafał Miłecki <ra...@milecki.pl> In order to get more details about each frequency we will need to set NL80211_ATTR_SPLIT_WIPHY_DUMP in the future. This will result in our callback being called multiple times. Modify it to support such a scenario: 1) Start putting new frequencies

[LEDE-DEV] [PATCH iwinfo 3/3] nl80211: store info about freq being not available for some bandwidths

From: Rafał Miłecki <ra...@milecki.pl> Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- iwinfo_nl80211.c | 13 + 1 file changed, 13 insertions(+) diff --git a/iwinfo_nl80211.c b/iwinfo_nl80211.c index f9b13dd..718e111 100644 --- a/iwinfo_nl80211.c +++ b/iwin

Re: [LEDE-DEV] [RFC] kernel patches cleanup

On 7 August 2017 at 21:20, Philip Prindeville wrote: >> On Jul 31, 2017, at 10:11 AM, John Crispin wrote: >> >> Hi, >> >> I rebased my ages old kernel patch cleanup series. It can be found here [1]. >> >> the series annotates all patches and

[LEDE-DEV] [PATCH] base-files: don't setup network in preinit if failsafe is disabled

From: Rafał Miłecki <ra...@milecki.pl> With failsafe disabled there is no point in early network setup. We don't send announcement over UDP and there is no way to ssh to the device. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/base-files/files/lib/preinit/10_indicate

Re: [LEDE-DEV] b43 support for AC chipsets like BCM4360 and BCM4352?

On 7 August 2017 at 08:25, Baptiste Jonglez wrote: > On Mon, Jul 31, 2017 at 06:31:43PM -0700, ros...@gmail.com wrote: >> Based on kernel activity, this driver is not under active development. >> >> And yes, avoid. > > Ok, I was hoping to get an answer from Rafał or

[LEDE-DEV] [PATCH] base-files: drop unused preinit_echo function

From: Rafał Miłecki <ra...@milecki.pl> It isn't used for years since 99_10_run_init has been dropped. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/base-files/files/lib/preinit/10_indicate_preinit | 5 - 1 file changed, 5 deletions(-) diff --git a/package/base-fil

[LEDE-DEV] Incorrect (undesired) switch setup during preinit

I have router with internal switch with 6 ports. The default config is: 0: LAN1 1: LAN2 2: LAN3 3: LAN4 4: WAN 5: CPU I want to use port 3 (LAN4) for something different. Another network, mwan, whatever. For that purpose I edited /etc/config/network and replaced option ports '0 1 2 3 5t' with

Re: [LEDE-DEV] [RFC] kernel patches cleanup

On 2 August 2017 at 06:36, John Crispin wrote: > On 31/07/17 18:11, John Crispin wrote: >> >> Hi, >> >> I rebased my ages old kernel patch cleanup series. It can be found here >> [1]. >> >> the series annotates all patches and splits them up into 3 folders >>

[LEDE-DEV] Problem with PKG_CONFIG_DEPENDS and string configs

Packages are allowed to specify dependency configs in their PKG_CONFIG_DEPENDS. Any value change for any dependency should result in rebuilding the package. This feature is handled with STAMP_CONFIGURED in package.mk. For every package we have something like:

[LEDE-DEV] [PATCH fstools] libblkid-tiny: add support for UBI superblock

From: Rafał Miłecki <ra...@milecki.pl> Detecting UBI superblock may be useful for tools wanting to simplify or automate attaching UBI. Please note it's not directly related to the ubifs support which is just a filesystem working on top of UBI volume. This patch adds simple code readi

Re: [LEDE-DEV] [PATCH ubox] Fix logger starvation and Add feature log priority filtering

On 4 July 2017 at 20:33, Ron Brash wrote: > This communication is intended for the use of the recipient to which it is > addressed, and may contain confidential, personal, and or privileged > information. Please contact the sender immediately if you are not the > intended

[LEDE-DEV] [PATCH] firmware-utils: mktplinkfw2: use static board struct for custom values

From: Rafał Miłecki <ra...@milecki.pl> It seems simpler to store all custom (command line set) option values in a struct identical to the predefined ones. It doesn't require: 1) Having so many global variables 2) Copying data from the predefined boards Signed-off-by: Rafał Miłec

[LEDE-DEV] [PATCH] firmware-utils: mktplinkfw2: fix MD5 salt

From: Rafał Miłecki <ra...@milecki.pl> LEDE supports 6 devices using TP-Link firmware format (V2 or V3): ArcherC20i, ArcherC50, ArcherMR200, TDW8970, TDW8980 and VR200v. Testing mktplinkfw2 tool with official (vendor generated) firmware files for all above devices has shown an erro

[LEDE-DEV] [PATCH] scripts: getver.sh: include branch name in a revision string

From: Rafał Miłecki <ra...@milecki.pl> The purpose of revision (r* number) is to provide a rough info about build next to the (very) specific SHA-1. Unfortunately without a branch name specified it's a bit misleading and what's more two commits may get the same revision, e.g.: For master

[LEDE-DEV] [PATCH] base-files: fix PKG_CONFIG_DEPENDS to include version.mk entries

From: Rafał Miłecki <ra...@milecki.pl> Including version.mk sets PKG_CONFIG_DEPENDS to config entries used for VERSION_SED command. We should keep these configs to make sure package gets refreshed when needed. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- package/base-files/

[LEDE-DEV] [PATCH V2 packages] minidlna: update to 1.2.0

From: Rafał Miłecki <ra...@milecki.pl> It contains compatibility/support for few more clients (including Kodi) and introduces rescan support (useful for devices with limited CPU power). Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- V2: Refresh patches --- multimedia/minid

[LEDE-DEV] [PATCH packages] minidlna: update to 1.2.0

From: Rafał Miłecki <ra...@milecki.pl> It contains compatibility/support for few more clients (including Kodi) and introduces rescan support (useful for devices with limited CPU power). Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- multimedia/minidlna/Makefile | 10 --

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V3

On 29 May 2017 at 09:03, John Crispin wrote: > here is a V3 of the remerge proposal, I tried to fold all the comments > people made into it, if anything is missing let me know. Please remeber that > post remerge anything can be voted on, so cluttering the proposal with many >

Re: [LEDE-DEV] [PATCH] bcm53xx: include wpad-mini only on devices with (supported) wireless

On 22 May 2017 at 12:50, Rafał Miłecki <zaj...@gmail.com> wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > Don't include wpad-mini when it's useless just like we don't include > useless wireless drivers. > > Signed-off-by: Rafał Miłecki <ra...@milecki.pl> I'

Re: [LEDE-DEV] [PATCH packages] libwebsockets: set PROVIDES for all variants

On 30 March 2017 at 12:45, Karl Palsson wrote: > From conversations when we were adding this in mosquitto, we > actually need to rename the default package to use PROVIDES > properly. > > jow pointed out that you can't have PROVIDES == actual package > name. > > Also,

Re: [LEDE-DEV] [PATCH packages] libwebsockets: bump to 2.2.1

On 29 March 2017 at 19:16, Rafał Miłecki <zaj...@gmail.com> wrote: > From: Rafał Miłecki <ra...@milecki.pl> > > For changes since 2.0.x see > https://github.com/warmcat/libwebsockets/blob/v2.2-stable/changelog > > Signed-off-by: Rafał Miłecki <ra...@milecki.pl

Re: [LEDE-DEV] [PATCH 2/2] kernel: kmod-usb-net-pl: Add support for PL-27A1

On 25 April 2017 at 13:07, Roman Spychała wrote: > From: Roman Spychała > > Just applying the same patch to 4.4 and 4.9 kernels. > > Signed-off-by: Roman Spychała Hi Roman, I can see your patch has been applied by David:

[LEDE-DEV] [PATCH] bcm53xx: include wpad-mini only on devices with (supported) wireless

From: Rafał Miłecki <ra...@milecki.pl> Don't include wpad-mini when it's useless just like we don't include useless wireless drivers. Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- target/linux/bcm53xx/Makefile | 2 +- target/linux/bcm53xx/image/M

Re: [LEDE-DEV] [OpenWrt-Devel] openwrt and lede - remerge proposal V2

On 05/22/2017 09:40 AM, John Crispin wrote: *) branding - the owrt side sees no option of using the lede brand - a (minor) majority voted for openwrt as a name over lede whilst most people said they did not care - as the last vote had a 100% ACK for a remerge using the owrt brand is the only

  1   2   3   4   >