Re: [LEDE-DEV] [PATCH 3/5] tools/mtd-utils: update to version 2.0.1

2018-04-16 Thread Koen Vandeputte
Hi Hauke, Thank you very much for this patch!! I will try to give it a spin today on imx6 hardware and specifically by using the imagebuilder. Noticing the upstream git repo, there were a few important fixes (especially for ubifs). Would you be in favor of: - Skip these until considered sta

[LEDE-DEV] [PATCH fstools] libfstools: add "const" to char pointer arguments in mount_move()

2018-04-16 Thread Rafał Miłecki
From: Rafał Miłecki That function never modifies these strings so it can/should use consts. It makes it a bit more flexible as now callers can also pass consts. Signed-off-by: Rafał Miłecki --- libfstools/libfstools.h | 2 +- libfstools/mount.c | 2 +- 2 files changed, 2 insertions(+), 2

Re: [LEDE-DEV] [PATCH fstools] libfstools: add "const" to char pointer arguments in mount_move()

2018-04-16 Thread John Crispin
On 16/04/18 14:30, Rafał Miłecki wrote: From: Rafał Miłecki That function never modifies these strings so it can/should use consts. It makes it a bit more flexible as now callers can also pass consts. Signed-off-by: Rafał Miłecki Acked-by: John Crispin --- libfstools/libfstools.h | 2

[LEDE-DEV] [PATCH fstools] libfstools: move mount points when switching to JFFS2

2018-04-16 Thread Rafał Miłecki
From: Rafał Miłecki Switching from "tmpfs" to "jffs2" happens after JFFS2 formatting is done. During that time user can use filesystem (thanks to RAM) and the role of switch2jffs() is to copy all changes to the JFFS2 overlay partition. What wasn't handled so far was moving mount points. User can

Re: [LEDE-DEV] [PATCH fstools] libfstools: move mount points when switching to JFFS2

2018-04-16 Thread John Crispin
On 16/04/18 16:11, Rafał Miłecki wrote: From: Rafał Miłecki Switching from "tmpfs" to "jffs2" happens after JFFS2 formatting is done. During that time user can use filesystem (thanks to RAM) and the role of switch2jffs() is to copy all changes to the JFFS2 overlay partition. What wasn't hand

Re: [LEDE-DEV] [PATCH fstools] libfstools: fix foreachdir() to pass dir with a trailing slash

2018-04-16 Thread John Crispin
On 13/04/18 13:26, Rafał Miłecki wrote: From: Rafał Miłecki Commit cc63723d886fd ("overlay: use lstat rather than stat and make sure there are no trailing spaces") changed behavior of foreachdir() breaking some callbacks. Before that modification all callbacks were getting directory with a tr

Re: [LEDE-DEV] [PATCH] ath10k-ct: make it depend on PCI support again

2018-04-16 Thread Matthias Schiffer
On 04/16/2018 12:54 AM, Hauke Mehrtens wrote: > The missing dependency causes build problems on systems without PCI > support. > The ath10k_pci kernel module depends on PCI support so this dependency > should be added. ath10k now also supported the ahb interface on the > IPQ4019 SoC, but this SoC a

Re: [LEDE-DEV] [PATCH 3/5] tools/mtd-utils: update to version 2.0.1

2018-04-16 Thread Hauke Mehrtens
On 04/16/2018 11:22 AM, Koen Vandeputte wrote: > Hi Hauke, > > Thank you very much for this patch!! > I will try to give it a spin today on imx6 hardware and specifically by > using the imagebuilder. Yes that would be nice, please report back if it worked or if you saw any problems. It would also

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH 0/4] Gemini forward-port to kernel v4.14

2018-04-16 Thread Linus Walleij
On Mon, Apr 16, 2018 at 2:00 AM, Roman Yeryomin wrote: >> Looking at your tree... >> I don't see any (affecting) differences in ethernet driver itself. >> Probably it's something else.. MDIO? >> > > After looking into ethernet I've found several issues. > 1. skew delay settings were not ported fr

Re: [LEDE-DEV] [PATCH] mbedtls: change libmbedcrypto.so soversion back to 0

2018-04-16 Thread Hauke Mehrtens
On 04/16/2018 01:01 AM, Syrone Wong wrote: > Why? the lib version bump means ABI incompatibility. The correct way > is to bump release to rebuild instead of decreasing it. > > > Best Regards, > Syrone Wong Let me explain what happened in mbedtls first. This change was added on version 2.7.0: ht

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH 0/4] Gemini forward-port to kernel v4.14

2018-04-16 Thread Roman Yeryomin
On 2018-04-17 00:36, Linus Walleij wrote: On Mon, Apr 16, 2018 at 2:00 AM, Roman Yeryomin wrote: Looking at your tree... I don't see any (affecting) differences in ethernet driver itself. Probably it's something else.. MDIO? After looking into ethernet I've found several issues. 1. skew del

Re: [LEDE-DEV] [OpenWrt-Devel] [PATCH 0/4] Gemini forward-port to kernel v4.14

2018-04-16 Thread Roman Yeryomin
On 2018-04-15 20:22, Roman Yeryomin wrote: On 2018-04-14 20:36, Hans Ulli Kroll wrote: Hi Roman On Tue, 10 Apr 2018, Linus Walleij wrote: On Mon, Apr 9, 2018 at 12:38 PM, Roman Yeryomin wrote: > I have tested them quickly yesterday on nas4220b board. Although I've > managed to boot it (had

Re: [LEDE-DEV] [PATCH] mbedtls: change libmbedcrypto.so soversion back to 0

2018-04-16 Thread Syrone Wong
Looks good. Best Regards, Syrone Wong On Tue, Apr 17, 2018 at 5:49 AM, Hauke Mehrtens wrote: > On 04/16/2018 01:01 AM, Syrone Wong wrote: >> Why? the lib version bump means ABI incompatibility. The correct way >> is to bump release to rebuild instead of decreasing it. >> >> >> Best Regards, >>