Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-30 Thread lewis
I get this traceback when latest commit opens: Leo Log Window Leo 5.1-final, build 20150825225221, Tue Aug 25 22:52:21 CDT 2015 Git repo info: branch = master, commit = 2df11b463ff1 Python 3.4.3, PyQt version 5.5.0 Windows 7 AMD64 (build 6.1.7601) SP1 load dir: N:\git\leo-editor\leo\core global

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-30 Thread lewis
All fixed. Thanks Lewis -- You received this message because you are subscribed to the Google Groups leo-editor group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-30 Thread john lunzer
I'll look into this. I think the issue may be related to this post: http://srinikom.github.io/pyside-bz-archive/866.html On Sunday, August 30, 2015 at 7:18:37 AM UTC-4, lewis wrote: I get this traceback when latest commit opens: Leo Log Window Leo 5.1-final, build 20150825225221, Tue Aug 25

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-30 Thread john lunzer
See I knew I was going to break something... anyway it should be fixed in Rev 9cc8e89, now the QVBoxLayout instance calls setContentsMargin instead of setMargin. Just a note, the code was automatically by pyuic4. Just something to keep in mind for others using that utility. On Sunday, August

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-27 Thread Edward K. Ream
On Wed, Aug 26, 2015 at 9:53 AM, john lunzer lun...@gmail.com wrote: I've done limited testing. This is my first commit that is likely to affect many other people's daily flow. Please let me know if I've broken anything. ​I don't really care what kind of testing any developer does, as long

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-27 Thread 'Terry Brown' via leo-editor
On Thu, 27 Aug 2015 09:42:22 -0500 Edward K. Ream edream...@gmail.com wrote: On Wed, Aug 26, 2015 at 9:53 AM, john lunzer lun...@gmail.com wrote: I've done limited testing. This is my first commit that is likely to affect many other people's daily flow. Please let me know if I've broken

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-27 Thread Edward K. Ream
On Thu, Aug 27, 2015 at 10:13 AM, 'Terry Brown' via leo-editor leo-editor@googlegroups.com wrote: I must admit that I don't always run the unit tests because sometimes I know there's no coverage in the area I'm working. But when I do, this is how I do it: ​Thanks for the summary. There

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-27 Thread john lunzer
Thank you for this, I was just going to ask... how I run the unit tests. Now I now, I will certainly do this from now on. On Thursday, August 27, 2015 at 11:13:24 AM UTC-4, Terry Brown wrote: On Thu, 27 Aug 2015 09:42:22 -0500 Edward K. Ream edre...@gmail.com javascript: wrote: On Wed,

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-26 Thread john lunzer
As C.S Lewis put it, “if you do one good deed your reward usually is to be set to do another and harder and better one.” I can certainly attempt to extend that dropdown to add in below current node or something a little shorter. For the other functionality what did you have in mind? Were you

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-26 Thread john lunzer
I will meditate on what feels the least confusing and least cluttered. On Wednesday, August 26, 2015 at 12:07:46 PM UTC-4, Terry Brown wrote: On Wed, 26 Aug 2015 08:50:13 -0700 (PDT) john lunzer lun...@gmail.com javascript: wrote: As C.S Lewis put it, “if you do one good deed your reward

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-26 Thread 'Terry Brown' via leo-editor
On Wed, 26 Aug 2015 08:50:13 -0700 (PDT) john lunzer lun...@gmail.com wrote: As C.S Lewis put it, “if you do one good deed your reward usually is to be set to do another and harder and better one.” I can certainly attempt to extend that dropdown to add in below current node or something a

Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-26 Thread john lunzer
I've done limited testing. This is my first commit that is likely to affect many other people's daily flow. Please let me know if I've broken anything. Also comments are welcome on my changes. I had to copy out some code out of leo core into one of the quicksearch classes to enable subtree and

Re: Recent commit adds subtree only and node capability to quicksearch plugin

2015-08-26 Thread 'Terry Brown' via leo-editor
On Wed, 26 Aug 2015 07:53:09 -0700 (PDT) john lunzer lun...@gmail.com wrote: I've done limited testing. This is my first commit that is likely to affect many other people's daily flow. Please let me know if I've broken anything. Also comments are welcome on my changes. I had to copy out