A couple more speedup proposals.

2008-03-26 Thread thyrsus
In my prior speedups, I replace c.allNodes_iter with something like c.all_nodes_with_unique_tnodes and I believe I have not changed the results generated. I see two more opportunities, but this *would* change the Leo semantics. c.allNodes_iter is used to look for both @settings and for @button

plugins' menu entries missing

2008-03-26 Thread Terry Brown
Just noticed some plugins (rst3, graphed) which place entries in some of the standard menus aren't placing those entries there now. Alt-X write-restructured-text works, so I think the plugin's installed no problem (it's in the plugins menu too), but its normal "Write restructured text" entry in t

Re: @settings docs.

2008-03-26 Thread Terry Brown
On Wed, 26 Mar 2008 11:01:13 -0500 "Edward K. Ream" <[EMAIL PROTECTED]> wrote: > Hmm. I think the docs are adequate. They refer people to the > sources for details. "The c.config class has the following getters. See the configSettings in leoCommands.py for details" configSettings in leoComman

Re: Terry Brown's changes now in the trunk

2008-03-26 Thread Terry Brown
On Wed, 26 Mar 2008 11:04:14 -0500 "Edward K. Ream" <[EMAIL PROTECTED]> wrote: > > Blithely ignoring the feature freeze :-} I added a @string setting > > 'cleo_color_file_nodes' which, if set to "" (not None) will disable > > file node coloring. > > No. You absolutely must not use @string whe

Re: Terry Brown's changes now in the trunk

2008-03-26 Thread Edward K. Ream
On Mar 26, 11:04 am, "Edward K. Ream" <[EMAIL PROTECTED]> wrote: > No. You absolutely must not use @string when @bool is meant. It's way too > confusing to users. Please change this to something like > > @bool cleo_colors_file_nodes = True > > This should be feasible now that you know how to sp

Re: B3 coming soon. Pls test

2008-03-26 Thread Edward K. Ream
On Wed, Mar 26, 2008 at 8:33 AM, vpe <[EMAIL PROTECTED]> wrote: > > problem: local "target_language=plain" settings are not applied The fix is on cvs. To make the fix work, please change: @language default_target_language = whatever to @string target_language = plain Note the double change:

Re: Terry Brown's changes now in the trunk

2008-03-26 Thread Edward K. Ream
On Wed, Mar 26, 2008 at 9:07 AM, Terry Brown <[EMAIL PROTECTED]> wrote: > > p.s. drunk with power, I've made the changes described below on the > trunk :-) No problem. Please change the @string setting to the @bool setting on the trunk. And while you are at it, please add all the other cleo se

Re: Terry Brown's changes now in the trunk

2008-03-26 Thread Edward K. Ream
On Wed, Mar 26, 2008 at 9:01 AM, Terry Brown <[EMAIL PROTECTED]> wrote: > > On Wed, 26 Mar 2008 05:28:03 -0500 > "Edward K. Ream" <[EMAIL PROTECTED]> wrote: > > > However, I got the following when I chose find-next-todo: > > : 'tuple' object has no attribute > > 'has_key' > > Hmm, I've tidied the

Re: @settings docs.

2008-03-26 Thread Edward K. Ream
On Wed, Mar 26, 2008 at 9:06 AM, Terry Brown <[EMAIL PROTECTED]> wrote: > > Could you tweak the docs for @settings in > http://webpages.charter.net/edreamleo/scripting.html to explain what > the getters return when there's no such setting? I assume it's False > or None. Hmm. I think the docs a

Re: Terry Brown's changes now in the trunk

2008-03-26 Thread Terry Brown
p.s. drunk with power, I've made the changes described below on the trunk :-) On Wed, 26 Mar 2008 09:01:42 -0500 Terry Brown <[EMAIL PROTECTED]> wrote: > > On Wed, 26 Mar 2008 05:28:03 -0500 > "Edward K. Ream" <[EMAIL PROTECTED]> wrote: > > > However, I got the following when I chose find-next

@settings docs.

2008-03-26 Thread Terry Brown
Could you tweak the docs for @settings in http://webpages.charter.net/edreamleo/scripting.html to explain what the getters return when there's no such setting? I assume it's False or None. Either value is a little tricky, because getBool could be confused by False, and I think you can use None a

Re: Terry Brown's changes now in the trunk

2008-03-26 Thread Terry Brown
On Wed, 26 Mar 2008 05:28:03 -0500 "Edward K. Ream" <[EMAIL PROTECTED]> wrote: > However, I got the following when I chose find-next-todo: > : 'tuple' object has no attribute > 'has_key' Hmm, I've tidied the code so that that function uses cleo's attribute getting method instead of doing the wor

Re: B3 coming soon. Pls test

2008-03-26 Thread vpe
problem: local "target_language=plain" settings are not applied My custom "leoSettings.leo" file in the HOME dir has setting "@language default_target_language = python", so that Python is default syntax. Some of my .leo files are mostly for text notes, so I have the following setting in them: "@

Leo 4.4.8 is feature frozen

2008-03-26 Thread Edward K. Ream
Now that bzr has made collaboration easier, we will all have to pay more attention to controlling changes at various points in the release cycle. It's my intention that only bug fixes appear in Leo's core from now until Leo 4.4.8 final. We have more leeway for plugins, but only just a little. J

Re: Mods to leoconfig.py, revert if you dont like.

2008-03-26 Thread Edward K. Ream
On Wed, Mar 26, 2008 at 5:45 AM, bobjack <[EMAIL PROTECTED]> wrote: > > I have made a small addition to leoConfig.py to support @popup menus > in setting trees. > > I thought it would be easier for you simply to revert the file if you > do not approve of me making the change, rather than going thr

Mods to leoconfig.py, revert if you dont like.

2008-03-26 Thread bobjack
Edward I have made a small addition to leoConfig.py to support @popup menus in setting trees. I thought it would be easier for you simply to revert the file if you do not approve of me making the change, rather than going through a series of merges. Apologies if you are unhappy with this. bob

Re: Terry Brown's changes now in the trunk

2008-03-26 Thread Edward K. Ream
On Tue, Mar 25, 2008 at 5:55 PM, Terry Brown <[EMAIL PROTECTED]> wrote: > > Ok - finally got the fix for the ignored Tk variable exception at > startup on to the trunk - log message didn't make so much sense because > of the order I did things in, will avoid that hiccup next time. > > It was a ver