Re: Summarizing recent settings/theme discussions
On Tuesday, March 6, 2018 at 12:00:41 PM UTC-6, Edward K. Ream wrote: I shall not approve using css settings that: > > A. can not easily be understood or explained. > B. modify the fundamental colors of a theme. > Terry points out that this is a developer preference. This is great news, because it means I won't have to "curate" existing themes in leoSettings.leo. Eventually some "preferred" themes will migrate to leo/themes. I have just upped LeoSolarizedDark.leo to this folder. It passes an important test: it appears to render well without *any *myLeoSettings.leo. Inheritance issue will soon arise re themes. For now, however, it's important just to add several more files to the leo/themes folder. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Summarizing recent settings/theme discussions
On Tue, Mar 6, 2018 at 12:22 PM, Terry Brown wrote: > On Tue, 6 Mar 2018 10:00:40 -0800 (PST) > "Edward K. Ream" wrote: > > > 5. They are settings that do not conflict with the theme's primary > > purpose. In particular, they do not alter the theme's basic colors. > > I don't think this merits argument because it's just a preference of > the theme designer. Good point. > I agree a theme should "just work", as distributed. As long as it > does, I don't think it matters too much how it's implemented, although > some themes may be much easier for users to tweak via settings than > others. If a user can't tweak a theme the way they want, they'll look > for another theme. > Oh good. We can move on ;-) Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
Re: Summarizing recent settings/theme discussions
On Tue, 6 Mar 2018 10:00:40 -0800 (PST) "Edward K. Ream" wrote: > 5. They are settings that do not conflict with the theme's primary > purpose. In particular, they do not alter the theme's basic colors. I don't think this merits argument because it's just a preference of the theme designer. If a theme designer wanted to make variations of a theme by redefining its colors, they should be free to do so. As I said, it's not uncommon to see the same theme released in different colors, like dark_world-green, dark_world-orange, dark_world-red, that kind of thing. That would most easily be done with one CSS and three sets of color settings. I agree a theme should "just work", as distributed. As long as it does, I don't think it matters too much how it's implemented, although some themes may be much easier for users to tweak via settings than others. If a user can't tweak a theme the way they want, they'll look for another theme. So > I shall not approve using css settings that: > > A. can not easily be understood or explained. seems like a good idea > B. modify the fundamental colors of a theme. seems like an unnecessary restriction Cheers -Terry -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
