Re: [libav-devel] [PATCH] dashenc: replace attribute id with contentType for the AdaptationSet element

2015-05-09 Thread Martin Storsjö
Hi, On Sun, 10 May 2015, James Almer wrote: id should be an integer, not a string. It is also optional, so use contentType instead which is the proper attribute for these values. I don't see anything in ISO/IEC 23009-1/2014 about id needing to be an integer - can you clarify where that requi

[libav-devel] [PATCH] dashenc: replace attribute id with contentType for the AdaptationSet element

2015-05-09 Thread James Almer
id should be an integer, not a string. It is also optional, so use contentType instead which is the proper attribute for these values. This fixes an MPD validation error. Signed-off-by: James Almer --- libavformat/dashenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[libav-devel] [PATCH] vda: Make output CVPixelBuffer format configurable

2015-05-09 Thread Luca Barbato
From: Stefano Pigozzi Signed-off-by: Luca Barbato --- Will be pushed tomorrow if nobody is against it. doc/APIchanges| 3 +++ libavcodec/vda.c | 27 ++- libavcodec/vda.h | 18 ++ libavcodec/vda_h264.c | 5 - libavcodec/version.h

Re: [libav-devel] [PATCH 1/2] pixfmt: Add Bayer pixel formats

2015-05-09 Thread Vittorio Giovara
On Sun, May 10, 2015 at 12:48 AM, Luca Barbato wrote: > On 09/05/15 22:45, Jean-Baptiste Kempf wrote: >> On 09 May, Luca Barbato wrote : >>> --- >>> doc/APIchanges | 3 +++ >>> libavutil/pixdesc.c | 45 + >>> libavutil/pixfmt.h | 15 +

Re: [libav-devel] [PATCH 1/2] pixfmt: Add Bayer pixel formats

2015-05-09 Thread Luca Barbato
On 09/05/15 22:45, Jean-Baptiste Kempf wrote: > On 09 May, Luca Barbato wrote : >> --- >> doc/APIchanges | 3 +++ >> libavutil/pixdesc.c | 45 + >> libavutil/pixfmt.h | 15 +++ >> libavutil/version.h | 4 ++-- >> 4 files changed, 65 i

Re: [libav-devel] [PATCH] vda: make output CVPixelBuffer format configurable

2015-05-09 Thread Luca Barbato
On 10/05/15 01:29, Vittorio Giovara wrote: > On Sat, May 9, 2015 at 7:48 PM, Stefano Pigozzi > wrote: >> --- >> libavcodec/vda.c | 27 ++- >> libavcodec/vda.h | 18 ++ >> libavcodec/vda_h264.c | 5 - >> 3 files changed, 48 insertions(+), 2 de

Re: [libav-devel] [PATCH] vda: make output CVPixelBuffer format configurable

2015-05-09 Thread Vittorio Giovara
On Sat, May 9, 2015 at 7:48 PM, Stefano Pigozzi wrote: > --- > libavcodec/vda.c | 27 ++- > libavcodec/vda.h | 18 ++ > libavcodec/vda_h264.c | 5 - > 3 files changed, 48 insertions(+), 2 deletions(-) This needs a MINOR bump in lavc, since v

Re: [libav-devel] [PATCH 2/2] fate: Use a single image to test the pixfmts

2015-05-09 Thread Timothy Gu
On Sat, May 09, 2015 at 11:13:09PM +0200, Luca Barbato wrote: > On 09/05/15 22:47, Luca Barbato wrote: >> The pixel format tests work on a single image that I know. Probably >> reducing the video-filter test to use just 5 frames would get some >> additional gain. >> > > Your suggestion works even

[libav-devel] [PATCH] fate: Reduce the number of frames used to test video-filter

2015-05-09 Thread Luca Barbato
Use 5 frames for video-filter and use a single one for the pixelformat tests. Greatly reduce the test duration without reducing the coverage. --- tests/fate-run.sh | 4 +- tests/ref/fate/filter-crop | 2 +- tests/ref/fate/filter-crop_scale |

Re: [libav-devel] [PATCH 2/2] fate: Use a single image to test the pixfmts

2015-05-09 Thread Luca Barbato
On 09/05/15 22:47, Luca Barbato wrote: > On 09/05/15 21:53, Timothy Gu wrote: >> On May 9, 2015 6:52 AM, "Luca Barbato" wrote: >>> >>> Reduce greatly the time to test, the coverage remains unchanged. >> >> I like this idea, but for some filters that require multiple frames to emit >> useful output

Re: [libav-devel] [PATCH 1/2] pixfmt: Add Bayer pixel formats

2015-05-09 Thread Luca Barbato
On 09/05/15 22:45, Jean-Baptiste Kempf wrote: > On 09 May, Luca Barbato wrote : >> --- >> doc/APIchanges | 3 +++ >> libavutil/pixdesc.c | 45 + >> libavutil/pixfmt.h | 15 +++ >> libavutil/version.h | 4 ++-- >> 4 files changed, 65 i

Re: [libav-devel] [PATCH 2/2] fate: Use a single image to test the pixfmts

2015-05-09 Thread Luca Barbato
On 09/05/15 21:53, Timothy Gu wrote: > On May 9, 2015 6:52 AM, "Luca Barbato" wrote: >> >> Reduce greatly the time to test, the coverage remains unchanged. > > I like this idea, but for some filters that require multiple frames to emit > useful output this might disrupt their output. How about us

Re: [libav-devel] [PATCH 1/2] pixfmt: Add Bayer pixel formats

2015-05-09 Thread Jean-Baptiste Kempf
On 09 May, Luca Barbato wrote : > --- > doc/APIchanges | 3 +++ > libavutil/pixdesc.c | 45 + > libavutil/pixfmt.h | 15 +++ > libavutil/version.h | 4 ++-- > 4 files changed, 65 insertions(+), 2 deletions(-) Why ? With my kindest r

Re: [libav-devel] [PATCH 4/5] h264: make sure the current picture is not made a long ref multiple times

2015-05-09 Thread Luca Barbato
On 09/05/15 22:01, Anton Khirnov wrote: > Fixes possible invalid reads, once one of those refs is freed, but the > others remain. > CC: libav-sta...@libav.org > --- > libavcodec/h264_refs.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_

Re: [libav-devel] [PATCH 5/5] h264: do not update the context fields copied between threads after finish_setup()

2015-05-09 Thread Luca Barbato
On 09/05/15 22:01, Anton Khirnov wrote: > Should fix a large number of possible races with frame threading. > --- > libavcodec/h264.c | 7 ++- > libavcodec/h264.h | 4 ++ > libavcodec/h264_slice.c | 125 > ++-- > 3 files changed, 88 inse

Re: [libav-devel] [PATCH 2/5] avconv: factor out flushing the filters

2015-05-09 Thread Luca Barbato
On 09/05/15 22:00, Anton Khirnov wrote: > This also ensures this is always done, avoiding infinite loops if an > error occurs at the end of the input. > --- > avconv.c | 34 ++ > 1 file changed, 22 insertions(+), 12 deletions(-) Seems Ok. lu _

Re: [libav-devel] [PATCH 3/5] avconv: do not stop processing the input packet on decoding error

2015-05-09 Thread Luca Barbato
On 09/05/15 22:01, Anton Khirnov wrote: > We still want to flush the filters on EOF and possibly apply streamcopy. > --- > avconv.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > Possibly ok, did you try what happens streamcopying a fuzzed file already? lu

Re: [libav-devel] [PATCH 1/5] h264: make sure the slices do not overlap during slice threading

2015-05-09 Thread Luca Barbato
On 09/05/15 22:00, Anton Khirnov wrote: > Based on a patch by Michael Niedermayer . > CC: libav-sta...@libav.org > Found-by: Kieran Kunhya > --- > libavcodec/h264.h | 2 ++ > libavcodec/h264_slice.c | 46 -- > 2 files changed, 42 insertions(+), 6

Re: [libav-devel] [PATCH] vda: make output CVPixelBuffer format configurable

2015-05-09 Thread Luca Barbato
On 09/05/15 20:48, Stefano Pigozzi wrote: > --- > libavcodec/vda.c | 27 ++- > libavcodec/vda.h | 18 ++ > libavcodec/vda_h264.c | 5 - > 3 files changed, 48 insertions(+), 2 deletions(-) > Looks fine to me. lu

[libav-devel] Phantom Cine demuxer and basic Bayer support

2015-05-09 Thread Luca Barbato
Since it is an outstanding bug and apparently at least there is a quite vocal user needing it I spent yet another bit of spare time on it. I'll look at getting the bayer conversion maybe later. Ideally would be probably nicer to have the gamma/wb/etc directly in the channel 3 as we do for the hwa

[libav-devel] [PATCH 1/2] pixfmt: Add Bayer pixel formats

2015-05-09 Thread Luca Barbato
--- doc/APIchanges | 3 +++ libavutil/pixdesc.c | 45 + libavutil/pixfmt.h | 15 +++ libavutil/version.h | 4 ++-- 4 files changed, 65 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 5934f45..1326200

[libav-devel] [PATCH 2/2] cine: Phantom Cine demuxer

2015-05-09 Thread Luca Barbato
From: Peter Ross Bug-Id: 764 Signed-off-by: Luca Barbato --- Changelog| 1 + doc/general.texi | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/cinedec.c| 323 +++ 5 files changed, 3

[libav-devel] [PATCH 2/5] avconv: factor out flushing the filters

2015-05-09 Thread Anton Khirnov
This also ensures this is always done, avoiding infinite loops if an error occurs at the end of the input. --- avconv.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/avconv.c b/avconv.c index 275c3eb..4aa40a8 100644 --- a/avconv.c +++ b/av

[libav-devel] [PATCH 1/5] h264: make sure the slices do not overlap during slice threading

2015-05-09 Thread Anton Khirnov
Based on a patch by Michael Niedermayer . CC: libav-sta...@libav.org Found-by: Kieran Kunhya --- libavcodec/h264.h | 2 ++ libavcodec/h264_slice.c | 46 -- 2 files changed, 42 insertions(+), 6 deletions(-) diff --git a/libavcodec/h264.h b/libavc

[libav-devel] [PATCH 5/5] h264: do not update the context fields copied between threads after finish_setup()

2015-05-09 Thread Anton Khirnov
Should fix a large number of possible races with frame threading. --- libavcodec/h264.c | 7 ++- libavcodec/h264.h | 4 ++ libavcodec/h264_slice.c | 125 ++-- 3 files changed, 88 insertions(+), 48 deletions(-) diff --git a/libavcodec/h26

[libav-devel] [PATCH 3/5] avconv: do not stop processing the input packet on decoding error

2015-05-09 Thread Anton Khirnov
We still want to flush the filters on EOF and possibly apply streamcopy. --- avconv.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/avconv.c b/avconv.c index 4aa40a8..5efa80d 100644 --- a/avconv.c +++ b/avconv.c @@ -1358,7 +1358,7 @@ static int send

[libav-devel] [PATCH 4/5] h264: make sure the current picture is not made a long ref multiple times

2015-05-09 Thread Anton Khirnov
Fixes possible invalid reads, once one of those refs is freed, but the others remain. CC: libav-sta...@libav.org --- libavcodec/h264_refs.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c index 2ddbdb7..adc2213 100644 --- a/libavcodec/h2

Re: [libav-devel] [PATCH 2/2] fate: Use a single image to test the pixfmts

2015-05-09 Thread Timothy Gu
On May 9, 2015 6:52 AM, "Luca Barbato" wrote: > > Reduce greatly the time to test, the coverage remains unchanged. I like this idea, but for some filters that require multiple frames to emit useful output this might disrupt their output. How about using a small number of frames, like 3? Also exc

[libav-devel] [PATCH/Libav12] pixdesc: Make the AVPixFmtDescriptor a little more future proof

2015-05-09 Thread Luca Barbato
8 flags are not enough. --- I need an additional flags and 8 are already in use. I'd land this patch as we are going to break the ABI soon anyway. libavutil/pixdesc.h | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libavutil/pixdesc.h b/libavutil/pixde

[libav-devel] [PATCH] vda: make output CVPixelBuffer format configurable

2015-05-09 Thread Stefano Pigozzi
--- libavcodec/vda.c | 27 ++- libavcodec/vda.h | 18 ++ libavcodec/vda_h264.c | 5 - 3 files changed, 48 insertions(+), 2 deletions(-) diff --git a/libavcodec/vda.c b/libavcodec/vda.c index f71fb16..a1a14de 100644 --- a/libavcodec/vda.c +++

Re: [libav-devel] [PATCH] D3D11va: add a Direct3D11 video decoder similar to DXVA2

2015-05-09 Thread Diego Biurrun
On Thu, May 07, 2015 at 10:04:50PM +0200, Steve Lhomme wrote: > --- > configure | 31 +++- > libavcodec/Makefile | 7 ++ > libavcodec/allcodecs.c | 5 ++ > libavcodec/d3d11va.h| 98 + > libavcodec/dxva2.c | 170 > ++

Re: [libav-devel] [PATCH 2/2] fate: Use a single image to test the pixfmts

2015-05-09 Thread Diego Biurrun
On Sat, May 09, 2015 at 03:52:09PM +0200, Luca Barbato wrote: > Reduce greatly the time to test, the coverage remains unchanged. Greatly reduce the test duration withour reducing coverage. I like the idea, patch OK. Diego ___ libav-devel mailing list l

Re: [libav-devel] dca_parser: Extend DTS core sync word and fix existing check

2015-05-09 Thread Diego Biurrun
On Thu, May 07, 2015 at 01:48:02AM +0100, Vittorio Giovara wrote: > --- a/libavcodec/dca_parser.c > +++ b/libavcodec/dca_parser.c > @@ -48,24 +55,25 @@ static int dca_find_frame_end(DCAParseContext > for (i = 0; i < buf_size; i++) { > state = (state << 8) | buf[i]; > -

Re: [libav-devel] [PATCH] configure: Provide an option to override the environment

2015-05-09 Thread Luca Barbato
On 06/05/15 13:48, Martin Storsjö wrote: > Looks nice to me (and is very useful to me, thanks!), although I'd wait > a little to see if Diego has something to add about it. This patch is in my merge queue and I'll merge it within the weekend if nobody says anything against it. lu

[libav-devel] [PATCH 2/2] fate: Use a single image to test the pixfmts

2015-05-09 Thread Luca Barbato
Reduce greatly the time to test, the coverage remains unchanged. --- tests/fate-run.sh | 2 +- tests/ref/fate/filter-pixfmts-copy | 182 ++-- tests/ref/fate/filter-pixfmts-crop | 84 - tests/ref/fate/filter-pixfmts-hflip | 84

[libav-devel] [PATCH 1/2] fate: Optionally keep the stderr

2015-05-09 Thread Luca Barbato
--- tests/Makefile| 2 +- tests/fate-run.sh | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index ed34101..fd9a1ee 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -143,7 +143,7 @@ fate: $(FATE) $(FATE): $(FATE_UTILS:%=tests/%$(H

[libav-devel] Pending FATE changes

2015-05-09 Thread Luca Barbato
Resending as set so they won't get lost. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] fate: Use a single image to test the pixfmts

2015-05-09 Thread Luca Barbato
On 02/05/15 00:08, Luca Barbato wrote: > Reduce greatly the time to test, the coverage remains unchanged. > --- > > Another annoying item in my list. > > tests/fate-run.sh | 2 +- > tests/ref/fate/filter-pixfmts-copy | 182 > ++-- > tests/ref