[libav-devel] [PATCH 1/3] arm: dsputil: fix overreads in put/avg_pixels functions

2014-08-17 Thread Janne Grunau
From: Mans Rullgard The vertically interpolating variants of these functions read ahead one line to optimise the loop. On the last line processed, this might be outside the buffer. Fix these invalid reads by processing the last line outside the loop. Signed-off-by: Mans Rullgard --- libavcod

[libav-devel] [PATCH 2/3] arm: dsputil: prettify some conditional instructions in put_pixels macros

2014-08-17 Thread Janne Grunau
From: Mans Rullgard Signed-off-by: Mans Rullgard --- libavcodec/arm/dsputil_neon.S | 62 ++- 1 file changed, 20 insertions(+), 42 deletions(-) diff --git a/libavcodec/arm/dsputil_neon.S b/libavcodec/arm/dsputil_neon.S index 4bdcd95..21b1aba 100644 --- a/

[libav-devel] Backport Arm NEON avg,put_pixels fixes to 0.8

2014-08-17 Thread Janne Grunau
Hi, backports following three commits to 0.8 cbc7d60afa0c5 arm: dsputil: fix overreads in put/avg_pixels functions 2eba6898c96fe arm: dsputil: prettify some conditional instructions in e54e6f25cfa8b arm/neon: dsputil: use correct size specifiers on Only the first is required to fix the reported

Re: [libav-devel] [PATCH 04/13] vaapi: add a mpeg1 hwaccel.

2014-08-14 Thread Janne Grunau
On 2013-11-21 11:50:54 +0100, Anton Khirnov wrote: > mpeg12 decoder passes the vaapi pixel format to get_format for both > mpeg 1 and 2. If the caller chooses vaapi for mpeg1, the decoder will > crash after failing to find a hwaccel for it. > --- > libavcodec/allcodecs.c |1 + > libavcodec/v

[libav-devel] [PATCH 1/1] doc: add links for the release/11 and release/10 api docs

2014-08-14 Thread Janne Grunau
--- release/11 is just an alias of master for now src/documentation | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/documentation b/src/documentation index 56c2444..02a7b26 100644 --- a/src/documentation +++ b/src/documentation @@ -37,6 +37,8 @@ developers will be able to better diagnos

[libav-devel] [GASPP PATCH 1/1] allow a comma between macro name and first macro parameter

2014-08-12 Thread Janne Grunau
Both gas and llvm's integrated assembler accept it. --- gas-preprocessor.pl | 2 +- test.S | 9 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 3020401..fbf0853 100755 --- a/gas-preprocessor.pl +++ b/gas-preproce

Re: [libav-devel] [PATCH] configure: Don't pass MSVC compiler options -M[TD] to armasm

2014-08-10 Thread Janne Grunau
On 2014-08-10 14:43:10 +0300, Martin Storsjö wrote: > The -MD option (for enabling a dynamically linked crt) gets interpreted > as a cpp option for generating dependency information (into a file named > '-.d', when preprocessing to a pipe). We shouldn't be passing > any and all C compiler flags to

Re: [libav-devel] [PATCH] configure: Suggest upgrading gas-preprocessor instead of just installing

2014-08-10 Thread Janne Grunau
On 2014-08-10 16:07:48 +0300, Martin Storsjö wrote: > Older versions don't support all the features we test for now. > --- > I chose not to fold this into the other patches since it didn't really > seem to be related to them. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [libav-devel] [RFC PATCH 2/2] configure: Fix checking for and autoenabling gas-preprocessor

2014-08-10 Thread Janne Grunau
On 2014-08-10 16:02:45 +0300, Martin Storsjö wrote: > On Sun, 10 Aug 2014, Janne Grunau wrote: > > >Most of my fate configs needs to have the explicit --as removed. > > At least for armasm, the explicit --as should still work, since that > one passes all tests, so it neve

Re: [libav-devel] [RFC PATCH 2/2] configure: Fix checking for and autoenabling gas-preprocessor

2014-08-10 Thread Janne Grunau
On 2014-08-10 14:14:23 +0300, Martin Storsjö wrote: > On Sun, 10 Aug 2014, Janne Grunau wrote: > > >I have no setup to test apple's gcc-4.2 with gas. > > Tested, almost works, requires the following fixup: > > -[ $target_os = "darwin" ] && gas

Re: [libav-devel] [GASPP RFC PATCH 2/2] Undefine platform specific predefined defines when preprocessing C source for armasm

2014-08-10 Thread Janne Grunau
On 2014-08-09 22:48:48 +0300, Martin Storsjö wrote: > Since plain 'cpp' is used for preprocessing, it inherits whatever > platform specific predefined defines. > > Previously this was set on the libav configure line, such as > --as='gas-preprocessor.pl -as-type armasm -- armasm -nologo -U__ELF__ -

Re: [libav-devel] [GASPP RFC PATCH 1/2] Pass -h through directly just as -v

2014-08-10 Thread Janne Grunau
On 2014-08-09 22:48:47 +0300, Martin Storsjö wrote: > This allows doing a simple no-op to test that gas-preprocessor > exists and works, since armasm doesn't have a -v option. > --- > gas-preprocessor.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gas-preprocessor.pl

Re: [libav-devel] [PATCH] lavc: drop the av_fast_{re, m}alloc compatibility wrappers

2014-08-10 Thread Janne Grunau
On 2014-08-10 10:18:30 +, Anton Khirnov wrote: > They were only needed until the bump. > --- > libavcodec/utils.c | 12 > 1 file changed, 12 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index b115da1..4253e8c 100644 > --- a/libavcodec/utils.c > +++ b/li

Re: [libav-devel] [PATCH] avcodec: Instruct users to align buffers to 32-byte.

2014-08-10 Thread Janne Grunau
On 2014-08-10 04:17:09 +0100, Kieran Kunhya wrote: > The Opus decoder in particular uses optimised float_dsp functions that expect > 32-byte alignment > --- > libavcodec/avcodec.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcode

Re: [libav-devel] [RFC PATCH 2/2] configure: Fix checking for and autoenabling gas-preprocessor

2014-08-10 Thread Janne Grunau
On 2014-08-09 22:48:29 +0300, Martin Storsjö wrote: > --- > This goes on top of Diego's RFC patch. > --- > configure | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/configure b/configure > index 4d2439e..877f240 100755 > --- a/configure > +++ b/configure > @@ -37

Re: [libav-devel] [RFC PATCH 1/2] configure: Add probe identification of MS armasm

2014-08-10 Thread Janne Grunau
On 2014-08-09 22:48:28 +0300, Martin Storsjö wrote: > --- > configure | 4 > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index 7e3f6ff..4d2439e 100755 > --- a/configure > +++ b/configure > @@ -2881,6 +2881,10 @@ probe_cc(){ > _cflags_size="-O2 -Munroll=c

[libav-devel] [GASPP PATCH 1/1] remove all lines starting with '#'

2014-08-09 Thread Janne Grunau
'#' at the start of the line indicates on all archs the start of a comment or a preprocessor directive. This is after preprocessing so removing the lines as comment is safe. Line number comments are stripped by this too since gas-preprocessor.pl ignores line numbers. So it removes just misleading d

Re: [libav-devel] [PATCH] [RFC] configure: Enable gas-preprocessor on all OSes but only if available

2014-08-09 Thread Janne Grunau
On 2014-08-09 08:06:12 -0700, Diego Biurrun wrote: > --- > > Implemented Janne's suggestion. Untested since I don't have the right system. > > configure | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 46b8391..7c2fab6 1007

Re: [libav-devel] [PATCH 1/1] configure: check $as first before using $gas as GNU as

2014-08-09 Thread Janne Grunau
On 2014-08-06 12:24:24 +0200, Diego Biurrun wrote: > On Tue, Aug 05, 2014 at 01:35:22PM +0200, Janne Grunau wrote: > > From: Janne Grunau > > --- a/configure > > +++ b/configure > > @@ -3760,22 +3760,32 @@ unsigned int endian = 'B' << 24 | 'I&#

Re: [libav-devel] [PATCH 2/3] configure: Only enable gas-preprocessor if the program is available

2014-08-09 Thread Janne Grunau
On 2014-08-08 14:58:39 +0200, Diego Biurrun wrote: > On Thu, Aug 07, 2014 at 06:39:33PM +0200, Diego Biurrun wrote: > > On Wed, Aug 06, 2014 at 04:41:24PM +0200, Janne Grunau wrote: > > > On 2014-08-06 05:57:39 -0700, Diego Biurrun wrote: > > > > > > the comm

Re: [libav-devel] [PATCH 2/3] [v2] configure: Only enable gas-preprocessor if the program is available

2014-08-08 Thread Janne Grunau
On 2014-08-07 10:13:26 -0700, Diego Biurrun wrote: > --- > configure | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 924fd46..4d3732b 100755 > --- a/configure > +++ b/configure > @@ -2199,8 +2199,6 @@ ranlib="ranlib" > strip="strip" >

Re: [libav-devel] [PATCH 3/3] [v2] configure: Only run gas checks on ARM and PowerPC

2014-08-08 Thread Janne Grunau
On 2014-08-07 10:13:27 -0700, Diego Biurrun wrote: > Standalone GNU assembly is not used on x86. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 4d3732b..c74d910 100755 > --- a/configure > +++ b/configure > @@ -3774,7 +3774,

Re: [libav-devel] [PATCH 1/3] [v2] configure: Die if gas is unavailable under aarch64 as well as ARM

2014-08-08 Thread Janne Grunau
On 2014-08-07 10:13:25 -0700, Diego Biurrun wrote: > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 26ea230..924fd46 100755 > --- a/configure > +++ b/configure > @@ -3778,7 +3778,7 @@ EOF > } > > if enabled asm; then > -

Re: [libav-devel] [PATCH 1/3] configure: Die or warn under the right conditions if gas is unavailable

2014-08-06 Thread Janne Grunau
On 2014-08-06 05:57:38 -0700, Diego Biurrun wrote: > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index c8c57b9..45da142 100755 > --- a/configure > +++ b/configure > @@ -3779,8 +3779,8 @@ EOF > } > > if enabled asm; then

Re: [libav-devel] [PATCH 3/3] configure: Only run gas checks on ARM and PowerPC

2014-08-06 Thread Janne Grunau
On 2014-08-06 05:57:40 -0700, Diego Biurrun wrote: > Standalone GNU assembly is not used on x86. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 81dfc09..a0d60e9 100755 > --- a/configure > +++ b/configure > @@ -3775,7 +3775,

Re: [libav-devel] [PATCH 2/3] configure: Only enable gas-preprocessor if the program is available

2014-08-06 Thread Janne Grunau
On 2014-08-06 05:57:39 -0700, Diego Biurrun wrote: the commit message describes the commit only partially. It also uses gas-preprocessor.pl if it's available and not only on darwin. I think that's not going to work since the plain 'gas-preprocessor.pl' without options will produce mach-O specif

Re: [libav-devel] [PATCH 1/3] configure: Die or warn under the right conditions if gas is unavailable

2014-08-06 Thread Janne Grunau
On 2014-08-06 05:57:38 -0700, Diego Biurrun wrote: > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index c8c57b9..45da142 100755 > --- a/configure > +++ b/configure > @@ -3779,8 +3779,8 @@ EOF > } > > if enabled asm; then

[libav-devel] [PATCH 1/1] configure: check $as first before using $gas as GNU as

2014-08-05 Thread Janne Grunau
From: Janne Grunau Hi, On 2014-08-05 13:38:47 +0300, Martin Storsjö wrote: > On Tue, 5 Aug 2014, Janne Grunau wrote: > > >From: Janne Grunau > > > >This was the last missing feature in llvm's integrated assembler on darwin. > >There is no need to use g

Re: [libav-devel] [PATCH 1/1] fate: generate tests/pixfmts.mak for all targets requiring it

2014-08-05 Thread Janne Grunau
On 2014-08-05 11:20:18 +0200, Luca Barbato wrote: > On 05/08/14 09:44, Janne Grunau wrote: > > All subtargets which should run the fate-filter-pixdesc% need to > > generate and include tests/pixfmts.mak. Most noteable missing target was > > fate itself. > > --- > >

[libav-devel] [PATCH 1/1] configure: AArch64: check if the assembler supports ':vararg'

2014-08-05 Thread Janne Grunau
From: Janne Grunau This was the last missing feature in llvm's integrated assembler on darwin. There is no need to use gas-preprocessor.pl if the assembler supports the asm fully. --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index b2

[libav-devel] [PATCH 1/1] fate: generate tests/pixfmts.mak for all targets requiring it

2014-08-05 Thread Janne Grunau
All subtargets which should run the fate-filter-pixdesc% need to generate and include tests/pixfmts.mak. Most noteable missing target was fate itself. --- tests/fate/filter-video.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/filter-video.mak b/tests/fate/filter

Re: [libav-devel] [libav-commits] fate: Only generate tests/pixfmts.mak if some pixfmts fate test is run

2014-08-04 Thread Janne Grunau
On 2014-08-04 20:32:15 +0200, Diego Biurrun wrote: > Module: libav > Branch: master > Commit: eee813eec7d3c0b0689f80665d3f796401742935 > > Author:Diego Biurrun > Committer: Diego Biurrun > Date: Sun Aug 3 06:21:15 2014 -0700 > > fate: Only generate tests/pixfmts.mak if some pixfmts f

Re: [libav-devel] [PATCH 1/1] fate: explicitly set the default THREADS value

2014-08-04 Thread Janne Grunau
On 2014-08-04 11:35:46 +0200, Diego Biurrun wrote: > On Mon, Aug 04, 2014 at 10:09:34AM +0200, Janne Grunau wrote: > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -1,3 +1,4 @@ > > +THREADS := 1 > > VREF = tests/vsynth1/00.pgm > > AREF = tests/

Re: [libav-devel] [PATCH] fate: Only generate tests/pixfmts.mak if some pixfmts fate test is run

2014-08-04 Thread Janne Grunau
On 2014-08-04 03:00:58 -0700, Diego Biurrun wrote: > --- > > Now w/o silly typo and not missing fate-list. > > tests/fate/filter-video.mak | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > index bbe77ce..cd905

Re: [libav-devel] [PATCH 2/2] build: Add explicit dependency declaration for generated version.h header

2014-08-04 Thread Janne Grunau
On 2014-08-03 15:48:21 -0700, Diego Biurrun wrote: > Otherwise the dependency is noticed only after compiling the first file > that requires it, resulting in double compilation of that file. requires what? I can't follow why this is necessary. .version and version.h should be always (re-)made fir

Re: [libav-devel] [PATCH 1/2] fate: Only generate tests/pixfmts.mak if some pixfmts fate test is run

2014-08-04 Thread Janne Grunau
On 2014-08-03 15:48:20 -0700, Diego Biurrun wrote: > --- > tests/fate/filter-video.mak | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > index bbe77ce..d1cb721 100644 > --- a/tests/fate/filter-video.mak > +++ b/

[libav-devel] [PATCH 1/1] fate: explicitly set the default THREADS value

2014-08-04 Thread Janne Grunau
This makes the default of '1' more explicit than defaulting to '1' in fate-run.sh and regression-funcs.sh if THREADS is not set. Fixes the reported thread count in fate-cpu if THREADS is not set. --- tests/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile b/tests/Makefile

Re: [libav-devel] [PATCH 1/2] fate: add informative cpu test

2014-08-03 Thread Janne Grunau
On 2014-08-03 18:06:04 +0200, Diego Biurrun wrote: > On Sun, Aug 03, 2014 at 04:37:05PM +0200, Janne Grunau wrote: > > --- a/libavutil/cpu.c > > +++ b/libavutil/cpu.c > > @@ -224,17 +228,50 @@ static const struct { > > > > +static void print_cpu_flag

Re: [libav-devel] [PATCH] mpeg4video: Initialize xvididct for all threads

2014-08-03 Thread Janne Grunau
On 2014-08-03 09:02:03 -0700, Diego Biurrun wrote: > From: Anton Khirnov > > Signed-off-by: Diego Biurrun > --- > > This fixes fate-xvid-idctmmx with more than one thread. > > libavcodec/mpeg4videodec.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/mpeg4videodec.c

[libav-devel] [PATCH 1/1] aarch64: use MACH-O const data asm directive in const macro

2014-08-03 Thread Janne Grunau
--- libavutil/aarch64/asm.S | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S index 850f16b..b766e67 100644 --- a/libavutil/aarch64/asm.S +++ b/libavutil/aarch64/asm.S @@ -57,7 +57,11 @@ FUNC.func \name ELF .size \name, . - \name

[libav-devel] [PATCH 2/2] cpu-test: test av_cpu_count

2014-08-03 Thread Janne Grunau
Add CPU count and number threads as informative values for fate. --- libavutil/cpu.c | 14 +- tests/fate/libavutil.mak | 2 +- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/libavutil/cpu.c b/libavutil/cpu.c index 20f0fe1..a7e5f7f 100644 --- a/libavutil/cpu.c

[libav-devel] [PATCH 1/2] fate: add informative cpu test

2014-08-03 Thread Janne Grunau
libavutil/cpu-test prints raw and effective cpu flags to STDERR. Detected cpu flags can be useful for debugging fate errors. No comparison of the result against a expected result since that would require fate config specific references. --- libavutil/cpu.c | 49 ++

Re: [libav-devel] [PATCH 1/2] aarch64: use MACH-O const data asm directive in const macro

2014-08-03 Thread Janne Grunau
On 2014-08-03 12:23:35 +0300, Martin Storsjö wrote: > On Sun, 3 Aug 2014, Martin Storsjö wrote: > > >On Thu, 24 Jul 2014, Janne Grunau wrote: > > > >>--- > >>libavutil/aarch64/asm.S | 9 - > >>1 file changed, 8 insertions(+), 1 deletion(-) &g

Re: [libav-devel] AArch64 asm fixes for llvm 3.5's integrated assembler on darwin

2014-08-03 Thread Janne Grunau
On 2014-07-24 15:11:24 +0200, Janne Grunau wrote: > Hi, > > following two patches improve support for llvm 3.5's integrated assembler > on darwin/ios. A locally patched llvm-3.5 with http://reviews.llvm.org/D3507 > passes mak

Re: [libav-devel] [PATCH] fate: Split fate-pixdesc tests and dispatch them through Make

2014-07-30 Thread Janne Grunau
On 2014-07-30 09:17:01 -0700, Diego Biurrun wrote: > This allows running all the tests individually and/or in parallel. > --- > > Fixed cross-compilation setups and added a newline to the end of the snippet. lgtm Janne ___ libav-devel mailing list liba

Re: [libav-devel] [PATCH] fate: Split fate-pixdesc tests and dispatch them through Make

2014-07-30 Thread Janne Grunau
On 2014-07-29 06:18:19 -0700, Diego Biurrun wrote: > This allows running all the tests individually and/or in parallel. > --- > > On Diegò's 32-core compile host this reduces the time to run fate in > parallel from 44.5s to 42.5s. > > diff --git a/.gitignore b/.gitignore > index 584ff94..19bb757

Re: [libav-devel] [PATCH] video4linux2: Avoid a floating point exception

2014-07-28 Thread Janne Grunau
On 2014-07-28 01:14:43 -0700, Diego Biurrun wrote: > From: Bernhard Übelacker > > This avoids a segfault in avconv_opt.c:opt_target when trying to > determine the norm. > > A workaround is to specify the norm as prefix to the target (instead > of "-target dvd" use "-target pal-dvd"). > --- > >

[libav-devel] [PATCH 1/1] fate: support testing of release branches

2014-07-26 Thread Janne Grunau
Adding 'branch=release/10' to the fate config file will check the release/10 branch instead of master. If no branch is specified it will use 'master' so that existing config are still valid. The server side changes are already deployed, see https://fate.libav.org/v10/ for an example. The server su

Re: [libav-devel] [PATCH 3/5] mpeg4video: Drop unnecessary MMX ifdefs around DCT init call

2014-07-24 Thread Janne Grunau
On 2014-07-23 15:51:10 +0200, Diego Biurrun wrote: > On Mon, Jul 21, 2014 at 11:58:26PM +0200, Janne Grunau wrote: > > On 2014-07-21 14:21:08 -0700, Diego Biurrun wrote: > > > The DCT init code takes care of MMX and other arch details on its own. > > > > yes and

[libav-devel] [PATCH 2/2] aarch64: add ', ' between assembler macro arguments where missing

2014-07-24 Thread Janne Grunau
llvm's integrated assembler does not accept spaces as macro argument delimiter when targeting darwin. Using a explicit delimiter is a good idea in principle since it makes case like 'macro 4 -2' vs 'macro 4 - 2' clear. --- libavcodec/aarch64/fft_neon.S | 2 +- libavcodec/aarch64/mpegaudio

[libav-devel] [PATCH 1/2] aarch64: use MACH-O const data asm directive in const macro

2014-07-24 Thread Janne Grunau
--- libavutil/aarch64/asm.S | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S index 850f16b..f765e59 100644 --- a/libavutil/aarch64/asm.S +++ b/libavutil/aarch64/asm.S @@ -26,6 +26,12 @@ # define ELF # #endif +#ifde

[libav-devel] AArch64 asm fixes for llvm 3.5's integrated assembler on darwin

2014-07-24 Thread Janne Grunau
Hi, following two patches improve support for llvm 3.5's integrated assembler on darwin/ios. A locally patched llvm-3.5 with http://reviews.llvm.org/D3507 passes make fate. Janne ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.or

Re: [libav-devel] [PATCH] build: Add define for SIMD extensions requiring 16-byte aligned buffers

2014-07-22 Thread Janne Grunau
On 2014-07-22 04:03:02 -0700, Diego Biurrun wrote: > --- > > Changed to also replace the need_memalign variable in configure, which > essentially indicates the same thing. > > I've followed the git-blame path of STRIDE_ALIGN and an now confident > this is the correct solution for a number of hack

Re: [libav-devel] [PATCH 2/5] libxvid: Drop PPC-specific CPU detection hack

2014-07-22 Thread Janne Grunau
On 2014-07-22 10:01:35 +0200, Diego Biurrun wrote: > On Tue, Jul 22, 2014 at 12:04:38AM +0200, Janne Grunau wrote: > > On 2014-07-21 14:21:07 -0700, Diego Biurrun wrote: > > > It is doubtful if the hack (still) works and PPC is obsolete for encoding. > > > > not so

Re: [libav-devel] [PATCH 2/5] libxvid: Drop PPC-specific CPU detection hack

2014-07-21 Thread Janne Grunau
On 2014-07-21 14:21:07 -0700, Diego Biurrun wrote: > It is doubtful if the hack (still) works and PPC is obsolete for encoding. not so sure about the latter but xvid had enough time to fix it. no need to keep this ugly workaround. > --- > libavcodec/libxvid.c | 12 > 1 file changed

Re: [libav-devel] [PATCH 3/5] mpeg4video: Drop unnecessary MMX ifdefs around DCT init call

2014-07-21 Thread Janne Grunau
On 2014-07-21 14:21:08 -0700, Diego Biurrun wrote: > The DCT init code takes care of MMX and other arch details on its own. yes and no > --- > libavcodec/mpeg4videodec.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4vi

[libav-devel] [PATCH 1/2] configure: add support for neon intrinsics

2014-07-21 Thread Janne Grunau
--- Makefile | 1 + configure | 12 2 files changed, 13 insertions(+) diff --git a/Makefile b/Makefile index 6302997..b8d1034 100644 --- a/Makefile +++ b/Makefile @@ -130,6 +130,7 @@ $(foreach V,$(SUBDIR_VARS),$(eval $(call RESET,$(V SUBDIR := $(1)/ include $(SRC_PATH)/$(1)/M

[libav-devel] [PATCH 2/2] aarch64: NEON intrinsics dct_unquantize_h263.

2014-07-21 Thread Janne Grunau
From: James Yu Intrinsics only used on aarch64 since the existing ARMv7 NEON asm is slightly faster (Cortex-A9, gcc-4.8, micro-benchmarks and full decoding time). Signed-off-by: James Yu Signed-off-by: Janne Grunau --- libavcodec/mpegvideo.c | 3 + libavcodec/mpegvideo.h | 1

Re: [libav-devel] Fwd: Bug#753528: libav-tools: Floating point exception is raised when recording vom video4linux2

2014-07-21 Thread Janne Grunau
On 2014-07-20 14:50:59 -0400, Reinhard Tartler wrote: > Control: forwarded -1 libav-devel@libav.org > > Hi, > > In Debian, we've received this bugreport regarding a bugfix in our > video4linux2 handling. > > Is the patch below acceptable for master? looks ok to me Janne ___

Re: [libav-devel] Pull requests on github

2014-07-21 Thread Janne Grunau
On 2014-07-19 10:42:55 -0400, Reinhard Tartler wrote: > Hi, > > I notice that we currently have 6 open pull requests on github: > > https://github.com/libav/libav/pulls > > Interestingly, there are also 8 closed requests: > > https://github.com/libav/libav/pulls?direction=desc&page=1&sort=creat

Re: [libav-devel] Travis

2014-07-21 Thread Janne Grunau
On 2014-07-19 18:26:22 +0200, Diego Biurrun wrote: > On Sat, Jul 19, 2014 at 12:23:58PM -0400, Reinhard Tartler wrote: > > > > For release branches, we currently don't have any FATE Farm. It would > > be great to have something like that, but as far as I understand, it > > is a lot of effort to se

Re: [libav-devel] [PATCH] tiff: decode grayscale 8bit images

2014-07-20 Thread Janne Grunau
On 2014-07-21 01:19:15 +0200, Luca Barbato wrote: > On 20/07/14 13:57, Luca Barbato wrote: > > On 20/07/14 13:47, Vittorio Giovara wrote: > >> From: Carl Eugen Hoyos > >> > >> --- > >> libavcodec/tiff.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/libavcodec/tiff.c b/libav

Re: [libav-devel] [Updated PATCH 2/4] armv6: Accelerate ff_fft_calc for general case (nbits != 4)

2014-07-18 Thread Janne Grunau
On 2014-07-16 19:33:59 +0300, Martin Storsjö wrote: > Hi Ben, > > On Wed, 16 Jul 2014, Ben Avison wrote: > > >>>+ldr v5, =\costable > >> > >>Should this perhaps use the movrelx macro? > > > >Um, maybe. I must admit to not really understanding what the movrel and > >movrelx macros are

Re: [libav-devel] [GASPP PATCH 4/4] Fix up temporary labels after .short as well as the existing .word and .hword

2014-07-16 Thread Janne Grunau
On 2014-07-13 11:42:57 +0300, Martin Storsjö wrote: > --- > gas-preprocessor.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl > index 86293d1..431270a 100755 > --- a/gas-preprocessor.pl > +++ b/gas-preprocessor.pl > @@ -877,7 +8

Re: [libav-devel] [PATCH] arm: Avoid using the 'setend' instruction on ARMv7 and newer

2014-07-08 Thread Janne Grunau
On 2014-07-08 10:58:10 +0300, Martin Storsjö wrote: > This instruction is deprecated on ARMv8, and it is serializing on > some ARMv7 cores as well [1]. > > http://article.gmane.org/gmane.linux.ports.arm.kernel/339293 > --- > libavcodec/arm/h264dsp_init_arm.c | 7 ++- > 1 file changed, 6 inser

Re: [libav-devel] [PATCH] arm: Avoid functions using the deprecated 'setend' instruction on modern arches

2014-07-07 Thread Janne Grunau
On 2014-07-06 17:48:14 +0300, Martin Storsjö wrote: > On Sun, 6 Jul 2014, Janne Grunau wrote: > > >On 2014-07-04 18:27:54 +0300, Martin Storsjö wrote: > >> > >>[1] > >>http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/268504.html > >>

Re: [libav-devel] [PATCH] arm: Avoid functions using the deprecated 'setend' instruction on modern arches

2014-07-06 Thread Janne Grunau
On 2014-07-04 18:27:54 +0300, Martin Storsjö wrote: > See [1] for discussion on the issue with using 'setend' on modern > arm versions. > > [1] > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/268504.html > --- > libavcodec/arm/h264dsp_init_arm.c | 6 +- > 1 file changed, 5

Re: [libav-devel] [PATCH] arm: Detect 32 bit cpu features on ARMv8 when running on a 64 bit kernel

2014-06-28 Thread Janne Grunau
On 2014-06-28 00:10:59 +0300, Martin Storsjö wrote: > When running on a 64 bit kernel, /proc/cpuinfo lists different > optional features than on 32 bit kernels (because some of them > are mandatory in the 64 bit implemenations). > > The kernel does list the old features properly if they are querie

Re: [libav-devel] [PATCH] arm: Include implicit cpu features on ARMv8 when parsing /proc/cpuinfo

2014-06-27 Thread Janne Grunau
On 2014-06-23 21:10:14 +0300, Martin Storsjö wrote: > When running on a 64 bit kernel, /proc/cpuinfo does not list > the cpu features that aren't optional on such CPUs. > > A 32 bit binary which runs on such a kernel, that tries to parse > /proc/cpuinfo to find the relevant cpu features at runtime

Re: [libav-devel] [PATCH 1/1] h264: avoid using uninitialized memory in NEON chroma mc

2014-06-23 Thread Janne Grunau
On 2014-06-19 12:26:15 +0200, Janne Grunau wrote: > Adapt commit 982b596ea6640bfe218a31f6c3fc542d9fe61c31 for the arm and > aarch64 NEON asm. 5-10% faster on Cortex-A9. > --- > libavcodec/aarch64/h264cmc_neon.S | 59 +++--- > libavcodec/arm/h264cmc_

Re: [libav-devel] [PATCH v3 2/2] aarch64: NEON intrinsics dct_unquantize_h263.

2014-06-20 Thread Janne Grunau
On 2014-06-19 18:46:15 +0200, Diego Biurrun wrote: > On Thu, Jun 19, 2014 at 12:29:04PM +0200, Janne Grunau wrote: > > --- a/libavcodec/mpegvideo.c > > +++ b/libavcodec/mpegvideo.c > > @@ -391,6 +391,9 @@ av_cold int ff_dct_common_init(MpegEncContext *s) > > s-

Re: [libav-devel] [PATCH v3 1/2] configure: add support for neon intrinsics

2014-06-19 Thread Janne Grunau
On 2014-06-19 18:55:45 +0200, Diego Biurrun wrote: > On Thu, Jun 19, 2014 at 12:29:03PM +0200, Janne Grunau wrote: > > --- a/configure > > +++ b/configure > > @@ -4403,6 +4411,17 @@ enabled_all dxva2 CoTaskMemFree && > > > > +for intrin in $INTRINSICS_L

[libav-devel] [PATCH v3 1/2] configure: add support for neon intrinsics

2014-06-19 Thread Janne Grunau
--- Makefile | 1 + configure | 20 2 files changed, 21 insertions(+) diff --git a/Makefile b/Makefile index 6302997..b8d1034 100644 --- a/Makefile +++ b/Makefile @@ -130,6 +130,7 @@ $(foreach V,$(SUBDIR_VARS),$(eval $(call RESET,$(V SUBDIR := $(1)/ include $(SRC_PATH

[libav-devel] [PATCH v3 2/2] aarch64: NEON intrinsics dct_unquantize_h263.

2014-06-19 Thread Janne Grunau
From: James Yu Intrinsics only used on aarch64 since the existing ARMv7 NEON asm is slightly faster (Cortex-A9, gcc-4.8, micro-benchmarks and full decoding time). Signed-off-by: James Yu --- libavcodec/mpegvideo.c | 3 + libavcodec/mpegvideo.h | 1 + libavcodec/neon/Makefile|

[libav-devel] [PATCH 1/1] h264: avoid using uninitialized memory in NEON chroma mc

2014-06-19 Thread Janne Grunau
Adapt commit 982b596ea6640bfe218a31f6c3fc542d9fe61c31 for the arm and aarch64 NEON asm. 5-10% faster on Cortex-A9. --- libavcodec/aarch64/h264cmc_neon.S | 59 +++--- libavcodec/arm/h264cmc_neon.S | 60 --- 2 files changed, 111

Re: [libav-devel] [PATCH 1/2] configure: add support for neon intrinsics

2014-06-17 Thread Janne Grunau
On 2014-06-17 13:59:17 +0200, Diego Biurrun wrote: > On Tue, Jun 10, 2014 at 10:43:33PM +0200, Janne Grunau wrote: > > --- a/configure > > +++ b/configure > > @@ -1361,6 +1361,7 @@ HAVE_LIST_PUB=" > > HEADERS_LIST=" > > alsa_asoundl

Re: [libav-devel] [PATCH 1/2] configure: add support for neon intrinsics

2014-06-15 Thread Janne Grunau
On 2014-06-10 22:43:33 +0200, Janne Grunau wrote: > --- > configure | 8 > 1 file changed, 8 insertions(+) > > diff --git a/configure b/configure > index 8359c68..5c21a33 100755 > --- a/configure > +++ b/configure > @@ -1361,6 +1361,7 @@ HAVE

Re: [libav-devel] [PATCH 1/1] mpegvideo: synchronize AVFrame pointers in ERContext fully

2014-06-11 Thread Janne Grunau
On 2014-06-11 19:51:35 +0200, Janne Grunau wrote: > Since error resilience uses AVFrame pointers instead of references it > has to copy NULL pointers too. After a codec flush the last/next frame > pointers in MpegEncContext are NULL and the old pointers remaining in > ERContext are in

[libav-devel] [PATCH 1/1] mpegvideo: synchronize AVFrame pointers in ERContext fully

2014-06-11 Thread Janne Grunau
Since error resilience uses AVFrame pointers instead of references it has to copy NULL pointers too. After a codec flush the last/next frame pointers in MpegEncContext are NULL and the old pointers remaining in ERContext are invalid. Fixes a crash in vlc for android thumbnailer. Reported and debugg

[libav-devel] [PATCH 2/2] aarch64: NEON intrinsics dct_unquantize_h263.

2014-06-10 Thread Janne Grunau
From: James Yu Intrinsics only used on aarch64 since the existing ARMv7 NEON asm is slightly faster (Cortex-A9, gcc-4.8, micro-benchmarks and full decoding time). Signed-off-by: James Yu --- libavcodec/aarch64/Makefile | 4 ++ libavcodec/arm/Makefile | 4 ++ libavcodec/arm/neon

[libav-devel] [PATCH 1/2] configure: add support for neon intrinsics

2014-06-10 Thread Janne Grunau
--- configure | 8 1 file changed, 8 insertions(+) diff --git a/configure b/configure index 8359c68..5c21a33 100755 --- a/configure +++ b/configure @@ -1361,6 +1361,7 @@ HAVE_LIST_PUB=" HEADERS_LIST=" alsa_asoundlib_h altivec_h +arm_neon_h arpa_inet_h cdio_parano

Re: [libav-devel] [PATCH] aarch64: NEON intrinsics dct_unquantize_h263. bug fixed.

2014-06-10 Thread Janne Grunau
Hi, sorry for the late reply, I missed this updated patch On 2014-05-17 12:21:10 +0800, james...@linaro.org wrote: > From: James Yu > > Using NEON intrinsics to support ARMv7 and ARMv8 simultaneously. > Rewrite ARMv7 assembly to intinsics version. > > Toolchain: > armv7: gcc-linaro-arm-linux-gnue

[libav-devel] [PATCH 1/1] h263enc: keep block_last_index always valid during advanced intra coding

2014-06-10 Thread Janne Grunau
Prevents a triggered assert during fate-vsynth{1,2}-rv20 in dct_unquantize_h263_intra_c(). --- libavcodec/ituh263enc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index cd4ed84..5f15b2f 100644 --- a/libavcodec/ituh26

Re: [libav-devel] [PATCH] x86: h264: Don't keep data in the redzone across function calls on 64 bit unix

2014-06-10 Thread Janne Grunau
On 2014-06-08 01:55:47 +0300, Martin Storsjö wrote: > We know that the called function (ff_chroma_inter_body_mmxext) > doesn't touch the redzone, and thus will be kept intact - thus, > this doesn't fix any bug per se. > > However, valgrind's memcheck tool intentionally assumes that the > redzone i

[libav-devel] [PATCH 1/1] av_dict_set: fix potential memory leak with AV_DICT_DONT_OVERWRITE

2014-06-08 Thread Janne Grunau
av_dict_set leaks it key/value arguments if AV_DICT_DONT_OVERWRITE is combined with AV_DICT_DONT_STRDUP_{KEY,VAL} and the key exists. --- libavutil/dict.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 3b95aba..112e082 100644 --- a

Re: [libav-devel] [PATCH] mpeg2: adding sequence display extension information

2014-06-03 Thread Janne Grunau
On 2014-06-03 13:40:12 +0200, Marc-Antoine ARNAUD wrote: > I found my error, I don't pass sample directory, I think it's that. > It looks okay now. > > But yes the FATE for Mpeg2 will change. What's the best way ? Resubmit a > complet patch (including FATE changes), yes, please resubmit a patch i

Re: [libav-devel] [PATCH] mpeg2: adding sequence display extension information

2014-06-03 Thread Janne Grunau
On 2014-06-03 11:18:31 +0200, Marc-Antoine ARNAUD wrote: > I don't find mpeg12 fate using : make fate-list | grep mpeg > What I need to update for fix my commit ? > > During make fate I have: > TESTfft-4 > make: *** [fate-fft-4] Erreur 127 That should not happen. Is there anything special abo

[libav-devel] [PATCH v2 1/1] configure: use .altmacro for gnu as check on arm

2014-06-03 Thread Janne Grunau
Clang's integrated assembler (after 3.4) does not yet support the '.altmacro' directive which is only used in arm asm. Support is planned: http://llvm.org/bugs/show_bug.cgi?id=18918 --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 59f7273..8359c68 1

Re: [libav-devel] [PATCH 5/5] configure: use .altmacro for gnu as check on arm

2014-06-03 Thread Janne Grunau
On 2014-06-02 14:49:39 +0200, Diego Biurrun wrote: > On Fri, May 30, 2014 at 08:56:30PM +0200, Janne Grunau wrote: > > Clang's integrated assembler (after 3.4) does not yet support the > > '.altmacro' directive which is only used in arm asm. Support is pla

[libav-devel] [PATCH v2 1/1] build: check if AS supports the '.func' directive

2014-06-03 Thread Janne Grunau
Not supported by Clang's integrated assembler. Since it just adds debug information it can safely omitted. --- configure | 6 ++ libavutil/aarch64/asm.S | 12 +--- libavutil/arm/asm.S | 12 +--- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/

[libav-devel] [PATCH v2 1/1] arm: check if AS supports .dn

2014-06-03 Thread Janne Grunau
Move the GNU as check before the arch specific asm checks since the .dn check requires gas compatible assembler. Disable the VC-1 motion compensation NEON asm which is the only part using that directive. The integrated assembler in the upcoming clang 3.5 does not support .dn/.qn without plans to c

[libav-devel] [PATCH v2 1/1] aarch64: use '#' for whole line asm comments

2014-06-03 Thread Janne Grunau
Both gnu as and clang treat lines starting with '#' as comments if they aren't consumed by the C-style preprocessor. Using '//' does not work with clang since comments are removed before macro expansion. --- reformulated the commit message libavutil/aarch64/asm.S | 2 +- 1 file changed, 1 inserti

Re: [libav-devel] [PATCH 1/5] aarch64: remove optional :pg_hi21: for adrp instruction

2014-06-03 Thread Janne Grunau
I've decided to handle the darwin styl relocations explicitly with #if in the hope that a future version of apple clang supports our asm fully. Janne ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 1/2] aarch64: add darwin style PAGE/PAGEOFF relocations

2014-06-03 Thread Janne Grunau
--- libavutil/aarch64/asm.S | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S index e9cc995..4896bf4 100644 --- a/libavutil/aarch64/asm.S +++ b/libavutil/aarch64/asm.S @@ -63,7 +63,10 @@ ELF .size \name, . - \name .endm

[libav-devel] [PATCH 2/2] aarch64: remove optional :pg_hi21: for adrp instruction

2014-06-03 Thread Janne Grunau
Clang's integrated assembler does not support it. --- libavutil/aarch64/asm.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S index 4896bf4..850f16b 100644 --- a/libavutil/aarch64/asm.S +++ b/libavutil/aarch64/asm.S @@ -67,7 +67

Re: [libav-devel] [PATCH 1/5] aarch64: remove optional :pg_hi21: for adrp instruction

2014-05-31 Thread Janne Grunau
On 2014-05-30 22:14:03 +0300, Martin Storsjö wrote: > On Fri, 30 May 2014, Janne Grunau wrote: > > >Clang's integrated assembler does not support it and it is optional > >for GNU as. > >--- > >libavutil/aarch64/asm.S | 2 +- > >1 file changed, 1 insert

Re: [libav-devel] [PATCH 3/5] arm: check if AS supports .dn

2014-05-31 Thread Janne Grunau
On 2014-05-30 22:20:14 +0300, Martin Storsjö wrote: > On Fri, 30 May 2014, Janne Grunau wrote: > > >Disable the VC-1 motion compensation NEON asm which is the only part > >using that directive. The integrated assembler in the upcoming clang 3.5 > >does not support .dn/.qn

Re: [libav-devel] [PATCH 1/5] aarch64: remove optional :pg_hi21: for adrp instruction

2014-05-31 Thread Janne Grunau
On 2014-05-30 22:14:03 +0300, Martin Storsjö wrote: > On Fri, 30 May 2014, Janne Grunau wrote: > > >Clang's integrated assembler does not support it and it is optional > >for GNU as. > >--- > >libavutil/aarch64/asm.S | 2 +- > >1 file changed, 1 insert

Re: [libav-devel] [PATCH 2/5] aarch64: use '#' for whole line asm comments

2014-05-31 Thread Janne Grunau
On 2014-05-30 22:17:42 +0300, Martin Storsjö wrote: > On Fri, 30 May 2014, Janne Grunau wrote: > > >Defining symbols conditionally to '//' does not work with clang's > >integrated assembler. Comments seems to be removed before the symbols > >are substituted

[libav-devel] [PATCH 2/5] aarch64: use '#' for whole line asm comments

2014-05-30 Thread Janne Grunau
Defining symbols conditionally to '//' does not work with clang's integrated assembler. Comments seems to be removed before the symbols are substituted. --- libavutil/aarch64/asm.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S

<    1   2   3   4   5   6   7   8   9   10   >