[libav-devel] [PATCH] AMF SDK integration code cleanup: replace writer_id option to LIBAV_AMF_WRITER_ID

2018-03-07 Thread Kravchenko, Alexander
> Also, I'd replace the log message with > > amf: Replace writer_id option with LIBAV_AMF_WRITER_ID constant > > AMFTraceWriter is an abstraction to configure how AMF outputs its logs > for the current process and can be configured to output different levels > of trace output. If

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: replace writer_id option to LIBAV_AMF_WRITER_ID

2018-03-01 Thread Kravchenko, Alexander
nup: > replace writer_id option to LIBAV_AMF_WRITER_ID > > On Wed, Feb 28, 2018 at 06:33:05AM +, Kravchenko, Alexander wrote: > > If we use multiple LibavWriter objects in one process, we will have > duplication of output in avlib log. > > What is avl

[libav-devel] HA: [PATCH] AMF SDK integration code cleanup: replace writer_id option to LIBAV_AMF_WRITER_ID

2018-03-01 Thread Kravchenko, Alexander
> Do you mind if I switch your name to the "Alexander Kravchenko" standard > "first name then last name" order? of course, no problem This e-mail and any attachment(s) are intended only for the recipient(s) named above and others who have been specifically

[libav-devel] [PATCH] AMF SDK integration code cleanup: replace writer_id option to LIBAV_AMF_WRITER_ID

2018-02-27 Thread Kravchenko, Alexander
AMFTraceWriter is abstraction to configure how AMF outputs its logs for current process, not for component. Example instances of AMFTraceWriter can be * FileWriter * SocketWriter * DebugOutputWriter * LibavWriter (output using av_log function). AMFTraceWriter can be

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

2018-02-27 Thread Kravchenko, Alexander
iter_id option & move AMF_COMMON_OPTIONS out from > amfenc.h > > On 27/02/2018 14:59, Kravchenko, Alexander wrote:> If we use multiple > LibavWriter objects in one process, we will have > > duplication of output in avlib log. To prevent this scenario we > > should use one cons

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

2018-02-27 Thread Kravchenko, Alexander
> > Hi, I thought the library user would like to have a separate writer_id > since I assumed that the identifier is used for logging and resource > accounting purposes (e.g. browsers using this backend might want to use > a separate identifier per-tab). > > The common options pattern is used when

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

2018-02-27 Thread Kravchenko, Alexander
> -Original Message- > From: Kravchenko, Alexander > Sent: Tuesday, February 27, 2018 2:47 PM > To: libav development > Subject: RE: [libav-devel] [PATCH] AMF SDK integration code cleanup: > remove writer_id option & move AMF_COMMON_OPTIONS out from > amfenc.

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

2018-02-27 Thread Kravchenko, Alexander
following separated changes 1. Remove writer_id 2. move AMF_COMMON_OPTIONS out from amfenc.h > > On Tue, Feb 27, 2018 at 10:34:27AM +, Kravchenko, Alexander wrote: > > From 4d0efe3f5fd03db188f41d52ee9549a046939d1d Mon Sep 17 00:00:00 > 2001 > > From: diamond88 <mr.aleksa

[libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

2018-02-27 Thread Kravchenko, Alexander
From 4d0efe3f5fd03db188f41d52ee9549a046939d1d Mon Sep 17 00:00:00 2001 From: diamond88 Date: Tue, 27 Feb 2018 09:46:08 +0300 Subject: [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h ---

[libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

2018-02-27 Thread Kravchenko, Alexander
This e-mail and any attachment(s) are intended only for the recipient(s) named above and others who have been specifically authorized to receive them. They may contain confidential information. If you are not the intended recipient, please do not read this