Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-24 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Sat, Apr 23, 2011 at 04:29:36PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: The FreeBSD FATE box passes '-D__BSD_VISIBLE -D__XSI_VISIBLE=600' as extra CFLAGS to configure:

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-24 Thread Sean McGovern
Nevermind, apparently I didn't read down far enough and inet_pton() is in that same _BSD_VISIBLE #ifdef. -- Sean On 4/24/11, Sean McGovern gsean...@gmail.com wrote: 2011/4/24 Måns Rullgård m...@mansr.com Diego Biurrun di...@biurrun.de writes: On Sat, Apr 23, 2011 at 04:29:36PM +0100, Måns

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Martin Storsjö
On Fri, 22 Apr 2011, Måns Rullgård wrote: Martin Storsjö mar...@martin.st writes: On Fri, 22 Apr 2011, Måns Rullgård wrote: __BSD_VISIBLE should not be set directly, IIRC. _BSD_SOURCE is the correct symbol to define. This can be done with add_cppflags -D_BSD_SOURCE in the relevant

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Diego Biurrun
On Sat, Apr 23, 2011 at 01:04:49PM +0300, Martin Storsjö wrote: As far as I can see, there's nothing else you can define to make it work, except undefining _POSIX_C_SOURCE. Here's the relevant parts of sys/cdefs.h (http://gitweb.dragonflybsd.org/dragonfly.git/blob?f=sys/sys/cdefs.h):

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Måns Rullgård
Diego Biurrun di...@biurrun.de writes: On Sat, Apr 23, 2011 at 01:04:49PM +0300, Martin Storsjö wrote: As far as I can see, there's nothing else you can define to make it work, except undefining _POSIX_C_SOURCE. Here's the relevant parts of sys/cdefs.h

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Diego Biurrun
On Sat, Apr 23, 2011 at 04:29:36PM +0100, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: The FreeBSD FATE box passes '-D__BSD_VISIBLE -D__XSI_VISIBLE=600' as extra CFLAGS to configure: http://fate.libav.org/x86_32-freebsd-gcc-4.4/20110423101824 I think the DragonFlay

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Diego Biurrun
On Thu, Apr 21, 2011 at 06:30:57PM -0400, Ronald S. Bultje wrote: On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö mar...@martin.st wrote: Setting this should fix the FATE build failure on DragonFly BSD, since inet_aton only is visible if __BSD_VISIBLE is set. Alternatively, a line

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Måns Rullgård
Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö mar...@martin.st wrote: Setting this should fix the FATE build failure on DragonFly BSD, since inet_aton only is visible if __BSD_VISIBLE is set. Alternatively, a line defining __BSD_VISIBLE=1

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Martin Storsjö
On Fri, 22 Apr 2011, Måns Rullgård wrote: Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö mar...@martin.st wrote: Setting this should fix the FATE build failure on DragonFly BSD, since inet_aton only is visible if __BSD_VISIBLE is set.

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Måns Rullgård
Martin Storsjö mar...@martin.st writes: On Fri, 22 Apr 2011, Måns Rullgård wrote: Ronald S. Bultje rsbul...@gmail.com writes: Hi, On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö mar...@martin.st wrote: Setting this should fix the FATE build failure on DragonFly BSD, since inet_aton

[libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-21 Thread Martin Storsjö
Setting this should fix the FATE build failure on DragonFly BSD, since inet_aton only is visible if __BSD_VISIBLE is set. Alternatively, a line defining __BSD_VISIBLE=1 could be added at the top of os_support.c. For FreeBSD, similar lines are required in libavdevice/bktr.c and

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-21 Thread Ronald S. Bultje
Hi, On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö mar...@martin.st wrote: Setting this should fix the FATE build failure on DragonFly BSD, since inet_aton only is visible if __BSD_VISIBLE is set. Alternatively, a line defining __BSD_VISIBLE=1 could be added at the top of os_support.c. For