Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-23 Thread Martin Storsjö
On Fri, 22 Apr 2011, Alex Converse wrote: > On Fri, Apr 22, 2011 at 8:29 PM, Nathan Caldwell wrote: > > On Sun, Apr 10, 2011 at 11:47 PM, Alex Converse > > wrote: > >> 2011/4/6 Aℓex Converse : > >>> On Tue, Apr 5, 2011 at 4:41 PM, Nathan Caldwell > >>> wrote: > > Update attached. >

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-22 Thread Alex Converse
On Fri, Apr 22, 2011 at 8:29 PM, Nathan Caldwell wrote: > On Sun, Apr 10, 2011 at 11:47 PM, Alex Converse > wrote: >> 2011/4/6 Aℓex Converse : >>> On Tue, Apr 5, 2011 at 4:41 PM, Nathan Caldwell wrote: Update attached. >>> >>> This looks good at a 1 foot level. I expect to ha

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-22 Thread Nathan Caldwell
On Sun, Apr 10, 2011 at 11:47 PM, Alex Converse wrote: > 2011/4/6 Aℓex Converse : >> On Tue, Apr 5, 2011 at 4:41 PM, Nathan Caldwell wrote: >>> >>> Update attached. >>> >> >> This looks good at a 1 foot level. I expect to have some time to >> do a through review friday or this weekend. > > Th

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-10 Thread Alex Converse
2011/4/6 Aℓex Converse : > On Tue, Apr 5, 2011 at 4:41 PM, Nathan Caldwell wrote: >> >> Update attached. >> > > This looks good at a 1 foot level. I expect to have some time to > do a through review friday or this weekend. This chunk seems kind of funny to me: +minsnr = pow(2.0f,

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-06 Thread Aℓex Converse
On Tue, Apr 5, 2011 at 4:41 PM, Nathan Caldwell wrote: > > Update attached. > This looks good at a 1 foot level. I expect to have some time to do a through review friday or this weekend. ___ libav-devel mailing list libav-devel@libav.org https://lis

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Nathan Caldwell
On Tue, Apr 5, 2011 at 3:01 PM, Diego Biurrun wrote: > On Tue, Apr 05, 2011 at 03:30:10AM -0600, Nathan Caldwell wrote: >> >> --- a/libavcodec/aacpsy.c >> +++ b/libavcodec/aacpsy.c >> @@ -235,16 +287,33 @@ static av_cold int psy_3gpp_init(FFPsyContext *ctx) { >> +    const int chan_bitrate = ctx->

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Diego Biurrun
On Tue, Apr 05, 2011 at 03:30:10AM -0600, Nathan Caldwell wrote: > > --- a/libavcodec/aacpsy.c > +++ b/libavcodec/aacpsy.c > @@ -235,16 +287,33 @@ static av_cold int psy_3gpp_init(FFPsyContext *ctx) { > +const int chan_bitrate = ctx->avctx->bit_rate / ctx->avctx->channels; > +const int ban

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Nathan Caldwell
On Tue, Apr 5, 2011 at 11:52 AM, Alex Converse wrote: > On Tue, Apr 5, 2011 at 12:55 AM, Nathan Caldwell wrote: >> On Tue, Apr 5, 2011 at 1:44 AM, Kostya wrote: >>> On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: +    pctx->pe.min =  8192.0f;   /* FIXME: 0.8 * 10 * FRAME_LE

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Alex Converse
On Tue, Apr 5, 2011 at 12:55 AM, Nathan Caldwell wrote: > On Tue, Apr 5, 2011 at 1:44 AM, Kostya wrote: >> On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: >>> +    pctx->pe.min =  8192.0f;   /* FIXME: 0.8 * 10 * FRAME_LENGTH_LONG * >>> bandwidth / (sample_rate / 2) */ >>> +    p

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Kostya
On Tue, Apr 05, 2011 at 03:30:10AM -0600, Nathan Caldwell wrote: > On Tue, Apr 5, 2011 at 2:28 AM, Nathan Caldwell wrote: > > On Tue, Apr 5, 2011 at 2:08 AM, Kostya wrote: > >> On Tue, Apr 05, 2011 at 01:55:58AM -0600, Nathan Caldwell wrote: > >>> On Tue, Apr 5, 2011 at 1:44 AM, Kostya wrote: >

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Nathan Caldwell
On Tue, Apr 5, 2011 at 2:28 AM, Nathan Caldwell wrote: > On Tue, Apr 5, 2011 at 2:08 AM, Kostya wrote: >> On Tue, Apr 05, 2011 at 01:55:58AM -0600, Nathan Caldwell wrote: >>> On Tue, Apr 5, 2011 at 1:44 AM, Kostya wrote: >>> > On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: >>>

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Nathan Caldwell
On Tue, Apr 5, 2011 at 2:08 AM, Kostya wrote: > On Tue, Apr 05, 2011 at 01:55:58AM -0600, Nathan Caldwell wrote: >> On Tue, Apr 5, 2011 at 1:44 AM, Kostya wrote: >> > On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: >> >> +    pctx->pe.min =  8192.0f;   /* FIXME: 0.8 * 10 * FRAME_

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Kostya
On Tue, Apr 05, 2011 at 01:55:58AM -0600, Nathan Caldwell wrote: > On Tue, Apr 5, 2011 at 1:44 AM, Kostya wrote: > > On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: > >> +    pctx->pe.min =  8192.0f;   /* FIXME: 0.8 * 10 * FRAME_LENGTH_LONG * > >> bandwidth / (sample_rate / 2) */

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Nathan Caldwell
On Tue, Apr 5, 2011 at 1:44 AM, Kostya wrote: > On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: >> +    pctx->pe.min =  8192.0f;   /* FIXME: 0.8 * 10 * FRAME_LENGTH_LONG * >> bandwidth / (sample_rate / 2) */ >> +    pctx->pe.max = 12288.0f;   /* FIXME: 1.2 * 10 * FRAME_LENGTH_LON

Re: [libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Kostya
On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: > There is still are still a few sections missing relating to TNS (not present) > and mid/side (contains other bugs). > > Overall this improves quality, and vastly improves rate-control. > --- > libavcodec/aacenc.c |4 +- > liba

[libav-devel] [PATCH 2/3] aacenc: Finish 3GPP psymodel analysis for non mid/side cases.

2011-04-05 Thread Nathan Caldwell
There is still are still a few sections missing relating to TNS (not present) and mid/side (contains other bugs). Overall this improves quality, and vastly improves rate-control. --- libavcodec/aacenc.c |4 +- libavcodec/aacpsy.c | 295 ++- 2 f