Re: [libav-devel] [PATCH] configure: fix writing library dependencies to config.sh

2017-11-12 Thread Diego Biurrun
On Sun, Nov 12, 2017 at 10:56:57PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Gosh, what an embarassing mistake of mine. OK Diego ___

Re: [libav-devel] [PATCH] configure: Simplify restrict keyword handling

2017-11-12 Thread James Almer
On 11/10/2017 11:57 AM, Diego Biurrun wrote: > Skip a variable indirection and only redefine restrict if necessary. > --- > > Should still work on MSVC 2010 now as I don't kill the ugly workaround. > > configure | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

Re: [libav-devel] [PATCH 5/5] Drop some unnecessary config.h #includes

2017-11-12 Thread Vittorio Giovara
On Fri, Nov 3, 2017 at 12:43 PM, Diego Biurrun wrote: > --- > > Noticed while working on the previous patch, spun off into a separate > commit. > > Out of curiosity, how did you find these extra includes? Did you use some tool or did you manually check every file? Thanks --

[libav-devel] [PATCH] configure: fix writing library dependencies to config.sh

2017-11-12 Thread James Almer
Signed-off-by: James Almer --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1f220c8bef..e608d26608 100755 --- a/configure +++ b/configure @@ -5405,7 +5405,7 @@ EOF for lib in $LIBRARY_LIST; do

[libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

2017-11-12 Thread Zhong Li
CAVLC option is only available for h264 encoding. CABAC is the only entropy coding way for hevc. Signed-off-by: Zhong Li --- libavcodec/qsvenc.h | 3 +-- libavcodec/qsvenc_h264.c | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsvenc.h

[libav-devel] [PATCH 2/2] qsv/h264enc: fix cavlc option setting useless issue

2017-11-12 Thread Zhong Li
No matter cavlc option is set to 0 or 1, the output bitstream is always cabac mode. Reproduce: -y -s widthxheight -i widthxheight.yuv -vcodec h264_qsv -b:v 2000k -maxrate 2000k -cavlc 1 test.h264 Then check the entropy_coding_mode_flag of the encoded bitstream It is due to the dulicate option

Re: [libav-devel] [PATCH 5/5] Drop some unnecessary config.h #includes

2017-11-12 Thread James Almer
On 11/3/2017 1:43 PM, Diego Biurrun wrote: > --- > > Noticed while working on the previous patch, spun off into a separate commit. > > libavcodec/thread.h | 1 - > libavformat/tls.h| 4 ++-- > libavutil/aarch64/cpu.h | 1 - > libavutil/arm/cpu.h | 1 - >

Re: [libav-devel] [PATCH 07/14] cbs_mpeg2: Fix marker_bit type

2017-11-12 Thread Mark Thompson
On 10/11/17 12:29, Diego Biurrun wrote: > On Thu, Nov 09, 2017 at 01:07:49AM +, Mark Thompson wrote: >> --- a/libavcodec/cbs_mpeg2.c >> +++ b/libavcodec/cbs_mpeg2.c >> @@ -54,7 +54,7 @@ >> >> #define marker_bit() do { \ >> -av_unused int one = 1; \ >> +av_unused uint32_t

Re: [libav-devel] [PATCH 08/14] cbs_h2645: Fix memory leak on when reading SEI fails

2017-11-12 Thread Mark Thompson
On 10/11/17 12:31, Diego Biurrun wrote: > On Thu, Nov 09, 2017 at 01:07:50AM +, Mark Thompson wrote: >> --- a/libavcodec/cbs_h2645.c >> +++ b/libavcodec/cbs_h2645.c >> @@ -824,6 +824,7 @@ static int cbs_h264_read_nal_unit(CodedBitstreamContext >> *ctx, >> err =

Re: [libav-devel] [PATCH 05/14] cbs: Minor comment fixes / cosmetics

2017-11-12 Thread Mark Thompson
On 10/11/17 12:27, Diego Biurrun wrote: > On Thu, Nov 09, 2017 at 01:07:47AM +, Mark Thompson wrote: >> --- a/libavcodec/cbs.h >> +++ b/libavcodec/cbs.h >> @@ -25,6 +25,19 @@ >> >> +/* >> + * This defines a framework for converting between a coded bitstream >> + * and structures defining all