Re: [libav-devel] [PATCH 1/2] arm: Add X() around all references to extern symbols

2014-02-07 Thread Janne Grunau
On 2014-02-07 12:06:56 +0200, Martin Storsjö wrote: Don't rely on the fact that an unprefixed label currently exists. --- libavcodec/arm/fmtconvert_neon.S | 2 +- libavcodec/arm/h264idct_neon.S | 16 libavcodec/arm/hpeldsp_armv6.S | 4 ++--

Re: [libav-devel] [PATCH 2/2] arm: Add EXTERN_ASM to the .func and .type declarations for exported symbols

2014-02-07 Thread Janne Grunau
On 2014-02-07 12:06:57 +0200, Martin Storsjö wrote: This makes the generated assembly more internally consistent, avoiding declaring two labels for the same function (for cases where EXTERN_ASM is empty) and not declaring a separate unprefixed label in other cases. This also makes sure the

Re: [libav-devel] [PATCH] h264: report errors from decode_nal_units()

2014-02-07 Thread Janne Grunau
On 2014-02-07 11:51:18 +0100, Vittorio Giovara wrote: --- libavcodec/h264.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index da2d4a5..0cbe944 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@

Re: [libav-devel] [PATCH 1/2] arm: Add X() around all references to extern symbols

2014-02-07 Thread Janne Grunau
On 2014-02-07 14:03:59 +0200, Martin Storsjö wrote: On Fri, 7 Feb 2014, Janne Grunau wrote: On 2014-02-07 12:06:56 +0200, Martin Storsjö wrote: Don't rely on the fact that an unprefixed label currently exists. --- libavcodec/arm/fmtconvert_neon.S | 2 +- libavcodec/arm

Re: [libav-devel] [PATCH] Don't interpret the bic instruction as a conditional branch

2014-02-07 Thread Janne Grunau
On 2014-02-07 16:31:38 +0200, Martin Storsjö wrote: Do not instead of Don't in the commit msg --- This doesn't help much right now, but in a number of experimental branches I've added things in this clause, and I've had to hack around misidentifying bic as a branch in all of them. ---

Re: [libav-devel] [PATCH] Don't interpret the bic instruction as a conditional branch

2014-02-07 Thread Janne Grunau
On 2014-02-07 17:01:06 +0200, Martin Storsjö wrote: +if ($cond ne ic) { +if (exists $thumb_labels{$label}) { +print ASMFILE .thumb_func $label\n; +} else { +$call_targets{$label}++; +} } }

Re: [libav-devel] [PATCH 1/1] dcadec: silence 'extensions_mask may be used uninitialized' warning

2014-02-07 Thread Janne Grunau
On 2014-02-07 18:45:50 +0100, Diego Biurrun wrote: On Fri, Feb 07, 2014 at 06:39:38PM +0100, Janne Grunau wrote: --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -1587,7 +1587,12 @@ static int dca_exss_parse_asset_header(DCAContext *s) case 2: extensions_mask = DCA_EXT_EXSS_LBR

Re: [libav-devel] [PATCH 1/1] dcadec: silence 'extensions_mask may be used uninitialized' warning

2014-02-07 Thread Janne Grunau
On 2014-02-07 19:12:30 +0100, Diego Biurrun wrote: On Fri, Feb 07, 2014 at 06:01:01PM +, Janne Grunau wrote: On 2014-02-07 18:45:50 +0100, Diego Biurrun wrote: On Fri, Feb 07, 2014 at 06:39:38PM +0100, Janne Grunau wrote: --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c

[libav-devel] [PATCH 1/1] configure: clang: add -Qunused-arguments to as|ld_flags as well

2014-02-07 Thread Janne Grunau
--- configure | 12 1 file changed, 12 insertions(+) diff --git a/configure b/configure index 7a305c3..abee247 100755 --- a/configure +++ b/configure @@ -4208,6 +4208,18 @@ elif enabled_any msvc icl; then fi fi +case $ld_type in +clang) + check_ldflags

Re: [libav-devel] [PATCH 1/1] configure: clang: add -Qunused-arguments to as|ld_flags as well

2014-02-07 Thread Janne Grunau
On 2014-02-07 20:40:43 +0200, Martin Storsjö wrote: On Fri, 7 Feb 2014, Janne Grunau wrote: --- configure | 12 1 file changed, 12 insertions(+) diff --git a/configure b/configure index 7a305c3..abee247 100755 --- a/configure +++ b/configure @@ -4208,6 +4208,18 @@ elif

Re: [libav-devel] [PATCH] Check the matched conditions in regexps that match branches

2014-02-07 Thread Janne Grunau
On 2014-02-07 21:03:12 +0200, Martin Storsjö wrote: This avoids interpreting instructions such as e.g. bic as a branch with the condition 'ic'. --- Updated to check the condition against the list of conditions from ARM ARM. --- gas-preprocessor.pl | 15 ++- 1 file changed, 10

[libav-devel] [PATCH 1/1] configure: clang: add -Qunused-arguments to as|ld_flags as well

2014-02-07 Thread Janne Grunau
On 2014-02-07 21:00:03 +0100, Diego Biurrun wrote: On Fri, Feb 07, 2014 at 07:24:28PM +0100, Janne Grunau wrote: --- configure | 12 1 file changed, 12 insertions(+) Why? A little bit more explanation would be appreciated. --- a/configure +++ b/configure @@ -4208,6

[libav-devel] [PATCH 1/1] dcadec: silence 'extensions_mask may be used uninitialized' warning

2014-02-07 Thread Janne Grunau
--- libavcodec/dcadec.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c index 66eb03f..0624209 100644 --- a/libavcodec/dcadec.c +++ b/libavcodec/dcadec.c @@ -1587,7 +1587,12 @@ static int dca_exss_parse_asset_header(DCAContext

Re: [libav-devel] [PATCH 1/1] dcadsp: add int8x8_fmul_int32 to dsp context

2014-02-07 Thread Janne Grunau
On 2014-02-07 21:51:02 +0100, Christophe Gisquet wrote: From c233b96fa29150b0385776499e90afc9b59405b5 Mon Sep 17 00:00:00 2001 From: Christophe Gisquet christophe.gisq...@gmail.com Date: Fri, 11 May 2012 11:17:36 +0200 Subject: [PATCH 01/10] dcadsp: add int8x8_fmul_int32 to DSP context It

Re: [libav-devel] [PATCH 02/11] x86: dcadsp: implement int8x8_fmul_int32

2014-02-07 Thread Janne Grunau
On 2014-02-07 21:57:08 +0100, Christophe Gisquet wrote: From 87983deb56aa52c2cdcfbf248dd76bccb97d694a Mon Sep 17 00:00:00 2001 From: Christophe Gisquet christophe.gisq...@gmail.com Date: Fri, 11 May 2012 11:25:30 +0200 Subject: [PATCH 02/10] x86: dcadsp: implement int8x8_fmul_int32 For the

[libav-devel] [PATCH 1/1] dcadsp: add int8x8_fmul_int32 to dsp context

2014-02-06 Thread Janne Grunau
From: Christophe Gisquet christophe.gisq...@gmail.com On 2014-02-06 00:40:50 +, Christophe Gisquet wrote: It is currently declared as a macro who is set to inlinable functions, among which a Neon implementation. Add a DSP parameter to the macro, so that the implementation can either be

Re: [libav-devel] [PATCH 02/11] x86: dcadsp: implement int8x8_fmul_int32

2014-02-06 Thread Janne Grunau
On 2014-02-06 00:40:51 +, Christophe Gisquet wrote: For the callable function (as opposed to the inline one): C SSE SSE2 SSE4 Win32: 47 42 2926 Win64: 30 33 2523 The SSE version is neither compiled nor set for 64bits. That are cpu cycles? When the proper

Re: [libav-devel] [PATCH 03/11] dcadsp: split lfe_dir cases

2014-02-06 Thread Janne Grunau
On 2014-02-06 00:40:52 +, Christophe Gisquet wrote: The x86 runs short on registers because numerous elements are not static. In addition, splitting them allows more optimized code, at least for x86. Can you expand on what gets better optimized if decifactor is constant? I don't see

Re: [libav-devel] [PATCH 02/11] x86: dcadsp: implement int8x8_fmul_int32

2014-02-06 Thread Janne Grunau
On 2014-02-06 16:08:29 +0100, Christophe Gisquet wrote: 2014-02-06 Janne Grunau janne-li...@jannau.net: On 2014-02-06 00:40:51 +, Christophe Gisquet wrote: Yes, as long as this header is included before dcadsp.h. This will be rewritten anyway, following your proposal. just because

Re: [libav-devel] [PATCH 03/11] dcadsp: split lfe_dir cases

2014-02-06 Thread Janne Grunau
On 2014-02-06 17:27:17 +0100, Christophe Gisquet wrote: Hi, 2014-02-06 Janne Grunau janne-li...@jannau.net: On 2014-02-06 00:40:52 +, Christophe Gisquet wrote: The x86 runs short on registers because numerous elements are not static. In addition, splitting them allows more optimized

Re: [libav-devel] [PATCH 02/11] x86: dcadsp: implement int8x8_fmul_int32

2014-02-06 Thread Janne Grunau
On 2014-02-06 16:21:49 +0100, Diego Biurrun wrote: On Thu, Feb 06, 2014 at 12:40:51AM +, Christophe Gisquet wrote: --- /dev/null +++ b/libavcodec/x86/dca.h @@ -0,0 +1,56 @@ +/* + * Copyright (c) 2012 Christophe Gisquet christophe.gisq...@gmail.com Happy new year? +#if

Re: [libav-devel] [PATCH 08/11] dcadsp: split synth_filter_float

2014-02-06 Thread Janne Grunau
On 2014-02-06 11:01:19 +0100, Christophe Gisquet wrote: 2014-02-06 Christophe Gisquet christophe.gisq...@gmail.com: The goal is to avoid function calls within assembly which are a mess on x86. This patch should ideally be squashed with the previous but: - this is mostly an RFC; - this

Re: [libav-devel] [PATCH] vp8: fix PPC assembly and bilinear C code to work if src_stride != dst_stride.

2014-02-06 Thread Janne Grunau
On 2014-02-06 12:36:03 +0100, Luca Barbato wrote: On 06/02/14 12:21, Martin Storsjö wrote: Can we push the plain C half of this commit first without waiting for refactoring the PPC stuff? Fine for me. pushed the libavcodec//vp8dsp.c part Janne

Re: [libav-devel] [PATCH] avplay: add support for seeking to chapter marks

2014-02-06 Thread Janne Grunau
On 2014-02-06 23:30:22 +0100, Tim Walker wrote: On 04 Feb 2014, at 22:34, Anton Khirnov an...@khirnov.net wrote: --- This patch is dedicated to av500's tshirt --- avplay.c| 33 + doc/avplay.texi |3 +++ 2 files changed, 36 insertions(+)

Re: [libav-devel] [PATCH] h264: give numbers to nalus

2014-02-06 Thread Janne Grunau
On 2014-02-07 00:28:32 +0100, Vittorio Giovara wrote: --- Mostly cosmetics, but quite useful when you don't have specs arounds. and are too lazy to count ;) purely cosmetic and ok Janne ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] vp8: use 2 registers for dst_stride and src_stride in neon bilin filter.

2014-02-05 Thread Janne Grunau
On 2014-02-05 12:18:34 +0200, Martin Storsjö wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/arm/vp8dsp_neon.S | 165 +++ 1 file changed, 87 insertions(+), 78 deletions(-) ok in the sense that the code does the right thing

[libav-devel] [PATCH 1/1] lavu: add missing log.h include in timer.h

2014-02-05 Thread Janne Grunau
--- libavutil/timer.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/timer.h b/libavutil/timer.h index ea5c891..d2c5001 100644 --- a/libavutil/timer.h +++ b/libavutil/timer.h @@ -32,6 +32,8 @@ #include config.h +#include log.h + #if ARCH_ARM # include arm/timer.h

Re: [libav-devel] [PATCH] vp8: Use 2 registers for dst_stride and src_stride in neon bilin filter.

2014-02-05 Thread Janne Grunau
On 2014-02-05 14:49:04 +0200, Martin Storsjö wrote: Based on a patch by Ronald S. Bultje. --- Updated as suggested by Janne, to not require pushing anything to the stack. --- libavcodec/arm/vp8dsp_neon.S | 120 +-- 1 file changed, 60 insertions(+),

Re: [libav-devel] [PATCH] vp8: Use 2 registers for dst_stride and src_stride in neon bilin filter.

2014-02-05 Thread Janne Grunau
On 2014-02-05 15:00:57 +0100, Christophe Gisquet wrote: Hi, 2014-02-05 Martin Storsjö mar...@martin.st: Based on a patch by Ronald S. Bultje. --- Updated as suggested by Janne, to not require pushing anything to the stack. That's not really an issue worthy of additional work, but

Re: [libav-devel] [PATCH] [RFC] avformat: include additional framerates

2014-02-04 Thread Janne Grunau
On 2014-02-04 12:06:00 +0100, Vittorio Giovara wrote: --- 48 is the high framerate used in cinema, 25 and 50 are European framerate. Not sure it's worth to add 100 and 120 high framerates too. Vittorio libavformat/avformat.h |2 +- libavformat/utils.c|3 ++-

[libav-devel] [PATCH 1/1] fate: force the simple idct for xvid custom matrix test

2014-02-04 Thread Janne Grunau
On 2014-02-04 22:54:51 +0100, Diego Biurrun wrote: On Fri, Jan 31, 2014 at 01:09:39PM +0100, Janne Grunau wrote: fixes fate-xvid-custom-matrix on non-x86 architectures, suggestions how to avoid the ugly $(FATE_XVID-yes-yes) are welcome. --- a/tests/fate/xvid.mak +++ b/tests/fate/xvid.mak

[libav-devel] [PATCH 1/1] x86: videodsp: Small speedups in ff_emulated_edge_mc x86 SIMD.

2014-01-31 Thread Janne Grunau
From: Ronald S. Bultje rsbul...@gmail.com On 2014-01-30 16:58:26 +0100, Diego Biurrun wrote: On Thu, Jan 30, 2014 at 03:43:32PM +0100, Janne Grunau wrote: --- a/libavcodec/x86/videodsp.asm +++ b/libavcodec/x86/videodsp.asm @@ -344,10 +344,6 @@ VERTICAL_EXTEND 16, 22 movzx

[libav-devel] [RFC] fate: force the simple idct for xvid custom matrix test

2014-01-31 Thread Janne Grunau
fixes fate-xvid-custom-matrix on non-x86 architectures, suggestions how to avoid the ugly $(FATE_XVID-yes-yes) are welcome. Janne ---8--- Run the original test only when MMX is available. --- tests/fate/xvid.mak | 9 ++--- tests/ref/fate/xvid-custom-matrix | 40

[libav-devel] [PATCH 1/3] x86: videodsp: Properly mark sse2 instructions in emulated_edge_mc as such.

2014-01-30 Thread Janne Grunau
From: Ronald S. Bultje rsbul...@gmail.com Should fix crashes or corrupt output on pre-SSE2 CPUs when they were using SSE2-code (e.g. AMD Athlon XP 2400+ or Intel Pentium III) in hfix or hvar single-edge (left/right) extension functions. Signed-off-by: Janne Grunau janne-li...@jannau.net

[libav-devel] [PATCH 3/3] x86: videodsp: Small speedups in ff_emulated_edge_mc x86 SIMD.

2014-01-30 Thread Janne Grunau
From: Ronald S. Bultje rsbul...@gmail.com Do not use word-size multiplications if size == 2, and if we're using SIMD instructions (size = 8), complete leftover 4byte sets using movd, not mov. Both of these changes lead to minor speedups. Signed-off-by: Janne Grunau janne-li...@jannau.net

[libav-devel] [PATCH 2/3] x86: videodsp: Fix a bug in a %if statement where we used '%%' instead of ''.

2014-01-30 Thread Janne Grunau
From: Ronald S. Bultje rsbul...@gmail.com Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec/x86/videodsp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/videodsp.asm b/libavcodec/x86/videodsp.asm index aceb77a..53b9e82 100644

[libav-devel] VideoDSP X86 asms

2014-01-30 Thread Janne Grunau
Hi, videodsp uses SSE2 instructions in SSE code which results in crashes on machines not support SSE2 but SSE like AMD's Athlon and theoretically Pentium3. Patch 1 fixes the issue at hand (squashed from two patches). Patch 2+3 are small changes which brings us up to date wrt to videodsp.asm.

[libav-devel] [PATCH 1/2] movdec: report 180 degree rotation as metadata

2014-01-29 Thread Janne Grunau
From: Dave Badia dba...@gmail.com Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index dc5b42b..5b444ab 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2253,6

[libav-devel] [PATCH 2/2] movdec: report 90 and 270 degrees clockwise rotation too

2014-01-29 Thread Janne Grunau
From: Piotr Tomasik pi...@tomasik.co Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavformat/mov.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 5b444ab..333995e 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c

[libav-devel] [PATCH 1/1] movdec: report 180 degree rotation as metadata

2014-01-29 Thread Janne Grunau
From: Dave Badia dba...@gmail.com stupid me, forgot to rebase for av_dict_set Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index dc5b42b..8b661e9 100644 --- a/libavformat

[libav-devel] [PATCH 1/1] lavf: include 60 fps in guessed standard frame rates

2014-01-29 Thread Janne Grunau
Due to what looks like an off-by-one error 60 * 12 * 1001 / 12 * 1001 is not tested as standard frame rate in avformat_find_stream_info(). --- libavformat/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index

Re: [libav-devel] [PATCH] mpeg: Drop unused parameters from ff_draw_horiz_band()

2014-01-29 Thread Janne Grunau
On 2014-01-29 14:14:46 +0100, Diego Biurrun wrote: --- libavcodec/mpegvideo.c | 10 -- libavcodec/mpegvideo.h | 7 +++ libavcodec/svq3.c | 5 +++-- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index

Re: [libav-devel] [PATCH] avformat: utils: Refactor duplicated PRINT macro

2014-01-29 Thread Janne Grunau
On 2014-01-29 17:05:43 +0100, Diego Biurrun wrote: --- Now with the improved name suggested by Janne. libavformat/utils.c | 54 ++- 1 file changed, 23 insertions(+), 31 deletions(-) diff --git a/libavformat/utils.c

[libav-devel] [PATCH 1/2] xvid: switch to xvid mmx idct as soon as possible

2014-01-29 Thread Janne Grunau
The idct implementation cannot be changed after the quantization matrices are read since it use a different permutaion. Fixes https://trac.videolan.org/vlc/ticket/7411 --- libavcodec/mpeg4videodec.c | 58 +++--- 1 file changed, 29 insertions(+), 29

[libav-devel] [PATCH 2/2] fate: add xvid test for custom matrices

2014-01-29 Thread Janne Grunau
Test sample is made from the sample in https://trac.videolan.org/vlc/ticket/7411 --- tests/Makefile| 1 + tests/fate/xvid.mak | 6 ++ tests/ref/fate/xvid-custom-matrix | 21 + 3 files changed, 28 insertions(+) create mode 100644

Re: [libav-devel] [PATCH 1/2] xvid: switch to xvid mmx idct as soon as possible

2014-01-29 Thread Janne Grunau
On 2014-01-29 18:46:43 +0100, Luca Barbato wrote: On 29/01/14 18:39, Janne Grunau wrote: The idct implementation cannot be changed after the quantization matrices are read since it use a different permutaion. Fixes https://trac.videolan.org/vlc/ticket/7411 --- libavcodec

Re: [libav-devel] [PATCH 1/1] configure: add missing x86 dependency for i686

2014-01-26 Thread Janne Grunau
On 2014-01-26 16:02:44 +0100, Diego Biurrun wrote: On Sat, Jan 25, 2014 at 04:56:34PM +0100, Janne Grunau wrote: --- a/configure +++ b/configure @@ -1561,6 +1561,7 @@ x86_64_suggest=fast_cmov amd3dnow_deps=mmx amd3dnowext_deps=amd3dnow +i686_deps=x86 mmx_deps=x86

Re: [libav-devel] [PATCH 1/1] mpeg12: check scantable indeces in all decode_block functions

2014-01-26 Thread Janne Grunau
On 2014-01-25 22:36:31 +0100, Luca Barbato wrote: On 25/01/14 21:06, Luca Barbato wrote: On 24/01/14 17:20, Janne Grunau wrote: Adds checks to the fast functions used with CODEC_FLAGS2_FAST and moves the check for all other functions to before the invalid memory is accessed. Fixes https

[libav-devel] [PATCH 1/1] configure: add missing x86 dependency for i686

2014-01-25 Thread Janne Grunau
--- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 98ac566..b7ff79c 100755 --- a/configure +++ b/configure @@ -1561,6 +1561,7 @@ x86_64_suggest=fast_cmov amd3dnow_deps=mmx amd3dnowext_deps=amd3dnow +i686_deps=x86 mmx_deps=x86 mmxext_deps=mmx

[libav-devel] [PATCH 1/1] configure: clang: explicitly state dep file and rule name in DEPFLAGS

2014-01-25 Thread Janne Grunau
Fixes dependency file generation with gas-preprocessor.pl and clang. Flags copied from GCC and tested with Apple's clang from Xcode 5 and 5.1 and clang 3.2, 3.3, 3.4 on Linux. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

[libav-devel] [PATCH 1/1] mpeg12: check scantable index in fast_decode_block_non_intra()

2014-01-24 Thread Janne Grunau
Fixes https://trac.videolan.org/vlc/ticket/9713 with CODEC_FLAGS2_FAST. --- libavcodec/mpeg12dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 49b7d1e..0c2ef8a 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@

[libav-devel] [PATCH 1/1] mpeg12: check scantable indeces in all decode_block functions

2014-01-24 Thread Janne Grunau
Hi, On 2014-01-24 16:26:32 +0100, Luca Barbato wrote: On 24/01/14 16:24, Janne Grunau wrote: Fixes https://trac.videolan.org/vlc/ticket/9713 with CODEC_FLAGS2_FAST. --- libavcodec/mpeg12dec.c | 5 + 1 file changed, 5 insertions(+) if that 64-1 has a name you might use

Re: [libav-devel] [PATCH 1/1] mpeg12: check scantable indeces in all decode_block functions

2014-01-24 Thread Janne Grunau
On 2014-01-24 17:41:46 +0100, Diego Biurrun wrote: indexes not indices? On Fri, Jan 24, 2014 at 05:20:18PM +0100, Janne Grunau wrote: Adds checks to the fast functions used with CODEC_FLAGS2_FAST and moves Add, move changed locally Janne

[libav-devel] [PATCH 1/1] avutil: remove timer.h include from internal.h

2014-01-23 Thread Janne Grunau
Added libavutil/timer.h include to all files with {START,STOP}_TIMER. --- libavcodec/dnxhddec.c | 1 + libavcodec/dnxhdenc.c | 1 + libavcodec/ffv1dec.c | 1 + libavcodec/h264.c | 1 + libavcodec/h264_cabac.c| 1 + libavcodec/ivi_common.c| 1 +

Re: [libav-devel] [PATCH 2/2] avformat: utils: Refactor duplicated PRINT macro

2014-01-23 Thread Janne Grunau
On 2014-01-16 03:55:45 +0100, Diego Biurrun wrote: --- libavformat/utils.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 4fee6ec..74d1e69 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c

[libav-devel] [PATCH 1/1] arm: rewrite .func directive as .thumb_func for thumb

2014-01-22 Thread Janne Grunau
On 2014-01-22 09:54:17 +0200, Martin Storsjö wrote: On Wed, 22 Jan 2014, Janne Grunau wrote: Makes sure all local function symbols are declared as .thumb_func even if they are not directly called. fft4|65536_neon in libavcodec/arm/fft_neon.S are only accessed through saved offset

Re: [libav-devel] [RFC] Merge libavdevice into libavformat.

2014-01-22 Thread Janne Grunau
On 2014-01-22 10:56:27 +0100, Luca Barbato wrote: The only marginal problem is having loads of external libraries pulled in and that might or might not annoying certain people. We don't pull most external libraries automatically in. only sdl, zlib and bzlib and maybe something I missed.

Re: [libav-devel] [PATCH 1/2] avformat: utils: KR formatting cosmetics

2014-01-22 Thread Janne Grunau
On 2014-01-17 15:00:50 +0100, Diego Biurrun wrote: On Fri, Jan 17, 2014 at 02:00:06PM +0100, Janne Grunau wrote: On 2014-01-16 03:55:44 +0100, Diego Biurrun wrote: --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -218,8 +219,10 @@ static int set_codec_from_probe_data

Re: [libav-devel] [PATCH] configure: Add missing deps for the mpegvideoenc component

2014-01-22 Thread Janne Grunau
On 2014-01-22 16:59:55 +0200, Martin Storsjö wrote: mpegvideo_enc.c unconditionally calls ff_h263dsp_init, therefore mpegvideoenc should depend on h263dsp. This fixes builds with e.g. --disable-decoders --disable-encoders --enable-encoder=mjpeg. --- configure | 2 +- 1 file changed, 1

Re: [libav-devel] [PATCH] mpegvideo_enc: Don't call ff_h263dsp_init unconditionally

2014-01-22 Thread Janne Grunau
On 2014-01-22 17:50:18 +0200, Martin Storsjö wrote: This fixes builds with e.g. --disable-decoders --disable-encoders --enable-encoder=mjpeg. --- libavcodec/mpegvideo_enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c

Re: [libav-devel] [PATCH 1/1] arm: declare functions called from data table as .thumb_func

2014-01-21 Thread Janne Grunau
On 2014-01-21 09:35:19 +0200, Martin Storsjö wrote: On Mon, 20 Jan 2014, Janne Grunau wrote: Handles fft4_neon and fft65536_neon from libavcodec/arm/fft_neon.S correctly which are only called through pc-relative offsets. Fixes i?mdct-4 fate tests on iOS with thumb. Signed-off

[libav-devel] [PATCH 1/1] arm: rewrite .func directive as .thumb_func for thumb

2014-01-21 Thread Janne Grunau
Makes sure all local function symbols are declared as .thumb_func even if they are not directly called. fft4|65536_neon in libavcodec/arm/fft_neon.S are only accessed through saved offset in a table for example. Fixes fate-mdct-4 tests in libav on iOS. --- gas-preprocessor.pl | 17

Re: [libav-devel] [PATCH] h264: reset data partitioning at the beginning of each decode call

2014-01-20 Thread Janne Grunau
On 2014-01-19 19:49:02 +0100, Anton Khirnov wrote: Prevents using GetBitContexts with data from previous calls. Fixes access to freed memory. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC:libav-sta...@libav.org --- libavcodec/h264.c | 11 ++- 1 file changed, 10

Re: [libav-devel] [libav-commits] lavc: deprecate CODEC_FLAG_EMU_EDGE and avcodec_get_edge_width().

2014-01-20 Thread Janne Grunau
On 2014-01-20 16:08:57 +0200, Martin Storsjö wrote: On Mon, 20 Jan 2014, Anton Khirnov wrote: Module: libav Branch: master Commit: 93c553c71ef48550ff7c2aa7b5712a7e01f1999f Author:Anton Khirnov an...@khirnov.net Committer: Anton Khirnov an...@khirnov.net Date: Thu Jan 2

[libav-devel] [PATCH 1/1] h264: skip chroma edges at the picture boundary while deblocking 4:4:4

2014-01-20 Thread Janne Grunau
This handles macroblock edges for the chroma components in the same way as for the luma compoment for 4:4:4 streams. The Spec explicitly states that the deblocking filter is not applied to edges at the boundary of the picture. Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec

Re: [libav-devel] [PATCH] lavc: do not force the emu edge flag

2014-01-20 Thread Janne Grunau
On 2014-01-20 15:27:46 +0100, Anton Khirnov wrote: The default get_buffer2() implementation (and possibly some user ones) does not allocate edges when this flag is set, which may expose bugs in some decoders. Until the 10 release is out, it is safer to remove this part. ---

Re: [libav-devel] [PATCH] lavc: do not force the emu edge flag

2014-01-20 Thread Janne Grunau
On 2014-01-20 18:50:26 +0100, Anton Khirnov wrote: On Mon, 20 Jan 2014 18:35:00 +0100, Janne Grunau janne-li...@jannau.net wrote: On 2014-01-20 15:27:46 +0100, Anton Khirnov wrote: The default get_buffer2() implementation (and possibly some user ones) does not allocate edges when

[libav-devel] [PATCH 1/1] arm: declare functions called from data table as .thumb_func

2014-01-20 Thread Janne Grunau
Handles fft4_neon and fft65536_neon from libavcodec/arm/fft_neon.S correctly which are only called through pc-relative offsets. Fixes i?mdct-4 fate tests on iOS with thumb. Signed-off-by: Janne Grunau janne-li...@jannau.net --- gas-preprocessor.pl | 6 ++ 1 file changed, 6 insertions

Re: [libav-devel] [PATCH] h264: reset data partitioning at the beginning of each decode call

2014-01-19 Thread Janne Grunau
On 2014-01-18 21:04:04 +0100, Anton Khirnov wrote: Prevents using GetBitContexts with data from previous calls. Fixes access to freed memory. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC:libav-sta...@libav.org --- libavcodec/h264.c | 10 ++ 1 file changed, 10

Re: [libav-devel] [PATCH 1/2] avformat: utils: KR formatting cosmetics

2014-01-17 Thread Janne Grunau
On 2014-01-16 03:55:44 +0100, Diego Biurrun wrote: Also adjust some comment wording and spelling. --- libavformat/utils.c | 1666 +++ 1 file changed, 899 insertions(+), 767 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c

Re: [libav-devel] [PATCH 2/9] aarch64: add cpuflags support for NEON and VFP

2014-01-15 Thread Janne Grunau
On 2014-01-15 10:14:11 +0200, Martin Storsjö wrote: On Wed, 15 Jan 2014, Janne Grunau wrote: diff --git a/libavutil/aarch64/cpu.h b/libavutil/aarch64/cpu.h new file mode 100644 index 000..78320f3 --- /dev/null +++ b/libavutil/aarch64/cpu.h @@ -0,0 +1,35 @@ + + [license

[libav-devel] [PATCH 1/1] dct-test: test ff_simple_idct_neon only on ARM for now

2014-01-15 Thread Janne Grunau
On 2014-01-15 10:11:04 +0200, Martin Storsj?? wrote: On Wed, 15 Jan 2014, Janne Grunau wrote: Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec/dct-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dct-test.c b/libavcodec/dct-test.c

[libav-devel] [PATCH 1/1] lavf: include 60 fps in guessed standard frame rates

2014-01-15 Thread Janne Grunau
Due to what looks like an off-by-one error 60 * 12 * 1001 / 12 * 1001 is not tested as standard frame rate in avformat_find_stream_info(). --- libavformat/utils.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index

Re: [libav-devel] [PATCH 4/9] h264: prevent two matching fields from being both a short/long ref combination

2014-01-15 Thread Janne Grunau
On 2014-01-06 08:36:37 +0100, Anton Khirnov wrote: Fixes possible access to freed memory. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC:libav-sta...@libav.org --- libavcodec/h264_refs.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/h264_refs.c

Re: [libav-devel] [PATCH 2/9] h264: limit allowed pred modes in ff_h264_check_intra_pred_mode() to 3

2014-01-15 Thread Janne Grunau
On 2014-01-06 08:36:35 +0100, Anton Khirnov wrote: Higher modes are not allowed for 16x16/chroma, which is what this function is used for. Otherwise this function would return 0 (vertical prediction) for invalid higher modes, which could result in invalid reads. Found-by: Mateusz j00ru

Re: [libav-devel] [PATCH 9/9] h264: reset data partitioning at the beginning of each decode call

2014-01-15 Thread Janne Grunau
On 2014-01-06 08:36:42 +0100, Anton Khirnov wrote: Prevents using GetBitContexts with data from previous calls. Fixes access to freed memory. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC:libav-sta...@libav.org --- libavcodec/h264.c |3 +++ 1 file changed, 3 insertions(+)

Re: [libav-devel] [PATCH 8/9] h264: make sure both fields are always marked as finished

2014-01-15 Thread Janne Grunau
On 2014-01-06 08:36:41 +0100, Anton Khirnov wrote: Fixes deadlocks. Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind CC:libav-sta...@libav.org --- libavcodec/h264.c |8 1 file changed, 8 insertions(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index

Re: [libav-devel] [PATCH 10/16] mpegvideo: allocate edges when encoding.

2014-01-15 Thread Janne Grunau
On 2014-01-09 09:38:10 +0100, Anton Khirnov wrote: On Fri, 3 Jan 2014 15:54:34 +0100, Janne Grunau janne-li...@jannau.net wrote: On 2014-01-03 15:07:44 +0100, Anton Khirnov wrote: Allocating edges will be removed from generic code, so the encoder must handle this explicitly

Re: [libav-devel] [PATCH 1/2] avconv: print a warning when falling back to a default framerate

2014-01-15 Thread Janne Grunau
On 2014-01-15 21:37:09 +0100, Anton Khirnov wrote: --- avconv.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/avconv.c b/avconv.c index 17dc468..edce1e5 100644 --- a/avconv.c +++ b/avconv.c @@ -1691,10 +1691,19 @@ static int transcode_init(void)

Re: [libav-devel] [PATCH 2/2] yuv4mpeg: set average frame rate

2014-01-15 Thread Janne Grunau
On 2014-01-15 21:37:10 +0100, Anton Khirnov wrote: --- libavformat/yuv4mpeg.c |1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/yuv4mpeg.c b/libavformat/yuv4mpeg.c index cc2755f..f793a0e 100644 --- a/libavformat/yuv4mpeg.c +++ b/libavformat/yuv4mpeg.c @@ -361,6 +361,7 @@

[libav-devel] [PATCH 2/4] aarch64: append optional left shift to certain movi variants

2014-01-14 Thread Janne Grunau
Xcode 5 and 5.1 complain over the missing shift although it's optional according to the reference manual. --- gas-preprocessor.pl | 4 1 file changed, 4 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 48cd6c0..a0287a2 100755 --- a/gas-preprocessor.pl +++

[libav-devel] [PATCH 3/4] aarch64: replace alias uxtl with ushll

2014-01-14 Thread Janne Grunau
Clang from Xcode 5 does not support uxtl. --- gas-preprocessor.pl | 4 1 file changed, 4 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index a0287a2..cdce3fa 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -629,6 +629,10 @@ sub handle_serialized_line {

[libav-devel] gas-preprocessor patches to fix aarch64 shortcomings in Xcode 5 and Xcode 5.1beta3

2014-01-14 Thread Janne Grunau
Hi, since we decided to fix shortcomings in Xcode's aarch64 assembler in gas-preprocessor following patches are necessary to build my aarch64 tree. bsl and saddl are in Xcode 5 only supported in a non-standard assembler syntax. Changing those instructions requires the env variable

[libav-devel] [PATCH 4/4] aarch64: fix bsl|saddl2? for Xcode5

2014-01-14 Thread Janne Grunau
Clang from Xcode5 supports bsl/saddl2? only in an unofficial assembler syntax. To avoid breakage with later versions or different assembler gas-preprocessor.pl checkss for the enviroment variable GASPP_FIX_XCODE5 before changing these instructions to the non-standard syntax. ---

[libav-devel] [PATCH 1/4] aarch64: replace alias vector mov with orr

2014-01-14 Thread Janne Grunau
Xcode 5 and 5.1 both do not support the alias. --- gas-preprocessor.pl | 5 + 1 file changed, 5 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 2edf2ef..48cd6c0 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -620,6 +620,11 @@ sub

[libav-devel] [PATCH 1/1] cabac: remove leftovers from the cabac encoder

2014-01-14 Thread Janne Grunau
The cabac encoder was only used by the removed cabac test. Signed-off-by: Janne Grunau janne-li...@jannau.net --- libavcodec/cabac.c | 13 - libavcodec/cabac.h | 3 --- 2 files changed, 16 deletions(-) diff --git a/libavcodec/cabac.c b/libavcodec/cabac.c index e1cd811..b6f56f0

Re: [libav-devel] [PATCH 4/4] aarch64: fix bsl|saddl2? for Xcode5

2014-01-14 Thread Janne Grunau
On 2014-01-14 17:01:18 +0100, Luca Barbato wrote: On 14/01/14 16:29, Janne Grunau wrote: Clang from Xcode5 supports bsl/saddl2? only in an unofficial assembler syntax. To avoid breakage with later versions or different assembler gas-preprocessor.pl checkss for the enviroment variable

Re: [libav-devel] [PATCH 12/20] mxfdec: Fix potential leak in mxf_read_local_tags()

2014-01-14 Thread Janne Grunau
On 2014-01-08 03:25:43 +0100, Luca Barbato wrote: From: Tomas Härdin tomas.har...@codemill.se Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavformat/mxfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 8c0c018..8fa2a89

Re: [libav-devel] [PATCH 16/20] mxfdec: Add uncompressed 422 8-bit rawvideo label

2014-01-14 Thread Janne Grunau
On 2014-01-08 03:25:47 +0100, Luca Barbato wrote: From: Philip de Nier phil...@rd.bbc.co.uk --- libavformat/mxf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index e51106f..37a09fd 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@

Re: [libav-devel] [PATCH 17/20] mxfdec: Add DNxHD UL

2014-01-14 Thread Janne Grunau
On 2014-01-08 03:25:48 +0100, Luca Barbato wrote: From: Tomas Härdin tomas.har...@codemill.se Note that the old DNxHD UL is actually JPEG 2000 according to RP224. Leaving it as-is for now. --- libavformat/mxf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mxf.c

Re: [libav-devel] [PATCH 14/20] mxfdec: Avoid double free and leaks

2014-01-14 Thread Janne Grunau
On 2014-01-08 03:25:45 +0100, Luca Barbato wrote: From: Michael Niedermayer michae...@gmx.at Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavformat/mxfdec.c | 110 ++- 1 file

Re: [libav-devel] [PATCH 19/20] mxfdec: Fix double free

2014-01-14 Thread Janne Grunau
On 2014-01-08 03:25:50 +0100, Luca Barbato wrote: From: Michael Niedermayer michae...@gmx.at Found-by: Mateusz j00ru Jurczyk and Gynvael Coldwind Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavformat/mxfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [libav-devel] [PATCH 2/3] build: Add separate hidden config option for the intrax8 code

2014-01-14 Thread Janne Grunau
On 2014-01-14 18:24:02 +0100, Diego Biurrun wrote: This allows for slightly cleaner dependency specification. --- configure | 5 +++-- libavcodec/Makefile | 7 +++ 2 files changed, 6 insertions(+), 6 deletions(-) ok Janne ___

Re: [libav-devel] [PATCH 3/3] x86: dsputil: Simplify xvmc deprecation conditional

2014-01-14 Thread Janne Grunau
On 2014-01-14 18:24:03 +0100, Diego Biurrun wrote: --- libavcodec/x86/dsputil_init.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/x86/dsputil_init.c b/libavcodec/x86/dsputil_init.c index c339e8f..82864e8 100644 ---

Re: [libav-devel] [PATCH 1/4] aarch64: replace alias vector mov with orr

2014-01-14 Thread Janne Grunau
On 2014-01-14 19:35:34 +0200, Martin Storsjö wrote: On Tue, 14 Jan 2014, Janne Grunau wrote: Xcode 5 and 5.1 both do not support the alias. --- gas-preprocessor.pl | 5 + 1 file changed, 5 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 2edf2ef

Re: [libav-devel] [PATCH 2/4] aarch64: append optional left shift to certain movi variants

2014-01-14 Thread Janne Grunau
On 2014-01-14 19:41:48 +0200, Martin Storsjö wrote: On Tue, 14 Jan 2014, Janne Grunau wrote: Xcode 5 and 5.1 complain over the missing shift although it's optional according to the reference manual. --- gas-preprocessor.pl | 4 1 file changed, 4 insertions(+) diff --git a/gas

Re: [libav-devel] [PATCH 4/4] aarch64: fix bsl|saddl2? for Xcode5

2014-01-14 Thread Janne Grunau
On 2014-01-14 19:45:40 +0200, Martin Storsjö wrote: On Tue, 14 Jan 2014, Janne Grunau wrote: Clang from Xcode5 supports bsl/saddl2? only in an unofficial assembler syntax. To avoid breakage with later versions or different assembler gas-preprocessor.pl checkss for the enviroment variable

[libav-devel] [PATCH 2/4] aarch64: append optional left shift to certain movi variants

2014-01-14 Thread Janne Grunau
Xcode 5 and 5.1 complain over the missing shift although it's optional according to the reference manual. --- gas-preprocessor.pl | 4 1 file changed, 4 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index f88c266..ed01141 100755 --- a/gas-preprocessor.pl +++

[libav-devel] [PATCH 1/4] aarch64: replace alias vector mov with orr

2014-01-14 Thread Janne Grunau
Xcode 5 and 5.1 both do not support the alias. --- gas-preprocessor.pl | 5 + 1 file changed, 5 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 2edf2ef..f88c266 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -620,6 +620,11 @@ sub

[libav-devel] [PATCH 4/4] aarch64: fix bsl|saddl2? for Xcode5

2014-01-14 Thread Janne Grunau
Clang from Xcode5 supports bsl/saddl2? only in an unofficial assembler syntax. To avoid breakage with later versions or different assembler gas-preprocessor.pl checks for the environment variable GASPP_FIX_XCODE5 before changing these instructions to the non-standard syntax. ---

<    5   6   7   8   9   10   11   12   13   14   >