Re: [libav-devel] [PATCH 2/2] configure: Restructure the way check_pkg_config() operates

2017-02-21 Thread Luca Barbato
On 16/02/2017 17:42, Diego Biurrun wrote: > Have check_pkg_config() enable variables and set cflags and extralibs > instead of relegating that task to require_pkg_config. This simplifies > require_pkg_config(), is consistent with what other helper functions > like check_lib() do and allows getting

Re: [libav-devel] [PATCH] nvenc: add default QP value options for I, P and B pictures.

2017-02-21 Thread Luca Barbato
On 21/02/2017 10:19, Konda Raju wrote: > I'd use i_quant_factor and b_quant_factor as fallback. The logic should be: if the specific options are set, use them, otherwise use the global options, otherwise use the default. lu ___ libav-devel mailing

[libav-devel] [PATCH] nvenc: add default QP value options for I, P and B pictures.

2017-02-21 Thread Konda Raju
--- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the

Re: [libav-devel] [PATCH 5/5] build: Move cli tool sources to a separate subdirectory

2017-02-21 Thread Luca Barbato
On 16/02/2017 10:16, Diego Biurrun wrote: > This unclutters the top-level directory and groups related files together. > --- > > Cleaner and simpler now that the logic is separate from the examples. > Not against it, maybe it is easier to rebase it on top of Mark's changes though.

Re: [libav-devel] [PATCH 02/24] hwcontext: Add function to find an AVHWDeviceType by name

2017-02-21 Thread Mark Thompson
On 21/02/17 07:35, wm4 wrote: > On Mon, 20 Feb 2017 22:03:50 + > Mark Thompson wrote: > >> On 20/02/17 05:42, wm4 wrote: >>> On Sun, 19 Feb 2017 18:46:24 + >>> Mark Thompson wrote: >>> --- libavutil/hwcontext.c | 11 +++

Re: [libav-devel] [PATCH 2/5] build: Avoid duplication in examples lists

2017-02-21 Thread Luca Barbato
On 16/02/2017 10:16, Diego Biurrun wrote: > --- > doc/Makefile | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/doc/Makefile b/doc/Makefile > index bd5c2e4..365ac5d 100644 > --- a/doc/Makefile > +++ b/doc/Makefile > @@ -25,16 +25,9 @@

Re: [libav-devel] [PATCH 18/24] lavu: OpenCL hwcontext implementation

2017-02-21 Thread wm4
On Tue, 21 Feb 2017 13:18:55 + Mark Thompson wrote: > On 21/02/17 08:00, wm4 wrote: > > On Mon, 20 Feb 2017 23:06:21 + > > Mark Thompson wrote: > > > +#ifdef CL_ABGR > +if (0) > >>> > >>> wut > >> > >> CL_ABGR didn't exist in

Re: [libav-devel] [PATCH] nvenc: add default QP value options for I, P and B pictures.

2017-02-21 Thread Diego Biurrun
On Tue, Feb 21, 2017 at 09:19:06AM +, Konda Raju wrote: > From caa77fa0cecd9371fba3da72b338880d5e67fff6 Mon Sep 17 00:00:00 2001 > From: rajukonda This looks like a Subversion user name or something, please configure your Git with your full name. Diego

Re: [libav-devel] [PATCH] nvenc: add default QP value options for I, P and B pictures.

2017-02-21 Thread Konda Raju
Yes, it will fall back to previous logic if the options are not set. -Original Message- From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca Barbato Sent: Tuesday, February 21, 2017 6:17 PM To: libav-devel@libav.org Subject: Re: [libav-devel] [PATCH] nvenc: add

Re: [libav-devel] [PATCH 1/5] build: Drop leftover reference to old EXAMPLES logic

2017-02-21 Thread Diego Biurrun
On Thu, Feb 16, 2017 at 10:16:05AM +0100, Diego Biurrun wrote: > --- > > Noticed one more stray EXAMPLES reference. > > Makefile | 2 +- > doc/Makefile | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) ping the set Diego ___ libav-devel

Re: [libav-devel] [PATCH 1/5] build: Drop leftover reference to old EXAMPLES logic

2017-02-21 Thread Luca Barbato
On 16/02/2017 10:16, Diego Biurrun wrote: > --- > > Noticed one more stray EXAMPLES reference. > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] nvenc: add default QP value options for I, P and B pictures.

2017-02-21 Thread Luca Barbato
On 21/02/2017 10:19, Konda Raju wrote: > Now that I'm looking at the current code in master, looks like the patch does not apply. Could you please rebase it? lu ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 5/5] build: Move cli tool sources to a separate subdirectory

2017-02-21 Thread Diego Biurrun
On Tue, Feb 21, 2017 at 02:52:01PM +0100, Luca Barbato wrote: > On 16/02/2017 10:16, Diego Biurrun wrote: > > This unclutters the top-level directory and groups related files together. > > --- > > > > Cleaner and simpler now that the logic is separate from the examples. > > Not against it, maybe

[libav-devel] [PATCH] movenc: factor initial_padding into edit lists

2017-02-21 Thread John Stebbins
initial_padding was getting added to the edit list indirectly due to initial negative dts. But in cases where the audio is delayed, all or part of initial_padding would be unaccounted for. This patch makes initial_padding explicit. --- libavformat/movenc.c | 58

Re: [libav-devel] [PATCH 5/5] build: Move cli tool sources to a separate subdirectory

2017-02-21 Thread Luca Barbato
On 21/02/2017 14:55, Diego Biurrun wrote: > On Tue, Feb 21, 2017 at 02:52:01PM +0100, Luca Barbato wrote: >> On 16/02/2017 10:16, Diego Biurrun wrote: >>> This unclutters the top-level directory and groups related files together. >>> --- >>> >>> Cleaner and simpler now that the logic is separate

Re: [libav-devel] [PATCH 20/24] hwcontext_opencl: QSV to OpenCL mapping for Intel Media SDK

2017-02-21 Thread wm4
On Tue, 21 Feb 2017 13:36:39 + Mark Thompson wrote: > Ok: > HAVE_BEIGNET_OPENCL_VAAPI > HAVE_INTEL_MEDIA_OPENCL_VAAPI > HAVE_OPENCL_DXVA2 > > (There could also be: > HAVE_OPENCL_D3D11VA (another standard extension) > HAVE_OPENCL_CUDA (not standard, but only Nvidia

Re: [libav-devel] [PATCH 01/24] hwcontext: Add device derivation

2017-02-21 Thread Mark Thompson
On 21/02/17 07:28, wm4 wrote: > On Mon, 20 Feb 2017 21:54:03 + > Mark Thompson wrote: > >> On 20/02/17 05:37, wm4 wrote: >>> On Sun, 19 Feb 2017 18:46:23 + >>> Mark Thompson wrote: >>> Creates a new device context from another of a different type

Re: [libav-devel] [PATCH 4/5] build: Separate logic for building examples from that for building avtools

2017-02-21 Thread Luca Barbato
On 16/02/2017 10:16, Diego Biurrun wrote: > --- > Makefile | 2 +- > doc/examples/Makefile | 5 + > 2 files changed, 6 insertions(+), 1 deletion(-) > Possibly ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 3/5] build: Split logic for building examples off into a separate Makefile

2017-02-21 Thread Luca Barbato
On 16/02/2017 10:16, Diego Biurrun wrote: > --- > Makefile | 4 ++-- > doc/Makefile | 23 ++- > doc/examples/Makefile | 26 ++ > 3 files changed, 30 insertions(+), 23 deletions(-) > create mode 100644 doc/examples/Makefile >

Re: [libav-devel] [PATCH] fate: Update fate-lavf-mkv after commit 5d3953a5dc

2017-02-21 Thread Luca Barbato
On 22/02/2017 00:48, John Stebbins wrote: > --- > tests/ref/lavf/mkv | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ref/lavf/mkv b/tests/ref/lavf/mkv > index db0aba0..04c5f3c 100644 > --- a/tests/ref/lavf/mkv > +++ b/tests/ref/lavf/mkv > @@ -1,3 +1,3 @@ >

Re: [libav-devel] [PATCH 18/24] lavu: OpenCL hwcontext implementation

2017-02-21 Thread Luca Barbato
On 21/02/2017 23:43, Mark Thompson wrote: > On 21/02/17 14:21, wm4 wrote: >> On Tue, 21 Feb 2017 13:18:55 + >> Mark Thompson wrote: >> >>> On 21/02/17 08:00, wm4 wrote: On Mon, 20 Feb 2017 23:06:21 + Mark Thompson wrote: >>> +#ifdef

Re: [libav-devel] [PATCH] fate: Update fate-lavf-mkv after commit 5d3953a5dc

2017-02-21 Thread wm4
On Wed, 22 Feb 2017 02:59:33 +0100 Luca Barbato wrote: > On 22/02/2017 00:48, John Stebbins wrote: > > --- > > tests/ref/lavf/mkv | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tests/ref/lavf/mkv b/tests/ref/lavf/mkv > > index

Re: [libav-devel] [PATCH 18/24] lavu: OpenCL hwcontext implementation

2017-02-21 Thread wm4
On Tue, 21 Feb 2017 22:43:05 + Mark Thompson wrote: > On 21/02/17 14:21, wm4 wrote: > > On Tue, 21 Feb 2017 13:18:55 + > > Mark Thompson wrote: > > > >> On 21/02/17 08:00, wm4 wrote: > >>> On Mon, 20 Feb 2017 23:06:21 + > >>> Mark Thompson

Re: [libav-devel] [PATCH] movenc: factor initial_padding into edit lists

2017-02-21 Thread John Stebbins
On 02/21/2017 02:54 PM, Martin Storsjö wrote: > On Tue, 21 Feb 2017, John Stebbins wrote: > >> initial_padding was getting added to the edit list indirectly due to >> initial negative dts. But in cases where the audio is delayed, >> all or part of initial_padding would be unaccounted for. This

[libav-devel] [PATCH] fate: Update fate-lavf-mkv after commit 5d3953a5dc

2017-02-21 Thread John Stebbins
--- tests/ref/lavf/mkv | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ref/lavf/mkv b/tests/ref/lavf/mkv index db0aba0..04c5f3c 100644 --- a/tests/ref/lavf/mkv +++ b/tests/ref/lavf/mkv @@ -1,3 +1,3 @@ -76d400179dfd6143f50ea4d19fe8ed99 *./tests/data/lavf/lavf.mkv

[libav-devel] [PATCH 1/3] Revert "configure: Add proper weak dependency of drawtext filter on libfontconfig"

2017-02-21 Thread Diego Biurrun
External dependencies cannot be handled as weak dependencies since they need to be explicitly enabled. If a weak dependency is set, the variable corresponding to the weak dependency can be enabled without the rest of the build system settings, resulting in a failing build. This reverts commit

[libav-devel] [PATCH 3/3] build: Fine-grained link-time dependency settings

2017-02-21 Thread Diego Biurrun
Previously, all link-time dependencies were added for all libraries, resulting in bogus link-time dependencies since not all dependencies are shared across libraries. Also, in some cases like libavutil, not all dependencies were taken into account, resulting in some cases of underlinking. To

[libav-devel] [PATCH 2/3] configure: Simplify dlopen check

2017-02-21 Thread Diego Biurrun
--- This was previously approved. configure | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/configure b/configure index 6f1be32..ef6a8e0 100755 --- a/configure +++ b/configure @@ -1608,7 +1608,6 @@ SYSTEM_FUNCS=" CommandLineToArgvW

Re: [libav-devel] [PATCH 2/3] movenc: Don't write any edit list if the start offset is zero

2017-02-21 Thread Yusuke Nakamura
2017-02-20 6:22 GMT+09:00 Martin Storsjö : > In these cases, the CTTS flag is set, but no edit list is necessary. > --- > libavformat/movenc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index

Re: [libav-devel] [PATCH 3/3] build: Fine-grained link-time dependency settings

2017-02-21 Thread Luca Barbato
On 21/02/2017 18:26, Diego Biurrun wrote: > all: $(AVPROGS) alltools checkheaders examples testprogs What? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 18/24] lavu: OpenCL hwcontext implementation

2017-02-21 Thread wm4
On Mon, 20 Feb 2017 23:06:21 + Mark Thompson wrote: > >> +#ifdef CL_ABGR > >> +if (0) > > > > wut > > CL_ABGR didn't exist in OpenCL 1.2, which is really the target. It's present > in later versions, though, so it's included here if possible for symmetry. I

Re: [libav-devel] [PATCH 19/24] hwcontext_opencl: VAAPI to/from OpenCL mapping for Intel i965+beignet

2017-02-21 Thread wm4
On Mon, 20 Feb 2017 23:12:27 + Mark Thompson wrote: > >> +switch (src_fc->sw_format) { > >> +case AV_PIX_FMT_YUV420P: va_fourcc = VA_FOURCC_IYUV; break; > >> +case AV_PIX_FMT_NV12:va_fourcc = VA_FOURCC_NV12; break; > >> +case AV_PIX_FMT_P010:va_fourcc

Re: [libav-devel] [PATCH 20/24] hwcontext_opencl: QSV to OpenCL mapping for Intel Media SDK

2017-02-21 Thread wm4
On Mon, 20 Feb 2017 23:29:20 + Mark Thompson wrote: > On 20/02/17 06:52, wm4 wrote: > > On Sun, 19 Feb 2017 18:46:42 + > > Mark Thompson wrote: > > > >> Uses the cl_intel_va_api_media_sharing extension, which supports only > >> NV12 surfaces and only

[libav-devel] [PATCHv3 2/3] mov: Export bounds and padding from spherical metadata

2017-02-21 Thread Vittorio Giovara
Update the fate test as needed. Signed-off-by: Vittorio Giovara --- libavformat/mov.c| 28 +++- tests/fate/mov.mak | 2 +- tests/ref/fate/mov-spherical | 6 +- 3 files changed, 33 insertions(+), 3 deletions(-) diff

[libav-devel] [PATCHv3 1/3] spherical: Add tiled equirectangular type and projection-specific properties

2017-02-21 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- This leaves bounds unchanged, simplifying future muxing code. Add a convenience function where human-readable values are needed. Update mov and mkv in subsequent patches. Vittorio avtools/avprobe.c | 18 ++---

Re: [libav-devel] [PATCH 18/24] lavu: OpenCL hwcontext implementation

2017-02-21 Thread Mark Thompson
On 21/02/17 14:21, wm4 wrote: > On Tue, 21 Feb 2017 13:18:55 + > Mark Thompson wrote: > >> On 21/02/17 08:00, wm4 wrote: >>> On Mon, 20 Feb 2017 23:06:21 + >>> Mark Thompson wrote: >>> >> +#ifdef CL_ABGR >> +if (0) > > wut

Re: [libav-devel] [PATCH] movenc: factor initial_padding into edit lists

2017-02-21 Thread Martin Storsjö
On Mon, 20 Feb 2017, John Stebbins wrote: On 02/20/2017 03:27 PM, Martin Storsjö wrote: I'd appreciate if you could add a few cases in that test (libavformat/tests/movenc.c) to validate all the different corner cases that this code touches. This test writes synthetic test data in different

[libav-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-02-21 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- libavformat/matroskadec.c | 60 +-- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 3dd54eb..adcb553 100644 ---

Re: [libav-devel] [PATCH] movenc: factor initial_padding into edit lists

2017-02-21 Thread Martin Storsjö
On Tue, 21 Feb 2017, John Stebbins wrote: initial_padding was getting added to the edit list indirectly due to initial negative dts. But in cases where the audio is delayed, all or part of initial_padding would be unaccounted for. This patch makes initial_padding explicit. ---

Re: [libav-devel] [PATCH 2/3] movenc: Don't write any edit list if the start offset is zero

2017-02-21 Thread Martin Storsjö
Hi Yusuke, On Wed, 22 Feb 2017, Yusuke Nakamura wrote: 2017-02-20 6:22 GMT+09:00 Martin Storsjö : In these cases, the CTTS flag is set, but no edit list is necessary. --- libavformat/movenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [libav-devel] [PATCH 20/24] hwcontext_opencl: QSV to OpenCL mapping for Intel Media SDK

2017-02-21 Thread Mark Thompson
On 21/02/17 08:14, wm4 wrote: > On Mon, 20 Feb 2017 23:29:20 + > Mark Thompson wrote: > >> On 20/02/17 06:52, wm4 wrote: >>> On Sun, 19 Feb 2017 18:46:42 + >>> Mark Thompson wrote: >>> Uses the cl_intel_va_api_media_sharing extension, which