[libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-21 Thread Alexandra Hájková
--- Applied all Henrik's and Diego's review comments: fixed stride, and size sizes, consistent naming tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 85 +++

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-14 Thread Henrik Gramner
On Fri, Oct 14, 2016 at 10:29 AM, Luca Barbato wrote: > The term checkasm is misleading. The whole thing is a unit-test for some > specific dsp functions. Not really, no. The checkasm tests only tests whether or not the output of the assembly functions matches the output of the C function. It doe

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-14 Thread Luca Barbato
On 14/10/2016 01:06, Diego Biurrun wrote: > Also, 12-bit, 14-bit, and 16-bit SIMD also does not exist, why not > start testing it as well right now? After all, the code might appear > in the future... The term checkasm is misleading. The whole thing is a unit-test for some specific dsp functions.

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-13 Thread Diego Biurrun
On Thu, Oct 13, 2016 at 10:14:54PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-10-13 22:09:03) > > On Thu, Oct 13, 2016 at 09:53:47PM +0300, Martin Storsjö wrote: > > > On Thu, 13 Oct 2016, Diego Biurrun wrote: > > > > > > >On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-13 Thread Anton Khirnov
Quoting Diego Biurrun (2016-10-13 22:09:03) > On Thu, Oct 13, 2016 at 09:53:47PM +0300, Martin Storsjö wrote: > > On Thu, 13 Oct 2016, Diego Biurrun wrote: > > > > >On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková wrote: > > > > > +void checkasm_check_hevc_add_res(void) > > +{

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-13 Thread Diego Biurrun
On Thu, Oct 13, 2016 at 09:53:47PM +0300, Martin Storsjö wrote: > On Thu, 13 Oct 2016, Diego Biurrun wrote: > > >On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková wrote: > > > +void checkasm_check_hevc_add_res(void) > +{ > +int bit_depth; > + > +for (bit_

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-13 Thread Martin Storsjö
On Thu, 13 Oct 2016, Diego Biurrun wrote: On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková wrote: >> +void checkasm_check_hevc_add_res(void) >> +{ >> +int bit_depth; >> + >> +for (bit_depth = 8; bit_depth <= 10; bit_depth++) { >> +HEVCDSPContext h; >> + >> +f

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-13 Thread Diego Biurrun
On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková wrote: > >> +#define randomize_buffers(buf, size)\ > >> +do {\ > >> +int j; \ > >> +for (j = 0; j < size; j++) {\ > >> +

[libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-13 Thread Alexandra Hájková
--- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 tests/checkasm/hevc_add_res.c

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-13 Thread Luca Barbato
On 13/10/2016 13:57, Alexandra Hájková wrote: > Because there's no 9 bit SIMD function, it's not tested but the code > looks simpler this way. And looks like there isn't much 9bit content out to warrant spending time on it right now =) lu ___ libav-deve

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-13 Thread Alexandra Hájková
>> +#define randomize_buffers(buf, size)\ >> +do {\ >> +int j; \ >> +for (j = 0; j < size; j++) {\ >> +int16_t r = rnd(); \ >> +AV_WN16A(buf

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-12 Thread Martin Storsjö
On Thu, 13 Oct 2016, Diego Biurrun wrote: On Wed, Oct 12, 2016 at 06:24:40PM +0200, Alexandra Hájková wrote: --- /dev/null +++ b/tests/checkasm/hevc_add_res.c @@ -0,0 +1,84 @@ + +#define randomize_buffers(buf, size)\ +do {\ +int j;

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-12 Thread Diego Biurrun
On Wed, Oct 12, 2016 at 06:24:40PM +0200, Alexandra Hájková wrote: > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -92,6 +92,7 @@ static const struct { > #if CONFIG_HEVC_DECODER > { "hevc_mc", checkasm_check_hevc_mc }, > { "hevc_idct", checkasm_check_hevc_idct },

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-12 Thread Martin Storsjö
On Wed, 12 Oct 2016, Martin Storsjö wrote: On Wed, 12 Oct 2016, Alexandra Hájková wrote: --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-12 Thread Martin Storsjö
On Wed, 12 Oct 2016, Alexandra Hájková wrote: --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files changed, 87 insertions(+), 1 deletion(-) create

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-12 Thread Luca Barbato
On 12/10/2016 18:24, Alexandra Hájková wrote: > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkasm/checkasm.h | 1 + > tests/checkasm/hevc_add_res.c | 84 > +++ > 4 files changed, 87 insertions(+), 1 d

[libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-12 Thread Alexandra Hájková
--- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 tests/checkasm/hevc_add_res.c