Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-09-02 Thread Ivana Varekova
- Original Message - > From: "Libo Chen" > To: "Dhaval Giani" > Cc: "Ivana Hutarova Varekova" , "Wengmeiling" > , "Libcg Development > list" , "Li Zefan" , > "Huang Qiang" > Sent: Wednesd

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-27 Thread Libo Chen
On 2013/8/27 21:12, Dhaval Giani wrote: > Hi Libo, > >>> $ ls -y >>> ls: illegal option -- y >>> usage: ls [-ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1] [file ...] >>> >>> I would like something like this. >> >> >> yes, it is the bash style. But this patch follows libcg style, this is >> important too

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-27 Thread Dhaval Giani
Hi Libo, >> $ ls -y >> ls: illegal option -- y >> usage: ls [-ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1] [file ...] >> >> I would like something like this. > > > yes, it is the bash style. But this patch follows libcg style, this is > important too? > I am not sure I understand the comment. Why can'

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-26 Thread Libo Chen
On 2013/8/15 1:34, Dhaval Giani wrote: > On Wed, Aug 14, 2013 at 3:18 AM, Libo Chen > wrote: >> On 2013/8/14 11:24, Dhaval Giani wrote: >>> Hi! >>> >>> On Tue, Aug 13, 2013 at 10:39 PM, Libo Chen >>> wrote: On 2013/8/14 4:37, Dhaval Giani wrote: > On Tue, Aug 6, 2013 at 3:15 AM, Libo C

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-26 Thread Dhaval Giani
Hi, On Mon, Aug 26, 2013 at 10:23 PM, Libo Chen wrote: > On 2013/8/6 15:15, Libo Chen wrote: > > > > Hi Ivana, > > what do you think about this patch ? Could you please address my comments? Thanks, Dhaval -- In

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-26 Thread Libo Chen
On 2013/8/6 15:15, Libo Chen wrote: Hi Ivana, what do you think about this patch ? > > we should check invalite parameter, and then print a warning > > Signed-off-by: Libo Chen > --- > src/tools/cgconfig.c | 10 +- > 1 files changed, 9 insertions(+), 1 deletions(-) > > di

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-14 Thread Dhaval Giani
On Wed, Aug 14, 2013 at 3:18 AM, Libo Chen wrote: > On 2013/8/14 11:24, Dhaval Giani wrote: >> Hi! >> >> On Tue, Aug 13, 2013 at 10:39 PM, Libo Chen >> wrote: >>> On 2013/8/14 4:37, Dhaval Giani wrote: On Tue, Aug 6, 2013 at 3:15 AM, Libo Chen wrote: > > we should check inval

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-14 Thread Libo Chen
On 2013/8/14 11:24, Dhaval Giani wrote: > Hi! > > On Tue, Aug 13, 2013 at 10:39 PM, Libo Chen > wrote: >> On 2013/8/14 4:37, Dhaval Giani wrote: >>> On Tue, Aug 6, 2013 at 3:15 AM, Libo Chen >>> wrote: we should check invalite parameter, and then print a warning Signed-off-

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-13 Thread Dhaval Giani
Hi! On Tue, Aug 13, 2013 at 10:39 PM, Libo Chen wrote: > On 2013/8/14 4:37, Dhaval Giani wrote: >> On Tue, Aug 6, 2013 at 3:15 AM, Libo Chen >> wrote: >>> >>> we should check invalite parameter, and then print a warning >>> >>> Signed-off-by: Libo Chen >> >> I'm not sure this extra warning is

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-13 Thread Libo Chen
On 2013/8/14 4:37, Dhaval Giani wrote: > On Tue, Aug 6, 2013 at 3:15 AM, Libo Chen wrote: >> >> we should check invalite parameter, and then print a warning >> >> Signed-off-by: Libo Chen > > I'm not sure this extra warning is needed. In most unix software, if > you use an invalid argument, the

Re: [Libcg-devel] [PATCH] cgconfig: add parameter check

2013-08-13 Thread Dhaval Giani
On Tue, Aug 6, 2013 at 3:15 AM, Libo Chen wrote: > > we should check invalite parameter, and then print a warning > > Signed-off-by: Libo Chen I'm not sure this extra warning is needed. In most unix software, if you use an invalid argument, the help is printed, which is exactly what happens here