Re: [Libguestfs] [libnbd PATCH v5 02/12] rust: Add a couple of integration tests

2023-08-16 Thread Tage Johansson
On 8/16/2023 11:35 PM, Eric Blake wrote: On Thu, Aug 03, 2023 at 03:36:06PM +, Tage Johansson wrote: A couple of integration tests are added in rust/tests. They are mostly ported from the OCaml tests. --- Overall, this looked like a nice counterpart to the OCaml unit tests, and I was

Re: [Libguestfs] [libnbd PATCH v7 0/9] Rust Bindings for Libnbd

2023-08-16 Thread Tage Johansson
On 8/16/2023 9:11 PM, Eric Blake wrote: On Thu, Aug 10, 2023 at 11:24:27AM +, Tage Johansson wrote: This is the 7th version of the Rust bindings for Libnbd. It is more or less identical to the 6th version without the already merged patches. Best regards, Tage I still hope to do more

Re: [Libguestfs] [libnbd PATCH v7 3/9] generator: Add information about the lifetime of closures

2023-08-16 Thread Eric Blake
On Thu, Aug 10, 2023 at 11:24:30AM +, Tage Johansson wrote: > Add two new fields, cblifetime and cbcount, to the `closure` type > in generator/API.ml*. cblifetime tells if the closure may only be used > for as long as the command is in flight or if the closure may be used > until the handle is

Re: [Libguestfs] [libnbd PATCH v5 02/12] rust: Add a couple of integration tests

2023-08-16 Thread Eric Blake
On Thu, Aug 03, 2023 at 03:36:06PM +, Tage Johansson wrote: > A couple of integration tests are added in rust/tests. They are mostly > ported from the OCaml tests. > --- Overall, this looked like a nice counterpart to the OCaml unit tests, and I was able to easily figure out how to amend my

Re: [Libguestfs] [libnbd PATCH v7 0/9] Rust Bindings for Libnbd

2023-08-16 Thread Eric Blake
On Thu, Aug 10, 2023 at 11:24:27AM +, Tage Johansson wrote: > This is the 7th version of the Rust bindings for Libnbd. It is more or > less identical to the 6th version without the already merged patches. > > Best regards, > Tage > I still hope to do more review of both merged patches and

Re: [Libguestfs] [libnbd PATCH] ci: Update lcitool to request cargo during CI

2023-08-16 Thread Eric Blake
On Wed, Aug 16, 2023 at 11:56:52AM +0100, Richard W.M. Jones wrote: > > It's interesting that awk is required. I've been attempting to keep > nbdkit from requiring awk (but we do require sed). > > In config.log I see: > > $ grep -i awk config.log > configure:5226: checking for gawk >

Re: [Libguestfs] [libnbd PATCH] ci: Update lcitool to request cargo during CI

2023-08-16 Thread Richard W.M. Jones
It's interesting that awk is required. I've been attempting to keep nbdkit from requiring awk (but we do require sed). In config.log I see: $ grep -i awk config.log configure:5226: checking for gawk configure:5247: found /usr/bin/gawk configure:5258: result: gawk ac_cv_prog_AWK=gawk