Re: [Libmesh-devel] Fun with -Wall

2008-07-08 Thread Roy Stogner
On Tue, 8 Jul 2008, John Peterson wrote: > On Tue, Jul 8, 2008 at 5:34 PM, Kirk, Benjamin (JSC-EG) > <[EMAIL PROTECTED]> wrote: >> Agreed. We gotta draw the line somewhere... Can you imagine how far down >> the rabbit hole we would go if to avoid const_cast we changed the underlying >> c librar

Re: [Libmesh-devel] Fun with -Wall

2008-07-08 Thread John Peterson
On Tue, Jul 8, 2008 at 5:34 PM, Kirk, Benjamin (JSC-EG) <[EMAIL PROTECTED]> wrote: > Agreed. We gotta draw the line somewhere... Can you imagine how far down > the rabbit hole we would go if to avoid const_cast we changed the underlying > c libraries? OK, so I'd say the "nays" have it. It's als

Re: [Libmesh-devel] Fun with -Wall

2008-07-08 Thread Kirk, Benjamin (JSC-EG)
2008 Subject: Re: [Libmesh-devel] Fun with -Wall On Tue, 8 Jul 2008, John Peterson wrote: > On a related note, the contributed packages were also built with > -Wall, which, between laspack, metis, parmetis, netcdf, and exodusII > resulted in around 2000 lines of warnings. I guess we could t

Re: [Libmesh-devel] Fun with -Wall

2008-07-08 Thread Roy Stogner
On Tue, 8 Jul 2008, John Peterson wrote: > On a related note, the contributed packages were also built with > -Wall, which, between laspack, metis, parmetis, netcdf, and exodusII > resulted in around 2000 lines of warnings. I guess we could try to > fix these (most of them are your garden variet

[Libmesh-devel] Fun with -Wall

2008-07-08 Thread John Peterson
Hi all, Due to interestingly configured mpicxx/mpicc scripts, I recently compiled the entire library in optimized mode with -Wall (by default, libmesh does not use -Wall in optimized mode). There were a lot of warnings about unused variables arising from the fact that we have a lot of code like