[Libreoffice-commits] .: sw/inc sw/source

2012-03-02 Thread Tor Lillqvist
sw/inc/shellio.hxx |3 - sw/source/filter/writer/writer.cxx | 82 + sw/source/filter/ww8/wrtww8.cxx|8 +-- 3 files changed, 27 insertions(+), 66 deletions(-) New commits: commit ad9960ffeb25f31ce4b1f819f909f1eb9ad6d7dd Author:

[Libreoffice-commits] Changes to 'feature/stub_writer'

2012-03-02 Thread Markus Mohrhard
New branch 'feature/stub_writer' available with the following commits: commit fa38d91786a5ec9504cf310748eda364c2427f88 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Mar 2 09:33:10 2012 +0100 some more work on stubbing SwDoc it compiles and links but executing

[Libreoffice-commits] .: 3 commits - sd/source sw/source unusedcode.easy

2012-03-02 Thread Caolán McNamara
sd/source/ui/dlg/copydlg.cxx |5 ++--- sd/source/ui/inc/copydlg.hxx |2 +- sw/source/filter/writer/writer.cxx |2 +- unusedcode.easy|6 +- 4 files changed, 9 insertions(+), 6 deletions(-) New commits: commit

[Libreoffice-commits] .: binfilter/bf_svtools binfilter/inc

2012-03-02 Thread Caolán McNamara
binfilter/bf_svtools/source/memtools/tl_unqidx.cxx | 20 binfilter/inc/bf_tools/unqidx.hxx |1 - 2 files changed, 21 deletions(-) New commits: commit 359bd679b9cc9849e9336c6b6fc289e900a18fdf Author: Caolán McNamara caol...@redhat.com Date: Fri Mar 2

[Libreoffice-commits] .: config_host.mk.in configure.in lcms2/makefile.mk lcms2/prj Makefile ooo.lst.in RepositoryExternal.mk

2012-03-02 Thread Fridrich Strba
Makefile |1 RepositoryExternal.mk | 27 + config_host.mk.in |1 configure.in | 22 +++ lcms2/makefile.mk | 97 ++ lcms2/prj/build.lst |3 + lcms2/prj/d.lst | 10 +

[Libreoffice-commits] .: sc/source

2012-03-02 Thread Markus Mohrhard
sc/source/core/data/table3.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 73e9eac0e86e4ab5dec09dfde890eca8760d298a Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Mar 2 10:20:27 2012 +0100 add missing loop conditions diff --git

[Libreoffice-commits] .: l10ntools/scripts Makefile RepositoryModule_ooo.mk solenv/gbuild solenv/inc

2012-03-02 Thread Matus Kukan
Makefile |2 +- RepositoryModule_ooo.mk |3 ++- l10ntools/scripts/po2lo |2 +- solenv/gbuild/AllLangResTarget.mk |5 ++--- solenv/gbuild/Configuration.mk|5 ++--- solenv/gbuild/Extension.mk|7 +++

[Libreoffice-commits] .: 2 commits - sd/source

2012-03-02 Thread Tor Lillqvist
sd/source/filter/eppt/pptexanimations.cxx |6 +- sd/source/filter/eppt/pptx-epptooxml.cxx |6 +- sd/source/filter/ppt/pptin.cxx|2 +- 3 files changed, 11 insertions(+), 3 deletions(-) New commits: commit 2f432afdf6335d2e0a777cf89ceebe99550328d8 Author: Tor

[Libreoffice-commits] .: lcms2/makefile.mk

2012-03-02 Thread Fridrich Strba
lcms2/makefile.mk |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 02888164e76fd08a7a6d02e526669f1c4e3a0239 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Mar 2 11:52:06 2012 +0100 Make lcms2 build on windows too diff --git

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - solenv/bin

2012-03-02 Thread Fridrich Strba
solenv/bin/modules/installer/windows/msiglobal.pm | 13 + 1 file changed, 13 insertions(+) New commits: commit 62c6863bc037e7ea3f44852c51cf3cafd75cebf1 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Mar 2 11:58:19 2012 +0100 tabs - spaces diff --git

[Libreoffice-commits] .: desktop/source

2012-03-02 Thread Stephan Bergmann
desktop/source/app/app.cxx | 34 +++--- desktop/source/app/userinstall.cxx | 13 + desktop/source/app/userinstall.hxx |7 --- 3 files changed, 28 insertions(+), 26 deletions(-) New commits: commit

[Libreoffice-commits] .: oox/source

2012-03-02 Thread Muthu Subramanian
oox/source/drawingml/shape.cxx |4 +++- oox/source/ppt/pptshape.cxx|2 +- 2 files changed, 4 insertions(+), 2 deletions(-) New commits: commit 77901e53ecd99aed59e5c8697461ab4d241388a4 Author: Muthu Subramanian sumu...@suse.com Date: Fri Mar 2 18:01:45 2012 +0530 n657904:

[Libreoffice-commits] .: Branch 'libreoffice-3-5-1' - solenv/bin

2012-03-02 Thread Michael Meeks
solenv/bin/modules/installer/windows/msiglobal.pm | 13 + 1 file changed, 13 insertions(+) New commits: commit b233485a3ef2e0acb65032945e46eb3d20dbc3d9 Author: Andras Timar ati...@suse.com Date: Fri Mar 2 10:46:17 2012 +0100 fdo#46181 Use Traditional Chinese installer for

[Libreoffice-commits] .: lotuswordpro/qa

2012-03-02 Thread Caolán McNamara
lotuswordpro/qa/cppunit/data/pass/wordpro.lwp |binary 1 file changed New commits: commit c45208832536d144007f01e419614f9bf37eb763 Author: Caolán McNamara caol...@redhat.com Date: Fri Mar 2 12:40:49 2012 + add a more extensive lotuswordpro sample diff --git

[Libreoffice-commits] .: oox/source

2012-03-02 Thread Radek Doulík
oox/source/drawingml/textcharacterproperties.cxx |2 +- oox/source/drawingml/textparagraph.cxx |9 - oox/source/drawingml/textparagraphproperties.cxx |2 ++ 3 files changed, 11 insertions(+), 2 deletions(-) New commits: commit

[Libreoffice-commits] .: oox/source

2012-03-02 Thread Noel Power
oox/source/ole/vbamodule.cxx | 48 +++ 1 file changed, 48 insertions(+) New commits: commit 24b402d67eb9acc7ff1f0afeee7237f6b3b14644 Author: Noel Power noel.po...@novell.com Date: Fri Mar 2 13:04:18 2012 + weed out unmatched Sub/End Sub

[Libreoffice-commits] .: cui/source

2012-03-02 Thread Tor Lillqvist
cui/source/inc/autocdlg.hxx | 26 +-- cui/source/tabpages/autocdlg.cxx | 143 ++- 2 files changed, 72 insertions(+), 97 deletions(-) New commits: commit 1a2b84fecc9be1f9a6e4d1f4edc3ee44f221a269 Author: Noel Grandin n...@peralex.com Date: Fri Mar

[Libreoffice-commits] .: solenv/gbuild

2012-03-02 Thread Andras Timar
solenv/gbuild/platform/WNT_INTEL_MSC.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 48666b7d6006618d46e2a7686391440830f47ef1 Author: Andras Timar ati...@suse.com Date: Fri Mar 2 14:35:43 2012 +0100 Cygwin uses internal Python which does not understand

[Libreoffice-commits] .: extensions/source tools/inc tools/source

2012-03-02 Thread Tor Lillqvist
extensions/source/resource/oooresourceloader.cxx |2 +- tools/inc/tools/simplerm.hxx | 13 - tools/source/rc/resmgr.cxx |7 --- 3 files changed, 1 insertion(+), 21 deletions(-) New commits: commit

[Libreoffice-commits] .: configure.in

2012-03-02 Thread Tor Lillqvist
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 62025f7446989c1a29596a2c4cb5ef597808f15e Author: Tor Lillqvist t...@iki.fi Date: Fri Mar 2 16:29:28 2012 +0200 Hide a potential error message which we aren't interested in seeing diff --git

[Libreoffice-commits] .: 3 commits - editeng/source sd/util

2012-03-02 Thread Ivan Timofeev
editeng/source/editeng/editdoc.hxx | 14 -- editeng/source/editeng/impedit4.cxx | 15 ++- sd/util/sd.flt |1 - 3 files changed, 14 insertions(+), 16 deletions(-) New commits: commit c1cf8dac6d54f3d0876803ca9dffce23df7241da Author: Ivan

[Libreoffice-commits] .: 13 commits - sc/source sd/source svtools/source svx/source

2012-03-02 Thread Tor Lillqvist
sc/source/filter/excel/xestream.cxx |4 sc/source/ui/inc/checklistmenu.hxx |1 sd/source/filter/ppt/pptinanimations.cxx |4 sd/source/ui/animations/SlideTransitionPane.cxx |6 +

[Libreoffice-commits] .: offapi/type_reference

2012-03-02 Thread Stephan Bergmann
offapi/type_reference/typelibrary_history.txt | 21 + 1 file changed, 21 insertions(+) New commits: commit 30a7a6189916396c7c2ee9bbd5861ad19bf7724c Author: Stephan Bergmann sberg...@redhat.com Date: Fri Mar 2 18:58:33 2012 +0100 Document how to incompatibly change

[Libreoffice-commits] .: tools/inc vcl/inc vcl/source

2012-03-02 Thread Tor Lillqvist
tools/inc/tools/wintypes.hxx |1 - vcl/inc/svids.hrc|1 - vcl/inc/vcl/msgbox.hxx |4 vcl/source/src/btntext.src |5 - vcl/source/window/msgbox.cxx | 14 -- 5 files changed, 25 deletions(-) New commits: commit

[Libreoffice-commits] .: oox/source

2012-03-02 Thread Radek Doulík
oox/source/drawingml/customshapes/generatePresetsPPTXs.pl | 25 +++--- 1 file changed, 20 insertions(+), 5 deletions(-) New commits: commit e3c0a952a7607436224fe57f9e1665597702f6b2 Author: Radek Doulik r...@novell.com Date: Fri Mar 2 20:40:04 2012 +0100 generate more pptx test

[Libreoffice-commits] .: RepositoryModule_ooo.mk

2012-03-02 Thread Matus Kukan
RepositoryModule_ooo.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 8d7321c8eb658c409122feaef4960cc88aa63459 Author: Matúš Kukan matus.ku...@gmail.com Date: Fri Mar 2 21:10:44 2012 +0100 remove translations from here diff --git a/RepositoryModule_ooo.mk

[Libreoffice-commits] .: 7 commits - oox/source sfx2/source sw/inc sw/source unotest/source

2012-03-02 Thread Michael Stahl
oox/source/drawingml/shape.cxx| 28 - sfx2/source/doc/QuerySaveDocument.cxx |5 + sw/inc/txtfld.hxx |3 sw/source/core/crsr/crstrvl.cxx |3

[Libreoffice-commits] .: 7 commits - editeng/source filter/source oox/source

2012-03-02 Thread Tor Lillqvist
editeng/source/editeng/impedit3.cxx |2 +- filter/source/msfilter/msdffimp.cxx |4 ++-- filter/source/msfilter/svdfppt.cxx |2 +- oox/source/export/chartexport.cxx |2 +- oox/source/export/drawingml.cxx | 10 +- oox/source/xls/stylesbuffer.cxx | 24

[Libreoffice-commits] .: 4 commits - sc/source xmloff/source

2012-03-02 Thread Markus Mohrhard
sc/source/ui/namedlg/namedefdlg.cxx|8 +++- sc/source/ui/view/cellsh1.cxx |2 -- xmloff/source/chart/SchXMLTableContext.cxx | 12 ++-- xmloff/source/chart/transporttypes.hxx | 12 4 files changed, 17 insertions(+), 17 deletions(-) New

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - xmloff/source

2012-03-02 Thread Kohei Yoshida
xmloff/source/chart/SchXMLTableContext.cxx | 10 +- xmloff/source/chart/transporttypes.hxx | 12 2 files changed, 9 insertions(+), 13 deletions(-) New commits: commit 61600b62068bf7837c532c8b32377984ee76af1e Author: Markus Mohrhard markus.mohrh...@googlemail.com

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source

2012-03-02 Thread Kohei Yoshida
sc/source/ui/namedlg/namedefdlg.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit f4f0ef5790bd06145d977183da0ee244c5c46058 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Mar 2 23:48:44 2012 +0100 don't show an error message for empty

Re: [PATCH] Convert SvPtrarr and tools/table.hxx usage in sw module.

2012-03-02 Thread Tor Lillqvist
Thanks, pushed to master. (Small wish: Please format the git commit comment according to conventions: One short (less than 79 characters) first line that summarizes the commit, followed if necessary by a blank line and one or several paragraphs, with max 79 character line length.) --tml

Re: [PATCH] [PUSHED] Convert SvPtrarr and tools/table.hxx usage in sw module.

2012-03-02 Thread Tor Lillqvist
[PUSHED] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Replace String by OUString

2012-03-02 Thread Tor Lillqvist
Looks fine, and can the sFontName variable and the single assignment to it be deleted even, I don't see it being used anywhere? Does it still compile after that? Please check and follow up. --tml ___ LibreOffice mailing list

Re: [PATCH] instance of SV_DECL_VARARR_SORT - std::set

2012-03-02 Thread Tor Lillqvist
As Matúš already is an established contributor I won't semi-automatically just push this patch, but want to wait for our C++ / STL experts (I am not) to actually review it... --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: minutes of ESC call ...

2012-03-02 Thread Stephan Bergmann
On 03/01/2012 10:25 PM, Michael Meeks wrote: On Thu, 2012-03-01 at 20:47 +0100, Stephan Bergmann wrote: AA: + l/strace-alike for UNO (Stephan) On a more constructive note ;) the above already exists, in the form

Copyright attribution

2012-03-02 Thread Ken Foskey
All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. Michael knew this already :-) Thanks Ken Foskey ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Exception cost on string allocations ...

2012-03-02 Thread Stephan Bergmann
On 02/29/2012 05:29 PM, Michael Meeks wrote: So - I did some more analysis, and re-compiled all of LibreOffice both with and without the attached patch - analysing all 287 shared libraries we get: $ du -b -c ../../without-stripped/program/*.so | tail ... 171373684 total $ du -b

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

2012-03-02 Thread Michael Meeks
On Thu, 2012-03-01 at 22:56 +0100, Andras Timar wrote: Copy to Clipboard what? My changes? You know what I mean. What do you think, how this feature can be improved? Should it be a small icon with help text Copy text from this dialog to clipboard, or should it be conditional? Sounds

Re: Weird code found by clang

2012-03-02 Thread Tor Lillqvist
Probably it should be pFields != pFieldsEnd ? See original commit: http://opengrok.libreoffice.org/xref/core/svtools/source/dialogs/addresstemplate.cxx?a=truer=447a63cfb6d6d3dff63af72490a4c0b96295db6d#250 Ah yes. That variable had then been removed as unused (which it was), while the right

Re: minutes of ESC call ...

2012-03-02 Thread Michael Meeks
On Fri, 2012-03-02 at 09:29 +0100, Stephan Bergmann wrote: Micheal, I think I still don't understand what you are up to here. What does logging have to do with XUnoTunnel ? Correct me if I'm wrong, but as soon as we start doing bridging - which is necessary for logging - then instead

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #212 from Mihkel Tõnnov mihh...@gmail.com 2012-03-02 01:37:36 PST --- (In reply to comment #211) When I hide a row and then copy the remaining rows Calc will also copy the hide rows. I'm not sure if this is a feature or a bug,

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #213 from Petr Mladek pmla...@suse.cz 2012-03-02 01:48:28 PST --- (In reply to comment #212) (In reply to comment #211) When I hide a row and then copy the remaining rows Calc will also copy the hide rows. I'm not sure if

Re: [PUSHED][3-5] don't try to update range names twice in ScDocument::TransferTab

2012-03-02 Thread Petr Mladek
Kohei Yoshida píše v Čt 01. 03. 2012 v 12:59 -0500: On Thu, 2012-03-01 at 14:40 +0100, Markus Mohrhard wrote: Missed the attachment, You can find the commit at http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b93146d442bb8396126d6106f05a5bb0ee9fffa Pushed to the 3-5 branch with my

[REVIEW 3-5-1] fdo#46181 fix installer language for zh-HK and zh-MO

2012-03-02 Thread Andras Timar
Hi, This was a bug in our multi language Windows Installer, users from Hong Kong saw Simplified Chinese install wizard instead of Traditional Chinese. I tested and the same happened when locale was set to Macau S.A.R., so I made the patch below. Sorry for the sloppy indentation, I fixed that in

Re: [PUSHED 3-5] Simple UI fix

2012-03-02 Thread Petr Mladek
Michael Meeks píše v Čt 01. 03. 2012 v 05:53 +: On Thu, 2012-03-01 at 00:28 +0100, Stefan Knorr (Astron) wrote: Can you please review the following one-liner for inclusion in the 3.5 branch? Sure - looks sensible; pushed :-) (I don't know if it's too late for 3.5.1 already,

Re: how to change the compile-time default settings, like page setting to B5

2012-03-02 Thread Michael Meeks
On Fri, 2012-03-02 at 09:26 +0800, huqitu du wrote: I found this http://ask.libreoffice.org/question/433/how-do-i-change-my-default-font-from-times-new but this is not me wanted, I want to change default settings from source file, so I can make a installer, and when I install Office, the

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-02 Thread Tor Lillqvist
Eek, in tail_build it is even worse; there I now see it looping, continuously recompiling some dozens of files in sw, unoxml, sfx2 etc and rebuilding the dependencies of some libraries [build DEP]. Sigh. It had been doing that for the whole night;) Maybe the best way out for me would be to make

Re: [PUSHED:3-5] Fix for fdo#40320

2012-03-02 Thread Petr Mladek
Markus Mohrhard píše v Út 28. 02. 2012 v 02:59 +0100: Hello Kohei, 2012/2/24 Kohei Yoshida kohei.yosh...@suse.com: On Fri, 2012-02-24 at 14:59 -0500, Kohei Yoshida wrote: Hi there, Please review the following commit

Re: minutes of ESC call ...

2012-03-02 Thread Michael Stahl
On 02/03/12 10:32, Michael Meeks wrote: On Fri, 2012-03-02 at 09:29 +0100, Stephan Bergmann wrote: Micheal, I think I still don't understand what you are up to here. What does logging have to do with XUnoTunnel ? Correct me if I'm wrong, but as soon as we start doing bridging -

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-02 Thread Tor Lillqvist
Maybe the best way out for me would be to make it ignore dependencies completely (not generate and not use any .d files), and do make clean more often, Is there a way to do make clean only for the host platform, not the build platform? Is there a way to make clean only for object files, and

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-02 Thread Matúš Kukan
On 2 March 2012 11:31, Tor Lillqvist t...@iki.fi wrote: Is there a way to do make clean only for the host platform, not the build platform? Is there a way to make clean only for object files, and especially not the stuff generated from IDL files? Well, I would push: --- a/Makefile +++

Re: [REVIEW 3-5-1] fdo#46181 fix installer language for zh-HK and zh-MO

2012-03-02 Thread Fridrich Strba
Rubber-stamping for 3-5 branch. 2 more review needed for 3-5-1 Cheers F. On 02/03/12 11:03, Andras Timar wrote: Hi, This was a bug in our multi language Windows Installer, users from Hong Kong saw Simplified Chinese install wizard instead of Traditional Chinese. I tested and the same

Re: [REVIEW 3-5-1] fdo#46181 fix installer language for zh-HK and zh-MO

2012-03-02 Thread Tor Lillqvist
+1 from me too. At first I stared a bit at the rename 3076,5124; but apparently that is legal Perl. And hmm, why wouldn't it be, numbers are numbers, they don't need quoting, and sure, a number can be used directly as a file name if that is what the file's name is, a numeric string;) --tml

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #214 from Petr Mladek pmla...@suse.cz 2012-03-02 03:06:09 PST --- Add bug 46843: Base Queries loose sorting-order when reopening for editing -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||46843 -- Configure

[PATCH] fdo#46501: EasyHack: cleanup SimpleResMgr ...

2012-03-02 Thread Dézsi Szabolcs
Hi! I deleted the constructor which uses OUString as suggested here: https://bugs.freedesktop.org/show_bug.cgi?id=46501 Szabolcs From f69fd5cb5e8cbe05a3b87b9b5adfd8494a9a4bab Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi dezsisz...@hotmail.com Date:

Bugzilla queries and NEEDINFO state

2012-03-02 Thread Petr Mladek
Hi, I have just fixed the queries at https://wiki.documentfoundation.org/Release_Criteria#Blocker_Bug_Nomination to accept the new NEEDINFO status. They show a bit more bugs now. Best Regards, Petr ___ LibreOffice mailing list

Re: [REVOKED] Fix for fdo#562027, lp#562027, deb#632920: Quickstarter breaks log out

2012-03-02 Thread Bjoern Michaelsen
On Tue, Feb 28, 2012 at 02:38:29PM +0100, Bjoern Michaelsen wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5279616d50b0394e8ec6d8e2109471ca649412b7 revoking this review request for now: patch is incomplete. Best, Bjoern ___

Re: [REVIEW][3-5-1][3-4] nsplugin broken due to typo

2012-03-02 Thread Michael Meeks
On Thu, 2012-03-01 at 09:39 +0100, Stephan Bergmann wrote: Only thing missing (since 2004) is to actually use them... Filed https://bugs.freedesktop.org/show_bug.cgi?id=46808 [Easy Hack] Adapt UNO services to new-style now. Nice work :-) Thanks for that, hopefully some enthusiastic

{PATCH] Convert tools/table.hxx to std::vector and std::map in CUI module

2012-03-02 Thread Noel Grandin
Hi Convert tools/table.hxx to std::vector and std::map in CUI module Contributed under LGPLv3+ / MPL 1.1 or later. (And my license statement is on file in the wiki) Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html

[PUSHED 3-5-1] fdo#46181 fix installer language for zh-HK and zh-MO

2012-03-02 Thread Michael Meeks
On Fri, 2012-03-02 at 13:00 +0200, Tor Lillqvist wrote: At first I stared a bit at the rename 3076,5124; but apparently that is legal Perl. And hmm, why wouldn't it be, numbers are numbers, :-) I checked the id's too cherry-picked it to libreoffice-3-5-1. Thanks,

[bjoern.michael...@canonical.com: minutes of gerrit.documentfoundation.org call 2012-03-01]

2012-03-02 Thread Bjoern Michaelsen
Hi there, gerrit call minutes from my scribblings: present: Robert, Norbert, Bjoern topics: - gerrit is up and running - against postgresql AA - set-up back-up solution for postgresql (Robert, ETA next week) - bouncycastle ssh-server: is it secure? - google is using it,

Re: {PATCH] [PUSHED] Convert tools/table.hxx to std::vector and std::map in CUI module

2012-03-02 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [PUSHED] fdo#46501: EasyHack: cleanup SimpleResMgr ...

2012-03-02 Thread Tor Lillqvist
Thanks, pushed. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: minutes of ESC call ...

2012-03-02 Thread Stephan Bergmann
On 03/02/2012 11:35 AM, Michael Stahl wrote: On 02/03/12 10:32, Michael Meeks wrote: On Fri, 2012-03-02 at 09:29 +0100, Stephan Bergmann wrote: Micheal, I think I still don't understand what you are up to here. What does logging have to do with XUnoTunnel ? Correct me if I'm wrong,

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-03-02 Thread Stephan Bergmann
On 03/01/2012 03:42 PM, Lubos Lunak wrote: On Wednesday 29 of February 2012, Caolán McNamara wrote: But ok, it's too much to just abort in every case. I think however that whether to abort or try to recover does not actually depend on the class where the problem occurs, but on where the class

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||46532

Re: [PATCH] Convert SvPtrarr and tools/table.hxx usage in sw module.

2012-03-02 Thread Ivan Timofeev
Hi, -DECLARE_TABLE( SwBookmarkNodeTable, SvPtrarr* ) +typedef std::multimapsal_uLong, const ::sw::mark::IMark* SwBookmarkNodeTable; ... +SwBookmarkNodeTable aBkmkNodePos; ... -SvPtrarr* pArr = (m_pImpl-pBkmkNodePos) ? -m_pImpl-pBkmkNodePos-Get( nNd ) : 0; -if( pArr

Re: [PATCH] Convert SvPtrarr and tools/table.hxx usage in sw module.

2012-03-02 Thread Noel Grandin
you are correct, I will spin a new patch. On 2012-03-02 17:42, Ivan Timofeev wrote: Hi, -DECLARE_TABLE( SwBookmarkNodeTable, SvPtrarr* ) +typedef std::multimapsal_uLong, const ::sw::mark::IMark* SwBookmarkNodeTable; ... +SwBookmarkNodeTable aBkmkNodePos; ... -SvPtrarr* pArr =

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

2012-03-02 Thread Stefan Knorr (Astron)
Hi all, first: Dézsi, it's great that you care about our UI! Michael wrote...        Copying the text to the clipboard is a real minority use-case and doesn't deserve a prominent button in every dialog IMHO. As one of the UX-advise guys, I have to agree with that. Gnome solve the same problem

License Statememnt

2012-03-02 Thread Andreas Proschofsky
As generic as possible ;) All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. cheers Andreas -- Andreas Proschofsky Gentoo Developer Twitter: @suka_hiroaki Identi.ca: @suka Google+:

[REVIEW-3-4] Fix for fdo#34209

2012-03-02 Thread Thorsten Behrens
Hi there, somewhat ugly but effective fix for not showing credits etc. on Mac. Got independently fixed by Stephan's 3layer-cleanup on -3-5, so no need for action there. I need one review. Cheers, -- Thorsten diff --git a/scp2/source/ooo/common_brand.scp b/scp2/source/ooo/common_brand.scp index

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

2012-03-02 Thread Tor Lillqvist
OK, so I think the consensus is that the patch should be reverted, and that Dézsi is kindly asked to re-design the UI for this (as such nice and wanted) functionality? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||46901

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-03-02 Thread Caolán McNamara
On Fri, 2012-03-02 at 16:00 +0100, Stephan Bergmann wrote: And when/if we replace the sal C API with a C++ one in LO 4 (where a memory allocation function, if we would still need a home-grown one anyway, would naturally throw bad_alloc) Yeah, back the O[UString contents with direct

[REVIEW 3-5] Custom Shapes compile speedup ...

2012-03-02 Thread Michael Meeks
Hi guys, I'd like to propose this for cherry-picking: http://cgit.freedesktop.org/libreoffice/core/commit/?id=f291fb57d087de41385a22dfacd8b694d8b9abc7 the rather large and tedious patch it generates is this:

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

2012-03-02 Thread Michael Meeks
On Fri, 2012-03-02 at 18:23 +0200, Tor Lillqvist wrote: OK, so I think the consensus is that the patch should be reverted, and that Dézsi is kindly asked to re-design the UI for this (as such nice and wanted) functionality? Yep :-) Michael. -- michael.me...@suse.com

Re: [REVIEW 3-5] Custom Shapes compile speedup ...

2012-03-02 Thread Radek Doulik
Hi Michael, thanks. The patch looks good to me. Pushed. It doesn't change the properties data, so it shouldn't break anything. I guess I will cook another sample document containing all presets for easier future testing. Cheers Radek On Fri, 2012-03-02 at 17:44 +, Michael Meeks wrote: Hi

Re: [PATCH] [REVERTED] fdo#46193: Let the user copy error message from error dialog

2012-03-02 Thread Tor Lillqvist
OK, so I think the consensus is that the patch should be reverted, and that Dézsi is kindly asked to re-design the UI for this (as such nice and wanted) functionality? Done. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: EasyHack: perl / autogen.sh should backup autogen.lastrun

2012-03-02 Thread Thomas Collerton
Hi, thanks for the tip. This is an improved (hopefully) version of the patch =) Cheers! 2012/2/29 Michael Meeks michael.me...@suse.com Hi there, On Wed, 2012-02-29 at 11:58 +0100, Thomas Collerton wrote: this patch accomplishes what the EasyHack requests =) Thanks - pushed it :-)

Re: Disabling Temporary Files?

2012-03-02 Thread Marc-André Laverdière
Hello, I will do that investigation. Just a quick question: if the original file was password-protected, will the temp files be similarly be protected? On 2012-02-28 1:57 PM, Michael Stahl mst...@redhat.com wrote: On 28/02/12 19:46, Marc-André Laverdière wrote: Hello, I need to ensure that

Re: LibreOffice 3.5 does not work anymore

2012-03-02 Thread Cor Nouws
Hi Luc, Luc Castermans wrote (02-03-12 19:53) Libo 3.5 and also 3.5rc1 do not start anymore. Attached message I get. LibreOffice 3.5 does not work anymore Looks pretty dramatic. How can I find out what's wrong? Best mail to QA-list with some more details. Or look in BugZilla

Re: [REVIEW 3-5] Custom Shapes compile speedup ...

2012-03-02 Thread Radek Doulik
Hi again, On Fri, 2012-03-02 at 19:51 +0100, Radek Doulik wrote: Hi Michael, thanks. The patch looks good to me. Pushed. It doesn't change the properties data, so it shouldn't break anything. I guess I will cook another sample document containing all presets for easier future testing.

Re: Disabling Temporary Files?

2012-03-02 Thread Michael Meeks
On Fri, 2012-03-02 at 14:31 -0500, Marc-André Laverdière wrote: I will do that investigation. Just a quick question: if the original file was password-protected, will the temp files be similarly be protected? Almost certainly not :-) but theoretically they could be of course.

Reduce duplicate code: PrinterJob::writeProlog

2012-03-02 Thread Chr. Rossmanith
Hi, static const sal_Char pProlog[] and static const sal_Char pSO52CompatProlog[] share about 90% of their content (2 out of 84 lines differ). I could split the prolog in three parts: part 1 and 3 identical for both variables and part 2 varies with m_pGraphics-getStrictSO52Compatibility()

[PUSHED 3-5-1] Simple UI fix

2012-03-02 Thread Michael Meeks
On Fri, 2012-03-02 at 11:10 +0100, Petr Mladek wrote: One more review needed for 3-5-1 branch. We got one on IRC pushed it to -3-5-1. Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot

Re: [REVIEW 3-5] Custom Shapes compile speedup ... #2

2012-03-02 Thread Michael Meeks
On Fri, 2012-03-02 at 20:46 +0100, Radek Doulik wrote: On Fri, 2012-03-02 at 19:51 +0100, Radek Doulik wrote: thanks. The patch looks good to me. Pushed. I just pushed a lot more of this stuff to master, basically out-lining all those (exception throwing = hard-to-optimise) object

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #217 from mariosv mari...@miguelangel.mobi 2012-03-02 16:04:31 PST --- (In reply to comment #211) When I hide a row and then copy the remaining rows Calc will also copy the hide rows. As I know this only works with rows hidden

[REVIEW] fix for fdo#46825, crash copying a chart

2012-03-02 Thread Markus Mohrhard
Hey, [1] fixes a crash when you copy a chart in the document. The problem is that you should not create a uno::Sequence with new because the uno::Sequence copy c'tor is creating a flat copy. This will later result in a double delete. I think the patch is quite save and fixes a crash and

[REVIEW] fix for fdo#46816, don't show error message for empty range name in Define Names

2012-03-02 Thread Markus Mohrhard
Hey, [1] improves the dialog a bit. The error message is a bit misleading and we can just use the disabled Add button as sign that you can't add an empty range name. It would be nice if this could be cherry-picked to 3-5 and maybe 3-5-1. Regards, Markus [1]

Re: [REVIEWED] [PUSHED 3-5] fix for fdo#46825, crash copying a chart

2012-03-02 Thread Kohei Yoshida
On Fri, Mar 2, 2012 at 7:08 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey, [1] fixes a crash when you copy a chart in the document. The problem is that you should not create a uno::Sequence with new because the uno::Sequence copy c'tor is creating a flat copy. This will later

Re: [REVIEWED] [PUSHED 3-5] fix for fdo#46816, don't show error message for empty range name in Define Names

2012-03-02 Thread Kohei Yoshida
On Fri, Mar 2, 2012 at 7:13 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: [1] improves the dialog a bit. The error message is a bit misleading and we can just use the disabled Add button as sign that you can't add an empty range name. [1]

Re: [Libreoffice-qa] FDO bugzilla setting for following all bug reports of certain module ?

2012-03-02 Thread Bjoern Michaelsen
On Fri, Mar 02, 2012 at 08:13:46AM +0100, Alex Thurgood wrote: I have been rummaging around FDO bugzilla trying to find a way to make myself automatically get CC on bugs filed fot the database module. As yet, I've not found any easier way to do this than by querying for all bugs where the

Re: [Libreoffice-qa] Make use of your karma - feel free to retag/edit posts (Fwd: QA forum feedback)

2012-03-02 Thread Pedro
Christian Lohmaier-3 wrote following feedback was sent regarding the askbot platform. I can only agree - so feel free to make use of your karma to moderate questions (retag, edit, ...) and make use of your votes (so that other people get their karma, and to make it easier to distinguish

[Libreoffice-qa] Bugzilla queries and NEEDINFO state

2012-03-02 Thread Petr Mladek
Hi, I have just fixed the queries at https://wiki.documentfoundation.org/Release_Criteria#Blocker_Bug_Nomination to accept the new NEEDINFO status. They show a bit more bugs now. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail

Re: [Libreoffice-qa] Make use of your karma - feel free to retag/edit posts (Fwd: QA forum feedback)

2012-03-02 Thread Christian Lohmaier
Hi Pedro, *, On Fri, Mar 2, 2012 at 11:15 AM, Pedro pedl...@gmail.com wrote: Christian Lohmaier-3 wrote [...] and make use of your votes (so that other people get their karma, and to make it easier to distinguish good/interesting and waste-of-time questions :-) Unfortunately the karma

Re: [Libreoffice-qa] Ubuntu/Canonical doing more manual testing for LibreOffice?

2012-03-02 Thread Bjoern Michaelsen
Hi Sophie, all, On Fri, Mar 02, 2012 at 11:29:32AM +0100, Sophie Gautier wrote: So, I'm ready to work on this, but as underlined by Yifan, it would be interesting for us to keep also our Litmus system up to date and synchronized because it's used under several OS and languages so it has a

Re: [Libreoffice-qa] Ubuntu/Canonical doing more manual testing for LibreOffice?

2012-03-02 Thread Sophie Gautier
Hi Bjoern, all, I've added Nicholas in copy of this mail On 02/03/2012 13:50, Bjoern Michaelsen wrote: Hi Sophie, all, On Fri, Mar 02, 2012 at 11:29:32AM +0100, Sophie Gautier wrote: So, I'm ready to work on this, but as underlined by Yifan, it would be interesting for us to keep also our

Re: [Libreoffice-qa] test cases quality; was: Ubuntu/Canonical doing more manual testing for LibreOffice?

2012-03-02 Thread Petr Mladek
Sophie Gautier píše v Pá 02. 03. 2012 v 14:33 +0100: - are the tests on Litmus good enough or should I write more? Great point. We have only very few test cases in Litmus (less than 50) and the quality is debatable :-/ For example, I see test cases: + create empty Writer document

  1   2   3   4   >