Re: [PATCH] libvisio: Fix tests without tools

quot;git format-patch" or submit to gerrit, so that I > can credit you properly? -- Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html signature.asc Description: OpenPGP d

Re: Re: [PATCH] libvisio: Fix tests without tools

6e71ed82b > > Thanks a lot for noticing this. > > Cheers > > Fridrich > > On 07/02/16 21:09, Fridrich Strba wrote: > > Could you send it as "git format-patch" or submit to gerrit, so that I > > can credit you properly? > > > -- > Please

Gerrit patch set for a regression of Lo 5.1 wrt Lo 5.0

Hi all, it seems that LO 5.1 can no longer save to Google Drive. See: <https://bugs.documentfoundation.org/show_bug.cgi?id=96174#c5> the Windows test only. Linux test is not possible due to: <https://bugs.documentfoundation.org/show_bug.cgi?id=96174#c7> Gerrit patch for m

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - libpng/libpng-1.5.1.patch libpng/libpng-1.5.26.patch libpng/makefile.mk

libpng/libpng-1.5.1.patch | 277 - libpng/libpng-1.5.26.patch | 302 + libpng/makefile.mk |4 3 files changed, 304 insertions(+), 279 deletions(-) New commits: commit

Re: help request on proposed VCL code patch

On 12/14/2015 06:46 AM, Lionel Elie Mamane wrote: > Was Caolan's commit, you said you would test "not before this weekend" > (a month ago), and to please poke you again "by Sunday" but nobody > poked you. (The poke fell through the list of things *I* have to do.) > >

Re: help request on proposed VCL code patch

On Mon, Dec 14, 2015 at 07:13:43AM -0800, Joel Madero wrote: > On 12/14/2015 06:46 AM, Lionel Elie Mamane wrote: >> Was Caolan's commit, you said you would test "not before this weekend" >> (a month ago), and to please poke you again "by Sunday" but nobody >> poked you. (The poke fell through the

Re: help request on proposed VCL code patch

On Mon, Dec 14, 2015 at 08:37:55PM +, Caolán McNamara wrote: > On Mon, 2015-12-14 at 15:13 +0100, Lionel Elie Mamane wrote: >> Well, you did, but apparently we didn't catch up on it and now we are >> about to ship 5.0.4 with a significant regression compared to 5.0.3 >> :-( >> See

Re: help request on proposed VCL code patch

On Wed, Nov 11, 2015 at 10:59:46AM +, Caolán McNamara wrote: > On Fri, 2015-10-30 at 11:31 +0100, Lionel Elie Mamane wrote: >> There is patch attached to tdf#94069, nominally a rather annoying >> Base UI bug (crash!), but which touches the VCL event loop (not >> speci

Re: help request on proposed VCL code patch

On 12/14/2015 06:13 AM, Lionel Elie Mamane wrote: > Do you think you can take a look at it "fast" or should we revert? I don't remember why/how I was involved with this? Did I say I would test it and somehow it fell through the list of things that I have to do? What should I "look at"? Was it

Re: help request on proposed VCL code patch

On Mon, Dec 14, 2015 at 06:37:36AM -0800, Joel Madero wrote: > On 12/14/2015 06:13 AM, Lionel Elie Mamane wrote: >> Do you think you can take a look at it "fast" or should we revert? > I don't remember why/how I was involved with this? Did I say I would > test it and somehow it fell through the

Re: help request on proposed VCL code patch

On Mon, Dec 14, 2015 at 06:59:27PM +0100, Alexander Thurgood wrote: > Le 14/12/2015 16:56, Lionel Elie Mamane a écrit : >> Regression is there. We are about to release 5.0.4.2 as final with >> that regression. > Looked at tdf#94069 and tested on master 5.2 alpha - I get no crash when > moving

Re: help request on proposed VCL code patch

Le 14/12/2015 16:56, Lionel Elie Mamane a écrit : Hi all, > Regression is there. We are about to release 5.0.4.2 as final with > that regression. > Looked at tdf#94069 and tested on master 5.2 alpha - I get no crash when moving the grid control around in a form in form design mode. What

Re: help request on proposed VCL code patch

On Mon, 2015-12-14 at 15:13 +0100, Lionel Elie Mamane wrote: > Well, you did, but apparently we didn't catch up on it and now we are > about to ship 5.0.4 with a significant regression compared to 5.0.3 > :-( > > See https://bugs.documentfoundation.org/96482 > > Do you think you can take a look

[PATCH] French dictionary update

Hi, Here is a patch to update the French dictionary. For master and 5.1. License: MPL 2. 0001-French-dictionary-update-v5.patch <http://nabble.documentfoundation.org/file/n4169109/0001-French-dictionary-update-v5.patch> Regards, Olivier -- View this message in context:

Re: patch

Thanks for your license statement. I see you are already on our wiki: https://wiki.documentfoundation.org/Development/Developers I you want help to get started or have any questions, then please contact me. I am here to help you (and others) getting their first patch submitted. LibreOffice

patch

All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: gerrit draft patch submission with SAL_DEBUG lines

Hi Kendy, > You can use 'git commit --no-verify -a' to avoid the git hooks; but please > use with care obviously - people will be angry if/when that gets to the > production code ;-) Thanks, I will be careful. Winfried ___ LibreOffice mailing list

Re: gerrit draft patch submission with SAL_DEBUG lines

Hi Winfried, Winfried Donkers píše v Pá 20. 11. 2015 v 09:17 +0100: > When I try 'git commit -a' prior to submitting to gerrit the SAL_DEBUG > lines make git cancel the commit. You can use 'git commit --no-verify -a' to avoid the git hooks; but please use with care obviously - people will be

gerrit draft patch submission with SAL_DEBUG lines

Hi, Is it possible to submit a draft patch (./logerrit submit-draft) to gerrit with one or more SAL_DEBUG lines still present in the code? When I try 'git commit -a' prior to submitting to gerrit the SAL_DEBUG lines make git cancel the commit. (Currently I am working on an addition for Calc

Re: gerrit draft patch submission with SAL_DEBUG lines

Comment out, *and* (for instance) change SAL_DEBUG to SAL__DEBUG ? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Patch: convert InsertDeleteFlags to use o3tl::typed_flags

On 11/17/2015 03:07 PM, Alex McMurchy wrote: Is there a way to determine which branch/release this patch is going to appear in - http://cgit.freedesktop.org/libreoffice/core/commit/?id=eaa34b4e29478770c4707d56aa102491bc8e058a as it was pushed to master only recently, it will only appear

Patch: convert InsertDeleteFlags to use o3tl::typed_flags

Is there a way to determine which branch/release this patch is going to appear in - http://cgit.freedesktop.org/libreoffice/core/commit/?id=eaa34b4e29478770c4707d56aa102491bc8e058a Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: help request on proposed VCL code patch

On Fri, 2015-10-30 at 11:31 +0100, Lionel Elie Mamane wrote: > Hi, > > There is patch attached to tdf#94069, nominally a rather annoying > Base UI bug (crash!), but which touches the VCL event loop (not > specific to Base) in a way that I don't understand the consequences

[PATCH] Replace boost::bind by lambdas in canvas/source/directx tree...

Hi, I would like you to review the following patch: https://gerrit.libreoffice.org/19702 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/19702/1 Replace boost::bind by lambdas in canvas/source/directx tree. Change-Id

Re: [PATCH] install_cygwin.ps1

ee would), and have already made several changes to the lode wiki pages to clarify a couple of pitfalls. My intentions was to work as a completely new person, which of course included submitting a patch by mail (since logerrit does not work for lode) and see how it was handled. with a little gi

help request on proposed VCL code patch

Hi, There is patch attached to tdf#94069, nominally a rather annoying Base UI bug (crash!), but which touches the VCL event loop (not specific to Base) in a way that I don't understand the consequences of (treat 10 events per call instead of 1...). Would the right fix rather be to arrange

[PATCH] install_cygwin.ps1

install_cygwin.ps1, since it is stored somewhere on our web server. I hope somebody can verify the "patch" and update the server. Bjoern@ this is the problem we discussed in Hamburg, giving problems later when trying to generate a visual studio solution. rgds jan I. Ps: my normal

Re: [PATCH] install_cygwin.ps1

On Friday, 30 October 2015, Norbert Thiebaud wrote: > On Thu, Oct 29, 2015 at 6:07 PM, jan iversen > wrote: > > Hi. > > > > During the hackfest in Hamburg I noticed that install_cygwin.ps1 did not > > install python3 (tested on a 64

Re: [PATCH] install_cygwin.ps1

On Thu, Oct 29, 2015 at 6:07 PM, jan iversen wrote: > Hi. > > During the hackfest in Hamburg I noticed that install_cygwin.ps1 did not > install python3 (tested on a 64 bit system). > > In fact it only installs python, due to a dependency from git. > > It turns out the -P

Re: [PATCH] install_cygwin.ps1

On Thu, Oct 29, 2015 at 6:32 PM, jan iversen wrote: > > > > Thanks for the answer, I will make a copy of that repo (so much for "core is > the only repo you will ever need") if you downloaded and used that ps1 file, that indicate that you were following the 'lode' ways

[Libreoffice-bugs] [Bug 64037] gerrit "patch submitted" mail: please quote pull command-line with anonymous git URL

https://bugs.documentfoundation.org/show_bug.cgi?id=64037 Dennis Roczek changed: What|Removed |Added Status|NEW |RESOLVED

New gerrit patch set ready for lo-5.0

Hi all, the change set: https://gerrit.libreoffice.org/#/c/19374/2 Is ready for a reviewer. I rebuild the change set it and tested on the context that generated the error. Thanks. -- Kind Regards, Giuseppe Castagno Acca Esse http://www.acca-esse.eu giuseppe.castagno at acca-esse.eu

Patch for 55185

Hi all, going through some issues in bugzilla, I found that https://bugs.documentfoundation.org//show_bug.cgi?id=55185 has a patch attached that was never reviewed. Could any dev take a look at it and review it please? Regards ___ LibreOffice mailing

[SC] [Performance] Calc and SubTotal performance patch submission

Hi, I would like to submit a set of patch i have written in order to improve the performances of the SubTotal functionality. 1/ What is the context Some people i work with are using the LO SubTotal functionality on very large spreadsheets. Let say something like 50 columns and 100 000 rows. We

[Libreoffice-bugs] [Bug 89082] patch-testing, ignore

https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89082 Christian Lohmaier changed: What|Removed |Added Assignee|libreoffice-b...@lists.free

[Libreoffice-bugs] [Bug 89082] patch-testing, ignore

https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89082 Christian Lohmaier changed: What|Removed |Added Severity|critical

[Libreoffice-bugs] [Bug 89082] New: patch-testing, ignore

https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89082 Bug ID: 89082 Summary: patch-testing, ignore Product: QA Tools Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity

Re: Help with Patch

On 05.09.2015 08:15, Nathan Wells wrote: > I > downloaded: > http://dev-builds.libreoffice.org/daily/master/Win-x86@39/2015-09-04_17.02.14/ > And get an error on startup: > Assertion failed! > Program:ram Files (x86)\LibreOfficeDev5\program\vcllc.dll > File:

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - curl/curl-7.19.7.patch libtextcat/libtextcat-2.2.patch redland/raptor redland/rasqal redland/redland sal/qa

curl/curl-7.19.7.patch| 47 libtextcat/libtextcat-2.2.patch | 39 redland/raptor/raptor-1.4.18.patch.autotools | 173 + redland/rasqal/rasqal-0.9.16.patch.autotools | 173 + redland/redland/redland-1.0.8.patch.autotools | 173 + sal/qa/osl/socket

Re: Help with Patch

On Thu, Sep 3, 2015 at 6:30 PM, Caolán McNamara <caol...@redhat.com> > wrote: > >> On Thu, 2015-09-03 at 08:29 +0700, Nathan Wells wrote: >> > I was wondering if someone with a working build of LibreOffice would >> > be willing to test a patch for me >> >> Co

Re: Help with Patch

On Thu, 2015-09-03 at 08:29 +0700, Nathan Wells wrote: > I was wondering if someone with a working build of LibreOffice would > be willing to test a patch for me Code builds and should do what it wants to do. Merged to master as http ://cgit.freedesktop.org/libreoffice/core/comm

Re: Help with Patch

aol...@redhat.com> wrote: > On Thu, 2015-09-03 at 08:29 +0700, Nathan Wells wrote: > > I was wondering if someone with a working build of LibreOffice would > > be willing to test a patch for me > > Code builds and should do what it wants to do. Merged to master as htt

Help with Patch

Hello, I've tried over the past couple of days to get LibreOffice to build in a Windows 10 environment without avail. I then tried an older Windows 8 machine and also couldn't get it to build. I was wondering if someone with a working build of LibreOffice would be willing to test a patch for me

Re: Help with Patch

> Hi Nathan, Would be good if you posted the build log you get, especially the error. I think it's best to figure out why your build fails. I wouldn't mind building your patch (if you attach to a mail and send it my way) but I think in the long run it's best to be able to build and

Re: Help with Patch

Hi Ashod, I was on the IRC channel trying to work through my build issues for two days - I would appreciate your help. I'll send you an email. I realize getting the build to work on my computer is ideal, but since it is such a small patch I thought this might be best for now (and because of my

Re: How to make Jenkins revisit my patch?

Hi Regina, On Mon, Aug 31, 2015 at 11:39 PM, Regina Henschel wrote: > Christian Lohmaier schrieb: >> On Mon, Aug 31, 2015 at 11:00 PM, Regina Henschel >> wrote: >>[...] >>> I have already >>> made "git pull -r" and build again. Next step? >> >>

Re: [PATCH]

On Tue, 2015-08-25 at 06:38 -0700, Olivier R. wrote: > Hi *, > > Here is a patch to update the French spelling dictionary. > For 5.0 and master. > > 0001-Update-French-spelling-dictionary-v5.patch > <http://nabble.documentfoundation.org/file/n4158216/0001-Update-Frenc &g

How to make Jenkins revisit my patch?

Hi all, I had put a tiny patch to gerrit [1] using "./logerrit submit master". Jenkins has build it, but failed. Unfortunately it was at the time of the build-break troubles on master for Windows. I'm sure, that my patch is correct. How do I get Jenkins to verify it?

Re: How to make Jenkins revisit my patch?

Hi Regina, On Mon, Aug 31, 2015 at 10:46 PM, Regina Henschel <rb.hensc...@t-online.de> wrote: > Hi all, > > I had put a tiny patch to gerrit [1] using "./logerrit submit master". > Jenkins has build it, but failed. Unfortunately it was at the time of the >

Re: How to make Jenkins revisit my patch?

Hi Christian, Christian Lohmaier schrieb: Hi Regina, On Mon, Aug 31, 2015 at 10:46 PM, Regina Henschel <rb.hensc...@t-online.de> wrote: Hi all, I had put a tiny patch to gerrit [1] using "./logerrit submit master". Jenkins has build it, but failed. Unfortunately it

Re: How to make Jenkins revisit my patch?

Hi Regina, On Mon, Aug 31, 2015 at 11:00 PM, Regina Henschel <rb.hensc...@t-online.de> wrote: > Christian Lohmaier schrieb: >> >> You need to rebase your patch to a working state. When there is a new >> revision of the patch, jenkins will pick it up automatically..

Re: How to make Jenkins revisit my patch?

Hi Christian, Christian Lohmaier schrieb: Hi Regina, On Mon, Aug 31, 2015 at 11:00 PM, Regina Henschel <rb.hensc...@t-online.de> wrote: Christian Lohmaier schrieb: You need to rebase your patch to a working state. When there is a new revision of the patch, jenkins will pick

patch sumitted to check my flow/setup

Hi, so I updated/refreshed my local setup and submitted a small patch to see if the whole flow is working again. If approved I am ready to do more. https://gerrit.libreoffice.org/#/c/18140/ -- Luc Castermans mailto:luc.casterm...@gmail.com

Re: Help with submitting patch

Alright - thanks! Nathan On Wed, Aug 26, 2015 at 2:23 PM, Samuel Mehrbrodt s.mehrbr...@gmail.com wrote: Hi Nathan, Most of the tutorials seem to be focused on Linix - that is fine. But which branch should I choose (from: https://wiki.documentfoundation.org/Development/gerrit )? git

Re: Help with submitting patch

Hi Nathan, Most of the tutorials seem to be focused on Linix - that is fine. But which branch should I choose (from: https://wiki.documentfoundation.org/Development/gerrit )? git checkout -b a_local_branch_name_of_your_choice You can use any branch name - it doesn't matter. You might

Help with submitting patch

Hello, I wanted to submit a patch for https://bugs.documentfoundation.org/show_bug.cgi?id=52020 But I am wholly unfamiliar with gerrit. I am familiar with Github and incorrectly created a pull request before I realized that was not how it is done https://github.com/LibreOffice/core/pull/4 I am

[PATCH]

Hi *, Here is a patch to update the French spelling dictionary. For 5.0 and master. 0001-Update-French-spelling-dictionary-v5.patch http://nabble.documentfoundation.org/file/n4158216/0001-Update-French-spelling-dictionary-v5.patch Thanks. Olivier -- View this message in context: http

Re: [PATCH] resolved: crash while closing ImageMap Editor

Hi Szymon, On Sun, 2015-08-16 at 10:19 +, Szymon Kłos (via Code Review) wrote: Change subject: resolved: crash while closing ImageMap Editor Thanks so much for that =) I've pushed to 5-0 and gerrit for -5-0-1 - extra reviews appreciated:

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

side is not effected because the sbasic.jar archive contains the file, which has the replacement already done. But still we need more info on the UNO stuff, before we commit the patch. Ideally the developer of that feature should tell a little more. Kind regards Regina

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

we commit the patch. Thanks for the review. kind regards -- Olivier Hallot Comunidade LibreOffice http://ask.libreoffice.org/pt-br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

Hi Olivier, Regina Henschel schrieb: Hi Olivier, So I moved the file to text/sbasic/shared/ and it has now the syntax highlighting. I've not yet tested it, but if you write the basic code as snippet on a file located in sbasic and embed that section in your file in shared, it should work

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

schrieb: [..] Thank you indeed for reviewing the patch. I actually wrote it to trigger / check the process of writing documentation and help files. So far, I am not happy with the amount of work it takes to write a single page. I took the whole weekend at this single page. Yes, I know

Re: [PATCH] TDF#80588 Help page for Basic IDE Options

Hi Olivier, Olivier Hallot schrieb: Em qua 29 jul 2015, às 16:29:52, Regina Henschel escreveu: [..] . Another issue I could'nt fix is that paragraph with role=basicode should display with colored fonts depending on the keywords and that does not happened with the sample we are

Re: Patch: Fix bug 90222 - Replace ScaList with std container

Hi Ryan, On Thursday, 2015-07-30 14:25:04 +1200, Ryan McCoskrie wrote: Apparently we don't have your license statement on file I've already done that. http://lists.freedesktop.org/archives/libreoffice/2014-September/063297.html Don't know why I missed that in

Re: Patch: Fix bug 90222 - Replace ScaList with std container

. If for some reason you *have* to use mail attachments, please use git format-patch to generate the patch to be attached, which preserves author and date and commit message, or even use the git send-email command. I use gerrit last year successfully but at the moment it's rejecting my public

Patch: Fix bug 90222 - Replace ScaList with std container

contents up by name. - ScaList, ScaOUStringList and ScaFuncDataList were all defined twice. This patch has maintained doubling up the wrapper class for the moment. -- Ryan McCoskrie North Canterbury, New Zealanddiff --git a/scaddins/source/datefunc/datefunc.cxx b/scaddins/source/datefunc/datefunc.cxx

Re: Patch: Fix bug 90222 - Replace ScaList with std container

Hi Ryan, Thanks for your patch! On Wednesday, 2015-07-29 22:45:18 +1200, Ryan McCoskrie wrote: (I'm having trouble with logerrit) That is why? We much prefer patches on gerrit, it eases review and handling a lot. Using git review might also be an option for you. If for some reason you *have

Fix for tdf#82744: on gerrit, patch was split

Hi all, I finished the testing, then I split the fix in three patches. First is at: https://gerrit.libreoffice.org/#/c/17080 Reviewers would be welcome. BTW, I added a short line here: https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch explaining the line length limits in

Re: [Libreoffice-qa] Bugzilla: Temporarily reverting patch to Importance fields

On Thu, Jul 16, 2015 at 9:18 PM, Joel Madero jmadero@gmail.com wrote: Now that we've actually had people testing it - is the only issue the NEEDINFO to NEW bug? I'm looking at the code now and probably can get a fix by this weekend. That's one of the unintended side effects. Take a look at

Re: [Libreoffice-qa] Bugzilla: Temporarily reverting patch to Importance fields

On Thu, Jul 16, 2015 at 9:18 PM, Joel Madero jmadero@gmail.com wrote: Now that we've actually had people testing it - is the only issue the NEEDINFO to NEW bug? I'm looking at the code now and probably can get a fix by this weekend. That's one of the unintended side effects. Take a look at

Bugzilla: Temporarily reverting patch to Importance fields

Hi all, As we've run into some unintended side effects from our latest local changes to Bugzilla, I've reverted our field-restriction patch for the time being. This means that everyone will once again be able to make changes to the Severity and Priority fields, so please do keep a watchful eye

[Libreoffice-qa] Bugzilla: Temporarily reverting patch to Importance fields

Hi all, As we've run into some unintended side effects from our latest local changes to Bugzilla, I've reverted our field-restriction patch for the time being. This means that everyone will once again be able to make changes to the Severity and Priority fields, so please do keep a watchful eye

Re: [Libreoffice-qa] Bugzilla: Temporarily reverting patch to Importance fields

On 07/16/2015 05:35 AM, Robinson Tryon wrote: Hi all, As we've run into some unintended side effects from our latest local changes to Bugzilla, I've reverted our field-restriction patch for the time being. Now that we've actually had people testing it - is the only issue the NEEDINFO to NEW

Re: [Libreoffice-qa] Bugzilla: Temporarily reverting patch to Importance fields

On 07/16/2015 05:35 AM, Robinson Tryon wrote: Hi all, As we've run into some unintended side effects from our latest local changes to Bugzilla, I've reverted our field-restriction patch for the time being. Now that we've actually had people testing it - is the only issue the NEEDINFO to NEW

[Libreoffice-bugs] [Bug 89065] New: Testing status changes (with latest patch)

https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89065 Bug ID: 89065 Summary: Testing status changes (with latest patch) Product: LibreOffice Version: 4.4.0.3 release Hardware: Other OS: All Status

[Libreoffice-bugs] [Bug 89065] Testing status changes (with latest patch)

https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89065 Testy Tester (qubit) bishop.robinson+tdf-bz-te...@gmail.com changed: What|Removed |Added

Re: How to comment on a patch in Gerrit, which is already merged?

Hi Regina, *, On Wed, Jul 8, 2015 at 10:16 PM, Regina Henschel rb.hensc...@t-online.de wrote: [...] But what would be the correct way, that my comments are public and noticed? Just do as you did. People taking part in the review will get the comment, so they are both public (and hopefully

How to comment on a patch in Gerrit, which is already merged?

Hi, today I had a look at https://gerrit.libreoffice.org/#/c/16110/. I have seen some problems in the patch, but it is already merged. I wrote my comments in Gerrit for now. But what would be the correct way, that my comments are public and noticed? Kind regards Regina

Re: How to comment on a patch in Gerrit, which is already merged?

Hello Regina It was a mistake introduced by an old Helpauthoring extension. The extension in LibreOffice git has it corrected. I will send another patch. Olivier On 08/07/2015 17:16, Regina Henschel wrote: Hi, today I had a look at https://gerrit.libreoffice.org/#/c/16110/. I have seen

[Libreoffice-bugs] [Bug 92429] PATCH: allow generation of install set with PRODUCTNAME != LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=92429 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED

[Libreoffice-bugs] [Bug 92429] PATCH: allow generation of install set with PRODUCTNAME != LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=92429 --- Comment #2 from Martin Hollmichel martin.hollmic...@gmail.com --- Created attachment 116927 -- https://bugs.documentfoundation.org/attachment.cgi?id=116927action=edit patch for solenv module -- You are receiving this mail because

[Libreoffice-bugs] [Bug 92429] New: PATCH: allow generation of install set with PRODUCTNAME != LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=92429 Bug ID: 92429 Summary: PATCH: allow generation of install set with PRODUCTNAME != LibreOffice Product: LibreOffice Version: unspecified Hardware: Other

[Libreoffice-bugs] [Bug 92429] PATCH: allow generation of install set with PRODUCTNAME != LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=92429 --- Comment #1 from Martin Hollmichel martin.hollmic...@gmail.com --- Created attachment 116926 -- https://bugs.documentfoundation.org/attachment.cgi?id=116926action=edit patch for instset_native module -- You are receiving this mail

[Libreoffice-bugs] [Bug 92429] PATCH: allow generation of install set with PRODUCTNAME != LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=92429 --- Comment #4 from Martin Hollmichel martin.hollmic...@gmail.com --- Created attachment 116929 -- https://bugs.documentfoundation.org/attachment.cgi?id=116929action=edit corrected patch for solenv module -- You are receiving this mail

[Libreoffice-bugs] [Bug 92429] PATCH: allow generation of install set with PRODUCTNAME != LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=92429 --- Comment #3 from Martin Hollmichel martin.hollmic...@gmail.com --- Created attachment 116928 -- https://bugs.documentfoundation.org/attachment.cgi?id=116928action=edit corrected patch for setup_native -- You are receiving this mail

[Libreoffice-bugs] [Bug 92429] PATCH: allow generation of install set with PRODUCTNAME != LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=92429 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|UNCONFIRMED |NEW

[Libreoffice-bugs] [Bug 92429] PATCH: allow generation of install set with PRODUCTNAME != LibreOffice

https://bugs.documentfoundation.org/show_bug.cgi?id=92429 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added CC|

Submitted patch for SwHTMLParser::AppendTextNode

Hi everybody, in SwHTMLParser::AppendTextNode I noticed some code that claimed to repair an improper handling of script-dependent hints, but was suspiciously mixing end positions of plain, CTL and CJK attributes. I submitted a patch: https://gerrit.libreoffice.org/16169 that restores

Re: [PATCH] French dictionary update

On Sat, 2015-04-25 at 07:25 -0700, Olivier R. wrote: Hello *, Here is a patch to update the French dictionary: 0001-Update-French-dictionary-v5.patch http://nabble.documentfoundation.org/file/n4147192/0001-Update-French-dictionary-v5.patch For 4.4 and 4.5/5.0 http

[Libreoffice-bugs] [Bug 64037] gerrit patch submitted mail: please quote pull command-line with anonymous git URL

https://bugs.documentfoundation.org/show_bug.cgi?id=64037 --- Comment #4 from Joel Madero jmadero@gmail.com --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and

[PATCH] French dictionary update

Hello *, Here is a patch to update the French dictionary: 0001-Update-French-dictionary-v5.patch http://nabble.documentfoundation.org/file/n4147192/0001-Update-French-dictionary-v5.patch For 4.4 and 4.5/5.0 Thanks. Olivier -- View this message in context: http

[PATCH 1/2] Update .gitignore [PATCH 2/2] Update INSTALL

Excuse me that I do not know how to send emails by git. So I send this email manually. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Overloaded Constructors Patch

diff --git a/idl/inc/bastype.hxx b/idl/inc/bastype.hxx index 2252f9a..fde017a 100644 --- a/idl/inc/bastype.hxx +++ b/idl/inc/bastype.hxx @@ -73,6 +73,10 @@ class SvIdentifier private: OString m_aStr; public: +SvIdentifier(OString str) +{ +m_aStr = str; +}

[PATCH] Remove Inheritance from std::vector

diff --git a/idl/inc/basobj.hxx b/idl/inc/basobj.hxx index c601fb1..807b861 100644 --- a/idl/inc/basobj.hxx +++ b/idl/inc/basobj.hxx @@ -88,8 +88,8 @@ protected: virtual void ReadAttributesSvIdl( SvIdlDataBase rBase, SvTokenStream rInStm ); public: -

Re: [Patch] Removed inheritance from std vector and std map.

Hey, so this is the wrong format to submit patches. The preferred way is to use gerrit and follow the instructions at https://wiki.documentfoundation.org/Development/gerrit There is still the discouraged way of attaching the result of got format-patch to a mail but if possible please use gerrit

[Patch] Removed inheritance from std vector and std map.

diff --git a/idl/inc/basobj.hxx b/idl/inc/basobj.hxx index c601fb1..807b861 100644 --- a/idl/inc/basobj.hxx +++ b/idl/inc/basobj.hxx @@ -88,8 +88,8 @@ protected: virtual void ReadAttributesSvIdl( SvIdlDataBase rBase, SvTokenStream rInStm ); public: -

Re: [PATCH] Remove Inheritance from std::vector

This is weird. This is the not what I intended to submit. Obviously this won't compile. 2015-04-08 22:22 GMT+01:00 Delveri chick chickdelv...@gmail.com: diff --git a/idl/inc/basobj.hxx b/idl/inc/basobj.hxx index c601fb1..807b861 100644 --- a/idl/inc/basobj.hxx +++ b/idl/inc/basobj.hxx @@

Libreoffice with Firebird3 patch

The good news is that it compiles https://gist.github.com/mariuz/bcde7f783b657b2465e5 configure flags removed in firebird 3.0 --disable-super server is no more (super and superclassic are one) --with-system-icu is not needed , firebird defaults on compiling with the system icu (MAKE)

[Solved]: uno.bin core dump during illumos build - patch included

Hi, as suggested, I patched the solaris_intel sources to support gcc 4.7. Let me know if the attached patch is fine for you to apply. Now I'm going on building, when everything will go through, I will provide you with all the patches we had to apply Gabriele

Re: [Solved]: uno.bin core dump during illumos build - patch included

On 02/19/2015 12:49 PM, Gabriele Bulfon wrote: as suggested, I patched the solaris_intel sources to support gcc 4.7. Let me know if the attached patch is fine for you to apply. Pushed (it only affects Solaris-only code, so just trust you that it actually helps). Now I'm going on building

<    1   2   3   4   5   6   7   8   9   10   >